@commonlyai/cli 0.1.163 → 0.1.164

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@commonlyai/cli",
-  "version": "0.1.163",
+  "version": "0.1.164",
   "license": "Apache-2.0",
   "description": "The Commonly CLI — connect agents, manage pods, iterate fast",
   "type": "module",

package/src/commands/agent.js

@@ -17,7 +17,6 @@ import { homedir, tmpdir } from 'os';
 import { fileURLToPath } from 'url';
 import { createHash } from 'crypto';
 
-import { requireSeatModel } from '../lib/adapters/seat-model.js';
 import { createClient } from '../lib/api.js';
 import { copyHandoffMemory } from '../lib/handoff-memory.js';
 import {
@@ -1254,7 +1253,6 @@ export const performRun = ({
   const effectiveTurnTimeoutMs = Number.isFinite(requestedTurnTimeout) && requestedTurnTimeout > 0
     ? Math.min(requestedTurnTimeout, 2_147_483_647) : 15 * 60 * 1000;
   const client = createClient({ instance: instanceUrl, token });
-  const missingModelNotices = new Set();
   const handoffAgent = sanitizeHandoffAgent(refusalHandoff);
   if (refusalHandoff && !handoffAgent) {
     log(`--refusal-handoff ignored: '${String(refusalHandoff).slice(0, 64)}' is not an agent handle`);
@@ -1679,30 +1677,6 @@ export const performRun = ({
       ? `${recycleBriefing}\n\n${promptWithSkills}`
       : promptWithSkills;
 
-    if (adapter.requiresModel) {
-      try {
-        requireSeatModel(seatEnvironment, adapter.name);
-      } catch (error) {
-        if (error.code === 'seat_model_missing' && eventPodId && !missingModelNotices.has(eventPodId)) {
-          try {
-            const delivery = await deliverChatReply({
-              client,
-              podId: eventPodId,
-              text: "This agent has no model set; add environment.model to its configuration.",
-              limit: chatCharLimit,
-              maxChunks: maxChatChunks,
-              log,
-            });
-            if (!delivery.skipped && !delivery.refused) missingModelNotices.add(eventPodId);
-          } catch (noticeError) {
-            log(`missing model notice could not be posted: ${noticeError.message}`);
-          }
-        }
-        // Configuration failure is retryable: never turn a notice into an ack.
-        throw error;
-      }
-    }
-
     log(`[${event.type}] spawning ${adapter.name}`);
     // TASK-102 part B. The CHILD gets a scoped credential; the wrapper keeps
     // the seat token for its own polling, claiming and posting (`client` was

package/src/lib/adapters/claude.js

@@ -43,7 +43,6 @@
  * SIGKILL escalation is a post-v1 concern (ADR-005 §Spawning semantics).
  */
 
-import { requireSeatModel } from './seat-model.js';
 import { spawn as childSpawn, spawnSync } from 'child_process';
 import { createHash, randomUUID } from 'crypto';
 import { accessSync, constants, realpathSync } from 'fs';
@@ -726,7 +725,6 @@ const prepareArgv = async (innerArgv, ctx) => {
 };
 
 export default {
-  requiresModel: true,
   name: 'claude',
   // Identity-bearing runtime tag written into AgentInstallation.config.runtime
   // by `commonly agent attach`. The CLI command stays `commonly agent attach
@@ -761,7 +759,6 @@ export default {
   },
 
   async spawn(prompt, rawCtx = {}) {
-    const seatModel = requireSeatModel(rawCtx.environment, 'claude');
     // `sandbox.trust: 'internal'` is refused for new declarations and read as
     // `public` for a record that already carries it; such a seat is confined
     // where it can be and refuses to derive where it cannot (Wren 69585).
@@ -812,7 +809,7 @@ export default {
     // session-recovery retry, or a retry runs at a different effort than the
     // turn it replaces.
     const modelArgs = [
-      '--model', seatModel,
+      ...(ctx.environment?.model ? ['--model', String(ctx.environment.model)] : []),
       ...(ctx.environment?.effort ? ['--effort', String(ctx.environment.effort)] : []),
     ];
     const baseArgs = ['-p', fullPrompt, '--output-format', 'text', sessionFlag, sessionId, ...modelArgs];

package/src/lib/adapters/codex.js

@@ -37,7 +37,6 @@
  * SIGKILL escalation is a post-v1 concern (ADR-005 §Spawning semantics).
  */
 
-import { requireSeatModel } from './seat-model.js';
 import { spawn as childSpawn, spawnSync } from 'child_process';
 import { createHash } from 'crypto';
 import { accessSync, constants } from 'fs';
@@ -617,7 +616,6 @@ const runCodex = ({ args, cwd, env, timeoutMs, credentials = [], spawnImpl = chi
 });
 
 export default {
-  requiresModel: true,
   name: 'codex',
   // See claude.js for the rationale — identity-bearing runtime tag persisted
   // to AgentInstallation.config.runtime (paired with host:'byo') so a CLI-
@@ -644,7 +642,6 @@ export default {
   },
 
   async spawn(prompt, ctx = {}) {
-    const seatModel = requireSeatModel(ctx.environment, 'codex');
     // Passed through UNCOALESCED. `ctx.memoryLongTerm || ''` was here, and
     // `null || ''` is `''` — which routed the unreadable case straight into
     // the empty-memory branch and made the whole distinction unreachable from
@@ -701,7 +698,7 @@ export default {
         mcpFlags: mcp.flags,
         mcpReadDirectories: mcp.mcpReadDirectories,
         publicSandboxMode,
-        model: seatModel,
+        model: ctx.environment?.model,
         effort: ctx.environment?.effort,
         commitAttributionEnv: ctx.commitAttributionEnv,
       });

package/src/lib/adapters/dsh.js

@@ -1,5 +1,4 @@
 /** DeepSeek Harness 0.2.1-rc.2, private seats only. Configuration is per spawn. */
-import { requireSeatModel } from './seat-model.js';
 import { spawn as childSpawn, spawnSync } from 'child_process';
 import { createHash } from 'crypto';
 import { existsSync } from 'fs';
@@ -219,7 +218,6 @@ export const runDsh = ({ binary, args, cwd, env, timeoutMs, credentials, spawnIm
 });
 
 export default {
-  requiresModel: true,
   name: 'dsh', runtimeType: 'dsh', supportsProvider: true,
 
   async validateEnvironment(environment, workspacePath) {
@@ -248,7 +246,6 @@ export default {
   },
 
   async spawn(prompt, ctx = {}) {
-    const seatModel = requireSeatModel(ctx.environment, 'dsh');
     assertPrivateDsh(ctx.environment);
     if (!ctx.environment?.provider || !ctx.environment?.model) {
       throw new Error('dsh requires environment.provider and environment.model');
@@ -278,7 +275,7 @@ export default {
         credentialFile: credential.path, instanceUrl: ctx.instanceUrl,
       });
       const patch = JSON.stringify(buildPatch({
-        proxyBaseURL: proxy.baseURL, model: seatModel,
+        proxyBaseURL: proxy.baseURL, model: ctx.environment.model,
         cwd: ctx.cwd, mcp, effort: ctx.environment.effort,
         deepseekOfficial: new URL(ctx.environment.provider.baseURL).hostname === 'api.deepseek.com',
       }), null, 2);

package/src/lib/adapters/goose.js

@@ -1,5 +1,4 @@
 /** Goose 1.54.0 wrapper. Public seats wait for TASK-236's deny-by-default proof. */
-import { requireSeatModel } from './seat-model.js';
 import { spawn as childSpawn, spawnSync } from 'node:child_process';
 import { mkdtemp, readFile, rm } from 'node:fs/promises';
 import { tmpdir } from 'node:os';
@@ -17,6 +16,7 @@ import { adapterFailure, spawnCredentials } from '../upstream-refusal.js';
 export const TESTED_GOOSE_VERSIONS = Object.freeze(['1.54.0']);
 const DEFAULT_TIMEOUT_MS = 15 * 60 * 1000;
 const TERMINATION_GRACE_MS = 5000;
+const DEFAULT_MODEL = 'deepseek-v4-flash';
 const DEFAULT_PROVIDER_HOST = 'https://litellm.commonly.me';
 const DEFAULT_PROVIDER_KEY = 'COMMONLY_LITELLM_KEY';
 const PLACEHOLDER_RE = /\$\{(COMMONLY_[A-Z_]+)\}/g;
@@ -174,7 +174,6 @@ const runGoose = ({ binary, args, cwd, env, timeoutMs, credentials, spawnImpl =
 });
 
 export default {
-  requiresModel: true,
   name: 'goose',
   providerKeyEnv: DEFAULT_PROVIDER_KEY,
   supportsProvider: true,
@@ -194,7 +193,6 @@ export default {
   },
 
   async spawn(prompt, ctx = {}) {
-    const seatModel = requireSeatModel(ctx.environment, 'goose');
     const keyFile = await this.validateEnvironment(ctx.environment, ctx.cwd);
     const sourceEnv = ctx.env || process.env;
     const configured = ctx.environment?.provider;
@@ -205,7 +203,7 @@ export default {
     if (!/^https?:$/.test(baseUrl.protocol) || baseUrl.username || baseUrl.password || baseUrl.search || baseUrl.hash) {
       throw new Error('goose adapter: provider.baseURL must be a plain HTTP(S) URL');
     }
-    const model = seatModel;
+    const model = ctx.environment?.model || DEFAULT_MODEL;
     const binary = ctx._binaryPath || 'goose';
     const version = ctx._version || versionOf(spawnSync(binary, ['--version'], { encoding: 'utf8', timeout: 5000 }).stdout);
     if (!TESTED_GOOSE_VERSIONS.includes(version)) {

package/src/lib/adapters/hermes.js

@@ -1,5 +1,4 @@
 /** Hermes 0.22.2 local CLI wrapper. Hermes owns provider I/O; this file only spawns it. */
-import { requireSeatModel } from './seat-model.js';
 import { spawn as childSpawn, spawnSync } from 'child_process';
 import { createHash } from 'crypto';
 import { mkdir } from 'fs/promises';
@@ -138,7 +137,6 @@ const runHermes = ({ args, prompt, cwd, env, timeoutMs, spawnImpl, credentials }
 });
 
 export default {
-  requiresModel: true,
   name: 'hermes',
   runtimeType: 'hermes',
   supportsProvider: false,
@@ -163,7 +161,6 @@ export default {
   },
 
   async spawn(prompt, ctx = {}) {
-    const seatModel = requireSeatModel(ctx.environment, 'hermes');
     await this.validateEnvironment(ctx.environment);
     // Keep Hermes away from the operator's default profile, including any
     // Nous Portal/Cloud credentials there. The wrapper provides the sole key.
@@ -180,7 +177,7 @@ export default {
     }
     const args = ['chat', '--oneshot', '--query-file', '-', '--format', 'stream-json',
       '--provider', 'openrouter', '--source', 'tool', '--no-restore-cwd'];
-    args.push('--model', seatModel);
+    if (ctx.environment?.model) args.push('--model', ctx.environment.model);
     if (ctx.sessionId) args.push('--resume', ctx.sessionId);
     const fullPrompt = buildMemoryPreamble(prompt, ctx.memoryLongTerm, {
       freshSession: !ctx.sessionId,

package/src/lib/adapters/opencode.js

@@ -19,7 +19,6 @@
  * `text.part.text`, and token counts in `step_finish.part.tokens`.
  */
 
-import { requireSeatModel } from './seat-model.js';
 import { spawn as childSpawn, spawnSync } from 'child_process';
 import { createHash } from 'crypto';
 import { realpathSync } from 'fs';
@@ -623,7 +622,6 @@ const describeOpenCodeVersionMismatch = (installedVersion) => {
 };
 
 export default {
-  requiresModel: true,
   name: 'opencode',
   runtimeType: 'opencode',
   supportsProvider: true,
@@ -647,7 +645,6 @@ export default {
   },
 
   async spawn(prompt, rawCtx = {}) {
-    const seatModel = requireSeatModel(rawCtx.environment, 'opencode');
     const sandbox = normalizeSandboxTrust(rawCtx.environment?.sandbox);
     const ctx = rawCtx.environment
       ? { ...rawCtx, environment: { ...rawCtx.environment, sandbox } }
@@ -808,7 +805,7 @@ export default {
         prompt: fullPrompt,
         sessionId: ctx.sessionId,
         cwd: ctx.cwd,
-        model: qualifiedProviderModel(provider, seatModel),
+        model: qualifiedProviderModel(provider, ctx.environment?.model),
         effort: ctx.environment?.effort,
         title: ctx.agentName,
       });

package/src/lib/adapters/pi.js

@@ -32,7 +32,6 @@
  * Contract (see stub.js): detect() and spawn(prompt, ctx) → { text, newSessionId }.
  */
 
-import { requireSeatModel } from './seat-model.js';
 import { spawn as childSpawn, spawnSync } from 'child_process';
 import { createHash, randomUUID } from 'crypto';
 import { mkdir, readdir, writeFile } from 'fs/promises';
@@ -66,6 +65,7 @@ export const DEFAULT_PROVIDER = Object.freeze({
   api: 'openai-completions',
   apiKeyEnv: 'COMMONLY_LITELLM_KEY',
 });
+export const DEFAULT_MODEL = 'deepseek-v4-flash';
 
 // ADR-008 `effort` → pi `--thinking`. pi's ladder is off/minimal/low/medium/high/xhigh/max.
 const THINKING = { none: 'off', off: 'off', minimal: 'minimal', low: 'low', medium: 'medium', high: 'high', xhigh: 'xhigh', max: 'max' };
@@ -390,7 +390,6 @@ const runPi = ({ args, cwd, env, payload, timeoutMs, credentials = [], spawnImpl
 });
 
 export default {
-  requiresModel: true,
   name: 'pi',
 
   // TASK-049: the variable this adapter needs from the environment of whatever
@@ -410,13 +409,12 @@ export default {
   },
 
   async spawn(prompt, ctx = {}) {
-    const seatModel = requireSeatModel(ctx.environment, 'pi');
     // pi has no enforced sandbox. claude.js and codex.js refuse a public-trust
     // seat they cannot confine; so does this adapter, and it refuses any declared
     // sandbox mode rather than run unconfined under a spec that promised one.
     assertNoSandboxDeclared(ctx.environment);
     const provider = resolveProvider(ctx.environment);
-    const model = seatModel;
+    const model = ctx.environment?.model || DEFAULT_MODEL;
     const thinking = thinkingFor(ctx.environment?.effort);
     const baseEnv = ctx.env || process.env;
     if (!baseEnv[provider.apiKeyEnv]) {

package/src/lib/adapters/qwen.js

@@ -1,5 +1,4 @@
 /** Qwen Code 0.25.1 wrapper. Public turns have fresh HOME, config and keys. */
-import { requireSeatModel } from './seat-model.js';
 import { spawn as childSpawn, spawnSync } from 'child_process';
 import { lstatSync, realpathSync } from 'fs';
 import { chmod, mkdtemp, readFile, rm, writeFile } from 'fs/promises';
@@ -209,7 +208,6 @@ const runQwen = ({ cmd, args, cwd, env, timeoutMs, spawnImpl, credentials }) =>
 });
 
 export default {
-  requiresModel: true,
   name: 'qwen',
   runtimeType: 'qwen',
   supportsProvider: true,
@@ -232,7 +230,6 @@ export default {
   },
 
   async spawn(prompt, ctx = {}) {
-    const seatModel = requireSeatModel(ctx.environment, 'qwen');
     const sandbox = normalizeSandboxTrust(ctx.environment?.sandbox);
     const isPublic = sandbox?.trust === 'public';
     const mode = isPublic ? resolvePublicSandboxMode(sandbox) : null;
@@ -307,7 +304,7 @@ export default {
         freshSession: true,
       });
       const args = [
-        '--bare', '--safe-mode', '--auth-type', 'openai', '-m', seatModel,
+        '--bare', '--safe-mode', '--auth-type', 'openai', '-m', ctx.environment.model,
         '--mcp-config', mcpPath, '--exclude-tools', [
           ...EXCLUDED_TOOLS, ...(isPublic ? PUBLIC_READ_TOOLS : []),
         ].join(','),

package/src/lib/adapters/seat-model.js

@@ -1,12 +0,0 @@
-/** A seat must choose its model independently of the operator's CLI defaults. */
-export const requireSeatModel = (environment, adapterName) => {
-  const model = environment?.model;
-  if (typeof model !== 'string' || !model.trim()) {
-    const error = new Error(
-      `${adapterName} requires environment.model; set the seat model with commonly agent config <name> --model <model> before running`,
-    );
-    error.code = 'seat_model_missing';
-    throw error;
-  }
-  return model.trim();
-};