@commercetools/connect-payments-sdk 0.4.2 → 0.4.4

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @commercetools/connect-payments-sdk
 
+## 0.4.4
+
+### Patch Changes
+
+- 062bbeb: Solved issue validating a payment refund as the code allowed to trigger a refund when the payment did not have a successful charge transaction
+
+## 0.4.3
+
+### Patch Changes
+
+- f155772: fix payment modification validations by checking that a payment could contain a cancelAuthorization transaction
+
 ## 0.4.2
 
 ### Patch Changes

package/dist/commercetools/services/ct-payment.service.d.ts

@@ -20,5 +20,6 @@ export declare class DefaultPaymentService implements PaymentService {
     private populateSetPaymentMethod;
     private findMatchingTransactions;
     private consolidateTransactionChanges;
+    private hasTransactionWithState;
     private calculateTotalAmount;
 }

package/dist/commercetools/services/ct-payment.service.js

@@ -45,12 +45,13 @@ class DefaultPaymentService {
         throw err;
     }
     validatePaymentCancelAuthorization(opts) {
-        const totalAuthorized = this.calculateTotalAmount(opts.payment, 'Authorization', opts.payment.amountPlanned.currencyCode);
-        if (totalAuthorized === 0) {
+        if (!this.hasTransactionWithState(opts.payment, 'Authorization', ['Success'])) {
             return { isValid: false, reason: `No authorization transaction found for resource ${opts.payment.id}.` };
         }
-        const totalCaptured = this.calculateTotalAmount(opts.payment, 'Charge', opts.payment.amountPlanned.currencyCode);
-        if (totalCaptured > 0) {
+        if (this.hasTransactionWithState(opts.payment, 'CancelAuthorization', ['Success', 'Pending'])) {
+            return { isValid: false, reason: `Resource ${opts.payment.id} has already been cancelled.` };
+        }
+        if (this.hasTransactionWithState(opts.payment, 'Charge', ['Success'])) {
             return { isValid: false, reason: `Resource ${opts.payment.id} has already been charged.` };
         }
         return { isValid: true };
@@ -66,6 +67,9 @@ class DefaultPaymentService {
         if (totalAuthorized === 0) {
             return { isValid: false, reason: `No authorization transaction found for resource ${opts.payment.id}.` };
         }
+        if (this.hasTransactionWithState(opts.payment, 'CancelAuthorization', ['Success', 'Pending'])) {
+            return { isValid: false, reason: `Resource ${opts.payment.id} has already been cancelled.` };
+        }
         const totalCaptured = this.calculateTotalAmount(opts.payment, 'Charge', opts.amount.currencyCode);
         const allowedAmount = totalAuthorized - totalCaptured;
         if (opts.amount.centAmount > allowedAmount) {
@@ -83,6 +87,9 @@ class DefaultPaymentService {
                 reason: `Invalid currency ${opts.amount.currencyCode} for resource ${opts.payment.id}, expected ${opts.payment.amountPlanned.currencyCode}`,
             };
         }
+        if (this.hasTransactionWithState(opts.payment, 'CancelAuthorization', ['Success', 'Pending'])) {
+            return { isValid: false, reason: `Resource ${opts.payment.id} has already been cancelled.` };
+        }
         const totalCaptured = this.calculateTotalAmount(opts.payment, 'Charge', opts.amount.currencyCode);
         if (totalCaptured === 0) {
             return { isValid: false, reason: `No charge transaction found for resource ${opts.payment.id}.` };
@@ -154,8 +161,7 @@ class DefaultPaymentService {
                 tx.amount.centAmount === transaction.amount.centAmount &&
                 tx.amount.currencyCode === transaction.amount.currencyCode &&
                 transaction.interactionId &&
-                ((tx.interactionId && tx.interactionId === transaction.interactionId) ||
-                    (!tx.interactionId && tx.state === 'Initial')));
+                (tx.interactionId || (!tx.interactionId && tx.state === 'Initial')));
         });
     }
     consolidateTransactionChanges(payment, transaction) {
@@ -185,6 +191,9 @@ class DefaultPaymentService {
         }
         return actions;
     }
+    hasTransactionWithState(payment, type, state) {
+        return payment.transactions.some((transaction) => transaction.type === type && state.includes(transaction.state));
+    }
     calculateTotalAmount(payment, type, currencyCode) {
         return payment.transactions
             .filter((transaction) => transaction.type === type &&

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@commercetools/connect-payments-sdk",
-  "version": "0.4.2",
+  "version": "0.4.4",
   "description": "Payment SDK for commercetools payment connectors",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -15,8 +15,8 @@
   ],
   "license": "ISC",
   "dependencies": {
-    "@commercetools/platform-sdk": "7.6.0",
-    "@commercetools/sdk-client-v2": "2.4.0",
+    "@commercetools/platform-sdk": "7.7.0",
+    "@commercetools/sdk-client-v2": "2.4.1",
     "jsonwebtoken": "9.0.2",
     "jwks-rsa": "3.1.0"
   }