@commercetools/connect-payments-sdk 0.4.2 → 0.4.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @commercetools/connect-payments-sdk
 
+## 0.4.3
+
+### Patch Changes
+
+- f155772: fix payment modification validations by checking that a payment could contain a cancelAuthorization transaction
+
 ## 0.4.2
 
 ### Patch Changes

package/dist/commercetools/services/ct-payment.service.js

@@ -49,6 +49,10 @@ class DefaultPaymentService {
         if (totalAuthorized === 0) {
             return { isValid: false, reason: `No authorization transaction found for resource ${opts.payment.id}.` };
         }
+        const totalCancelled = this.calculateTotalAmount(opts.payment, 'CancelAuthorization', opts.payment.amountPlanned.currencyCode);
+        if (totalCancelled > 0) {
+            return { isValid: false, reason: `Resource ${opts.payment.id} has already been cancelled.` };
+        }
         const totalCaptured = this.calculateTotalAmount(opts.payment, 'Charge', opts.payment.amountPlanned.currencyCode);
         if (totalCaptured > 0) {
             return { isValid: false, reason: `Resource ${opts.payment.id} has already been charged.` };
@@ -66,6 +70,10 @@ class DefaultPaymentService {
         if (totalAuthorized === 0) {
             return { isValid: false, reason: `No authorization transaction found for resource ${opts.payment.id}.` };
         }
+        const totalCancelled = this.calculateTotalAmount(opts.payment, 'CancelAuthorization', opts.payment.amountPlanned.currencyCode);
+        if (totalCancelled > 0) {
+            return { isValid: false, reason: `Resource ${opts.payment.id} has already been cancelled.` };
+        }
         const totalCaptured = this.calculateTotalAmount(opts.payment, 'Charge', opts.amount.currencyCode);
         const allowedAmount = totalAuthorized - totalCaptured;
         if (opts.amount.centAmount > allowedAmount) {
@@ -83,6 +91,10 @@ class DefaultPaymentService {
                 reason: `Invalid currency ${opts.amount.currencyCode} for resource ${opts.payment.id}, expected ${opts.payment.amountPlanned.currencyCode}`,
             };
         }
+        const totalCancelled = this.calculateTotalAmount(opts.payment, 'CancelAuthorization', opts.payment.amountPlanned.currencyCode);
+        if (totalCancelled > 0) {
+            return { isValid: false, reason: `Resource ${opts.payment.id} has already been cancelled.` };
+        }
         const totalCaptured = this.calculateTotalAmount(opts.payment, 'Charge', opts.amount.currencyCode);
         if (totalCaptured === 0) {
             return { isValid: false, reason: `No charge transaction found for resource ${opts.payment.id}.` };
@@ -154,8 +166,7 @@ class DefaultPaymentService {
                 tx.amount.centAmount === transaction.amount.centAmount &&
                 tx.amount.currencyCode === transaction.amount.currencyCode &&
                 transaction.interactionId &&
-                ((tx.interactionId && tx.interactionId === transaction.interactionId) ||
-                    (!tx.interactionId && tx.state === 'Initial')));
+                (tx.interactionId || (!tx.interactionId && tx.state === 'Initial')));
         });
     }
     consolidateTransactionChanges(payment, transaction) {
@@ -188,7 +199,7 @@ class DefaultPaymentService {
     calculateTotalAmount(payment, type, currencyCode) {
         return payment.transactions
             .filter((transaction) => transaction.type === type &&
-            transaction.state === 'Success' &&
+            (transaction.state === 'Success' || transaction.state === 'Pending') &&
             transaction.amount.currencyCode === currencyCode)
             .reduce((total, transaction) => total + transaction.amount.centAmount, 0);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@commercetools/connect-payments-sdk",
-  "version": "0.4.2",
+  "version": "0.4.3",
   "description": "Payment SDK for commercetools payment connectors",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -15,8 +15,8 @@
   ],
   "license": "ISC",
   "dependencies": {
-    "@commercetools/platform-sdk": "7.6.0",
-    "@commercetools/sdk-client-v2": "2.4.0",
+    "@commercetools/platform-sdk": "7.7.0",
+    "@commercetools/sdk-client-v2": "2.4.1",
     "jsonwebtoken": "9.0.2",
     "jwks-rsa": "3.1.0"
   }