@commercetools/connect-payments-sdk 0.27.1 → 0.28.0

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # @commercetools/connect-payments-sdk
 
+## 0.28.0
+
+### Minor Changes
+- 9e2f639: chore(deps): upgrade dependencies to latest stable versions, including security patches
+
+## 0.27.2
+
+### Patch Changes
+
+- d66f007: fix(payments): correct retry mechanism and add exponential backoff to payment updates
+
 ## 0.27.1
 
 ### Patch Changes

package/dist/commercetools/services/ct-payment.service.d.ts

@@ -19,6 +19,17 @@ export declare class DefaultPaymentService implements PaymentService {
     findPaymentsByInterfaceId(opts: FindPaymentsByInterfaceId): Promise<Payment[]>;
     createPayment(draft: PaymentDraft): Promise<Payment>;
     updatePayment(opts: UpdatePayment): Promise<Payment>;
+    /**
+     * Calculates exponential backoff delay with jitter
+     * @param attempt - Current attempt number (0-based)
+     * @returns Delay in milliseconds
+     */
+    private calculateExponentialBackoff;
+    /**
+     * Sleep for a specified duration
+     * @param ms - Duration in milliseconds
+     */
+    private sleep;
     private consolidateUpdateActions;
     private populateSetInterfaceIdAction;
     private populateChangeTransactionInteractionId;

package/dist/commercetools/services/ct-payment.service.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DefaultPaymentService = void 0;
 const ct_api_error_1 = require("../errors/ct-api.error");
+const node_crypto_1 = require("node:crypto");
 /**
  * This is the default implementation of the PaymentService interface.
  */
@@ -24,40 +25,60 @@ class DefaultPaymentService {
     }
     async updatePayment(opts) {
         const maxRetries = 3;
-        let err;
-        for (let retries = 0; retries < maxRetries; retries++) {
+        let lastError;
+        for (let attempt = 0; attempt < maxRetries; attempt++) {
             const payment = await this.getPayment({ id: opts.id });
             const actions = this.consolidateUpdateActions(payment, opts);
-            this.logger.info({ paymentId: payment.id, paymentVersion: payment.version, actions, retries }, 'Updating payment with actions');
+            this.logger.info({ paymentId: payment.id, paymentVersion: payment.version, actions, attempt }, 'Updating payment with actions');
             if (actions.length === 0) {
-                this.logger.info({ paymentId: payment.id, paymentVersion: payment.version, retries }, 'Update payment skipped, no actions to perform');
+                this.logger.info({ paymentId: payment.id, paymentVersion: payment.version, attempt }, 'Update payment skipped, no actions to perform');
                 return payment;
             }
             try {
-                const updatedPayment = await this.ctAPI.payment.updatePayment({
+                return await this.ctAPI.payment.updatePayment({
                     resource: {
                         id: payment.id,
                         version: payment.version,
                     },
                     actions,
                 });
-                return updatedPayment;
             }
             catch (e) {
-                err = e;
-                if (e instanceof ct_api_error_1.CommercetoolsAPIError &&
+                lastError = e;
+                const isRetryableError = e instanceof ct_api_error_1.CommercetoolsAPIError &&
                     (e.httpErrorStatus === 409 ||
-                        (e.httpErrorStatus === 400 && e.message.includes('already used without setting a payment interface')))) {
-                    this.logger.warn({ paymentId: payment.id, paymentVersion: payment.version, retries, err }, 'Unable to update the payment, retrying');
-                    retries++;
-                }
-                else {
-                    this.logger.error({ paymentId: payment.id, paymentVersion: payment.version, retries, err }, 'Unable to update the payment, abort');
-                    throw e;
+                        (e.httpErrorStatus === 400 && e.message.includes('already used without setting a payment interface')));
+                if (isRetryableError && attempt < maxRetries - 1) {
+                    const delayMs = this.calculateExponentialBackoff(attempt);
+                    this.logger.warn({ paymentId: payment.id, paymentVersion: payment.version, attempt, delayMs, err: e }, 'Unable to update the payment, retrying');
+                    await this.sleep(delayMs);
+                    continue;
                 }
+                this.logger.error({ paymentId: payment.id, paymentVersion: payment.version, attempt, err: e }, 'Unable to update the payment, abort');
+                throw e;
             }
         }
-        throw err;
+        throw lastError;
+    }
+    /**
+     * Calculates exponential backoff delay with jitter
+     * @param attempt - Current attempt number (0-based)
+     * @returns Delay in milliseconds
+     */
+    calculateExponentialBackoff(attempt) {
+        const baseDelayMs = 100;
+        const maxDelayMs = 2000;
+        const jitterMs = 100;
+        const exponentialDelay = baseDelayMs * Math.pow(2, attempt);
+        const jitter = (0, node_crypto_1.randomInt)(0, jitterMs);
+        return Math.min(exponentialDelay + jitter, maxDelayMs);
+    }
+    /**
+     * Sleep for a specified duration
+     * @param ms - Duration in milliseconds
+     */
+    sleep(ms) {
+        return new Promise((resolve) => setTimeout(resolve, ms));
     }
     consolidateUpdateActions(payment, updateInfo) {
         const actions = [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@commercetools/connect-payments-sdk",
-  "version": "0.27.1",
+  "version": "0.28.0",
   "description": "Payment SDK for commercetools payment connectors",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -15,12 +15,12 @@
   ],
   "license": "ISC",
   "dependencies": {
-    "@commercetools-backend/loggers": "24.5.0",
-    "@commercetools/platform-sdk": "8.18.0",
-    "@commercetools/ts-client": "3.4.1",
-    "jsonwebtoken": "9.0.2",
+    "@commercetools-backend/loggers": "27.4.0",
+    "@commercetools/platform-sdk": "8.25.0",
+    "@commercetools/ts-client": "4.9.1",
+    "jsonwebtoken": "9.0.3",
     "jwks-rsa": "3.2.0",
-    "lodash": "4.17.21",
+    "lodash": "4.18.1",
     "logform": "2.7.0"
   }
 }

package/tsconfig.test.json

@@ -0,0 +1,9 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "module": "CommonJS",
+    "moduleResolution": "node10",
+    "types": ["jest"]
+  },
+  "include": ["src/**/*.ts"]
+}