@comfanion/workflow 4.38.1-dev.9 → 4.38.1

package/src/opencode/plugins/__tests__/leak-stress.test.ts

@@ -0,0 +1,315 @@
+/**
+ * Memory Leak Stress Tests
+ *
+ * Goal: prove the 3 plugins are NOT the source of a memory leak.
+ *
+ * Strategy:
+ * 1. Run each plugin's hot path N times in a tight loop
+ * 2. Measure heap snapshots at intervals
+ * 3. Assert heap growth is sub-linear (flat / bounded)
+ * 4. Specifically test known risk areas:
+ *    - custom-compaction: closure variables (lastActiveAgent, lastSessionId)
+ *    - file-indexer: module-level pendingFiles Map
+ *    - version-check: stateless (baseline)
+ *
+ * NOTE: Tests use only the public plugin interface (no internal imports).
+ *
+ * Run only leak tests:
+ *   bun test plugins/__tests__/leak-stress.test.ts
+ */
+import { describe, it, expect, beforeEach, afterEach } from "bun:test"
+import { join } from "path"
+import {
+  createMockCtx,
+  createTempDir,
+  cleanupTempDir,
+  FIXTURE_SESSION_STATE,
+  FIXTURE_STORY_MD,
+  FIXTURE_EPIC_STATE,
+  FIXTURE_TODOS,
+  FIXTURE_CONFIG_YAML,
+} from "./helpers/mock-ctx"
+import { CustomCompactionPlugin } from "../custom-compaction"
+import { FileIndexerPlugin } from "../file-indexer"
+import { VersionCheckPlugin } from "../version-check"
+
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+function heapMB(): number {
+  return process.memoryUsage().heapUsed / 1024 / 1024
+}
+
+function tryGC(): void {
+  if (typeof globalThis.gc === "function") {
+    globalThis.gc()
+  }
+}
+
+/** Take N heap snapshots at equal intervals during a callback. */
+async function profile(
+  iterations: number,
+  snapshots: number,
+  fn: (i: number) => Promise<void>,
+): Promise<number[]> {
+  const interval = Math.floor(iterations / snapshots)
+  const heaps: number[] = []
+
+  tryGC()
+  heaps.push(heapMB())
+
+  for (let i = 0; i < iterations; i++) {
+    await fn(i)
+    if ((i + 1) % interval === 0) {
+      tryGC()
+      heaps.push(heapMB())
+    }
+  }
+
+  return heaps
+}
+
+/**
+ * Check that heap growth is bounded:
+ * last snapshot - first snapshot < maxGrowthMB.
+ */
+function assertBoundedGrowth(
+  heaps: number[],
+  maxGrowthMB: number,
+  label: string,
+): void {
+  const growth = heaps[heaps.length - 1] - heaps[0]
+  const peak = Math.max(...heaps)
+  const valley = Math.min(...heaps)
+
+  console.log(
+    `  [${label}] heap snapshots (MB): ${heaps.map((h) => h.toFixed(1)).join(" -> ")}`,
+  )
+  console.log(
+    `  [${label}] growth: ${growth.toFixed(1)} MB, peak: ${peak.toFixed(1)} MB, valley: ${valley.toFixed(1)} MB`,
+  )
+
+  expect(growth).toBeLessThan(maxGrowthMB)
+}
+
+// =============================================================================
+// 1. CUSTOM COMPACTION -- hot path: chat.message + compaction
+// =============================================================================
+describe("leak: custom-compaction", () => {
+  const ITERATIONS = 500
+  const SNAPSHOTS = 5
+  const MAX_GROWTH_MB = 30
+
+  it("chat.message + compaction cycle doesn't leak", async () => {
+    const dir = await createTempDir({
+      ".opencode/session-state.yaml": FIXTURE_SESSION_STATE,
+      ".opencode/state/todos.json": FIXTURE_TODOS,
+      "docs/sprint-artifacts/sprint-1/stories/story-01-03-jwt-refresh.md":
+        FIXTURE_STORY_MD,
+    })
+    const ctx = createMockCtx(dir)
+    const hooks = await CustomCompactionPlugin(ctx as any)
+
+    const heaps = await profile(ITERATIONS, SNAPSHOTS, async (i) => {
+      await hooks["chat.message"]!(
+        { agent: "dev", sessionID: `s-${i}` } as any,
+        { message: {}, parts: [] } as any,
+      )
+      const output = { context: [] as string[], prompt: undefined }
+      await hooks["experimental.session.compacting"]!(
+        { sessionID: `s-${i}` } as any,
+        output as any,
+      )
+    })
+
+    assertBoundedGrowth(heaps, MAX_GROWTH_MB, "compaction-cycle")
+    await cleanupTempDir(dir)
+  })
+
+  it("chat.message rapid-fire doesn't accumulate strings", async () => {
+    const dir = await createTempDir()
+    const ctx = createMockCtx(dir)
+    const hooks = await CustomCompactionPlugin(ctx as any)
+
+    const heaps = await profile(2000, SNAPSHOTS, async (i) => {
+      await hooks["chat.message"]!(
+        { agent: `agent-${i % 50}`, sessionID: `s-${i}` } as any,
+        { message: {}, parts: [] } as any,
+      )
+    })
+
+    assertBoundedGrowth(heaps, MAX_GROWTH_MB, "chat.message-rapid")
+    await cleanupTempDir(dir)
+  })
+
+  it("event hook doesn't leak on repeated session.idle", async () => {
+    const dir = await createTempDir()
+    const ctx = createMockCtx(dir)
+    const hooks = await CustomCompactionPlugin(ctx as any)
+
+    const heaps = await profile(1000, SNAPSHOTS, async () => {
+      await hooks.event!({ event: { type: "session.idle" } as any })
+    })
+
+    assertBoundedGrowth(heaps, MAX_GROWTH_MB, "event-idle")
+    await cleanupTempDir(dir)
+  })
+
+  it("plugin factory doesn't leak across many instances", async () => {
+    const heaps = await profile(100, SNAPSHOTS, async (i) => {
+      const dir = await createTempDir()
+      const ctx = createMockCtx(dir)
+      const hooks = await CustomCompactionPlugin(ctx as any)
+      await hooks["chat.message"]!(
+        { agent: "dev", sessionID: `s-${i}` } as any,
+        { message: {}, parts: [] } as any,
+      )
+      const output = { context: [] as string[], prompt: undefined }
+      await hooks["experimental.session.compacting"]!(
+        { sessionID: `s-${i}` } as any,
+        output as any,
+      )
+      await cleanupTempDir(dir)
+    })
+
+    assertBoundedGrowth(heaps, 50, "compaction-instances")
+  })
+})
+
+// =============================================================================
+// 2. FILE INDEXER -- hot path: event handler (file.edited queueing)
+// =============================================================================
+describe("leak: file-indexer", () => {
+  const ITERATIONS = 1000
+  const SNAPSHOTS = 5
+  const MAX_GROWTH_MB = 30
+
+  it("file.edited event handler doesn't leak (cycling file names)", async () => {
+    const dir = await createTempDir({
+      ".opencode/config.yaml": FIXTURE_CONFIG_YAML,
+    })
+    const ctx = createMockCtx(dir)
+    const hooks = await FileIndexerPlugin(ctx as any)
+
+    const heaps = await profile(ITERATIONS, SNAPSHOTS, async (i) => {
+      await hooks.event!({
+        event: {
+          type: "file.edited",
+          properties: { file: join(dir, `src/file-${i % 50}.ts`) },
+        } as any,
+      })
+    })
+
+    assertBoundedGrowth(heaps, MAX_GROWTH_MB, "file-edited-events")
+    await cleanupTempDir(dir)
+  })
+
+  it("disabled plugin doesn't accumulate anything", async () => {
+    const dir = await createTempDir({
+      ".opencode/config.yaml": `vectorizer:\n  enabled: false\n  auto_index: false\n`,
+    })
+    const ctx = createMockCtx(dir)
+    const hooks = await FileIndexerPlugin(ctx as any)
+
+    const heaps = await profile(2000, SNAPSHOTS, async () => {
+      await hooks.event!({
+        event: {
+          type: "file.edited",
+          properties: { file: join(dir, "src/app.ts") },
+        } as any,
+      })
+    })
+
+    assertBoundedGrowth(heaps, 10, "disabled-plugin")
+    await cleanupTempDir(dir)
+  })
+})
+
+// =============================================================================
+// 3. VERSION CHECK -- hot path: event handler (no-op)
+// =============================================================================
+describe("leak: version-check", () => {
+  const ITERATIONS = 2000
+  const SNAPSHOTS = 5
+  const MAX_GROWTH_MB = 10
+
+  it("no-op event handler doesn't leak", async () => {
+    const dir = await createTempDir()
+    const ctx = createMockCtx(dir)
+    const hooks = await VersionCheckPlugin(ctx as any)
+
+    const heaps = await profile(ITERATIONS, SNAPSHOTS, async () => {
+      await hooks.event!({ event: { type: "session.idle" } as any })
+    })
+
+    assertBoundedGrowth(heaps, MAX_GROWTH_MB, "version-noop")
+    await cleanupTempDir(dir)
+  })
+
+  it("multiple plugin instances don't leak", async () => {
+    const heaps = await profile(100, SNAPSHOTS, async () => {
+      const dir = await createTempDir()
+      const ctx = createMockCtx(dir)
+      const hooks = await VersionCheckPlugin(ctx as any)
+      await hooks.event!({ event: { type: "session.idle" } as any })
+      await cleanupTempDir(dir)
+    })
+
+    assertBoundedGrowth(heaps, 30, "version-instances")
+  })
+})
+
+// =============================================================================
+// 4. COMBINED -- simulate a realistic session with all 3 plugins
+// =============================================================================
+describe("leak: combined realistic session", () => {
+  it("all 3 plugins running together don't leak", async () => {
+    const dir = await createTempDir({
+      ".opencode/session-state.yaml": FIXTURE_SESSION_STATE,
+      ".opencode/state/todos.json": FIXTURE_TODOS,
+      ".opencode/config.yaml": FIXTURE_CONFIG_YAML,
+      "docs/sprint-artifacts/sprint-1/stories/story-01-03-jwt-refresh.md":
+        FIXTURE_STORY_MD,
+    })
+    const ctx = createMockCtx(dir)
+
+    const [compaction, indexer, versionCheck] = await Promise.all([
+      CustomCompactionPlugin(ctx as any),
+      FileIndexerPlugin(ctx as any),
+      VersionCheckPlugin(ctx as any),
+    ])
+
+    const heaps = await profile(300, 5, async (i) => {
+      // Simulate realistic session cycle:
+      // 1. Agent sends message
+      await compaction["chat.message"]!(
+        { agent: "dev", sessionID: `s-${i}` } as any,
+        { message: {}, parts: [] } as any,
+      )
+
+      // 2. File gets edited
+      await indexer.event!({
+        event: {
+          type: "file.edited",
+          properties: { file: join(dir, `src/module-${i % 20}.ts`) },
+        } as any,
+      })
+
+      // 3. Session idle
+      await compaction.event!({ event: { type: "session.idle" } as any })
+      await versionCheck.event!({ event: { type: "session.idle" } as any })
+
+      // 4. Every 50 iterations, simulate compaction
+      if (i % 50 === 0) {
+        const output = { context: [] as string[], prompt: undefined }
+        await compaction["experimental.session.compacting"]!(
+          { sessionID: `s-${i}` } as any,
+          output as any,
+        )
+      }
+    })
+
+    assertBoundedGrowth(heaps, 40, "combined-session")
+    await cleanupTempDir(dir)
+  })
+})

package/src/opencode/plugins/__tests__/version-check.test.ts

@@ -0,0 +1,223 @@
+import { describe, it, expect, beforeEach, afterEach } from "bun:test"
+import { join } from "path"
+import { writeFile } from "fs/promises"
+import { VersionCheckPlugin } from "../version-check"
+import { createMockCtx, createTempDir, cleanupTempDir } from "./helpers/mock-ctx"
+
+// =============================================================================
+// LOCAL REPLICAS of internal functions (not exported from plugin)
+// These mirror the source logic so we can unit-test the algorithms directly.
+// =============================================================================
+
+/** Replica of compareVersions from version-check.ts (with pre-release strip fix) */
+function compareVersions(local: string, latest: string): number {
+  const strip = (v: string) => v.replace(/-.*$/, '')
+  const localParts = strip(local).split('.').map(Number)
+  const latestParts = strip(latest).split('.').map(Number)
+
+  for (let i = 0; i < 3; i++) {
+    const l = localParts[i] || 0
+    const r = latestParts[i] || 0
+    if (l < r) return -1
+    if (l > r) return 1
+  }
+  return 0
+}
+
+// =============================================================================
+// UNIT TESTS: compareVersions (replica)
+// =============================================================================
+describe("compareVersions", () => {
+  it("returns 0 for equal versions", () => {
+    expect(compareVersions("1.0.0", "1.0.0")).toBe(0)
+    expect(compareVersions("4.36.21", "4.36.21")).toBe(0)
+  })
+
+  it("returns -1 when local < latest (patch)", () => {
+    expect(compareVersions("1.0.0", "1.0.1")).toBe(-1)
+  })
+
+  it("returns -1 when local < latest (minor)", () => {
+    expect(compareVersions("1.0.0", "1.1.0")).toBe(-1)
+  })
+
+  it("returns -1 when local < latest (major)", () => {
+    expect(compareVersions("1.0.0", "2.0.0")).toBe(-1)
+  })
+
+  it("returns 1 when local > latest (patch)", () => {
+    expect(compareVersions("1.0.2", "1.0.1")).toBe(1)
+  })
+
+  it("returns 1 when local > latest (minor)", () => {
+    expect(compareVersions("1.2.0", "1.1.9")).toBe(1)
+  })
+
+  it("returns 1 when local > latest (major)", () => {
+    expect(compareVersions("3.0.0", "2.99.99")).toBe(1)
+  })
+
+  it("handles versions with missing parts", () => {
+    expect(compareVersions("1.0", "1.0.0")).toBe(0)
+    expect(compareVersions("1", "1.0.0")).toBe(0)
+    expect(compareVersions("1.0.0", "1.0")).toBe(0)
+  })
+
+  it("handles large version numbers", () => {
+    expect(compareVersions("100.200.300", "100.200.300")).toBe(0)
+    expect(compareVersions("100.200.300", "100.200.301")).toBe(-1)
+  })
+
+  it("handles pre-release versions (strips suffix)", () => {
+    expect(compareVersions("4.38.1-beta.1", "4.38.1")).toBe(0)
+    expect(compareVersions("4.38.1-dev.16", "4.38.2")).toBe(-1)
+    expect(compareVersions("5.0.0-rc.1", "4.99.99")).toBe(1)
+    expect(compareVersions("1.0.0-alpha", "1.0.0-beta")).toBe(0) // both strip to 1.0.0
+  })
+
+  it("does not return NaN for pre-release versions", () => {
+    const result = compareVersions("4.38.1-beta.1", "4.38.2")
+    expect(result).not.toBeNaN()
+    expect(result).toBe(-1)
+  })
+})
+
+// =============================================================================
+// INTEGRATION: Plugin initialization & hooks
+// =============================================================================
+describe("VersionCheckPlugin", () => {
+  let tempDir: string
+
+  beforeEach(async () => {
+    tempDir = await createTempDir()
+  })
+
+  afterEach(async () => {
+    await cleanupTempDir(tempDir)
+  })
+
+  it("returns hooks object with event handler", async () => {
+    const ctx = createMockCtx(tempDir)
+    const hooks = await VersionCheckPlugin(ctx as any)
+
+    expect(hooks).toBeDefined()
+    expect(hooks.event).toBeFunction()
+  })
+
+  it("event handler is a no-op (does not throw)", async () => {
+    const ctx = createMockCtx(tempDir)
+    const hooks = await VersionCheckPlugin(ctx as any)
+
+    // Call event with various event types - should not throw
+    await hooks.event!({ event: { type: "session.idle" } as any })
+    await hooks.event!({ event: { type: "file.edited" } as any })
+    await hooks.event!({ event: { type: "unknown.event" } as any })
+  })
+
+  it("does not throw when client.tui is missing", async () => {
+    const ctx = {
+      directory: tempDir,
+      worktree: tempDir,
+      client: {},
+      project: { name: "test" },
+      serverUrl: new URL("http://localhost:3000"),
+      $: {},
+    }
+    // Should not throw even with minimal client
+    const hooks = await VersionCheckPlugin(ctx as any)
+    expect(hooks).toBeDefined()
+  })
+
+  it("getLocalVersion reads build-info.json via plugin behavior", async () => {
+    // Write build-info.json — the plugin reads this internally during setTimeout
+    await writeFile(
+      join(tempDir, ".opencode", "build-info.json"),
+      JSON.stringify({ version: "4.38.0" })
+    )
+    const ctx = createMockCtx(tempDir)
+    const hooks = await VersionCheckPlugin(ctx as any)
+    // Plugin initializes successfully
+    expect(hooks).toBeDefined()
+  })
+
+  it("getLocalVersion fallback to config.yaml", async () => {
+    await writeFile(
+      join(tempDir, ".opencode", "config.yaml"),
+      `version: "3.5.0"\nproject_name: test\n`
+    )
+    const ctx = createMockCtx(tempDir)
+    const hooks = await VersionCheckPlugin(ctx as any)
+    expect(hooks).toBeDefined()
+  })
+
+  it("getLanguage defaults to 'en' when config missing", async () => {
+    // No config.yaml — language detection should default to 'en'
+    const ctx = createMockCtx(tempDir)
+    const hooks = await VersionCheckPlugin(ctx as any)
+    expect(hooks).toBeDefined()
+  })
+
+  it("loads and saves cache via plugin lifecycle", async () => {
+    // Write version info so plugin has something to work with
+    await writeFile(
+      join(tempDir, ".opencode", "build-info.json"),
+      JSON.stringify({ version: "4.38.0" })
+    )
+    const ctx = createMockCtx(tempDir)
+    const hooks = await VersionCheckPlugin(ctx as any)
+    expect(hooks).toBeDefined()
+    // Plugin will attempt to check version in background (setTimeout)
+    // No assertion needed — just ensure no crash
+  })
+})
+
+// =============================================================================
+// MEMORY SAFETY
+// =============================================================================
+describe("memory safety", () => {
+  let tempDir: string
+
+  beforeEach(async () => {
+    tempDir = await createTempDir()
+  })
+
+  afterEach(async () => {
+    await cleanupTempDir(tempDir)
+  })
+
+  it("no state accumulation across multiple event calls", async () => {
+    const ctx = createMockCtx(tempDir)
+    const hooks = await VersionCheckPlugin(ctx as any)
+
+    // Call event handler many times - should not accumulate state
+    for (let i = 0; i < 1000; i++) {
+      await hooks.event!({ event: { type: "session.idle" } as any })
+    }
+
+    // If we get here without OOM or excessive delay, no leak
+    expect(true).toBe(true)
+  })
+
+  it("multiple plugin initializations don't leak", async () => {
+    const memBefore = process.memoryUsage().heapUsed
+
+    for (let i = 0; i < 50; i++) {
+      const dir = await createTempDir()
+      const ctx = createMockCtx(dir)
+      const hooks = await VersionCheckPlugin(ctx as any)
+      await hooks.event!({ event: { type: "session.idle" } as any })
+      await cleanupTempDir(dir)
+    }
+
+    // Force GC if available
+    if (typeof Bun !== "undefined" && (globalThis as any).gc) {
+      ;(globalThis as any).gc()
+    }
+
+    const memAfter = process.memoryUsage().heapUsed
+    const growthMB = (memAfter - memBefore) / 1024 / 1024
+
+    // Memory growth should be < 50MB for 50 iterations
+    expect(growthMB).toBeLessThan(50)
+  })
+})

package/src/opencode/plugins/custom-compaction.ts

@@ -260,8 +260,9 @@ DO NOT skip this step. DO NOT ask user what to do. Just read these files first.`
                 const fullPath = join(statePath, stateFile)
                 const content = await readFile(fullPath, "utf-8")
                 
-                // Check if this epic is in-progress
-                if (content.includes("status: \"in-progress\"") || content.includes("status: in-progress")) {
+                // Check if this epic is in-progress (normalize variants)
+                const contentLower = content.toLowerCase()
+                if (contentLower.includes("status: \"in-progress\"") || contentLower.includes("status: in-progress") || contentLower.includes("status: \"in_progress\"") || contentLower.includes("status: in_progress")) {
                   // Parse epic state
                   const epicIdMatch = content.match(/epic_id:\s*["']?([^"'\n]+)["']?/i)
                   const epicTitleMatch = content.match(/epic_title:\s*["']?([^"'\n]+)["']?/i)
@@ -343,11 +344,18 @@ DO NOT skip this step. DO NOT ask user what to do. Just read these files first.`
         return m ? m[1].trim() : null
       }
       const list = (parent: string, key: string): string[] => {
+        // First try inline format: key: [T1, T2] or key: T1, T2
         const val = nested(parent, key)
-        if (!val) return []
-        // Handle [T1, T2] or T1, T2
-        const clean = val.replace(/^\[/, '').replace(/\]$/, '')
-        return clean.split(',').map(s => s.trim()).filter(Boolean)
+        if (val) {
+          const clean = val.replace(/^\[/, '').replace(/\]$/, '')
+          return clean.split(',').map(s => s.trim()).filter(Boolean)
+        }
+        // Fallback: YAML block list under parent.key
+        const section = content.match(new RegExp(`^${parent}:\\s*\\n([\\s\\S]*?)(?=^\\w+:|$)`, 'm'))
+        if (!section) return []
+        const keyBlock = section[1].match(new RegExp(`^\\s+${key}:\\s*\\n((?:\\s+-\\s+.+\\n?)*)`, 'm'))
+        if (!keyBlock) return []
+        return [...keyBlock[1].matchAll(/^\s+-\s+(.+)$/gm)].map(m => m[1].trim())
       }
 
       // Parse key_decisions as list
@@ -422,7 +430,7 @@ DO NOT skip this step. DO NOT ask user what to do. Just read these files first.`
       // Parse story file
       const storyContent = await readFile(join(directory, storyPath), "utf-8")
       const titleMatch = storyContent.match(/^#\s+(.+)/m)
-      const statusMatch = storyContent.match(/\*\*Status:\*\*\s*(\w+)/i)
+      const statusMatch = storyContent.match(/\*\*Status:\*\*\s*([\w-]+)/i)
 
       const completedTasks: string[] = []
       const pendingTasks: string[] = []
@@ -547,7 +555,7 @@ DO NOT skip this step. DO NOT ask user what to do. Just read these files first.`
     try {
       const storyContent = await readFile(join(directory, storyPath), "utf-8")
       const titleMatch = storyContent.match(/^#\s+(.+)/m)
-      const statusMatch = storyContent.match(/\*\*Status:\*\*\s*(\w+)/i)
+      const statusMatch = storyContent.match(/\*\*Status:\*\*\s*([\w-]+)/i)
 
       const completedTasks: string[] = []
       const pendingTasks: string[] = []
@@ -802,7 +810,8 @@ ${ctx.relevantFiles.map(f => `- \`${f}\``).join("\n")}`)
   async function formatInstructions(ctx: SessionContext): Promise<string> {
     const agent = ctx.activeAgent?.toLowerCase()
     const hasInProgressTasks = ctx.todos.some(t => t.status === "in_progress")
-    const hasInProgressStory = ctx.story?.status === "in-progress"
+    const storyStatus = ctx.story?.status?.toLowerCase().replace(/_/g, '-') || ''
+    const hasInProgressStory = storyStatus === "in-progress"
     
     // Check if we're in epic workflow
     const epicState = await getActiveEpicState()
@@ -1022,6 +1031,9 @@ This is /dev-epic autopilot mode. Execute stories sequentially until epic done.`
       await log(directory, `=== COMPACTION STARTED ===`)
       await log(directory, `  lastActiveAgent: ${lastActiveAgent}`)
       
+      // Guard: ensure output.context is an array
+      if (!output.context) output.context = []
+      
       // Use tracked agent or try to detect from session
       const agent = lastActiveAgent
       const ctx = await buildContext(agent)
@@ -1039,6 +1051,14 @@ This is /dev-epic autopilot mode. Execute stories sequentially until epic done.`
       const ss = ctx.sessionState
       const briefing = buildBriefing(agent, ss, ctx, readCommands)
       output.context.push(briefing)
+
+      // Push agent-specific context (story details, epic progress, AC) and resume instructions
+      if (context) {
+        output.context.push(context)
+      }
+      if (instructions) {
+        output.context.push(instructions)
+      }
       
       await log(directory, `  -> output.context pushed (${output.context.length} items)`)
       await log(directory, `=== COMPACTION DONE ===`)