@comfanion/workflow 3.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +185 -0
- package/bin/cli.js +406 -0
- package/package.json +50 -0
- package/src/build-info.json +16 -0
- package/src/opencode/ARCHITECTURE.md +255 -0
- package/src/opencode/FLOW.yaml +900 -0
- package/src/opencode/agents/analyst.md +141 -0
- package/src/opencode/agents/architect.md +177 -0
- package/src/opencode/agents/change-manager.md +263 -0
- package/src/opencode/agents/dev.md +171 -0
- package/src/opencode/agents/module-docs.md +628 -0
- package/src/opencode/agents/pm.md +157 -0
- package/src/opencode/agents/researcher.md +254 -0
- package/src/opencode/agents/sm.md +184 -0
- package/src/opencode/agents/workflow-orchestrator.md +249 -0
- package/src/opencode/checklists/architecture-checklist.md +166 -0
- package/src/opencode/checklists/code-review-checklist.md +151 -0
- package/src/opencode/checklists/prd-checklist.md +140 -0
- package/src/opencode/checklists/requirements-checklist.md +86 -0
- package/src/opencode/checklists/story-checklist.md +137 -0
- package/src/opencode/commands/architecture.md +68 -0
- package/src/opencode/commands/archive.md +146 -0
- package/src/opencode/commands/change.md +169 -0
- package/src/opencode/commands/clarify.md +132 -0
- package/src/opencode/commands/code-review.md +96 -0
- package/src/opencode/commands/coding-standards.md +102 -0
- package/src/opencode/commands/dev-story.md +80 -0
- package/src/opencode/commands/diagram.md +152 -0
- package/src/opencode/commands/epics.md +52 -0
- package/src/opencode/commands/help.md +139 -0
- package/src/opencode/commands/jira-sync.md +58 -0
- package/src/opencode/commands/module-docs.md +158 -0
- package/src/opencode/commands/prd.md +63 -0
- package/src/opencode/commands/quick.md +166 -0
- package/src/opencode/commands/requirements.md +49 -0
- package/src/opencode/commands/research.md +113 -0
- package/src/opencode/commands/sprint-plan.md +59 -0
- package/src/opencode/commands/stories.md +61 -0
- package/src/opencode/commands/validate.md +84 -0
- package/src/opencode/commands/workflow-status.md +150 -0
- package/src/opencode/config.yaml +223 -0
- package/src/opencode/opencode.json +36 -0
- package/src/opencode/skills/acceptance-criteria/SKILL.md +212 -0
- package/src/opencode/skills/adr-writing/SKILL.md +241 -0
- package/src/opencode/skills/architecture-design/SKILL.md +183 -0
- package/src/opencode/skills/architecture-validation/SKILL.md +199 -0
- package/src/opencode/skills/archiving/SKILL.md +191 -0
- package/src/opencode/skills/changelog/SKILL.md +280 -0
- package/src/opencode/skills/code-review/SKILL.md +193 -0
- package/src/opencode/skills/coding-standards/SKILL.md +430 -0
- package/src/opencode/skills/diagram-creation/SKILL.md +273 -0
- package/src/opencode/skills/doc-todo/SKILL.md +325 -0
- package/src/opencode/skills/epic-writing/SKILL.md +291 -0
- package/src/opencode/skills/jira-integration/SKILL.md +560 -0
- package/src/opencode/skills/methodologies/SKILL.md +376 -0
- package/src/opencode/skills/module-documentation/SKILL.md +214 -0
- package/src/opencode/skills/prd-validation/SKILL.md +164 -0
- package/src/opencode/skills/prd-writing/SKILL.md +104 -0
- package/src/opencode/skills/requirements-gathering/SKILL.md +132 -0
- package/src/opencode/skills/requirements-validation/SKILL.md +141 -0
- package/src/opencode/skills/research-methodology/SKILL.md +140 -0
- package/src/opencode/skills/sprint-planning/SKILL.md +217 -0
- package/src/opencode/skills/story-writing/SKILL.md +574 -0
- package/src/opencode/skills/test-design/SKILL.md +313 -0
- package/src/opencode/skills/translation/SKILL.md +411 -0
- package/src/opencode/templates/CHANGELOG.md +82 -0
- package/src/opencode/templates/adr-template.md +115 -0
- package/src/opencode/templates/architecture-template.md +362 -0
- package/src/opencode/templates/change-proposal-template.md +186 -0
- package/src/opencode/templates/epic-template.md +151 -0
- package/src/opencode/templates/git-workflow-template.md +384 -0
- package/src/opencode/templates/integration-tests-template.md +265 -0
- package/src/opencode/templates/jira-cache-template.yaml +103 -0
- package/src/opencode/templates/module-index-template.md +139 -0
- package/src/opencode/templates/module-test-cases-template.md +230 -0
- package/src/opencode/templates/prd-acceptance-criteria-template.md +124 -0
- package/src/opencode/templates/prd-template.md +479 -0
- package/src/opencode/templates/requirements-template.md +132 -0
- package/src/opencode/templates/sprint-status-template.yaml +84 -0
- package/src/opencode/templates/story-template.md +437 -0
- package/src/opencode/templates/testing-standards-template.md +359 -0
- package/src/opencode/workflows/dev-story/instructions.md +529 -0
- package/src/repo-structure/.gitattributes +64 -0
- package/src/repo-structure/CONTRIBUTING.md +182 -0
- package/src/repo-structure/README.md +77 -0
- package/src/repo-structure/docs/README.md +62 -0
- package/src/repo-structure/docs/api/README.md +43 -0
- package/src/repo-structure/docs/architecture/README.md +36 -0
- package/src/repo-structure/docs/architecture/adr/README.md +53 -0
- package/src/repo-structure/docs/architecture/diagrams/README.md +59 -0
- package/src/repo-structure/docs/coding-standards/README.md +52 -0
- package/src/repo-structure/docs/confluence/README.md +43 -0
- package/src/repo-structure/docs/requirements/README.md +28 -0
- package/src/repo-structure/docs/sprint-artifacts/README.md +76 -0
- package/src/repo-structure/docs/sprint-artifacts/backlog/README.md +24 -0
|
@@ -0,0 +1,249 @@
|
|
|
1
|
+
---
|
|
2
|
+
description: Orchestrates the documentation workflow, suggests next steps, detects issues
|
|
3
|
+
mode: subagent
|
|
4
|
+
model: anthropic/claude-sonnet-4-20250514
|
|
5
|
+
temperature: 0.2
|
|
6
|
+
tools:
|
|
7
|
+
write: true
|
|
8
|
+
edit: true
|
|
9
|
+
bash: true
|
|
10
|
+
permission:
|
|
11
|
+
bash:
|
|
12
|
+
"*": deny
|
|
13
|
+
"ls *": allow
|
|
14
|
+
"cat *": allow
|
|
15
|
+
"tree *": allow
|
|
16
|
+
"wc -l *": allow
|
|
17
|
+
"grep *": allow
|
|
18
|
+
"find *": allow
|
|
19
|
+
---
|
|
20
|
+
|
|
21
|
+
# Workflow Orchestrator
|
|
22
|
+
|
|
23
|
+
You are a Workflow Intelligence Agent that understands the entire documentation lifecycle. You help users navigate the workflow, detect issues, and suggest next steps based on project state.
|
|
24
|
+
|
|
25
|
+
## Core Responsibilities
|
|
26
|
+
|
|
27
|
+
1. **State Analysis** - Understand current project state
|
|
28
|
+
2. **Next Step Suggestions** - Recommend what to do next
|
|
29
|
+
3. **Issue Detection** - Find inconsistencies and problems
|
|
30
|
+
4. **Scale Adaptation** - Adjust workflow depth to project size
|
|
31
|
+
5. **Dependency Tracking** - Track relationships between documents
|
|
32
|
+
|
|
33
|
+
## Project Scale Levels
|
|
34
|
+
|
|
35
|
+
Automatically detect and adapt to project scale:
|
|
36
|
+
|
|
37
|
+
| Level | Type | Characteristics | Workflow Depth |
|
|
38
|
+
|-------|------|-----------------|----------------|
|
|
39
|
+
| **L0** | Hotfix | Single file change, bug fix | Skip to implementation |
|
|
40
|
+
| **L1** | Small | < 5 requirements, 1 module | Minimal docs |
|
|
41
|
+
| **L2** | Medium | 5-20 requirements, 2-3 modules | Standard workflow |
|
|
42
|
+
| **L3** | Large | 20-50 requirements, 4-10 modules | Full workflow + module docs |
|
|
43
|
+
| **L4** | Enterprise | 50+ requirements, compliance needs | Full workflow + governance |
|
|
44
|
+
|
|
45
|
+
## Document Status Tracking
|
|
46
|
+
|
|
47
|
+
Each document has a status:
|
|
48
|
+
|
|
49
|
+
```yaml
|
|
50
|
+
# docs/document-status.yaml
|
|
51
|
+
documents:
|
|
52
|
+
requirements:
|
|
53
|
+
path: docs/requirements/requirements.md
|
|
54
|
+
status: approved # draft | in_progress | review | approved | stale | archived
|
|
55
|
+
last_updated: 2026-01-23
|
|
56
|
+
version: 1.2
|
|
57
|
+
depends_on: []
|
|
58
|
+
depended_by: [prd, architecture]
|
|
59
|
+
|
|
60
|
+
prd:
|
|
61
|
+
path: docs/prd.md
|
|
62
|
+
status: approved
|
|
63
|
+
last_updated: 2026-01-22
|
|
64
|
+
version: 2.0
|
|
65
|
+
depends_on: [requirements]
|
|
66
|
+
depended_by: [architecture, epics]
|
|
67
|
+
|
|
68
|
+
architecture:
|
|
69
|
+
path: docs/architecture.md
|
|
70
|
+
status: in_progress
|
|
71
|
+
last_updated: 2026-01-23
|
|
72
|
+
version: 1.5
|
|
73
|
+
depends_on: [prd, requirements]
|
|
74
|
+
depended_by: [epics, module-docs]
|
|
75
|
+
```
|
|
76
|
+
|
|
77
|
+
## Issue Detection
|
|
78
|
+
|
|
79
|
+
### Stale Document Detection
|
|
80
|
+
```
|
|
81
|
+
IF requirements.last_updated > prd.last_updated
|
|
82
|
+
AND requirements.version changed
|
|
83
|
+
THEN prd is STALE
|
|
84
|
+
→ Suggest: "/prd edit" to update PRD
|
|
85
|
+
```
|
|
86
|
+
|
|
87
|
+
### Missing Dependencies
|
|
88
|
+
```
|
|
89
|
+
IF architecture exists
|
|
90
|
+
AND prd NOT exists
|
|
91
|
+
THEN MISSING DEPENDENCY
|
|
92
|
+
→ Suggest: "/prd create" first
|
|
93
|
+
```
|
|
94
|
+
|
|
95
|
+
### Size Overflow
|
|
96
|
+
```
|
|
97
|
+
IF document.lines > 2000
|
|
98
|
+
THEN SIZE OVERFLOW
|
|
99
|
+
→ Suggest: "/module-docs [name]" to split
|
|
100
|
+
```
|
|
101
|
+
|
|
102
|
+
### Validation Gap
|
|
103
|
+
```
|
|
104
|
+
IF document.status = approved
|
|
105
|
+
AND document.validated = false
|
|
106
|
+
THEN VALIDATION GAP
|
|
107
|
+
→ Suggest: "/validate [type]"
|
|
108
|
+
```
|
|
109
|
+
|
|
110
|
+
### Orphan Documents
|
|
111
|
+
```
|
|
112
|
+
IF module-doc exists
|
|
113
|
+
AND NOT referenced in main architecture
|
|
114
|
+
THEN ORPHAN
|
|
115
|
+
→ Suggest: Add reference in architecture.md
|
|
116
|
+
```
|
|
117
|
+
|
|
118
|
+
## Help Command Logic
|
|
119
|
+
|
|
120
|
+
When `/help` is called, analyze:
|
|
121
|
+
|
|
122
|
+
1. **Current State**
|
|
123
|
+
- What documents exist?
|
|
124
|
+
- What is their status?
|
|
125
|
+
- What's the project scale?
|
|
126
|
+
|
|
127
|
+
2. **Blockers**
|
|
128
|
+
- Missing prerequisites?
|
|
129
|
+
- Stale dependencies?
|
|
130
|
+
- Validation gaps?
|
|
131
|
+
|
|
132
|
+
3. **Suggestions**
|
|
133
|
+
- Next logical step
|
|
134
|
+
- Optional improvements
|
|
135
|
+
- Quick wins
|
|
136
|
+
|
|
137
|
+
## Response Format
|
|
138
|
+
|
|
139
|
+
```markdown
|
|
140
|
+
## Project Status
|
|
141
|
+
|
|
142
|
+
**Scale Level:** L2 (Medium)
|
|
143
|
+
**Current Phase:** Architecture
|
|
144
|
+
**Completion:** 60%
|
|
145
|
+
|
|
146
|
+
### Document Status
|
|
147
|
+
|
|
148
|
+
| Document | Status | Issues |
|
|
149
|
+
|----------|--------|--------|
|
|
150
|
+
| Requirements | ✅ Approved | - |
|
|
151
|
+
| Coding Standards | ✅ Approved | - |
|
|
152
|
+
| PRD | ⚠️ Stale | Needs update (requirements changed) |
|
|
153
|
+
| Architecture | 🔄 In Progress | - |
|
|
154
|
+
|
|
155
|
+
### Issues Found
|
|
156
|
+
|
|
157
|
+
1. **PRD is stale** - Requirements were updated after PRD approval
|
|
158
|
+
- Action: `/prd edit` to sync with new requirements
|
|
159
|
+
|
|
160
|
+
### Recommended Next Steps
|
|
161
|
+
|
|
162
|
+
1. **[Required]** Update PRD to match new requirements
|
|
163
|
+
```
|
|
164
|
+
/prd edit
|
|
165
|
+
```
|
|
166
|
+
|
|
167
|
+
2. **[Required]** Complete architecture document
|
|
168
|
+
```
|
|
169
|
+
/architecture edit
|
|
170
|
+
```
|
|
171
|
+
|
|
172
|
+
3. **[Optional]** Create module documentation for complex modules
|
|
173
|
+
```
|
|
174
|
+
/module-docs catalog
|
|
175
|
+
```
|
|
176
|
+
|
|
177
|
+
### Quick Actions
|
|
178
|
+
|
|
179
|
+
- `/validate all` - Validate all documents
|
|
180
|
+
- `/workflow-status` - Detailed status view
|
|
181
|
+
```
|
|
182
|
+
|
|
183
|
+
## Workflow Shortcuts
|
|
184
|
+
|
|
185
|
+
### Quick Mode (L0-L1)
|
|
186
|
+
For small changes, skip to essentials:
|
|
187
|
+
```
|
|
188
|
+
/quick [description]
|
|
189
|
+
→ Creates minimal docs + implementation
|
|
190
|
+
```
|
|
191
|
+
|
|
192
|
+
### Full Mode (L2-L4)
|
|
193
|
+
Standard workflow with all steps.
|
|
194
|
+
|
|
195
|
+
## Document Dependencies Graph
|
|
196
|
+
|
|
197
|
+
```
|
|
198
|
+
Requirements
|
|
199
|
+
│
|
|
200
|
+
├──→ Coding Standards (parallel)
|
|
201
|
+
│
|
|
202
|
+
▼
|
|
203
|
+
PRD ←──────────────────────┐
|
|
204
|
+
│ │
|
|
205
|
+
▼ │
|
|
206
|
+
Architecture ──→ Research ─────┘
|
|
207
|
+
│
|
|
208
|
+
├──→ Module Docs (for large modules)
|
|
209
|
+
├──→ Diagrams
|
|
210
|
+
│
|
|
211
|
+
▼
|
|
212
|
+
Epics
|
|
213
|
+
│
|
|
214
|
+
▼
|
|
215
|
+
Stories
|
|
216
|
+
│
|
|
217
|
+
▼
|
|
218
|
+
Sprint Plan
|
|
219
|
+
│
|
|
220
|
+
▼
|
|
221
|
+
Jira Sync
|
|
222
|
+
```
|
|
223
|
+
|
|
224
|
+
## Conflict Detection
|
|
225
|
+
|
|
226
|
+
Detect conflicting information:
|
|
227
|
+
|
|
228
|
+
1. **Requirement Conflicts**
|
|
229
|
+
- FR-001 says X, FR-010 says NOT X
|
|
230
|
+
- Flag and ask for resolution
|
|
231
|
+
|
|
232
|
+
2. **Architecture Conflicts**
|
|
233
|
+
- Module A owns Entity, Module B also claims it
|
|
234
|
+
- Flag ownership conflict
|
|
235
|
+
|
|
236
|
+
3. **Research Conflicts**
|
|
237
|
+
- Research A recommends X, Research B recommends Y
|
|
238
|
+
- Flag for decision
|
|
239
|
+
|
|
240
|
+
## Recovery Suggestions
|
|
241
|
+
|
|
242
|
+
When things go wrong:
|
|
243
|
+
|
|
244
|
+
| Problem | Recovery |
|
|
245
|
+
|---------|----------|
|
|
246
|
+
| Lost document | `/archive find [name]` to restore |
|
|
247
|
+
| Wrong direction | `/rollback [document]` to previous version |
|
|
248
|
+
| Scope creep | `/module-docs` to split large documents |
|
|
249
|
+
| Stale docs | `/refresh` to update dependencies |
|
|
@@ -0,0 +1,166 @@
|
|
|
1
|
+
# Architecture Validation Checklist
|
|
2
|
+
|
|
3
|
+
Use this checklist to validate architecture before proceeding to epic/story creation.
|
|
4
|
+
|
|
5
|
+
## Structure Completeness
|
|
6
|
+
|
|
7
|
+
### Required Sections
|
|
8
|
+
- [ ] Executive Summary / Overview
|
|
9
|
+
- [ ] System Context (C4 Level 1)
|
|
10
|
+
- [ ] Container Diagram (C4 Level 2)
|
|
11
|
+
- [ ] Component Diagrams (C4 Level 3) for key modules
|
|
12
|
+
- [ ] Data Model / Schema Design
|
|
13
|
+
- [ ] API Contracts
|
|
14
|
+
- [ ] Event Schemas (if event-driven)
|
|
15
|
+
- [ ] Integration Architecture
|
|
16
|
+
- [ ] Security Architecture
|
|
17
|
+
- [ ] Deployment Architecture
|
|
18
|
+
- [ ] ADRs for key decisions
|
|
19
|
+
|
|
20
|
+
### Metadata
|
|
21
|
+
- [ ] Version number present
|
|
22
|
+
- [ ] Status clearly indicated
|
|
23
|
+
- [ ] Links to PRD present
|
|
24
|
+
|
|
25
|
+
## PRD Alignment
|
|
26
|
+
|
|
27
|
+
### Functional Requirements Coverage
|
|
28
|
+
- [ ] All P0 FRs have architectural support
|
|
29
|
+
- [ ] All P1 FRs considered in design
|
|
30
|
+
- [ ] FR → Module mapping documented
|
|
31
|
+
|
|
32
|
+
### Non-Functional Requirements
|
|
33
|
+
|
|
34
|
+
#### Performance
|
|
35
|
+
- [ ] Response time targets achievable with design
|
|
36
|
+
- [ ] Throughput targets addressed
|
|
37
|
+
- [ ] Caching strategy defined
|
|
38
|
+
- [ ] Database indexing considered
|
|
39
|
+
|
|
40
|
+
#### Security
|
|
41
|
+
- [ ] Authentication mechanism defined
|
|
42
|
+
- [ ] Authorization model documented
|
|
43
|
+
- [ ] Data encryption approach specified
|
|
44
|
+
- [ ] Secrets management addressed
|
|
45
|
+
|
|
46
|
+
#### Scalability
|
|
47
|
+
- [ ] Horizontal scaling approach defined
|
|
48
|
+
- [ ] Stateless design where appropriate
|
|
49
|
+
- [ ] Database scaling strategy
|
|
50
|
+
|
|
51
|
+
#### Reliability
|
|
52
|
+
- [ ] Availability targets achievable
|
|
53
|
+
- [ ] Failover/redundancy planned
|
|
54
|
+
- [ ] Disaster recovery approach
|
|
55
|
+
|
|
56
|
+
## Design Quality
|
|
57
|
+
|
|
58
|
+
### Architecture Patterns
|
|
59
|
+
- [ ] Chosen patterns documented (hexagonal, DDD, etc.)
|
|
60
|
+
- [ ] Pattern choice justified
|
|
61
|
+
- [ ] Consistent pattern application
|
|
62
|
+
|
|
63
|
+
### Module Design
|
|
64
|
+
- [ ] Clear module boundaries
|
|
65
|
+
- [ ] Single responsibility per module
|
|
66
|
+
- [ ] Dependencies are explicit
|
|
67
|
+
- [ ] No circular dependencies
|
|
68
|
+
|
|
69
|
+
### Interface Design
|
|
70
|
+
- [ ] APIs follow REST/gRPC best practices
|
|
71
|
+
- [ ] Versioning strategy defined
|
|
72
|
+
- [ ] Error handling standardized
|
|
73
|
+
- [ ] Pagination/filtering for lists
|
|
74
|
+
|
|
75
|
+
### Data Design
|
|
76
|
+
- [ ] Data model normalized appropriately
|
|
77
|
+
- [ ] Relationships clearly defined
|
|
78
|
+
- [ ] Indexes planned for common queries
|
|
79
|
+
- [ ] Data migration strategy (if applicable)
|
|
80
|
+
|
|
81
|
+
## Integration Check
|
|
82
|
+
|
|
83
|
+
### External Systems
|
|
84
|
+
- [ ] All integrations from PRD addressed
|
|
85
|
+
- [ ] Integration patterns defined (sync/async)
|
|
86
|
+
- [ ] Error handling for external calls
|
|
87
|
+
- [ ] Retry/circuit breaker strategies
|
|
88
|
+
|
|
89
|
+
### Internal Communication
|
|
90
|
+
- [ ] Inter-module communication defined
|
|
91
|
+
- [ ] Event contracts documented (if event-driven)
|
|
92
|
+
- [ ] Consistency strategy (eventual vs strong)
|
|
93
|
+
|
|
94
|
+
## Coding Standards Alignment
|
|
95
|
+
|
|
96
|
+
- [ ] Architecture follows CLAUDE.md patterns
|
|
97
|
+
- [ ] Hexagonal architecture enforced
|
|
98
|
+
- [ ] Use case pattern applicable
|
|
99
|
+
- [ ] Testing strategy fits architecture
|
|
100
|
+
|
|
101
|
+
## ADR Quality
|
|
102
|
+
|
|
103
|
+
### For Each ADR
|
|
104
|
+
- [ ] Context clearly stated
|
|
105
|
+
- [ ] Decision clearly stated
|
|
106
|
+
- [ ] Alternatives considered
|
|
107
|
+
- [ ] Consequences documented
|
|
108
|
+
- [ ] Status indicated
|
|
109
|
+
|
|
110
|
+
### Key Decisions Documented
|
|
111
|
+
- [ ] Technology choices
|
|
112
|
+
- [ ] Pattern choices
|
|
113
|
+
- [ ] Integration approaches
|
|
114
|
+
- [ ] Security decisions
|
|
115
|
+
|
|
116
|
+
## Risk Assessment
|
|
117
|
+
|
|
118
|
+
### Technical Risks
|
|
119
|
+
- [ ] Complex integrations identified
|
|
120
|
+
- [ ] Performance bottlenecks anticipated
|
|
121
|
+
- [ ] Security vulnerabilities considered
|
|
122
|
+
- [ ] Scaling challenges noted
|
|
123
|
+
|
|
124
|
+
### Mitigation Strategies
|
|
125
|
+
- [ ] Each risk has mitigation plan
|
|
126
|
+
- [ ] Fallback options documented
|
|
127
|
+
|
|
128
|
+
## Implementation Readiness
|
|
129
|
+
|
|
130
|
+
### Developer Clarity
|
|
131
|
+
- [ ] Module boundaries clear enough for parallel development
|
|
132
|
+
- [ ] Interfaces defined enough to code against
|
|
133
|
+
- [ ] Dependencies documented for implementation order
|
|
134
|
+
|
|
135
|
+
### Testing Strategy
|
|
136
|
+
- [ ] Unit test approach fits architecture
|
|
137
|
+
- [ ] Integration test points identified
|
|
138
|
+
- [ ] E2E test scenarios align with user journeys
|
|
139
|
+
|
|
140
|
+
## Validation Summary
|
|
141
|
+
|
|
142
|
+
| Category | Score | Status | Notes |
|
|
143
|
+
|----------|-------|--------|-------|
|
|
144
|
+
| Structure Completeness | /10 | | |
|
|
145
|
+
| PRD Alignment | /10 | | |
|
|
146
|
+
| Design Quality | /10 | | |
|
|
147
|
+
| Integration | /10 | | |
|
|
148
|
+
| ADR Quality | /10 | | |
|
|
149
|
+
| Implementation Readiness | /10 | | |
|
|
150
|
+
|
|
151
|
+
**Overall Score:** /60
|
|
152
|
+
**Status:** APPROVED / NEEDS REVISION / BLOCKED
|
|
153
|
+
|
|
154
|
+
### Severity Levels
|
|
155
|
+
- **60-54:** Excellent - Ready for implementation planning
|
|
156
|
+
- **53-42:** Good - Minor improvements recommended
|
|
157
|
+
- **41-30:** Acceptable - Some revisions needed
|
|
158
|
+
- **<30:** Needs Work - Significant revision required
|
|
159
|
+
|
|
160
|
+
**Action Items:**
|
|
161
|
+
1. [High priority item]
|
|
162
|
+
2. [Medium priority item]
|
|
163
|
+
3. [Low priority item]
|
|
164
|
+
|
|
165
|
+
**Validated By:** {{user_name}}
|
|
166
|
+
**Date:** {{date}}
|
|
@@ -0,0 +1,151 @@
|
|
|
1
|
+
# Code Review Checklist
|
|
2
|
+
|
|
3
|
+
Use this checklist when reviewing implemented code before marking story as "done".
|
|
4
|
+
|
|
5
|
+
## Acceptance Criteria Verification
|
|
6
|
+
|
|
7
|
+
### Each AC from Story
|
|
8
|
+
- [ ] AC1: Implementation satisfies criterion
|
|
9
|
+
- [ ] AC2: Implementation satisfies criterion
|
|
10
|
+
- [ ] AC3: Implementation satisfies criterion
|
|
11
|
+
- [ ] [Add more as needed]
|
|
12
|
+
|
|
13
|
+
### Edge Cases
|
|
14
|
+
- [ ] Error scenarios handled
|
|
15
|
+
- [ ] Boundary conditions tested
|
|
16
|
+
- [ ] Invalid input rejected appropriately
|
|
17
|
+
|
|
18
|
+
## Code Quality
|
|
19
|
+
|
|
20
|
+
### Architecture Compliance
|
|
21
|
+
- [ ] Follows hexagonal architecture
|
|
22
|
+
- [ ] Domain layer has no infrastructure imports
|
|
23
|
+
- [ ] Use cases have 4 files (inport, dto, handler, mappers)
|
|
24
|
+
- [ ] Explicit mapping (no reflection libraries)
|
|
25
|
+
- [ ] Dependencies flow correctly (infra → app → domain)
|
|
26
|
+
|
|
27
|
+
### Code Structure
|
|
28
|
+
- [ ] Single responsibility principle followed
|
|
29
|
+
- [ ] Functions are focused and small (<50 lines)
|
|
30
|
+
- [ ] No code duplication
|
|
31
|
+
- [ ] Clear naming conventions
|
|
32
|
+
- [ ] Appropriate abstractions used
|
|
33
|
+
|
|
34
|
+
### Error Handling
|
|
35
|
+
- [ ] Errors are wrapped with context
|
|
36
|
+
- [ ] Domain errors vs infrastructure errors distinguished
|
|
37
|
+
- [ ] Error messages are descriptive
|
|
38
|
+
- [ ] No swallowed/ignored errors
|
|
39
|
+
- [ ] Errors propagated appropriately
|
|
40
|
+
|
|
41
|
+
### Comments & Documentation
|
|
42
|
+
- [ ] Complex logic is documented
|
|
43
|
+
- [ ] Public APIs have doc comments
|
|
44
|
+
- [ ] No commented-out code
|
|
45
|
+
- [ ] Self-documenting code where possible
|
|
46
|
+
|
|
47
|
+
## Testing
|
|
48
|
+
|
|
49
|
+
### Test Coverage
|
|
50
|
+
- [ ] Unit tests for all new functions
|
|
51
|
+
- [ ] Integration tests for component interactions
|
|
52
|
+
- [ ] Edge cases tested
|
|
53
|
+
- [ ] Error scenarios tested
|
|
54
|
+
- [ ] Coverage meets requirements (80%+ for domain)
|
|
55
|
+
|
|
56
|
+
### Test Quality
|
|
57
|
+
- [ ] Tests are independent
|
|
58
|
+
- [ ] Clear test names (TestX_Y_Z pattern)
|
|
59
|
+
- [ ] Arrange-Act-Assert structure
|
|
60
|
+
- [ ] No test interdependencies
|
|
61
|
+
- [ ] Mocks used appropriately
|
|
62
|
+
|
|
63
|
+
### Test Execution
|
|
64
|
+
- [ ] All tests pass locally
|
|
65
|
+
- [ ] No flaky tests introduced
|
|
66
|
+
- [ ] Reasonable execution time
|
|
67
|
+
|
|
68
|
+
## Security
|
|
69
|
+
|
|
70
|
+
### Input Validation
|
|
71
|
+
- [ ] All user input validated
|
|
72
|
+
- [ ] SQL injection prevented
|
|
73
|
+
- [ ] XSS prevented (if applicable)
|
|
74
|
+
|
|
75
|
+
### Authentication/Authorization
|
|
76
|
+
- [ ] Auth checks present where needed
|
|
77
|
+
- [ ] No unauthorized access possible
|
|
78
|
+
- [ ] Sensitive operations protected
|
|
79
|
+
|
|
80
|
+
### Data Protection
|
|
81
|
+
- [ ] No hardcoded secrets
|
|
82
|
+
- [ ] Sensitive data not logged
|
|
83
|
+
- [ ] PII handled correctly
|
|
84
|
+
|
|
85
|
+
## Performance
|
|
86
|
+
|
|
87
|
+
### Efficiency
|
|
88
|
+
- [ ] No N+1 query issues
|
|
89
|
+
- [ ] Appropriate caching used
|
|
90
|
+
- [ ] No obvious bottlenecks
|
|
91
|
+
- [ ] Database queries optimized
|
|
92
|
+
|
|
93
|
+
### Resource Usage
|
|
94
|
+
- [ ] No memory leaks
|
|
95
|
+
- [ ] Connections properly closed
|
|
96
|
+
- [ ] Resources cleaned up
|
|
97
|
+
|
|
98
|
+
## CLAUDE.md Compliance
|
|
99
|
+
|
|
100
|
+
- [ ] Import order correct (stdlib, external, internal)
|
|
101
|
+
- [ ] Naming conventions followed
|
|
102
|
+
- [ ] Context passed as first parameter
|
|
103
|
+
- [ ] Value objects used for domain concepts
|
|
104
|
+
- [ ] Error patterns followed
|
|
105
|
+
|
|
106
|
+
## Story File Updates
|
|
107
|
+
|
|
108
|
+
- [ ] All tasks marked complete [x]
|
|
109
|
+
- [ ] File List updated with all changes
|
|
110
|
+
- [ ] Change Log updated
|
|
111
|
+
- [ ] Dev Agent Record has notes
|
|
112
|
+
- [ ] Status set to "review"
|
|
113
|
+
|
|
114
|
+
## Review Decision
|
|
115
|
+
|
|
116
|
+
### Severity Classification
|
|
117
|
+
|
|
118
|
+
| Issue | Severity | Description |
|
|
119
|
+
|-------|----------|-------------|
|
|
120
|
+
| | High | Security, correctness, data loss - must fix |
|
|
121
|
+
| | Medium | Code quality, maintainability - should fix |
|
|
122
|
+
| | Low | Style, minor improvements - nice to fix |
|
|
123
|
+
|
|
124
|
+
### Issues Found
|
|
125
|
+
|
|
126
|
+
| # | Severity | File:Line | Issue | Suggestion |
|
|
127
|
+
|---|----------|-----------|-------|------------|
|
|
128
|
+
| 1 | | | | |
|
|
129
|
+
| 2 | | | | |
|
|
130
|
+
| 3 | | | | |
|
|
131
|
+
|
|
132
|
+
## Review Outcome
|
|
133
|
+
|
|
134
|
+
- [ ] **APPROVE** - Ready to merge, all criteria met
|
|
135
|
+
- [ ] **CHANGES REQUESTED** - Issues need addressing (see above)
|
|
136
|
+
- [ ] **BLOCKED** - Major issues prevent approval
|
|
137
|
+
|
|
138
|
+
### Summary
|
|
139
|
+
|
|
140
|
+
**Strengths:**
|
|
141
|
+
- [What was done well]
|
|
142
|
+
|
|
143
|
+
**Areas for Improvement:**
|
|
144
|
+
- [What needs work]
|
|
145
|
+
|
|
146
|
+
**Action Items:**
|
|
147
|
+
1. [If changes requested]
|
|
148
|
+
2. [If changes requested]
|
|
149
|
+
|
|
150
|
+
**Reviewed By:** {{user_name}}
|
|
151
|
+
**Date:** {{date}}
|
|
@@ -0,0 +1,140 @@
|
|
|
1
|
+
# PRD Validation Checklist
|
|
2
|
+
|
|
3
|
+
Use this checklist to validate PRD before proceeding to architecture design.
|
|
4
|
+
|
|
5
|
+
## Structure Completeness
|
|
6
|
+
|
|
7
|
+
### Required Sections
|
|
8
|
+
- [ ] Executive Summary present
|
|
9
|
+
- [ ] Project Classification defined
|
|
10
|
+
- [ ] Success Criteria with measurable targets
|
|
11
|
+
- [ ] User Personas defined
|
|
12
|
+
- [ ] User Journeys documented
|
|
13
|
+
- [ ] Product Scope (MVP/Growth/Vision)
|
|
14
|
+
- [ ] Functional Requirements (all FRs)
|
|
15
|
+
- [ ] Non-Functional Requirements (all NFRs)
|
|
16
|
+
- [ ] Dependencies & Integrations
|
|
17
|
+
- [ ] Risks & Mitigations
|
|
18
|
+
- [ ] Constraints documented
|
|
19
|
+
- [ ] Glossary included
|
|
20
|
+
- [ ] Traceability Matrix present
|
|
21
|
+
|
|
22
|
+
### Metadata
|
|
23
|
+
- [ ] Version number present
|
|
24
|
+
- [ ] Status clearly indicated
|
|
25
|
+
- [ ] Author identified
|
|
26
|
+
- [ ] Date recorded
|
|
27
|
+
|
|
28
|
+
## Functional Requirements Quality
|
|
29
|
+
|
|
30
|
+
### SMART Validation (Score each FR 1-5)
|
|
31
|
+
|
|
32
|
+
| FR # | Specific | Measurable | Attainable | Relevant | Traceable | Avg | Flag |
|
|
33
|
+
|------|----------|------------|------------|----------|-----------|-----|------|
|
|
34
|
+
| FR-001 | | | | | | | |
|
|
35
|
+
| FR-002 | | | | | | | |
|
|
36
|
+
| ... | | | | | | | |
|
|
37
|
+
|
|
38
|
+
**Legend:** 1=Poor, 3=Acceptable, 5=Excellent
|
|
39
|
+
**Flag:** X = Any score < 3
|
|
40
|
+
|
|
41
|
+
### Acceptance Criteria
|
|
42
|
+
- [ ] Every FR has acceptance criteria
|
|
43
|
+
- [ ] AC uses Given/When/Then format
|
|
44
|
+
- [ ] AC is testable
|
|
45
|
+
- [ ] Edge cases covered
|
|
46
|
+
|
|
47
|
+
### Coverage
|
|
48
|
+
- [ ] All user journeys have supporting FRs
|
|
49
|
+
- [ ] All personas have relevant FRs
|
|
50
|
+
- [ ] MVP scope is clearly marked
|
|
51
|
+
|
|
52
|
+
## Non-Functional Requirements Quality
|
|
53
|
+
|
|
54
|
+
### Performance
|
|
55
|
+
- [ ] Response time targets specified
|
|
56
|
+
- [ ] Throughput targets specified
|
|
57
|
+
- [ ] Measurement method defined
|
|
58
|
+
|
|
59
|
+
### Security
|
|
60
|
+
- [ ] Authentication requirements defined
|
|
61
|
+
- [ ] Authorization requirements defined
|
|
62
|
+
- [ ] Data protection requirements defined
|
|
63
|
+
- [ ] Compliance requirements listed
|
|
64
|
+
|
|
65
|
+
### Scalability
|
|
66
|
+
- [ ] Scale targets specified
|
|
67
|
+
- [ ] Growth projections documented
|
|
68
|
+
|
|
69
|
+
### Reliability
|
|
70
|
+
- [ ] Availability target (SLA) defined
|
|
71
|
+
- [ ] Recovery objectives (RTO/RPO) specified
|
|
72
|
+
|
|
73
|
+
## Traceability Check
|
|
74
|
+
|
|
75
|
+
### Source Tracing
|
|
76
|
+
- [ ] Each FR traces to source document
|
|
77
|
+
- [ ] Each FR traces to user journey
|
|
78
|
+
- [ ] Each FR maps to persona
|
|
79
|
+
|
|
80
|
+
### Forward Tracing
|
|
81
|
+
- [ ] Epic assignments planned
|
|
82
|
+
- [ ] Story breakdown feasible
|
|
83
|
+
|
|
84
|
+
## Consistency Check
|
|
85
|
+
|
|
86
|
+
### Terminology
|
|
87
|
+
- [ ] Terms used consistently
|
|
88
|
+
- [ ] All terms in glossary defined
|
|
89
|
+
- [ ] No conflicting definitions
|
|
90
|
+
|
|
91
|
+
### Priority Alignment
|
|
92
|
+
- [ ] P0 requirements are truly critical
|
|
93
|
+
- [ ] MVP scope is minimal but viable
|
|
94
|
+
- [ ] Dependencies respect priority order
|
|
95
|
+
|
|
96
|
+
### No Implementation Leakage
|
|
97
|
+
- [ ] No specific technology mandates (unless constraint)
|
|
98
|
+
- [ ] Focus is on WHAT, not HOW
|
|
99
|
+
- [ ] No premature architecture decisions
|
|
100
|
+
|
|
101
|
+
## Risk Assessment
|
|
102
|
+
|
|
103
|
+
### Risks Identified
|
|
104
|
+
- [ ] Technical risks documented
|
|
105
|
+
- [ ] Business risks documented
|
|
106
|
+
- [ ] Timeline risks documented
|
|
107
|
+
- [ ] Each risk has mitigation strategy
|
|
108
|
+
|
|
109
|
+
### Dependencies
|
|
110
|
+
- [ ] External dependencies listed
|
|
111
|
+
- [ ] Internal dependencies identified
|
|
112
|
+
- [ ] Fallback plans for critical dependencies
|
|
113
|
+
|
|
114
|
+
## Validation Summary
|
|
115
|
+
|
|
116
|
+
| Category | Score | Status | Notes |
|
|
117
|
+
|----------|-------|--------|-------|
|
|
118
|
+
| Structure Completeness | /10 | | |
|
|
119
|
+
| FR Quality (SMART) | /10 | | |
|
|
120
|
+
| NFR Quality | /10 | | |
|
|
121
|
+
| Traceability | /10 | | |
|
|
122
|
+
| Consistency | /10 | | |
|
|
123
|
+
| Risk Coverage | /10 | | |
|
|
124
|
+
|
|
125
|
+
**Overall Score:** /60
|
|
126
|
+
**Status:** APPROVED / NEEDS REVISION / BLOCKED
|
|
127
|
+
|
|
128
|
+
### Severity Levels
|
|
129
|
+
- **60-54:** Excellent - Ready for architecture
|
|
130
|
+
- **53-42:** Good - Minor improvements recommended
|
|
131
|
+
- **41-30:** Acceptable - Some revisions needed
|
|
132
|
+
- **<30:** Needs Work - Significant revision required
|
|
133
|
+
|
|
134
|
+
**Action Items:**
|
|
135
|
+
1. [High priority item]
|
|
136
|
+
2. [Medium priority item]
|
|
137
|
+
3. [Low priority item]
|
|
138
|
+
|
|
139
|
+
**Validated By:** {{user_name}}
|
|
140
|
+
**Date:** {{date}}
|