@combeenation/3d-viewer 7.0.0-beta2 → 7.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@combeenation/3d-viewer",
-  "version": "7.0.0-beta2",
+  "version": "7.0.0",
   "description": "Combeenation 3D Viewer",
   "homepage": "https://github.com/Combeenation/3d-viewer#readme",
   "bugs": {

package/src/api/classes/event.ts

@@ -30,7 +30,7 @@ export const emitter = new EventEmitter();
  * viewer.on(Event.SCENE_PROCESSING_END, scene => {
  *   scene.clearColor = new Color4(0, 0, 0, 0);
  * });
- * await viewer.bootstrap();
+ * await viewer.bootstrap([]);
  * ```
  */
 export class Event {

package/src/api/classes/viewer.ts

@@ -248,7 +248,8 @@ export class Viewer extends EventBroadcaster {
 
   /**
    * Sets the strategy handler for naming cloned nodes.\
-   * Check the docs of the tag managers [renaming](https://3dviewer.docs.combeenation.com/pages/documentation/Tag-Manager.html#uniqueness-of-node-and-tag-names)
+   * Check the docs of the tag managers
+   * [renaming](./../pages/documentation/Tag-Manager.html#uniqueness-of-node-and-tag-names)
    * chapter for further details.
    */
   set nodeNamingStrategyHandler(value: NodeNamingStrategyHandler) {
@@ -270,7 +271,7 @@ export class Viewer extends EventBroadcaster {
    * @emits {@link Event.BOOTSTRAP_START}
    * @emits {@link Event.BOOTSTRAP_END}
    */
-  public async bootstrap(tagManagerParameterValues?: TagManagerParameterValue[]): Promise<Viewer> {
+  public async bootstrap(tagManagerParameterValues: TagManagerParameterValue[]): Promise<Viewer> {
     this.broadcastEvent(Event.BOOTSTRAP_START, this);
     let indexJson;
     if (isString(this.structureJson)) {
@@ -565,9 +566,9 @@ export class Viewer extends EventBroadcaster {
    * Resets everything by calling {@link destroy} to clear all references and {@link bootstrap} to setup a clean
    * environment
    */
-  public async reset(): Promise<Viewer> {
+  public async reset(tagManagerParameterValues: TagManagerParameterValue[]): Promise<Viewer> {
     await this.destroy();
-    return this.bootstrap();
+    return this.bootstrap(tagManagerParameterValues);
   }
 
   /**

package/src/api/manager/variantInstanceManager.ts

@@ -204,7 +204,8 @@ export class VariantInstanceManager extends EventBroadcaster {
    *
    * @param tagMapping Object for renaming tags on the clone, whereas the "key" is the tag name of orignal variant
    * instance and the "value" is the new tag name that should be created from it.\
-   * Check the docs of the tag managers [renaming](https://3dviewer.docs.combeenation.com/pages/documentation/Tag-Manager.html#uniqueness-of-node-and-tag-names)
+   * Check the docs of the tag managers
+   * [renaming](./../pages/documentation/Tag-Manager.html#uniqueness-of-node-and-tag-names)
    * chapter for further details.
    *
    * @emits {@link Event.VARIANT_INSTANCE_CLONED}

package/src/api/util/babylonHelper.ts

@@ -110,6 +110,11 @@ const cloneTransformNode = function (
     if (node.constructor.name === 'InstancedMesh') {
       clone.setEnabled(node.isEnabled(false));
     }
+    // copying tags is a temporary workaround, as it doesn't work for TransformNodes ATM
+    // see https://forum.babylonjs.com/t/transformnode-clone-doesnt-contain-original-tags/38429/1
+    if (Tags?.HasTags(node)) {
+      Tags.AddTagsTo(clone, Tags.GetTags(node, true));
+    }
   }
   if (deep) {
     const children = node.getChildTransformNodes(true);

package/src/api/util/globalTypes.ts

@@ -456,6 +456,10 @@ type SpecGenerationData = {
   url: string;
 };
 
+/**
+ * Key = Old tag name\
+ * Value = New tag name
+ */
 type TagMapping = {
   [tagName: string]: string;
 };