@combeenation/3d-viewer 5.2.0-alpha5 → 6.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@combeenation/3d-viewer",
-  "version": "5.2.0-alpha5",
+  "version": "6.0.0",
   "description": "Combeenation 3D Viewer",
   "homepage": "https://github.com/Combeenation/3d-viewer#readme",
   "bugs": {

package/src/api/classes/element.ts

@@ -272,7 +272,7 @@ export class Element extends VariantParameterizable {
     if (!(node instanceof AbstractMesh)) {
       throw new Error(`The path must be an instance of "AbstractMesh" for camera observer in element "${this.id}".`);
     }
-    this.variant.viewer.sceneManager.activeCamera.onViewMatrixChangedObservable.add(() => {
+    this.variant.viewer.sceneManager.activeCamera.onViewMatrixChangedObservable.add((eventData, eventState) => {
       const position = getClientRectFromMesh(node, this.variant.viewer.scene, this.variant.viewer.canvas);
       if (payload) {
         payload.style.top = `${position.top}px`;
@@ -534,7 +534,7 @@ export class Element extends VariantParameterizable {
       },
     ]);
     this._parameterObservers.set(Parameter.HIGHLIGHT_COLOR, [
-      async (element: Element) => {
+      async (element: Element, oldValue: ParameterValue, newValue: ParameterValue) => {
         // trigger Parameter.HIGHLIGHTED observers
         this._parameterObservers.get(Parameter.HIGHLIGHTED)?.forEach(observer => {
           observer(element, !!element.highlighted, !!element.highlighted);

package/src/api/classes/variant.ts

@@ -616,7 +616,7 @@ export class Variant extends Parameterizable {
   protected async loadAssets(): Promise<Variant> {
     this.broadcastEvent(Event.ASSET_LOADING_START, this);
 
-    const promisifiedLoader = new Promise<Variant>(resolve => {
+    const promisifiedLoader = new Promise<Variant>((resolve, reject) => {
       if (!this.structureJson) {
         this.broadcastEvent(Event.ASSET_LOADING_END, this);
         return resolve(this);

package/src/api/internal/debugViewer.ts

@@ -36,7 +36,7 @@ export class DebugViewer extends Viewer {
     return scene;
   }
 
-  protected instanceDebugger() {
+  protected instanceDebugger(instance: VariantInstance) {
     const instances: string[] = [];
     this.variantInstances.all.forEach(variantInstance => {
       instances.push(

package/src/api/manager/sceneManager.ts

@@ -88,7 +88,7 @@ export class SceneManager extends ParameterObservable {
   }
 
   protected addParameterObservers(): SceneManager {
-    const handleEnvParamChange = (manager: SceneManager) => {
+    const handleEnvParamChange = (manager: SceneManager, oldValue: ParameterValue, newValue: ParameterValue) => {
       const params = {
         color: manager.parameters[Parameter.ENVIRONMENT_COLOR],
         intensity: manager.parameters[Parameter.ENVIRONMENT_INTENSITY],

package/src/api/util/sceneLoaderHelper.ts

@@ -24,7 +24,7 @@ const getCustomCbnBabylonLoaderPlugin = function (previousLoaderPlugin: ISceneLo
     extensions: '.babylon',
     importMesh: previousLoaderPlugin.importMesh,
     load: previousLoaderPlugin.load,
-    loadAssetContainer: function (scene, data, rootUrl) {
+    loadAssetContainer: function (scene, data, rootUrl, onError) {
       //* 1) --- manipulate ORIGINAL data
       const dataParsed = JSON.parse(data);
       //* 2) --- call default (non-custom) loading method
@@ -46,7 +46,7 @@ const getCustomCbnBabylonLoaderPlugin = function (previousLoaderPlugin: ISceneLo
  * @returns observer
  */
 const getMaterialPostLoadObserver = function (targetMeshOrInstance: AbstractMesh, concerningMesh: Mesh) {
-  return () => {
+  return (eventData: any, eventState: any) => {
     const hasBeenEnabled = concerningMesh.isEnabled(true);
     const materialMissing = has(concerningMesh.metadata, missingMaterialMetadataName);
     if (!hasBeenEnabled || !materialMissing) return;

package/src/dev.ts

@@ -31,7 +31,7 @@ window.Cbn = {
       // Fallback to random mock material
       return mockMaterials[Math.floor(Math.random() * mockMaterials.length)];
     },
-    assertMaterialExists(): boolean {
+    assertMaterialExists(materialId: string): boolean {
       return true;
     },
   },