@combeenation/3d-viewer 5.2.0-alpha4 → 6.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@combeenation/3d-viewer",
-  "version": "5.2.0-alpha4",
+  "version": "6.0.0",
   "description": "Combeenation 3D Viewer",
   "homepage": "https://github.com/Combeenation/3d-viewer#readme",
   "bugs": {
@@ -26,13 +26,14 @@
   "scripts": {
     "bundle-analyzer": "npm run generate-profile && webpack-bundle-analyzer dist/webpack-stats.json dist/lib-full",
     "dev": "cross-env NODE_ENV='dev' webpack serve --config build/webpack.conf.js --progress --hot",
-    "dist-cjs": "tsc --project commonjs.tsconfig.json && npm run replace-version",
-    "dist-es6": "tsc --project es6.tsconfig.json && npm run replace-version",
-    "dist-full": "cross-env NODE_ENV='production' webpack --config build/webpack.conf.js --progress && npm run replace-version",
+    "dist-cjs": "npm run lint && tsc --project commonjs.tsconfig.json && npm run replace-version",
+    "dist-es6": "npm run lint && tsc --project es6.tsconfig.json && npm run replace-version",
+    "dist-full": "npm run lint && cross-env NODE_ENV='production' webpack --config build/webpack.conf.js --progress && npm run replace-version",
     "docs-local": "typedoc --tsconfig tsconfig.json --media doc/assets --out docs-local",
     "docs-publish": "typedoc --tsconfig tsconfig.json --media doc/assets --out docs",
     "format": "prettier --write .",
     "generate-profile": "cross-env NODE_ENV='dev' webpack --config build/webpack.conf.js --profile --json > dist/webpack-stats.json",
+    "lint": "eslint src/**",
     "pack": "npm run dist-cjs && npm pack",
     "pack-to-cjs": "npm run dist-cjs && npm pack --pack-destination=\"../custom-js/Swissmobilia/moebelsystem\"",
     "pub-alpha": "npm run dist-cjs && npm publish --tag alpha",
@@ -44,33 +45,35 @@
   },
   "prettier": "@combeenation/prettier-config",
   "dependencies": {
-    "@babylonjs/core": "5.25.0",
-    "@babylonjs/loaders": "5.25.0",
-    "@babylonjs/materials": "5.25.0",
-    "@babylonjs/serializers": "5.25.0",
-    "eventemitter3": "^4.0.7",
-    "gsap": "^3.11.2",
-    "lodash-es": "^4.17.21"
+    "@babylonjs/core": "5.27.1",
+    "@babylonjs/loaders": "5.27.1",
+    "@babylonjs/materials": "5.27.1",
+    "@babylonjs/serializers": "5.27.1",
+    "eventemitter3": "4.0.7",
+    "gsap": "3.11.2",
+    "lodash-es": "4.17.21"
   },
   "devDependencies": {
-    "@combeenation/prettier-config": "^0.0.3",
-    "@combeenation/ts-config": "^0.0.2",
-    "@knodes/typedoc-plugin-pages": "^0.23.1",
-    "@types/lodash-es": "^4.17.6",
-    "clean-webpack-plugin": "^4.0.0",
-    "cross-env": "^7.0.3",
-    "html-webpack-plugin": "^5.5.0",
-    "prettier": "^2.7.1",
-    "replace": "^1.2.1",
-    "terser-webpack-plugin": "^5.3.6",
-    "ts-loader": "^9.4.1",
-    "typedoc": "^0.23.15",
-    "typedoc-plugin-merge-modules": "^4.0.1",
-    "typescript": "^4.8.4",
-    "webpack": "^5.74.0",
-    "webpack-bundle-analyzer": "^4.6.1",
-    "webpack-cli": "^4.10.0",
-    "webpack-dev-server": "^4.11.1",
-    "webpack-merge": "^5.8.0"
+    "@combeenation/eslint-config": "0.0.5",
+    "@combeenation/prettier-config": "0.0.3",
+    "@combeenation/ts-config": "0.0.2",
+    "@knodes/typedoc-plugin-pages": "0.23.1",
+    "@types/lodash-es": "4.17.6",
+    "clean-webpack-plugin": "4.0.0",
+    "cross-env": "7.0.3",
+    "eslint": "8.25.0",
+    "html-webpack-plugin": "5.5.0",
+    "prettier": "2.7.1",
+    "replace": "1.2.1",
+    "terser-webpack-plugin": "5.3.6",
+    "ts-loader": "9.4.1",
+    "typedoc": "0.23.15",
+    "typedoc-plugin-merge-modules": "4.0.1",
+    "typescript": "4.8.4",
+    "webpack": "5.74.0",
+    "webpack-bundle-analyzer": "4.6.1",
+    "webpack-cli": "4.10.0",
+    "webpack-dev-server": "4.11.1",
+    "webpack-merge": "5.8.0"
   }
 }

package/src/api/classes/dottedPath.ts

@@ -107,7 +107,7 @@ export class DottedPath {
    *      ["part1", "part1.part2", "part1.part2.part_3"]
    */
   get leafTokens(): string[] {
-    let parents: string[] = [];
+    const parents: string[] = [];
     return this.parts.map(part => {
       parents.push(part);
       return DottedPath.create(parents).path;

package/src/api/classes/element.ts

@@ -313,7 +313,8 @@ export class Element extends VariantParameterizable {
     }
 
     // TODO: Not sure if this really should be overwritten every time the paintable is redrawn.
-    // Maybe the 3D artist had something in mind when setting a certain transparency mode, which would get overwritten in this case.
+    // Maybe the 3D artist had something in mind when setting a certain transparency mode, which would get overwritten
+    // in this case.
     // Applying it as a default if no material is set is fine though (see roughness/metallic some lines above).
     // Removing this line will most likely break existing configurators, so be cautios!
     node.material.transparencyMode = Material.MATERIAL_ALPHATESTANDBLEND;
@@ -699,7 +700,7 @@ export class Element extends VariantParameterizable {
    * Handles callback for given light parameter.
    */
   private async castShadowValueHandler(lightCsl: ParameterValue, mutator: CallableFunction) {
-    let lights: Light[] = [];
+    const lights: Light[] = [];
     for (const lightName of Parameter.parseCommaSeparatedList(lightCsl)) {
       const viewerLight = await this.variant.getViewerLight(lightName);
       if (viewerLight) {

package/src/api/classes/parameter.ts

@@ -283,9 +283,11 @@ export class Parameter {
   public static readonly ENVIRONMENT_INTENSITY = 'environment.intensity';
 
   /**
-   * Background texture on a [PhotoDome](https://doc.babylonjs.com/divingDeeper/environment/360PhotoDome). Just background, no IBL or reflection.
+   * Background texture on a [PhotoDome](https://doc.babylonjs.com/divingDeeper/environment/360PhotoDome).
+   * Just background, no IBL or reflection.
    *
-   * Recommended format is `*.jpg`. HDR files are not supported as background but can be converted to `*.jpg` using tools like Photoshop, Gimp or various free online converters.
+   * Recommended format is `*.jpg`. HDR files are not supported as background but can be converted to `*.jpg` using
+   * tools like Photoshop, Gimp or various free online converters.
    *
    * See [environment page](./../pages/Documentation/Environment.html) for details on how to use this.
    *
@@ -401,7 +403,7 @@ export class Parameter {
     let cleanedValue = value.split(' ').join('');
     if (cleanedValue.startsWith('(') && cleanedValue.endsWith(')')) {
       cleanedValue = cleanedValue.substring(1, cleanedValue.length - 1);
-      let [x, y, z] = cleanedValue.split(',').map(value => parseFloat(value));
+      const [x, y, z] = cleanedValue.split(',').map(value => parseFloat(value));
       return new Vector3(x, y, z);
     } else {
       throw new Error(`Unable to parse "${value}" to a Vector: expected "(x,y,z)".`);
@@ -457,14 +459,15 @@ export class Parameter {
     }
     if (cleanedValue.startsWith('(') && cleanedValue.endsWith(')')) {
       cleanedValue = cleanedValue.substring(1, cleanedValue.length - 1);
-      let [r, g, b] = cleanedValue.split(',').map(value => parseFloat(value));
+      const [r, g, b] = cleanedValue.split(',').map(value => parseFloat(value));
       return Color3.FromInts(r, g, b);
     }
     throw new Error(`Unable to parse "${value}" to a Color: expected "#rrggbb" or "(r,g,b)".`);
   }
 
   /**
-   * Parses a `boolean` string (`'true'`/`'1'` or `'false'`/`'0'`) or `number` (`1` or `0`) to a `boolean` or `undefined`.
+   * Parses a `boolean` string (`'true'`/`'1'` or `'false'`/`'0'`) or `number` (`1` or `0`) to a `boolean` or
+   * `undefined`.
    */
   public static parseBoolean(value: ParameterValue): boolean {
     if (value.toString() === 'true' || value.toString() === '1') {

package/src/api/classes/placementAnimation.ts

@@ -130,7 +130,8 @@ export class PlacementAnimation implements AnimationInterface {
         delete this._placementDefinition.position;
         ghostCam.dispose();
       } else if (this._animationDefinition.shortestWay && this._placementDefinition.alpha !== undefined) {
-        // transform the target's alpha value into the same turn as the current camera position to avoid movements > 360 degrees
+        // transform the target's alpha value into the same turn as the current camera position to avoid movements
+        // > 360 degrees
         const alphaGap = this.mutable.alpha - this._placementDefinition.alpha;
         const cntTurns = Math.round(alphaGap / (2 * Math.PI));
         this._placementDefinition.alpha += 2 * Math.PI * cntTurns;

package/src/api/classes/variant.ts

@@ -1,6 +1,6 @@
 import { deactivateTransformNode, getDottedPathForNode, injectNodeMetadata } from '../util/babylonHelper';
 import { loadJson, mergeMaps } from '../util/resourceHelper';
-import { getMaterialFromCbnAssets } from '../util/sceneLoaderHelper';
+import { createMaterialFromCbnAssets } from '../util/sceneLoaderHelper';
 import { DottedPath } from './dottedPath';
 import { Element } from './element';
 import { Event } from './event';
@@ -30,7 +30,7 @@ import '@babylonjs/loaders/glTF/2.0/Extensions/KHR_materials_variants';
 import '@babylonjs/loaders/glTF/2.0/Extensions/KHR_texture_basisu';
 import '@babylonjs/loaders/glTF/2.0/Extensions/KHR_texture_transform';
 import '@babylonjs/loaders/glTF/2.0/glTFLoader';
-import { cloneDeep, concat, get, has, isElement, isEmpty, isEqual, isString, merge, reject, set } from 'lodash-es';
+import { cloneDeep, concat, get, isEmpty, isEqual, isString, merge, set } from 'lodash-es';
 
 /**
  * A concrete "Variant". Most of these are handled by either the {@link Viewer} or {@link VariantInstance}.
@@ -265,7 +265,7 @@ export class Variant extends Parameterizable {
    * The {@link ParameterDeclarations} inherited from this {@link Variant}'s parents.
    */
   get inheritedParameterDeclaration(): ParameterDeclarations {
-    let declaration = {};
+    const declaration = {};
     this.ancestors.forEach(ancestor => {
       merge(declaration, ancestor.parameterDeclaration);
     });
@@ -276,7 +276,7 @@ export class Variant extends Parameterizable {
    * The {@link ParameterBag} inherited from this {@link Variant}'s parents.
    */
   get inheritedParameters(): ParameterBag {
-    let parameters = {};
+    const parameters = {};
     this.ancestors.forEach(ancestor => {
       merge(parameters, ancestor.parameters);
     });
@@ -424,7 +424,7 @@ export class Variant extends Parameterizable {
   /**
    * Gets the Material defined in one of the variants glTFs by its id.
    */
-  public getMaterial(id: string): Material {
+  public getOrCreateMaterial(id: string): Material {
     const scene = this.viewer.scene;
 
     for (const material of this.inheritedMaterials) {
@@ -438,7 +438,7 @@ export class Variant extends Parameterizable {
         return material;
       }
     }
-    const cbnAssetMaterial = getMaterialFromCbnAssets(id, scene);
+    const cbnAssetMaterial = createMaterialFromCbnAssets(id, scene);
     if (cbnAssetMaterial) {
       return cbnAssetMaterial;
     }
@@ -727,7 +727,7 @@ export class Variant extends Parameterizable {
   protected async commitParameterToElements(parameter: string, value: ParameterValue): Promise<Variant> {
     const promises = [];
     for (const element of this.elements) {
-      const paramShowsElement = Parameter.VISIBLE === parameter && value;
+      const paramShowsVariant = Parameter.VISIBLE === parameter && value;
 
       // Fixes https://combeenation.youtrack.cloud/issue/CB-7773
       // Don't enable/show the variants element if it is explicitly hidden via its element parameters.
@@ -750,7 +750,7 @@ export class Variant extends Parameterizable {
       const elVisibleParamValue = this.inheritedParameters[elVisibleParamPath];
       const elVisibleParamValueParsed = elVisibleParamValue && Parameter.parseBoolean(elVisibleParamValue);
       const elIsHiddenViaParams = elVisibleParamValueParsed === false;
-      if (paramShowsElement && elIsHiddenViaParams) continue;
+      if (paramShowsVariant && elIsHiddenViaParams) continue;
 
       // To discuss: Is this a viable solution or is it too hacky to apply the elements material param, when the param
       //             at hand is actually the visible param?
@@ -759,7 +759,7 @@ export class Variant extends Parameterizable {
       // is never shown when "overwritten" by elements material param.
       const elMaterialParamPath = DottedPath.create([element.name, Parameter.MATERIAL]).toString();
       const elMaterialParamValue = this.inheritedParameters[elMaterialParamPath];
-      if (paramShowsElement && elMaterialParamValue) {
+      if (paramShowsVariant && elMaterialParamValue) {
         // To discuss: Should we rather use `this.commitParametersToElements` here?
         //             I'm not really sure about the actual differences, both seem to do the job 🤷‍♂️
         // To discuss: Should we actively `await` this (as is) or should we also push the resulting promise into the

package/src/api/classes/variantInstance.ts

@@ -19,33 +19,33 @@ export class VariantInstance extends EventBroadcaster {
   /**
    * WORK IN PROGRESS
    */
-  public translate(
-    joint: DottedPathArgument,
-    variantInstance: VariantInstance,
-    variantInstanceJoint: DottedPathArgument
-  ): VariantInstance {
-    /*
-		joint = DottedPath.create( joint );
-		variantInstanceJoint = DottedPath.create( variantInstanceJoint );
-		const jointNode = variantInstance.variant.getNode( joint.path );
-		const variantInstanceJointNode = variantInstance.variant.getNode( variantInstanceJoint.path );
-		const differenceVector = variantInstanceJointNode.getAbsolutePosition().subtract( jointNode.getAbsolutePosition() );
-		const differenceVectorRotation = variantInstanceJointNode.rotation.subtract( jointNode.rotation );
+  /*
+public translate(
+  joint: DottedPathArgument,
+  variantInstance: VariantInstance,
+  variantInstanceJoint: DottedPathArgument
+): VariantInstance {
+  joint = DottedPath.create( joint );
+  variantInstanceJoint = DottedPath.create( variantInstanceJoint );
+  const jointNode = variantInstance.variant.getNode( joint.path );
+  const variantInstanceJointNode = variantInstance.variant.getNode( variantInstanceJoint.path );
+  const differenceVector = variantInstanceJointNode.getAbsolutePosition().subtract( jointNode.getAbsolutePosition() );
+  const differenceVectorRotation = variantInstanceJointNode.rotation.subtract( jointNode.rotation );
 
-		console.log( variantInstanceJointNode.rotationQuaternion, 'ROTATION' );
+  console.log( variantInstanceJointNode.rotationQuaternion, 'ROTATION' );
 
-		this.variant.nodes.forEach( node => {
-			node.translate( Axis.X, differenceVector.x, Space.WORLD );
-			node.translate( Axis.Y, differenceVector.y, Space.WORLD );
-			node.translate( Axis.Z, differenceVector.z, Space.WORLD );
+  this.variant.nodes.forEach( node => {
+    node.translate( Axis.X, differenceVector.x, Space.WORLD );
+    node.translate( Axis.Y, differenceVector.y, Space.WORLD );
+    node.translate( Axis.Z, differenceVector.z, Space.WORLD );
 
-			node.rotateAround( Axis.Y, differenceVectorRotation, 20 );
-			// node.rotate(Axis.Y, differenceVectorRotation.y, Space.WORLD );
-			// node.rotate(Axis.Z, differenceVectorRotation.z, Space.WORLD );
-		} );
-		*/
-    return this;
-  }
+    node.rotateAround( Axis.Y, differenceVectorRotation, 20 );
+    // node.rotate(Axis.Y, differenceVectorRotation.y, Space.WORLD );
+    // node.rotate(Axis.Z, differenceVectorRotation.z, Space.WORLD );
+  } );
+  return this;
+}
+  */
 
   /**
    * A proxy for {@link Variant.getElement}.

package/src/api/classes/variantParameterizable.ts

@@ -37,8 +37,8 @@ export abstract class VariantParameterizable extends Parameterizable {
   }
 
   /**
-   * Places the given {@link ParameterBag} in the {@link VariantParameterizable}'s parameters, replaces all patterns in the
-   * {@link StructureJson} and broadcasts all {@link ParameterObserver}s.
+   * Places the given {@link ParameterBag} in the {@link VariantParameterizable}'s parameters, replaces all patterns in
+   * the {@link StructureJson} and broadcasts all {@link ParameterObserver}s.
    */
   public async commitParameters(parameters?: ParameterBag): Promise<VariantParameterizable> {
     if (!parameters) {

package/src/api/classes/viewer.ts

@@ -209,8 +209,10 @@ export class Viewer extends EventBroadcaster {
 
   /**
    * Enables the BabylonJS [Inspector](https://doc.babylonjs.com/toolsAndResources/tools/inspector).\
-   * Due to the additional size of the inspector, the CDN version is used instead of shipping the required code with the viewer.\
-   * This means that the code will be downloaded only when needed and calling `enableDebugLayer` can take a little while depending on your internet connection etc.
+   * Due to the additional size of the inspector, the CDN version is used instead of shipping the required code with
+   * the viewer.\
+   * This means that the code will be downloaded only when needed and calling `enableDebugLayer` can take a little while
+   * depending on your internet connection etc.
    */
   public async enableDebugLayer(options?: IInspectorOptions) {
     if (!this._inspectorLoaded) {
@@ -451,10 +453,8 @@ export class Viewer extends EventBroadcaster {
       const plane = Mesh.CreatePlane('TextPlane', size, scene, true);
       plane.material = new StandardMaterial('TextPlaneMaterial', scene);
       plane.material.backFaceCulling = false;
-      // @ts-ignore
-      plane.material.specularColor = new Color3(0, 0, 0);
-      // @ts-ignore
-      plane.material.diffuseTexture = dynamicTexture;
+      (plane.material as StandardMaterial).specularColor = new Color3(0, 0, 0);
+      (plane.material as StandardMaterial).diffuseTexture = dynamicTexture;
       return plane;
     };
 
@@ -613,7 +613,8 @@ export class Viewer extends EventBroadcaster {
 
     // `minZ` is the camera distance beyond which the mesh will be clipped
     // this should be very low, but can't be zero
-    // a good value seems to be 1% of the bounding box size (= radius), whereas the value shouldn't go above 1, which is also the default value
+    // a good value seems to be 1% of the bounding box size (= radius), whereas the value shouldn't go above 1, which is
+    // also the default value
     const radius = boundingBox.getBoundingInfo().boundingSphere.radius;
     helperCamera.minZ = Math.min(radius / 100, 1);
 

package/src/api/classes/viewerLight.ts

@@ -211,7 +211,7 @@ export class ViewerLight extends VariantParameterizable {
     let lightId = this.id;
     let babylonLight;
     switch (definition.type) {
-      case 'baked':
+      case 'baked': {
         if (!definition['path']) {
           throw new Error(`The light "${lightId}" of type "${definition.type}" needs a "path".`);
         }
@@ -225,18 +225,20 @@ export class ViewerLight extends VariantParameterizable {
           throw new Error(`No light found for path "${definition['path']}" in ViewerLight "${lightId}".`);
         }
         break;
-      case 'hemispheric':
+      }
+      case 'hemispheric': {
         if (!parameters['direction']) {
           throw new Error(`The ViewerLight "${lightId}" of type "${definition.type}" needs a "direction".`);
         }
-        // @ts-ignore
+        // @ts-ignore es6 build doesn't allow dynamic imports
         const hemisphericLightModule = await import(
           /* webpackChunkName: "hemispheric-light" */ '@babylonjs/core/Lights/hemisphericLight'
         );
         babylonLight = new hemisphericLightModule.HemisphericLight(lightId, parameters['direction'], scene);
         break;
-      case 'point':
-        // @ts-ignore
+      }
+      case 'point': {
+        // @ts-ignore es6 build doesn't allow dynamic imports
         const pointLightModule = await import(
           /* webpackChunkName: "point-light" */ '@babylonjs/core/Lights/pointLight'
         );
@@ -246,17 +248,19 @@ export class ViewerLight extends VariantParameterizable {
           scene
         );
         break;
-      case 'directional':
+      }
+      case 'directional': {
         if (!parameters['direction']) {
           throw new Error(`The ViewerLight "${lightId}" of type "${definition.type}" needs a "direction".`);
         }
-        // @ts-ignore
+        // @ts-ignore es6 build doesn't allow dynamic imports
         const directionalLightModule = await import(
           /* webpackChunkName: "directional-light" */ '@babylonjs/core/Lights/directionalLight'
         );
         babylonLight = new directionalLightModule.DirectionalLight(lightId, parameters['direction'], scene);
         break;
-      case 'spot':
+      }
+      case 'spot': {
         if (!parameters['direction']) {
           throw new Error(`The ViewerLight "${lightId}" of type "${definition.type}" needs a "direction".`);
         }
@@ -266,7 +270,7 @@ export class ViewerLight extends VariantParameterizable {
         if (!parameters['exponent']) {
           throw new Error(`The ViewerLight "${lightId}" of type "${definition.type}" needs an "exponent".`);
         }
-        // @ts-ignore
+        // @ts-ignore es6 build doesn't allow dynamic imports
         const spotLightModule = await import(/* webpackChunkName: "spot-light" */ '@babylonjs/core/Lights/spotLight');
         babylonLight = new spotLightModule.SpotLight(
           lightId,
@@ -277,6 +281,7 @@ export class ViewerLight extends VariantParameterizable {
           scene
         );
         break;
+      }
       default:
         throw new Error(`The type "${definition.type}" for ViewerLight "${lightId}" is not implemented (yet).`);
     }

package/src/api/internal/debugViewer.ts

@@ -1,8 +1,8 @@
 /**
  * @internal
  */
+/// <reference path="../util/globalTypes.ts" />
 import { Event } from '../classes/event';
-import { VariantInstance } from '../classes/variantInstance';
 import { Viewer } from '../classes/viewer';
 import { Scene } from '@babylonjs/core/scene';
 

package/src/api/internal/sceneSetup.ts

@@ -9,7 +9,7 @@ import { GroundMesh } from '@babylonjs/core/Meshes/groundMesh';
 import { MeshBuilder } from '@babylonjs/core/Meshes/meshBuilder';
 import { DefaultRenderingPipeline } from '@babylonjs/core/PostProcesses/RenderPipeline/Pipelines/defaultRenderingPipeline';
 import { Scene } from '@babylonjs/core/scene';
-import { get, isEmpty, set } from 'lodash-es';
+import { get, isEmpty } from 'lodash-es';
 
 const defaultSceneClearColor = new Color4(0, 0, 0, 0);
 const defaultEnvHelperColor = new Color4(1, 1, 1, 0);
@@ -78,8 +78,8 @@ const processCamera = async function (scene: Scene, name: string, cameraSetup: C
     target = Parameter.parseVector(cameraSetup.target);
   }
   switch (cameraSetup.type) {
-    case 'arc':
-      // @ts-ignore
+    case 'arc': {
+      // @ts-ignore es6 build doesn't allow dynamic imports
       const arcCameraModule = await import(
         /* webpackChunkName: "arc-rotate-camera" */ '@babylonjs/core/Cameras/arcRotateCamera'
       );
@@ -90,6 +90,7 @@ const processCamera = async function (scene: Scene, name: string, cameraSetup: C
         radius: 2,
       };
       break;
+    }
   }
   if (cameraSetup.active) {
     camera.attachControl(scene.getEngine().getRenderingCanvas()!, true);
@@ -112,7 +113,7 @@ const sceneSetup = async function (engine: Engine, sceneJson: SceneJson): Promis
   const cameras: Camera[] = [];
   const cameraDefinitions = get(sceneJson.scene, 'cameras') as CameraDefinitions;
   if (!isEmpty(cameraDefinitions)) {
-    for (let cameraName in cameraDefinitions) {
+    for (const cameraName in cameraDefinitions) {
       cameras.push(await processCamera(scene, cameraName, cameraDefinitions[cameraName]));
     }
   } else {
@@ -167,7 +168,7 @@ const sceneSetup = async function (engine: Engine, sceneJson: SceneJson): Promis
       scene.imageProcessingConfiguration.exposure = sceneJson.scene.globals['camera-settings']!.exposure;
     }
     if (sceneJson.scene.globals['camera-settings']!.dof && sceneJson.scene.globals['camera-settings']!.dof.enabled) {
-      //@ts-ignore
+      // @ts-ignore es6 build doesn't allow dynamic imports
       const module = await import(/* webpackChunkName: "lens-rendering" */ './lensRendering');
       new module.LensRenderingPipeline(
         'lens-rendering',

package/src/api/manager/animationManager.ts

@@ -30,7 +30,7 @@ export class AnimationManager {
    */
   public resetCamera(animate: boolean = false) {
     //TODO currently only works for arcrotate. are there any other cameras?
-    let activeCamera = this.scene.activeCamera as Nullable<ArcRotateCamera>;
+    const activeCamera = this.scene.activeCamera as Nullable<ArcRotateCamera>;
     if (!activeCamera) {
       throw new Error('There is no active camera');
     }
@@ -52,7 +52,7 @@ export class AnimationManager {
    * @deprecated Use viewer.moveCameraTo().
    */
   public animateArcRotateCamera(targetAlpha: number, targetBeta: number, targetRadius: number) {
-    let activeCamera = this.scene.activeCamera as Nullable<ArcRotateCamera>;
+    const activeCamera = this.scene.activeCamera as Nullable<ArcRotateCamera>;
     if (!activeCamera) {
       throw new Error('There is no active camera');
     }
@@ -111,7 +111,7 @@ export class AnimationManager {
     activeCamera.animations.push(betaAnimation);
     activeCamera.animations.push(radiusAnimation);
 
-    let animation = this.scene.beginAnimation(activeCamera, 0, 100, false, 10);
+    const animation = this.scene.beginAnimation(activeCamera, 0, 100, false, 10);
     animation.disposeOnEnd = true;
   }
 

package/src/api/manager/gltfExportManager.ts

@@ -23,7 +23,7 @@ export class GltfExportManager {
    * Exports selected nodes to a file.
    * @param filename optional name of the exported .GLB file.
    * @param exportOptions export options to be merged with default options.
-   * @param excluded optional list of geometry (meshes, elements, variants, variantInstances) to be excluded from export.
+   * @param excluded optional list of geometry (meshes, elements, variants, variantInstances) to be excluded from export
    */
   public async exportGlb(
     filename = 'glb-export.glb',
@@ -55,7 +55,7 @@ export class GltfExportManager {
    * Exports selected nodes to GLTF. This may result in more than one file, since textures are exported separately.
    * @param filename name of the main (text-based) .GLTF file referring to separate texture files.
    * @param exportOptions export options to be merged with default options.
-   * @param excluded optional list of geometry (meshes, elements, variants, variantInstances) to be excluded from export.
+   * @param excluded optional list of geometry (meshes, elements, variants, variantInstances) to be excluded from export
    */
   public async exportGltfToFile(filename: string, exportOptions: IExportOptions = {}, excluded?: ExcludedGeometryList) {
     this.exportPreProcess();
@@ -134,7 +134,8 @@ export class GltfExportManager {
       if (!(n.material instanceof PBRMaterial)) continue;
       if (!(n.material as PBRMaterial).subSurface.isRefractionEnabled) continue;
       if ((n.material as PBRMaterial).transparencyMode !== PBRMaterial.PBRMATERIAL_OPAQUE) continue;
-      // if we're here, we have a node holding a material with set refraction whose transparencyMode is set to PBRMATERIAL_OPAQUE
+      // if we're here, we have a node holding a material with set refraction whose transparencyMode is set to
+      // PBRMATERIAL_OPAQUE
       n.material = this.createRefractionMaterialReplacement(n.material);
     }
   }
@@ -168,7 +169,7 @@ export class GltfExportManager {
     if (this.isMaterialClonedForExport(mat)) return mat;
 
     // change material according to https://www.notion.so/combeenation/Glas-materials-don-t-look-glasy-after-export-d5fda2c6515e4420a8772744d3e6b460
-    let clonedMaterial = mat.clone(mat.name); // clone material. clone uses same name
+    const clonedMaterial = mat.clone(mat.name); // clone material. clone uses same name
     clonedMaterial.metadata = { ...mat.metadata, clonedFrom: mat.uniqueId }; // create shallow copy of metadata on clone. see https://forum.babylonjs.com/t/the-metadata-of-the-mesh-cloned-by-the-instantiatemodelstoscene-method-is-a-shallow-copy/21563
     clonedMaterial.refractionTexture = null;
     clonedMaterial.metallicReflectanceTexture = null; // is this the correct one for metallic roughness?