@combeenation/3d-viewer 12.4.1-beta2 → 12.4.1-beta4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@combeenation/3d-viewer",
-  "version": "12.4.1-beta2",
+  "version": "12.4.1-beta4",
   "description": "Combeenation 3D Viewer",
   "homepage": "https://github.com/Combeenation/3d-viewer#readme",
   "bugs": {

package/src/api/classes/viewer.ts

@@ -700,6 +700,30 @@ The inspector can only be used in development builds.`);
         }
       };
     }
+
+    // textures based CBN image assets are hard to analyse in the inspector, since the asset url is set as name
+    // with this functionality we try to find these CBN image assets and crop the name accordingly
+    scene.onNewTextureAddedObservable.add(async texture => {
+      // name is only available after the texture is "ready"
+      // since there is no "wait for texture ready" functionality we can use it on scene level
+      await scene.whenReadyAsync();
+
+      const cbnServerString = 'https://cbnpeuwstassets.blob.core.windows.net/public/';
+      const textureQueryString = '?name=';
+      const texture3dFolderString = 'Textures3d/';
+      const isFromCbnServer = texture.name.startsWith(cbnServerString);
+      const indexOfTextureQueryParam = texture.name.lastIndexOf(textureQueryString);
+
+      if (isFromCbnServer && indexOfTextureQueryParam > -1) {
+        let texturePath = texture.name.substring(indexOfTextureQueryParam + textureQueryString.length);
+        if (texturePath.startsWith(texture3dFolderString)) {
+          texturePath = texturePath.substring(texturePath.length - texture3dFolderString.length);
+        }
+
+        texture.name = `CBN asset: ${texturePath}`;
+      }
+    });
+
     this._sceneManager = await SceneManager.create(scene);
     this._animationManager = await AnimationManager.create(scene);
     if (sceneJson.cloneMaterialsOnMutation !== undefined) {
@@ -708,6 +732,7 @@ The inspector can only be used in development builds.`);
     // register observers for tag manager
     this.tagManager.registerNewObjectObservers(scene);
     this.broadcastEvent(Event.SCENE_PROCESSING_END, scene);
+
     return scene;
   }
 

package/src/api/manager/gltfExportManager.ts

@@ -300,9 +300,6 @@ export class GltfExportManager {
    * - Render target textures: Disposing the clone will leave the scene in a "not ready" state
    *   => this scenario is not fully analyzed yet, but it's not really worth the effort right now, since this kind of
    *      of texture is not really used ATM
-   *
-   * dynamic textures (paintables) or render
-   * target textures, as there are speci
    */
   protected static _exchangeMaterial(material: Material) {
     const baseTextures = material.getActiveTextures();