@combeenation/3d-viewer 12.3.0 → 12.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@combeenation/3d-viewer",
-  "version": "12.3.0",
+  "version": "12.4.0",
   "description": "Combeenation 3D Viewer",
   "homepage": "https://github.com/Combeenation/3d-viewer#readme",
   "bugs": {
@@ -79,7 +79,10 @@
     "webpack-merge": "5.8.0"
   },
   "optionalDependencies": {
+    "@babylonjs/gui": "6.27.1",
+    "@babylonjs/gui-editor": "6.27.1",
     "@babylonjs/inspector": "6.27.1",
+    "@babylonjs/materials": "6.27.1",
     "@babylonjs/node-editor": "6.27.1",
     "@babylonjs/node-geometry-editor": "6.27.1"
   },

package/src/api/classes/variant.ts

@@ -689,6 +689,7 @@ export class Variant extends Parameterizable {
             this.viewer.scene.addCamera(camera);
           });
           this.assetContainer.materials.forEach(material => this.viewer.scene.materials.push(material));
+          this.assetContainer.textures.forEach(texture => this.viewer.scene.textures.push(texture));
           this.assetContainer.skeletons.forEach(skeleton => this.viewer.scene.skeletons.push(skeleton));
           this.broadcastEvent(Event.ASSET_LOADING_END, this);
           resolve(this);

package/src/api/classes/viewer.ts

@@ -676,6 +676,10 @@ The inspector can only be used in development builds.`);
       engine.getCaps().maxTextureSize = (sceneJson.engine!.limitTextureSize as LimitTextureSizeConfig).size;
     }
 
+    if (sceneJson.engine?.useParallelShaderCompile === false) {
+      engine.getCaps().parallelShaderCompile = undefined;
+    }
+
     const scene = await sceneSetup(engine, sceneJson);
     if (sceneJson.meshPicking) {
       new HighlightLayer('default', scene);

package/src/api/util/globalTypes.ts

@@ -204,6 +204,15 @@ type SceneJson = {
      * only as well.
      */
     limitTextureSize?: LimitTextureSizeConfig | false;
+    /**
+     * See this forum entry for description of parallel shader compilition effect:
+     * https://forum.babylonjs.com/t/scene-flickering-when-turning-off-light/48733.
+     * Parallel shading compilition generally improves the speed of material compilition and helps when switching
+     * materials while objects are moving (eg: animations).
+     * Deactivating parallel shading compilition is benefitial when switching lights and materials in static scenarios.
+     * It's activated by default due to compatibility reasons but can be overwritten with this flag.
+     */
+    useParallelShaderCompile?: boolean;
   };
   scene: SceneDefinition;
   animations?: AnimationDefinitions;