@combeenation/3d-viewer 12.0.0-alpha2 → 12.0.0-alpha3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@combeenation/3d-viewer",
-  "version": "12.0.0-alpha2",
+  "version": "12.0.0-alpha3",
   "description": "Combeenation 3D Viewer",
   "homepage": "https://github.com/Combeenation/3d-viewer#readme",
   "bugs": {

package/src/api/manager/gltfExportManager.ts

@@ -59,6 +59,8 @@ export class GltfExportManager {
   }
 
   protected async _exportPreProcess(excluded?: ExcludedGeometryList): Promise<void> {
+    this.viewer.pauseRendering();
+
     // handle materials
     this.viewer.scene.materials
       .filter(material => this._shouldReplaceMaterial(material))
@@ -75,7 +77,7 @@ export class GltfExportManager {
 
     // reset transformation of all "TransformNodes", which couldn't be handled by the geometry baking algorithm
     // it's important that this is done AFTER all geometries have been baked
-    this.viewer.scene.transformNodes
+    [...this.viewer.scene.transformNodes, ...this.viewer.scene.meshes]
       .filter(node => !!node.metadata?.[GltfExportManager._METADATA_PROPS.exportNode])
       .forEach(node => resetTransformation(node as TransformNode));
   }
@@ -89,6 +91,8 @@ export class GltfExportManager {
     this.viewer.scene.materials
       .filter(mat => !!mat.metadata?.[GltfExportManager._METADATA_PROPS.deleteAfterExport])
       .forEach(material => material.dispose(false, false));
+
+    this.viewer.resumeRendering();
   }
 
   protected _gltfExportOptions(): IExportOptions {
@@ -176,12 +180,12 @@ export class GltfExportManager {
   /**
    * Create an export-friendly replacement material for a material using refraction.
    */
-  protected _createRefractionMaterialReplacement(material: PBRMaterial): PBRMaterial {
+  protected _createRefractionMaterialReplacement(material: PBRMaterial) {
     const newName = `${material.name}_clone`;
-    // change material according to https://www.notion.so/combeenation/Glas-materials-don-t-look-glasy-after-export-d5fda2c6515e4420a8772744d3e6b460
-    const clonedMaterial = material.clone(newName); // clone material
+
+    const clonedMaterial = material.clone(newName);
     clonedMaterial.refractionTexture = null;
-    clonedMaterial.metallicReflectanceTexture = null; // is this the correct one for metallic roughness?
+    clonedMaterial.metallicReflectanceTexture = null;
     clonedMaterial.alpha = 0.7;
     clonedMaterial.albedoColor = new Color3(0.3, 0.3, 0.3);
     clonedMaterial.transparencyMode = PBRMaterial.PBRMATERIAL_ALPHABLEND;
@@ -190,7 +194,5 @@ export class GltfExportManager {
 
     injectMetadata(material, { [GltfExportManager._METADATA_PROPS.exchangeMaterialWith]: newName });
     injectMetadata(clonedMaterial, { [GltfExportManager._METADATA_PROPS.deleteAfterExport]: true });
-
-    return clonedMaterial;
   }
 }