@colyseus/schema 4.0.24 → 4.0.25

package/build/index.js

@@ -1375,7 +1375,8 @@
                 key += `-${this.root.types.schemas.get(parentConstructor)}`;
             }
             key += `-${parentIndex}`;
-            const fieldHasViewTag = Metadata.hasViewTagAtIndex(parentConstructor?.[Symbol.metadata], parentIndex);
+            const parentMetadata = parentConstructor?.[Symbol.metadata];
+            const fieldHasViewTag = Metadata.hasViewTagAtIndex(parentMetadata, parentIndex);
             this.isFiltered = parent[$changes].isFiltered // in case parent is already filtered
                 || this.root.types.parentFiltered[key]
                 || fieldHasViewTag;
@@ -1384,9 +1385,22 @@
             // when it's available, we need to enqueue the "changes" changeset into the "filteredChanges" changeset.
             //
             if (this.isFiltered) {
+                //
+                // Children of a `@view(N)` collection (non-default tag) inherit
+                // visibility from their parent, so items pushed/set after the
+                // initial `view.add(state, N)` show up automatically.
+                //
+                // Default-tag `@view()` collections deliberately keep per-item
+                // gating — `view.add(item)` is required to opt each one in.
+                //
+                // The `parentMetadata[parentIndex].tag` access is safe inside
+                // this branch: the OR's short-circuit means we only reach it
+                // when `fieldHasViewTag` is true, which guarantees the metadata
+                // entry and its `tag` property exist.
+                //
                 this.isVisibilitySharedWithParent = (parentChangeTree.isFiltered &&
                     typeof (refType) !== "string" &&
-                    !fieldHasViewTag);
+                    (!fieldHasViewTag || (parentIsCollection && parentMetadata[parentIndex].tag !== DEFAULT_VIEW_TAG)));
                 if (!this.filteredChanges) {
                     this.filteredChanges = createChangeSet();
                     this.allFilteredChanges = createChangeSet();

package/build/index.mjs

@@ -1369,7 +1369,8 @@ class ChangeTree {
             key += `-${this.root.types.schemas.get(parentConstructor)}`;
         }
         key += `-${parentIndex}`;
-        const fieldHasViewTag = Metadata.hasViewTagAtIndex(parentConstructor?.[Symbol.metadata], parentIndex);
+        const parentMetadata = parentConstructor?.[Symbol.metadata];
+        const fieldHasViewTag = Metadata.hasViewTagAtIndex(parentMetadata, parentIndex);
         this.isFiltered = parent[$changes].isFiltered // in case parent is already filtered
             || this.root.types.parentFiltered[key]
             || fieldHasViewTag;
@@ -1378,9 +1379,22 @@ class ChangeTree {
         // when it's available, we need to enqueue the "changes" changeset into the "filteredChanges" changeset.
         //
         if (this.isFiltered) {
+            //
+            // Children of a `@view(N)` collection (non-default tag) inherit
+            // visibility from their parent, so items pushed/set after the
+            // initial `view.add(state, N)` show up automatically.
+            //
+            // Default-tag `@view()` collections deliberately keep per-item
+            // gating — `view.add(item)` is required to opt each one in.
+            //
+            // The `parentMetadata[parentIndex].tag` access is safe inside
+            // this branch: the OR's short-circuit means we only reach it
+            // when `fieldHasViewTag` is true, which guarantees the metadata
+            // entry and its `tag` property exist.
+            //
             this.isVisibilitySharedWithParent = (parentChangeTree.isFiltered &&
                 typeof (refType) !== "string" &&
-                !fieldHasViewTag);
+                (!fieldHasViewTag || (parentIsCollection && parentMetadata[parentIndex].tag !== DEFAULT_VIEW_TAG)));
             if (!this.filteredChanges) {
                 this.filteredChanges = createChangeSet();
                 this.allFilteredChanges = createChangeSet();