@colyseus/schema 3.0.49 → 3.0.51

package/build/cjs/index.js

@@ -1104,7 +1104,7 @@ class ChangeTree {
             if (typeof (this.ref[$childType]) !== "string") {
                 // MapSchema / ArraySchema, etc.
                 for (const [key, value] of this.ref.entries()) {
-                    callback(value[$changes], key);
+                    callback(value[$changes], this.indexes?.[key] ?? key);
                 }
             }
         }
@@ -1543,10 +1543,6 @@ const encodeSchemaOperation = function (encoder, bytes, changeTree, index, opera
 const encodeKeyValueOperation = function (encoder, bytes, changeTree, index, operation, it) {
     // encode operation
     bytes[it.offset++] = operation & 255;
-    // custom operations
-    if (operation === exports.OPERATION.CLEAR) {
-        return;
-    }
     // encode index
     encode.number(bytes, index, it);
     // Do not encode value for DELETE operations
@@ -1592,7 +1588,12 @@ const encodeArray = function (encoder, bytes, changeTree, field, operation, it,
     const useOperationByRefId = hasView && changeTree.isFiltered && (typeof (changeTree.getType(field)) !== "string");
     let refOrIndex;
     if (useOperationByRefId) {
-        refOrIndex = ref['tmpItems'][field][$changes].refId;
+        const item = ref['tmpItems'][field];
+        // Skip encoding if item is undefined (e.g. when clear() is called)
+        if (!item) {
+            return;
+        }
+        refOrIndex = item[$changes].refId;
         if (operation === exports.OPERATION.DELETE) {
             operation = exports.OPERATION.DELETE_BY_REFID;
         }
@@ -1605,11 +1606,6 @@ const encodeArray = function (encoder, bytes, changeTree, field, operation, it,
     }
     // encode operation
     bytes[it.offset++] = operation & 255;
-    // custom operations
-    if (operation === exports.OPERATION.CLEAR ||
-        operation === exports.OPERATION.REVERSE) {
-        return;
-    }
     // encode index
     encode.number(bytes, refOrIndex, it);
     // Do not encode value for DELETE operations
@@ -3413,7 +3409,12 @@ class Schema {
             ? ` [×${root.refCount[refId]}]`
             : '';
         let output = `${getIndent(level)}${keyPrefix}${ref.constructor.name} (refId: ${refId})${refCount}${contents}\n`;
-        changeTree.forEachChild((childChangeTree, key) => {
+        changeTree.forEachChild((childChangeTree, indexOrKey) => {
+            let key = indexOrKey;
+            if (typeof indexOrKey === 'number' && ref['$indexes']) {
+                // MapSchema
+                key = ref['$indexes'].get(indexOrKey) ?? indexOrKey;
+            }
             const keyPrefix = (ref['forEach'] !== undefined && key !== undefined) ? `["${key}"]: ` : "";
             output += this.debugRefIds(childChangeTree.ref, showContents, level + 1, decoder, keyPrefix);
         });
@@ -4108,11 +4109,15 @@ class Encoder {
             }
             for (let j = 0; j < numChanges; j++) {
                 const fieldIndex = changeSet.operations[j];
-                const operation = (fieldIndex < 0)
-                    ? Math.abs(fieldIndex) // "pure" operation without fieldIndex (e.g. CLEAR, REVERSE, etc.)
-                    : (isEncodeAll)
-                        ? exports.OPERATION.ADD
-                        : changeTree.indexedOperations[fieldIndex];
+                if (fieldIndex < 0) {
+                    // "pure" operation without fieldIndex (e.g. CLEAR, REVERSE, etc.)
+                    // encode and continue early - no need to reach $filter check
+                    buffer[it.offset++] = Math.abs(fieldIndex) & 255;
+                    continue;
+                }
+                const operation = (isEncodeAll)
+                    ? exports.OPERATION.ADD
+                    : changeTree.indexedOperations[fieldIndex];
                 //
                 // first pass (encodeAll), identify "filtered" operations without encoding them
                 // they will be encoded per client, based on their view.