@colyseus/schema 3.0.44 → 3.0.46

package/build/esm/index.mjs

@@ -1424,7 +1424,9 @@ class ChangeTree {
      */
     addParent(parent, index) {
         // Check if this parent already exists in the chain
-        if (this.hasParent((p, i) => p[$changes] === parent[$changes] && i === index)) {
+        if (this.hasParent((p, _) => p[$changes] === parent[$changes])) {
+            // if (this.hasParent((p, i) => p[$changes] === parent[$changes] && i === index)) {
+            this.parentChain.index = index;
             return;
         }
         this.parentChain = {
@@ -2008,7 +2010,7 @@ class ArraySchema {
                             }
                             if (previousValue !== undefined) {
                                 // remove root reference from previous value
-                                previousValue[$changes].root?.remove(previousValue[$changes], obj);
+                                previousValue[$changes].root?.remove(previousValue[$changes]);
                             }
                         }
                         else {
@@ -2165,7 +2167,7 @@ class ArraySchema {
         const changeTree = this[$changes];
         // remove children references
         changeTree.forEachChild((childChangeTree, _) => {
-            changeTree.root?.remove(childChangeTree, this);
+            changeTree.root?.remove(childChangeTree);
         });
         changeTree.discard(true);
         changeTree.operation(OPERATION.CLEAR);
@@ -2719,7 +2721,7 @@ class MapSchema {
                 operation = OPERATION.DELETE_AND_ADD;
                 // remove reference from previous value
                 if (previousValue !== undefined) {
-                    previousValue[$changes].root?.remove(previousValue[$changes], this);
+                    previousValue[$changes].root?.remove(previousValue[$changes]);
                 }
             }
         }
@@ -2756,7 +2758,7 @@ class MapSchema {
         changeTree.indexes = {};
         // remove children references
         changeTree.forEachChild((childChangeTree, _) => {
-            changeTree.root?.remove(childChangeTree, this);
+            changeTree.root?.remove(childChangeTree);
         });
         // clear previous indexes
         this.$indexes.clear();
@@ -3598,7 +3600,7 @@ class CollectionSchema {
         changeTree.indexes = {};
         // remove children references
         changeTree.forEachChild((childChangeTree, _) => {
-            changeTree.root?.remove(childChangeTree, this);
+            changeTree.root?.remove(childChangeTree);
         });
         // clear previous indexes
         this.$indexes.clear();
@@ -3920,9 +3922,8 @@ class Root {
         // console.log("ADD", { refId: changeTree.refId, refCount: this.refCount[changeTree.refId] });
         return isNewChangeTree;
     }
-    remove(changeTree, parent) {
+    remove(changeTree) {
         const refCount = (this.refCount[changeTree.refId]) - 1;
-        // console.log("REMOVE", { refId: changeTree.refId, refCount });
         if (refCount <= 0) {
             //
             // Only remove "root" reference if it's the last reference
@@ -3941,7 +3942,7 @@ class Root {
                     if ((child.parentChain === undefined || // no parent, remove it
                         (child.parentChain && this.refCount[child.refId] > 1) // parent is still in use, but has more than one reference, remove it
                     )) {
-                        this.remove(child, changeTree.ref);
+                        this.remove(child);
                     }
                     else if (child.parentChain) {
                         // re-assigning a child of the same root, move it to the end
@@ -4422,7 +4423,11 @@ class Decoder {
                 // Trying to access a reference that haven't been decoded yet.
                 //
                 if (!nextRef) {
-                    throw new Error(`"refId" not found: ${nextRefId}`);
+                    // throw new Error(`"refId" not found: ${nextRefId}`);
+                    console.error(`"refId" not found: ${nextRefId}`, { previousRef: ref, previousRefId: this.currentRefId });
+                    console.warn("Please report this to the developers. All refIds =>");
+                    console.warn(Schema.debugRefIdsFromDecoder(this));
+                    this.skipCurrentStructure(bytes, it, totalBytes);
                 }
                 else {
                     ref = nextRef;