@colyseus/schema 3.0.34 → 3.0.36

package/README.md

@@ -246,9 +246,9 @@ const decoder = new Decoder(state);
 decoder.decode(encodedBytes);
 ```
 
-### Backwards/forwards compability
+### Backwards/forwards compatibility
 
-Backwards/fowards compatibility is possible by declaring new fields at the
+Backwards/forwards compatibility is possible by declaring new fields at the
 end of existing structures, and earlier declarations to not be removed, but
 be marked `@deprecated()` when needed.
 
@@ -307,10 +307,10 @@ Each Colyseus SDK has its own decoder implementation of the `@colyseus/schema` p
 
 ## Why
 
-Initial thoghts/assumptions, for Colyseus:
+Initial thoughts/assumptions, for Colyseus:
 - little to no bottleneck for detecting state changes.
-- have a schema definition on both server and client
-- better experience on staticaly-typed languages (C#, C++)
+- have a schema definition on both the server and the client
+- better experience on statically-typed languages (C#, C++)
 - mutations should be cheap.
 
 Practical Colyseus issues this should solve:

package/build/cjs/index.js

@@ -4214,7 +4214,7 @@ class ReferenceTracker {
     }
     removeCallback(refId, field, callback) {
         const index = this.callbacks?.[refId]?.[field]?.indexOf(callback);
-        if (index !== -1) {
+        if (index !== undefined && index !== -1) {
             spliceOne(this.callbacks[refId][field], index);
         }
     }
@@ -4980,7 +4980,7 @@ class StateView {
         if (tag === DEFAULT_VIEW_TAG) {
             // parent is collection (Map/Array)
             const parent = changeTree.parent;
-            if (!Metadata.isValidInstance(parent)) {
+            if (!Metadata.isValidInstance(parent) && changeTree.isFiltered) {
                 const parentChangeTree = parent[$changes];
                 let changes = this.changes.get(parentChangeTree.refId);
                 if (changes === undefined) {
@@ -4992,7 +4992,7 @@ class StateView {
             }
             else {
                 // delete all "tagged" properties.
-                metadata?.[$viewFieldIndexes].forEach((index) => changes[index] = exports.OPERATION.DELETE);
+                metadata?.[$viewFieldIndexes]?.forEach((index) => changes[index] = exports.OPERATION.DELETE);
             }
         }
         else {