@colyseus/schema 3.0.28 → 3.0.29

package/build/esm/index.mjs

@@ -957,6 +957,9 @@ const Metadata = {
             fields[metadata[i].name] = metadata[i].type;
         }
         return fields;
+    },
+    hasViewTagAtIndex(metadata, index) {
+        return metadata?.[$viewFieldIndexes]?.includes(index);
     }
 };
 
@@ -1377,7 +1380,7 @@ class ChangeTree {
             key += `-${this.root.types.schemas.get(parentConstructor)}`;
         }
         key += `-${parentIndex}`;
-        const fieldHasViewTag = parentConstructor?.[Symbol.metadata]?.[$viewFieldIndexes]?.includes(parentIndex);
+        const fieldHasViewTag = Metadata.hasViewTagAtIndex(parentConstructor?.[Symbol.metadata], parentIndex);
         this.isFiltered = parent[$changes].isFiltered // in case parent is already filtered
             || this.root.types.parentFiltered[key]
             || fieldHasViewTag;
@@ -1520,7 +1523,7 @@ const encodeArray = function (encoder, bytes, changeTree, field, operation, it,
     // encode index
     encode.number(bytes, refOrIndex, it);
     // Do not encode value for DELETE operations
-    if (operation === OPERATION.DELETE) {
+    if (operation === OPERATION.DELETE || operation === OPERATION.DELETE_BY_REFID) {
         return;
     }
     const type = changeTree.getType(field);
@@ -1741,10 +1744,14 @@ const decodeArray = function (decoder, bytes, it, ref, allChanges) {
     else if (operation === OPERATION.ADD_BY_REFID) {
         const refId = decode.number(bytes, it);
         const itemByRefId = decoder.root.refs.get(refId);
-        // use existing index, or push new value
-        index = (itemByRefId)
-            ? ref.findIndex((value) => value === itemByRefId)
-            : ref.length;
+        // if item already exists, use existing index
+        if (itemByRefId) {
+            index = ref.findIndex((value) => value === itemByRefId);
+        }
+        // fallback to use last index
+        if (index === -1 || index === undefined) {
+            index = ref.length;
+        }
     }
     else {
         index = decode.number(bytes, it);