@colyseus/schema 3.0.21 → 3.0.22

package/build/cjs/index.js

@@ -3923,13 +3923,14 @@ class Encoder {
             const changeTree = this.root.changeTrees[refId];
             if (changeTree === undefined) {
                 // detached instance, remove from view and skip.
+                // console.log("detached instance, remove from view and skip.", refId);
                 view.changes.delete(refId);
                 continue;
             }
             const keys = Object.keys(changes);
             if (keys.length === 0) {
                 // FIXME: avoid having empty changes if no changes were made
-                // console.log("changes.size === 0, skip", changeTree.ref.constructor.name);
+                // console.log("changes.size === 0, skip", refId, changeTree.ref.constructor.name);
                 continue;
             }
             const ref = changeTree.ref;
@@ -4075,7 +4076,7 @@ class ReferenceTracker {
             //
             // Ensure child schema instances have their references removed as well.
             //
-            if (Metadata.isValidInstance(ref)) {
+            if (ref.constructor[Symbol.metadata] !== undefined) {
                 const metadata = ref.constructor[Symbol.metadata];
                 for (const index in metadata) {
                     const field = metadata[index].name;
@@ -4086,7 +4087,7 @@ class ReferenceTracker {
                 }
             }
             else {
-                if (typeof (Object.values(ref[$childType])[0]) === "function") {
+                if (typeof (ref[$childType]) === "function") {
                     Array.from(ref.values())
                         .forEach((child) => {
                         const childRefId = this.refIds.get(child);
@@ -4729,7 +4730,7 @@ class StateView {
     }
     // TODO: allow to set multiple tags at once
     add(obj, tag = DEFAULT_VIEW_TAG, checkIncludeParent = true) {
-        if (!obj[$changes]) {
+        if (!obj?.[$changes]) {
             console.warn("StateView#add(), invalid object:", obj);
             return this;
         }
@@ -4851,7 +4852,7 @@ class StateView {
         }
         this.items.delete(changeTree);
         const ref = changeTree.ref;
-        const metadata = ref.constructor[Symbol.metadata];
+        const metadata = ref.constructor[Symbol.metadata]; // ArraySchema/MapSchema do not have metadata
         let changes = this.changes.get(changeTree.refId);
         if (changes === undefined) {
             changes = {};
@@ -4872,12 +4873,12 @@ class StateView {
             }
             else {
                 // delete all "tagged" properties.
-                metadata[$viewFieldIndexes].forEach((index) => changes[index] = exports.OPERATION.DELETE);
+                metadata?.[$viewFieldIndexes].forEach((index) => changes[index] = exports.OPERATION.DELETE);
             }
         }
         else {
             // delete only tagged properties
-            metadata[$fieldIndexesByViewTag][tag].forEach((index) => changes[index] = exports.OPERATION.DELETE);
+            metadata?.[$fieldIndexesByViewTag][tag].forEach((index) => changes[index] = exports.OPERATION.DELETE);
         }
         // remove tag
         if (this.tags && this.tags.has(changeTree)) {