@colyseus/schema 3.0.2 → 3.0.4

package/build/esm/index.mjs

@@ -1545,7 +1545,7 @@ function decodeValue(decoder, operation, ref, index, type, bytes, it, allChanges
             //     previousValue,
             // });
         }
-        value = null;
+        value = undefined;
     }
     if (operation === OPERATION.DELETE) ;
     else if (Schema.is(type)) {
@@ -1859,6 +1859,9 @@ class ArraySchema {
             // type format: { array: "string" }
             (type['array'] !== undefined));
     }
+    static from(iterable) {
+        return new ArraySchema(...Array.from(iterable));
+    }
     constructor(...items) {
         this.items = [];
         this.tmpItems = [];
@@ -2225,8 +2228,8 @@ class ArraySchema {
     lastIndexOf(searchElement, fromIndex = this.length - 1) {
         return this.items.lastIndexOf(searchElement, fromIndex);
     }
-    every(callbackfn, thisArg) {
-        return this.items.every(callbackfn, thisArg);
+    every(predicate, thisArg) {
+        return this.items.every(predicate, thisArg);
     }
     /**
      * Determines whether the specified callback function returns true for any element of an array.
@@ -2408,6 +2411,9 @@ class ArraySchema {
     //
     with(index, value) {
         const copy = this.items.slice();
+        // Allow negative indexing from the end
+        if (index < 0)
+            index += this.length;
         copy[index] = value;
         return new ArraySchema(...copy);
     }
@@ -4483,7 +4489,10 @@ function getDecoderStateCallbacks(decoder) {
                     }
                 }
                 // trigger onChange
-                if (change.value !== change.previousValue) {
+                if (change.value !== change.previousValue &&
+                    // FIXME: see "should not encode item if added and removed at the same patch" test case.
+                    // some "ADD" + "DELETE" operations on same patch are being encoded as "DELETE"
+                    (change.value !== undefined || change.previousValue !== undefined)) {
                     const replaceCallbacks = $callbacks[OPERATION.REPLACE];
                     for (let i = replaceCallbacks?.length - 1; i >= 0; i--) {
                         replaceCallbacks[i](change.value, change.dynamicIndex ?? change.field);
@@ -4596,6 +4605,9 @@ function getDecoderStateCallbacks(decoder) {
             const onRemove = function (ref, callback) {
                 return $root.addCallback($root.refIds.get(ref), OPERATION.DELETE, callback);
             };
+            const onChange = function (ref, callback) {
+                return $root.addCallback($root.refIds.get(ref), OPERATION.REPLACE, callback);
+            };
             return new Proxy({
                 onAdd: function (callback, immediate = true) {
                     //
@@ -4627,6 +4639,19 @@ function getDecoderStateCallbacks(decoder) {
                         return onRemove(context.instance, callback);
                     }
                 },
+                onChange: function (callback) {
+                    if (context.onInstanceAvailable) {
+                        // collection instance not received yet
+                        let detachCallback = () => { };
+                        context.onInstanceAvailable((ref) => {
+                            detachCallback = onChange(ref, callback);
+                        });
+                        return () => detachCallback();
+                    }
+                    else if (context.instance) {
+                        return onChange(context.instance, callback);
+                    }
+                },
             }, {
                 get(target, prop) {
                     if (!target[prop]) {