@colyseus/schema 3.0.2 → 3.0.3

package/build/esm/index.mjs

@@ -1545,7 +1545,7 @@ function decodeValue(decoder, operation, ref, index, type, bytes, it, allChanges
             //     previousValue,
             // });
         }
-        value = null;
+        value = undefined;
     }
     if (operation === OPERATION.DELETE) ;
     else if (Schema.is(type)) {
@@ -4483,7 +4483,10 @@ function getDecoderStateCallbacks(decoder) {
                     }
                 }
                 // trigger onChange
-                if (change.value !== change.previousValue) {
+                if (change.value !== change.previousValue &&
+                    // FIXME: see "should not encode item if added and removed at the same patch" test case.
+                    // some "ADD" + "DELETE" operations on same patch are being encoded as "DELETE"
+                    (change.value !== undefined || change.previousValue !== undefined)) {
                     const replaceCallbacks = $callbacks[OPERATION.REPLACE];
                     for (let i = replaceCallbacks?.length - 1; i >= 0; i--) {
                         replaceCallbacks[i](change.value, change.dynamicIndex ?? change.field);
@@ -4596,6 +4599,9 @@ function getDecoderStateCallbacks(decoder) {
             const onRemove = function (ref, callback) {
                 return $root.addCallback($root.refIds.get(ref), OPERATION.DELETE, callback);
             };
+            const onChange = function (ref, callback) {
+                return $root.addCallback($root.refIds.get(ref), OPERATION.REPLACE, callback);
+            };
             return new Proxy({
                 onAdd: function (callback, immediate = true) {
                     //
@@ -4627,6 +4633,19 @@ function getDecoderStateCallbacks(decoder) {
                         return onRemove(context.instance, callback);
                     }
                 },
+                onChange: function (callback) {
+                    if (context.onInstanceAvailable) {
+                        // collection instance not received yet
+                        let detachCallback = () => { };
+                        context.onInstanceAvailable((ref) => {
+                            detachCallback = onChange(ref, callback);
+                        });
+                        return () => detachCallback();
+                    }
+                    else if (context.instance) {
+                        return onChange(context.instance, callback);
+                    }
+                },
             }, {
                 get(target, prop) {
                     if (!target[prop]) {