@columenlabs/lumen-ship 0.1.157 → 0.1.159

package/README.md

@@ -100,7 +100,7 @@ lumen-ship check kit-neutral [paths]   # no name from LUMEN_FORBIDDEN_NAMES (def
 lumen-ship check suppressions          # a useExhaustiveDependencies suppression needs a reason of 3+ words
 lumen-ship check settings-copy         # a Settings section description is one plain line of 64 characters or less
 lumen-ship check magic-numbers         # hard-coded px/rem class values may only go down
-lumen-ship check parts <folders>       # the kit's part pages: hint-text, text-action, raw-overlay may only go down
+lumen-ship check parts <folders>       # the kit's part pages: hint-text, text-action, raw-overlay, settings-page may only go down
 ```
 
 Run each from a package folder in its `lint` script; run `parts` from the repo root with the app folders (`lumen-ship check parts apps/*/web/src`). `magic-numbers` reads the repo's `scripts/magic-numbers.baseline` (or `LUMEN_SHIP_BASELINE`): one `<folder> <count>` a line, lowered in the change that removes one. `parts` reads `scripts/parts.baseline` (or `LUMEN_SHIP_PARTS_BASELINE`): one `<folder> <rule> <count>` a line; `--write-baseline` writes today's counts on a first run. Each rule is explained, with what to write instead, at https://lumen.columenlabs.com/parts/README.md.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@columenlabs/lumen-ship",
-  "version": "0.1.157",
+  "version": "0.1.159",
   "description": "Lumen's shipping kit: release notes, the What's new changelog and lint guards.",
   "license": "MIT",
   "type": "module",

package/scripts/check-parts.sh

@@ -7,6 +7,8 @@
 #   hint-text    a grey line under a field or title: <p className="... text-xs ... text-muted-foreground ...">
 #   text-action  a <Button> whose text is an action: an IconButton (or SaveButton) instead
 #   raw-overlay  an import of the kit's raw ui/sheet, ui/dialog, ui/select, ui/command or ui/combobox
+#   settings-page a route, link or nav item to a page of its own named settings: settings are sections
+#                of the one Settings dialog (LumenShell settings, opened at ?settings=<section>)
 set -euo pipefail
 write=0
 if [ "${1:-}" = "--write-baseline" ]; then
@@ -18,7 +20,7 @@ if [ $# -eq 0 ]; then
   exit 1
 fi
 baseline=${LUMEN_SHIP_PARTS_BASELINE:-$(git rev-parse --show-toplevel)/scripts/parts.baseline}
-rules="hint-text text-action raw-overlay"
+rules="hint-text text-action raw-overlay settings-page"
 
 # Prints `file:line` for each break of one rule in one folder.
 hits() {
@@ -31,6 +33,8 @@ hits() {
         $re = qr/<p\s[^>]*className="(?=[^"]*\btext-xs\b)(?=[^"]*\btext-muted-foreground\b)[^"]*"/;
       } elsif ($rule eq "text-action") {
         $re = qr/<Button\b[^>]*>\s*(?:<[A-Z]\w*[^>]*\/>\s*)?(?:\{[^}]*\?\s*)?\x27?(?:Save|Run|Test|Send|Sync|Refresh|Copy|Edit|Delete|Remove|Retry|Reset)\b/;
+      } elsif ($rule eq "settings-page") {
+        $re = qr/\b(?:path|to|href)\s*[:=]\s*\{?\s*[\x27"`](?:[^\x27"`]*\/)?settings(?=[\/?#\x27"`])/i;
       } else {
         $re = qr/from\s+[\x27"]\@columenlabs\/lumen-ui\/ui\/(?:sheet|dialog|select|command|combobox)[\x27"]/;
       }