@colrealpro/react-luau-doctor 0.20.2 → 0.20.3

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.20.3
+
+### Fixed
+
+- Improved PR summary footer wording
+- Inline reviews are now scoped to only findings introduced by the latest PR push again
+
 ## 0.20.2
 
 ### Changed

package/dist/cli.js

@@ -11,7 +11,7 @@ var package_default = {
   publishConfig: {
     access: "public"
   },
-  version: "0.20.2",
+  version: "0.20.3",
   description: "Static analysis for React-Luau hooks, effects, rendering, and performance.",
   license: "MIT",
   type: "module",
@@ -9464,10 +9464,10 @@ No eligible React-Luau files changed in this pull request \xB7 scan skipped`;
       baseline: true
     }
   ];
-  const inlineNote = options.inlineCount > 0 ? "See inline comments for fixes" : "See this report for findings";
+  const inlineNote = total > 0 && options.inlineCount > 0 ? " \xB7 See inline comments for fixes" : "";
   const footer = `
 
-<sub>Reviewed by [React-Luau Doctor](https://github.com/ColRealPro/react-luau-doctor)` + ` for commit ${inlineCode(options.sha.slice(0, 7))} \xB7 ${inlineNote}</sub>
+<sub>Reviewed by [React-Luau Doctor](https://github.com/ColRealPro/react-luau-doctor)` + ` for commit ${inlineCode(options.sha.slice(0, 7))}${inlineNote}</sub>
 `;
   const reportLink = options.runUrl ? `[the full workflow report](${options.runUrl})` : "the workflow summary and logs";
   const overflow = `
@@ -14735,12 +14735,29 @@ ${JSON.stringify({ ...report, fixedDiagnostics: fixed })}
     await publishSummary();
     if (settings.reviewComments && snapshot && base && !stale) {
       try {
+        const reviewBase = event.action === "synchronize" ? event.before : base;
+        if (event.action === "synchronize" && (!reviewBase || !/^[a-f0-9]{40}$/i.test(reviewBase) || gitResult(scan.repoRoot, ["merge-base", "--is-ancestor", reviewBase, head]) === null)) {
+          throw new Error("Previous PR head is unavailable or history was rewritten; new inline comments were skipped");
+        }
         const lines = createGitScopePlan(path11.resolve(settings.directory), {
           scope: "lines",
-          base
+          base: reviewBase
         }).changedLines;
+        const canInline = (diagnostic) => (lines.get(diagnostic.file) ?? []).some((range) => diagnostic.location.line >= range.start && diagnostic.location.line <= range.end);
+        let introduced = !event.action || event.action === "opened" ? analysis.introduced : [];
+        if (analysis.complete && event.action === "synchronize" && analysis.introduced.some(({ diagnostic }) => canInline(diagnostic))) {
+          const update = await scanForCi({ ...settings, scope: "changed" }, true, reviewBase, head);
+          if (!update.analysis.complete) {
+            throw new Error("Previous PR head analysis was incomplete; new inline comments were skipped");
+          }
+          const fresh = new Set(update.comparison.diagnostics.map((diagnostic) => diagnostic.file + "\x00" + diagnostic.id));
+          introduced = analysis.introduced.filter(({ diagnostic }) => fresh.has(diagnostic.file + "\x00" + diagnostic.id));
+        }
         const latestSnapshot = await reviewSnapshot(client);
-        inlineCount = await reconcileReviews(client, latestSnapshot, analysis, (diagnostic) => (lines.get(diagnostic.file) ?? []).some((range) => diagnostic.location.line >= range.start && diagnostic.location.line <= range.end));
+        inlineCount = await reconcileReviews(client, latestSnapshot, {
+          ...analysis,
+          introduced
+        }, canInline);
       } catch (error) {
         stale ||= error instanceof StalePublication;
         process.stderr.write(`react-luau-doctor: could not update inline review comments: ${errorMessage(error)}
@@ -16704,5 +16721,5 @@ ${renderUpdateNotice(update.current, update.latest, colorized)}
 }
 main();
 
-//# debugId=72F30B6744C80DF864756E2164756E21
+//# debugId=1B34073C2F3EACBB64756E2164756E21
 //# sourceMappingURL=cli.js.map