@colrealpro/react-luau-doctor 0.20.1 → 0.20.3

package/dist/config.schema.json

@@ -329,7 +329,7 @@
             "suggestion"
           ],
           "default": "warning",
-          "description": "Do not read binding snapshots during render except to initialize a ref"
+          "description": "Do not read binding snapshots during render except in hook initialization arguments"
         },
         "react-luau/usememo-must-return": {
           "type": "string",

package/dist/scan-worker.js

@@ -1168,7 +1168,13 @@ function isLazyRefInitialization(context, call) {
   }
   return false;
 }
-function isRefInitializer(context, call) {
+var hookInitializerArguments = new Map([
+  ["React.useRef", 0],
+  ["React.useState", 0],
+  ["React.useBinding", 0],
+  ["React.useReducer", 1]
+]);
+function isHookInitializer(context, call) {
   let node = call;
   while (node.parent) {
     const parent = node.parent;
@@ -1176,8 +1182,11 @@ function isRefInitializer(context, call) {
       return false;
     if (parent.type === "arguments") {
       const hook = parent.parent;
-      if (hook?.type === "function_call" && reactApiPath(context, hook) === "React.useRef" && context.callArguments(hook)[0]?.id === node.id)
-        return true;
+      if (hook?.type === "function_call") {
+        const argumentIndex = hookInitializerArguments.get(reactApiPath(context, hook) ?? "");
+        if (argumentIndex !== undefined && context.callArguments(hook)[argumentIndex]?.id === node.id)
+          return true;
+      }
     }
     node = parent;
   }
@@ -1211,18 +1220,18 @@ var noBindingGetValueInRender = {
   id: "react-luau/no-binding-getvalue-in-render",
   category: "Correctness",
   severity: "warning",
-  description: "Do not read binding snapshots during render except to initialize a ref",
+  description: "Do not read binding snapshots during render except in hook initialization arguments",
   guidance: {
     explanation: "getValue returns a snapshot without subscribing \u2014 later binding updates do not rerender the component or update props built from that snapshot",
     help: "Pass the binding directly to the prop or use binding:map(function(value) return ... end)",
-    caveat: "A snapshot used to initialize React.useRef is allowed because the initial value is intentionally preserved"
+    caveat: "Snapshots in the first argument to React.useRef, React.useState, or React.useBinding, or the second argument to React.useReducer, are allowed because those arguments are used only for initialization"
   },
   run(context) {
     return context.findCalls().flatMap((call) => {
       const owner = context.nearestFunction(call);
       const name = call.childForFieldName("name");
       const receiver = name?.namedChildren[0];
-      if (!owner || !owner.isComponent && !owner.isHook || name?.type !== "method_index_expression" || name.namedChildren.at(-1)?.text !== "getValue" || !receiver || !isBinding(context, receiver) || isRefInitializer(context, call))
+      if (!owner || !owner.isComponent && !owner.isHook || name?.type !== "method_index_expression" || name.namedChildren.at(-1)?.text !== "getValue" || !receiver || !isBinding(context, receiver) || isHookInitializer(context, call))
         return [];
       return [
         {
@@ -9329,6 +9338,7 @@ async function analyzeReactFile(input, tree, selectedRules = rules) {
       project: input.project
     };
     const context = createRuleContext(file);
+    const syntaxFindings = parsedTree.rootNode.hasError ? parseErrors.run(context) : [];
     const categorySet = input.categories && input.categories.length > 0 ? new Set(input.categories) : null;
     const isSuppressed = input.respectInlineDisables ? createInlineSuppressionChecker(input.source) : () => false;
     const diagnostics = [];
@@ -9340,7 +9350,7 @@ async function analyzeReactFile(input, tree, selectedRules = rules) {
       const severity = effectiveSeverity(rule.severity, rule.id, input.config);
       if (!severity)
         continue;
-      const findings = rule.run(context);
+      const findings = rule.id === parseErrors.id ? syntaxFindings : rule.run(context);
       for (const finding of findings) {
         const configuredSeverity = input.config.rules?.[rule.id];
         const diagnostic = toDiagnostic(file, rule.id, rule.category, severity, {
@@ -9361,7 +9371,8 @@ async function analyzeReactFile(input, tree, selectedRules = rules) {
       relativePath: input.relativePath,
       isReactFile: model.isReactFile,
       scanned: true,
-      diagnostics: filteredDiagnostics
+      diagnostics: filteredDiagnostics,
+      unverified: syntaxFindings.length > 0
     };
   } finally {
     if (!tree)
@@ -10348,5 +10359,5 @@ parentPort.on("message", async (request) => {
   }
 });
 
-//# debugId=AB0DC00E72A2325A64756E2164756E21
+//# debugId=3E81A30ECFF40BE164756E2164756E21
 //# sourceMappingURL=scan-worker.js.map