@colixsystems/widget-sdk 0.228.0 → 0.229.0

package/README.md

@@ -84,7 +84,16 @@ See the design reference for the full architecture: [`docs/architecture/widget-m
 
 ## Status
 
-`v0.228.0` — pre-publish. The package surface (types, function names, export paths) is the v1 contract; runtime behaviour for some hooks is stubbed (each hook documents what's wired and what isn't). It is **not yet published to npm**.
+`v0.229.0` — pre-publish. The package surface (types, function names, export paths) is the v1 contract; runtime behaviour for some hooks is stubbed (each hook documents what's wired and what isn't). It is **not yet published to npm**.
+
+### What's new in 0.229.0 (contract unchanged)
+
+**A field's focus ring and a card's border stay inside the widget.** The hosts clip a widget at its own edge, so anything painted outside it is cut off.
+
+- **`<TextField>` and the `<Select>` trigger draw focus inside their own box.** A focused field shows a 2px ring in the accent: its border plus an inset 1px `boxShadow`, in the error colour while the field is invalid. On the web it turns the browser's outer focus outline off, because that outline sat outside the field and was cut off wherever the field touched the widget's edge. `<SearchField>` and the built-in form fields use the same field, so they get it too. The text field also takes `minWidth: 0`, so it shrinks in a row instead of pushing its neighbour past the edge. A caller's `style` still comes last.
+- **New linter rule `full-width-margin-overflow` (severity `warning`, non-blocking).** It flags a style object that sets `width: "100%"` together with a non-zero side margin (`margin`, `marginHorizontal`, `marginLeft`/`Right`/`Start`/`End`, `marginInline`/`InlineStart`/`InlineEnd`; a zero, `undefined` or `null` value is not counted). The percentage is already the parent's whole width, so the margin pushes the box past its parent and the host cuts off its right edge, border included. Drop the width, because a `View` already stretches, and inset with the parent's `padding`. The scan reads one style literal, not the tree, so it stays a warning. Comments are not scanned.
+
+`CONTRACT` is unchanged (no new field), and no export changed signature.
 
 ### What's new in 0.228.0 (contract 1.184.0)
 

package/dist/form-control-tokens.js

@@ -71,6 +71,26 @@ export function focusHaloStyle(t, focused, radius) {
   };
 }
 
+// Web: a field shell draws its own ring, so the host's outer one stays off.
+export const FIELD_OUTLINE_OFF = Object.freeze({ outlineColor: "transparent" });
+
+/**
+ * A field shell's state border (`<TextField>`, a `<Select>` trigger). Focus is
+ * the border plus an inset 1px ring, 2px in all and inside the box, so a parent
+ * clipping at the field's edge cannot cut it. An invalid field rings in the
+ * error colour while it is being fixed.
+ *
+ * @param {object} t — resolved form-control tokens.
+ * @param {{focused: boolean, invalid: boolean}} state
+ */
+export function fieldStateStyle(t, { focused, invalid }) {
+  if (focused) {
+    const color = invalid ? t.errorColor : t.focusColor;
+    return { borderColor: color, boxShadow: `inset 0 0 0 1px ${color}` };
+  }
+  return invalid ? { borderColor: t.errorColor } : null;
+}
+
 /**
  * The colours a switch hands the platform control. A caller's `trackColor`
  * overrides the theme per state, and iOS, which paints the off track from

package/dist/linter.cjs

@@ -1477,6 +1477,92 @@ function _flexBasisPercentRules(source) {
   return findings;
 }
 
+// sc-11277 — `width: "100%"` plus a side margin is wider than its parent.
+//
+// The percentage is the parent's whole content width and the margin is added
+// outside it, so the box overflows by the margin. The hosts clip a widget at
+// its own edge (the Player's sideways guard, a fixed-height slot), which cuts
+// off the right edge of a bordered card or input. A `View` already stretches
+// across a column, so the width is redundant; the inset belongs in the
+// parent's padding.
+//
+// A warning: the scan reads one style literal, not the tree, so a row parent
+// that absorbs the excess still matches.
+const _FULL_WIDTH_RE = /\bwidth\s*:\s*(["'`])100%\1/g;
+const _SIDE_MARGIN_KEY_RE =
+  /\bmargin(?:Horizontal|Left|Right|Start|End|Inline(?:Start|End)?)?\s*:/g;
+const _ZERO_VALUE_RE =
+  /^\s*(?:(["'`]?)-?0(?:\.0*)?(?:px)?\1\s*(?:[,}]|$)|(?:undefined|null)\b)/m;
+
+// The innermost `{ … }` around `at`, as [start, end); null outside any.
+function _enclosingObject(code, at) {
+  let start = -1;
+  for (let i = at - 1, depth = 0; i >= 0; i--) {
+    if (code[i] === "}") depth++;
+    else if (code[i] === "{" && depth-- === 0) {
+      start = i;
+      break;
+    }
+  }
+  if (start < 0) return null;
+  for (let j = at, depth = 0; j < code.length; j++) {
+    if (code[j] === "{") depth++;
+    else if (code[j] === "}" && depth-- === 0) return [start, j + 1];
+  }
+  return null;
+}
+
+// The object's own keys only: a nested object's margin is not this box's.
+// Blanked rather than cut, so an offset here is the same offset in the source.
+function _ownKeysMask(structure, [start, end]) {
+  let body = structure.slice(start, end);
+  let previous;
+  do {
+    previous = body;
+    body = body.replace(/(?<!^)\{[^{}]*\}(?!$)/g, (nested) => " ".repeat(nested.length));
+  } while (body !== previous);
+  return body;
+}
+
+function _hasSideMargin(code, structure, span) {
+  const keys = _ownKeysMask(structure, span);
+  _SIDE_MARGIN_KEY_RE.lastIndex = 0;
+  let key;
+  while ((key = _SIDE_MARGIN_KEY_RE.exec(keys))) {
+    const valueAt = span[0] + key.index + key[0].length;
+    if (!_ZERO_VALUE_RE.test(code.slice(valueAt, valueAt + 40))) return true;
+  }
+  return false;
+}
+
+function _fullWidthMarginRules(source) {
+  const findings = [];
+  const code = _stripNonCode(source, { keepStrings: true });
+  // Strings blanked, so a brace inside a literal never unbalances the match.
+  const structure = _stripNonCode(source);
+  const sourceLines = source.split(/\r?\n/);
+  _FULL_WIDTH_RE.lastIndex = 0;
+  let hit;
+  while ((hit = _FULL_WIDTH_RE.exec(code))) {
+    const span = _enclosingObject(structure, hit.index);
+    if (!span) continue;
+    if (!_hasSideMargin(code, structure, span)) continue;
+    const line = code.slice(0, hit.index).split(/\r?\n/).length;
+    findings.push({
+      rule: "full-width-margin-overflow",
+      severity: "warning",
+      label:
+        `width: "100%" plus a side margin is wider than the parent by that ` +
+        `margin, so the host clips the box's right edge and its border. Drop ` +
+        `the width (a View already stretches) or move the inset to the ` +
+        `parent's padding.`,
+      line,
+      snippet: (sourceLines[line - 1] || "").trim().slice(0, 200),
+    });
+  }
+  return findings;
+}
+
 // sc-4913 — a measured frame INCLUDES the element's own padding, so cells sized
 // from it overflow the content box and the last one wraps into an empty column.
 // Mirror of linter.js (see there for the full rationale).
@@ -2100,6 +2186,8 @@ function lintSource(source, options) {
   // sc-7274 — soft warning: a percentage flexBasis sizes the main axis, so in a
   // column it claims the parent's whole height and overflows.
   findings.push(..._flexBasisPercentRules(source));
+  // sc-11277 — soft warning: a full-width box with a side margin is clipped.
+  findings.push(..._fullWidthMarginRules(source));
   // sc-4913 — soft warning: a measured width that includes the widget's own
   // padding wraps the last grid column into an empty one.
   findings.push(..._measuredPaddingRules(source));

package/dist/linter.js

@@ -1518,6 +1518,92 @@ function _flexBasisPercentRules(source) {
   return findings;
 }
 
+// sc-11277 — `width: "100%"` plus a side margin is wider than its parent.
+//
+// The percentage is the parent's whole content width and the margin is added
+// outside it, so the box overflows by the margin. The hosts clip a widget at
+// its own edge (the Player's sideways guard, a fixed-height slot), which cuts
+// off the right edge of a bordered card or input. A `View` already stretches
+// across a column, so the width is redundant; the inset belongs in the
+// parent's padding.
+//
+// A warning: the scan reads one style literal, not the tree, so a row parent
+// that absorbs the excess still matches.
+const _FULL_WIDTH_RE = /\bwidth\s*:\s*(["'`])100%\1/g;
+const _SIDE_MARGIN_KEY_RE =
+  /\bmargin(?:Horizontal|Left|Right|Start|End|Inline(?:Start|End)?)?\s*:/g;
+const _ZERO_VALUE_RE =
+  /^\s*(?:(["'`]?)-?0(?:\.0*)?(?:px)?\1\s*(?:[,}]|$)|(?:undefined|null)\b)/m;
+
+// The innermost `{ … }` around `at`, as [start, end); null outside any.
+function _enclosingObject(code, at) {
+  let start = -1;
+  for (let i = at - 1, depth = 0; i >= 0; i--) {
+    if (code[i] === "}") depth++;
+    else if (code[i] === "{" && depth-- === 0) {
+      start = i;
+      break;
+    }
+  }
+  if (start < 0) return null;
+  for (let j = at, depth = 0; j < code.length; j++) {
+    if (code[j] === "{") depth++;
+    else if (code[j] === "}" && depth-- === 0) return [start, j + 1];
+  }
+  return null;
+}
+
+// The object's own keys only: a nested object's margin is not this box's.
+// Blanked rather than cut, so an offset here is the same offset in the source.
+function _ownKeysMask(structure, [start, end]) {
+  let body = structure.slice(start, end);
+  let previous;
+  do {
+    previous = body;
+    body = body.replace(/(?<!^)\{[^{}]*\}(?!$)/g, (nested) => " ".repeat(nested.length));
+  } while (body !== previous);
+  return body;
+}
+
+function _hasSideMargin(code, structure, span) {
+  const keys = _ownKeysMask(structure, span);
+  _SIDE_MARGIN_KEY_RE.lastIndex = 0;
+  let key;
+  while ((key = _SIDE_MARGIN_KEY_RE.exec(keys))) {
+    const valueAt = span[0] + key.index + key[0].length;
+    if (!_ZERO_VALUE_RE.test(code.slice(valueAt, valueAt + 40))) return true;
+  }
+  return false;
+}
+
+function _fullWidthMarginRules(source) {
+  const findings = [];
+  const code = _stripNonCode(source, { keepStrings: true });
+  // Strings blanked, so a brace inside a literal never unbalances the match.
+  const structure = _stripNonCode(source);
+  const sourceLines = source.split(/\r?\n/);
+  _FULL_WIDTH_RE.lastIndex = 0;
+  let hit;
+  while ((hit = _FULL_WIDTH_RE.exec(code))) {
+    const span = _enclosingObject(structure, hit.index);
+    if (!span) continue;
+    if (!_hasSideMargin(code, structure, span)) continue;
+    const line = code.slice(0, hit.index).split(/\r?\n/).length;
+    findings.push({
+      rule: "full-width-margin-overflow",
+      severity: "warning",
+      label:
+        `width: "100%" plus a side margin is wider than the parent by that ` +
+        `margin, so the host clips the box's right edge and its border. Drop ` +
+        `the width (a View already stretches) or move the inset to the ` +
+        `parent's padding.`,
+      line,
+      snippet: (sourceLines[line - 1] || "").trim().slice(0, 200),
+    });
+  }
+  return findings;
+}
+
 // sc-4913 — a measured frame INCLUDES the element's own padding.
 //
 // `onLayout` reports the frame width, and padding sits inside that frame. A
@@ -2168,6 +2254,8 @@ export function lintSource(source, options) {
   // sc-7274 — soft warning: a percentage flexBasis sizes the main axis, so in a
   // column it claims the parent's whole height and overflows.
   findings.push(..._flexBasisPercentRules(source));
+  // sc-11277 — soft warning: a full-width box with a side margin is clipped.
+  findings.push(..._fullWidthMarginRules(source));
   // sc-4913 — soft warning: a measured width that includes the widget's own
   // padding wraps the last grid column into an empty one.
   findings.push(..._measuredPaddingRules(source));

package/dist/select-view.js

@@ -13,6 +13,8 @@ import { Icon } from "./icon.js";
 import { TEXT_FIELD_TOKEN_NAMES } from "./text-field-tokens.js";
 import {
   CONTROL_MIN_TARGET,
+  FIELD_OUTLINE_OFF,
+  fieldStateStyle,
   nextOptionIndex,
   resolveFormControlTokens,
   selectedOption,
@@ -253,8 +255,8 @@ export function makeSelect(rn) {
               borderRadius: t.radius,
               backgroundColor: t.background,
             },
-            focused ? { borderColor: t.focusColor } : null,
-            invalid ? { borderColor: t.errorColor } : null,
+            FIELD_OUTLINE_OFF,
+            fieldStateStyle(t, { focused, invalid }),
             style,
           ],
         },

package/dist/text-field-view.js

@@ -6,7 +6,11 @@ import React from "react";
 import { useHostTheme } from "./hooks.js";
 import { DEFAULT_THEME_TOKENS } from "./_theme-tokens.js";
 import { TEXT_FIELD_TOKEN_NAMES } from "./text-field-tokens.js";
-import { resolveFormControlTokens } from "./form-control-tokens.js";
+import {
+  FIELD_OUTLINE_OFF,
+  fieldStateStyle,
+  resolveFormControlTokens,
+} from "./form-control-tokens.js";
 import {
   errorMessage,
   hasNote,
@@ -45,7 +49,6 @@ export function makeTextField(rn) {
       ...others
     } = props;
     const theme = useHostTheme() || DEFAULT_THEME_TOKENS;
-    // Native draws no focus ring, so the border itself shows focus.
     const [focused, setFocused] = React.useState(false);
     const overrides = {};
     const rest = {};
@@ -80,10 +83,11 @@ export function makeTextField(rn) {
           color: t.textColor,
           fontFamily: t.fontFamily,
           fontSize: t.fontSize,
+          // An input will not shrink below its text width in a row otherwise.
+          minWidth: 0,
         },
-        focused ? { borderColor: t.focusColor } : null,
-        // After focus: an invalid field stays marked while it is being fixed.
-        invalid ? { borderColor: t.errorColor } : null,
+        FIELD_OUTLINE_OFF,
+        fieldStateStyle(t, { focused, invalid }),
         // The frame dims a framed field as a whole.
         disabled && !framed ? { opacity: t.disabledOpacity } : null,
         style,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@colixsystems/widget-sdk",
-  "version": "0.228.0",
+  "version": "0.229.0",
   "description": "Common widget interface for AppStudio. Implements WidgetManifest, WidgetContext, property schema, and helper hooks.",
   "homepage": "https://github.com/Colix-AB/AppStudio",
   "type": "module",