@coldiq/mcp 0.2.6 → 0.2.8

package/tests/tools/search-places.test.ts

@@ -1,6 +1,54 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
 import { initClient } from '../../src/client.js'
-import { searchPlacesHandler } from '../../src/tools/search-places.js'
+import { searchPlacesHandler, applyPlaceFilters } from '../../src/tools/search-places.js'
+
+describe('applyPlaceFilters', () => {
+  const sample = {
+    places: [
+      { title: 'Low rating, many reviews', totalScore: 2.9, reviewsCount: 81 },
+      { title: 'Mid rating, mid reviews', totalScore: 3.9, reviewsCount: 322 },
+      { title: 'High rating, many reviews', totalScore: 4.6, reviewsCount: 1101 },
+      { title: 'High rating, few reviews', totalScore: 4.7, reviewsCount: 12 },
+      { title: 'Missing fields', /* no totalScore or reviewsCount */ },
+    ],
+  }
+
+  it('passes through unchanged when no filters supplied', () => {
+    const out = applyPlaceFilters(sample, {}) as { places: unknown[] }
+    expect(out.places).toHaveLength(5)
+  })
+
+  it('does not mutate its input', () => {
+    const before = JSON.stringify(sample)
+    applyPlaceFilters(sample, { maxRating: 4 })
+    expect(JSON.stringify(sample)).toBe(before)
+  })
+
+  it('max_overall_rating drops places above the cap', () => {
+    const out = applyPlaceFilters(sample, { maxRating: 4 }) as { places: Array<{ totalScore?: number }> }
+    expect(out.places.map((p) => p.totalScore)).toEqual([2.9, 3.9])
+  })
+
+  it('min_total_reviews drops places below the floor', () => {
+    const out = applyPlaceFilters(sample, { minReviews: 20 }) as { places: Array<{ reviewsCount?: number }> }
+    expect(out.places.map((p) => p.reviewsCount)).toEqual([81, 322, 1101])
+  })
+
+  it('combined filters apply as AND', () => {
+    const out = applyPlaceFilters(sample, { maxRating: 4, minReviews: 20 }) as { places: Array<{ title?: string }> }
+    expect(out.places.map((p) => p.title)).toEqual(['Low rating, many reviews', 'Mid rating, mid reviews'])
+  })
+
+  it('places with missing totalScore/reviewsCount are dropped when corresponding filter is active', () => {
+    const out = applyPlaceFilters(sample, { minRating: 0 }) as { places: Array<{ title?: string }> }
+    expect(out.places.map((p) => p.title)).not.toContain('Missing fields')
+  })
+
+  it('non-object / non-array shapes are passed through untouched', () => {
+    expect(applyPlaceFilters(null, { maxRating: 4 })).toBe(null)
+    expect(applyPlaceFilters({ places: 'not an array' }, { maxRating: 4 })).toEqual({ places: 'not an array' })
+  })
+})
 
 describe('search_places handler', () => {
   const originalFetch = globalThis.fetch
@@ -100,6 +148,54 @@ describe('search_places handler', () => {
     }
   })
 
+  it('google_maps response is post-filtered by max_overall_rating + min_total_reviews', async () => {
+    // Regression guard: if the handler stops wiring applyPlaceFilters, this test fails.
+    globalThis.fetch = vi.fn(async (url: string | URL | Request) => {
+      const u = url.toString()
+      if (u.includes('/google-maps/scraper') && !u.includes('/scraper/')) {
+        return new Response(JSON.stringify({ jobId: 'gm-filter' }), { status: 200 })
+      }
+      if (u.includes('/google-maps/scraper/gm-filter')) {
+        return new Response(JSON.stringify({
+          jobId: 'gm-filter',
+          status: 'done',
+          places: [
+            { title: 'Strict match — keep', totalScore: 3.5, reviewsCount: 120 },
+            { title: 'Rating too high — drop', totalScore: 4.7, reviewsCount: 800 },
+            { title: 'Too few reviews — drop', totalScore: 2.9, reviewsCount: 10 },
+          ],
+        }), { status: 200 })
+      }
+      return new Response(JSON.stringify({ error: 'unexpected' }), { status: 500 })
+    }) as typeof fetch
+
+    const { getProviders } = await import('../../src/registry.js')
+    const providers = getProviders('search_places')
+    const gm = providers.find((p) => p.id === 'google_maps')!
+    const orig = { t: gm.async!.timeoutMs, i: gm.async!.pollIntervalMs }
+
+    try {
+      gm.async!.timeoutMs = 500
+      gm.async!.pollIntervalMs = 20
+      const result = await searchPlacesHandler({
+        query: 'dentist',
+        country: 'FR',
+        provider: 'google_maps',
+        max_overall_rating: 4,
+        min_total_reviews: 20,
+        limit: 10,
+      })
+
+      expect(result.isError).toBeFalsy()
+      const parsed = JSON.parse(result.content[0].text)
+      expect(parsed._meta.provider).toBe('google_maps')
+      expect(parsed.data.places.map((p: { title: string }) => p.title)).toEqual(['Strict match — keep'])
+    } finally {
+      gm.async!.timeoutMs = orig.t
+      gm.async!.pollIntervalMs = orig.i
+    }
+  })
+
   it('all providers fail — returns isError', async () => {
     globalThis.fetch = vi.fn(async () => {
       return new Response(JSON.stringify({ error: 'down' }), { status: 503 })