@cohortapp/agent-sdk 2.4.0 → 2.4.1

package/lib/setup/enroll-from-cohort.mjs

@@ -186,7 +186,17 @@ export function mapProfileToAgentConfig(profile) {
   // the "Background" section of the prompt persona block (lib/identity/persona.mjs)
   // so the agent writes with its own history behind it rather than as a generic
   // seat-holder. The org is the SoT for this; we never synthesise one.
-  const persona = sectionText(sections, ["persona", "background", "bio", "about", "profile"]);
+  // Real Cohort records put this prose in one of two places, and the section
+  // list alone missed both for a live seat: the section is named SUMMARY (not
+  // "persona"/"background"), and the DTO also carries a top-level `bio` with the
+  // same text. Missing it is not cosmetic — an empty persona leaves
+  // `{{agent.persona}}` unresolved in CLAUDE.md and drops the Background line
+  // from the prompt block, which is the exact "generic assistant" failure this
+  // whole change exists to remove. Section first (it is the richer, explicitly
+  // authored field), then the top-level bio.
+  const persona =
+    sectionText(sections, ["persona", "background", "bio", "about", "profile", "summary"]) ||
+    str(p.bio);
   if (persona) patch.persona = persona;
 
   // charter — the Cohort-authored operating charter (CharterDTO:
@@ -345,7 +355,17 @@ function findSection(sections, names) {
       const id = str(s.id).toLowerCase();
       const title = str(s.title).toLowerCase();
       const heading = str(s.heading).toLowerCase();
-      return wanted.includes(id) || wanted.includes(title) || wanted.includes(heading);
+      // `kind` is what a real Cohort ProfileSection identifies itself by
+      // (SUMMARY, VISUAL_PROMPT, COUNTERPARTS_NARRATIVE). Matching only
+      // id/title/heading silently missed EVERY section on a live seat, so a
+      // fully-populated org profile still yielded an empty persona.
+      const kind = str(s.kind).toLowerCase();
+      return (
+        wanted.includes(id) ||
+        wanted.includes(title) ||
+        wanted.includes(heading) ||
+        wanted.includes(kind)
+      );
     }) || null
   );
 }

package/lib/setup/enroll-from-cohort.test.mjs

@@ -273,3 +273,28 @@ test("pullAndPlan: a local override is NOT clobbered without --force", async ()
   const forced = await pullAndPlan({ agentRoot: root, env, force: true, fetchSelfProfileImpl: async () => ({ ok: true, result: PROFILE }) });
   assert.equal(forced.patch.title, "VP of Engineering", "--force overwrites");
 });
+
+test("persona falls back to the SUMMARY section and then the top-level bio", () => {
+  // A live Cohort seat had its prose in a section named SUMMARY and in the
+  // DTO's top-level `bio` — neither of which the original name list matched.
+  // The result was an empty persona, an unresolved {{agent.persona}} in
+  // CLAUDE.md, and no Background line in the prompt: exactly the generic-seat
+  // failure this mapping exists to prevent.
+  const fromSummary = mapProfileToAgentConfig({
+    profileSections: [{ kind: "SUMMARY", body: "I build the agent substrate." }],
+  });
+  assert.equal(fromSummary.persona, "I build the agent substrate.");
+
+  const fromBio = mapProfileToAgentConfig({ bio: "I run platform engineering." });
+  assert.equal(fromBio.persona, "I run platform engineering.");
+
+  // An explicitly authored section still wins over the terser bio.
+  const both = mapProfileToAgentConfig({
+    bio: "short bio",
+    profileSections: [{ kind: "background", body: "the long authored version" }],
+  });
+  assert.equal(both.persona, "the long authored version");
+
+  // Nothing to say stays empty — we never synthesise a persona.
+  assert.equal(mapProfileToAgentConfig({}).persona, undefined);
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cohortapp/agent-sdk",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "description": "Cohort Agent SDK \u2014 autonomous AI colleague runtime. Deploy senior AI colleagues on dedicated Mac minis, wired to the Cohort operating surface.",
   "type": "module",
   "bin": {