@cohortapp/agent-sdk 2.17.0 → 2.18.4

package/scripts/daemon/lib/self-echo.test.mjs

@@ -1,153 +0,0 @@
-/**
- * self-echo.test.mjs — the sender==self match that three production recurrences
- * (2026-08-25 / 08-27 / 08-30) proved the old inline check could not make.
- *
- * Run: node --test scripts/daemon/lib/self-echo.test.mjs
- *
- * The load-bearing case is the REAL event shape: cohort inbox items carry the
- * display name verbatim (`sender: "Isla Roselli"`), while the old filter
- * compared against `fullName.toLowerCase().replace(/\s+/g, "-")` —
- * "isla-roselli" — so the echo sailed through and the agent acked itself.
- */
-
-import { test, describe, beforeEach } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, writeFileSync, readFileSync, rmSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { loadSelfIdentity, isSelfSender, normalizeName, logSelfEchoDrop, _resetSelfIdentity } from "./self-echo.mjs";
-
-const ROOT = mkdtempSync(join(tmpdir(), "self-echo-test-"));
-mkdirSync(join(ROOT, "config"), { recursive: true });
-writeFileSync(join(ROOT, "config", "agent.json"), JSON.stringify({
-  firstName: "Isla",
-  fullName: "Isla Roselli",
-  memberId: "cmqh0tcml004ihhl6zev6ocb5",
-  email: "isla@example.com",
-  org: { cohort: { agentId: "A016" } },
-}));
-
-beforeEach(() => _resetSelfIdentity());
-
-const me = () => loadSelfIdentity(ROOT);
-
-describe("normalizeName", () => {
-  test("folds case and the separator zoo to one comparable form", () => {
-    for (const v of ["Isla Roselli", "isla roselli", "isla-roselli", "Isla_Roselli", "isla.roselli", "  Isla   Roselli "]) {
-      assert.equal(normalizeName(v), "isla roselli", `"${v}" must normalise`);
-    }
-  });
-});
-
-describe("isSelfSender — the shapes real events actually carry", () => {
-  test("REGRESSION: the verbatim display name — the exact 25/27/30 Aug echo shape — matches", () => {
-    // Field-for-field the 30 Aug production echo (cmtfqjwvv01kype01t002t8jf):
-    const echo = {
-      id: "cohort-cmtfqjwvv01kype01t002t8jf",
-      service: "cohort",
-      channel: "dm-a016-a039",
-      sender: "Isla Roselli",
-      raw_ref: "cohort:dm:cmtfqjwvv01kype01t002t8jf:192025",
-      event_kind: "send",
-      is_dm: true,
-    };
-    assert.equal(isSelfSender(echo, me()), true);
-  });
-
-  test("the OLD filter's dashed form and other separator variants also match", () => {
-    for (const s of ["isla-roselli", "Isla_Roselli", "isla roselli"]) {
-      assert.equal(isSelfSender({ sender: s }, me()), true, `"${s}" is this agent`);
-    }
-  });
-
-  test("REGRESSION: the BARE first name alone is NOT self — it collides with every namesake", () => {
-    // "Isla" as a display name is any colleague, contact or CC'd person who
-    // shares the first name. Matching it dropped their genuine inbound.
-    assert.equal(isSelfSender({ sender: "Isla" }, me()), false);
-    assert.equal(isSelfSender({ sender: "isla" }, me()), false);
-  });
-
-  test("REGRESSION: a NON-matching id EXONERATES a colliding display name", () => {
-    // A namesake — display name "Isla Roselli", but a DIFFERENT member cuid.
-    // The id positively identifies the sender as someone else; the name rung
-    // must never be reached, so this is NOT self and must not be dropped.
-    assert.equal(
-      isSelfSender({ sender: "Isla Roselli", sender_id: "cmDIFFERENT00000000000000" }, me()),
-      false,
-      "an id that resolves to someone else outranks the name collision",
-    );
-    assert.equal(
-      isSelfSender({ sender: "isla-roselli", author_id: "cmDIFFERENT00000000000000" }, me()),
-      false,
-    );
-  });
-
-  test("REGRESSION: a NON-matching email exonerates a colliding display name too", () => {
-    assert.equal(
-      isSelfSender({ sender: "Isla Roselli", sender_email: "other.isla@example.com" }, me()),
-      false,
-    );
-    // …while the OWN email still matches regardless of the display name.
-    assert.equal(
-      isSelfSender({ sender: "totally different name", sender_email: "isla@example.com" }, me()),
-      true,
-    );
-  });
-
-  test("a member cuid on any id-ish field matches (strongest evidence)", () => {
-    for (const item of [
-      { sender: "someone", sender_id: "cmqh0tcml004ihhl6zev6ocb5" },
-      { sender: "someone", author_id: "CMQH0TCML004IHHL6ZEV6OCB5" },
-      { sender: "someone", from: { id: "cmqh0tcml004ihhl6zev6ocb5" } },
-    ]) {
-      assert.equal(isSelfSender(item, me()), true);
-    }
-  });
-
-  test("the org seat slug matches too", () => {
-    assert.equal(isSelfSender({ sender: "x", sender_id: "A016" }, me()), true);
-  });
-
-  test("own email matches (gmail/orgmail lanes)", () => {
-    assert.equal(isSelfSender({ sender: "Isla via mail", sender_email: "isla@example.com" }, me()), true);
-  });
-
-  test("genuine colleagues NEVER match — no false drops", () => {
-    for (const s of ["Jordan Blake", "Candace Wong", "Isla Fisher", "roselli", "isla2", "ceo"]) {
-      assert.equal(isSelfSender({ sender: s }, me()), false, `"${s}" must not be dropped`);
-    }
-    assert.equal(isSelfSender({ sender: "Candace Wong", sender_id: "cmOTHER000000000000000000" }, me()), false);
-  });
-
-  test("an UNCONFIGURED identity matches nothing — a half-set-up repo drops no inbound", () => {
-    const bare = mkdtempSync(join(tmpdir(), "self-echo-bare-"));
-    try {
-      const id = loadSelfIdentity(bare);
-      assert.equal(isSelfSender({ sender: "Isla Roselli" }, id), false);
-      assert.equal(isSelfSender({ sender: "Agent" }, id), false);
-    } finally {
-      rmSync(bare, { recursive: true, force: true });
-    }
-  });
-});
-
-describe("logSelfEchoDrop — every drop is auditable", () => {
-  test("appends one JSONL row per drop under logs/daemon/", () => {
-    const item = { id: "e-1", raw_ref: "cohort:dm:e-1:42", sender: "Isla Roselli", channel: "dm-a016-a039", service: "cohort", event_kind: "send" };
-    logSelfEchoDrop(item, { stage: "poll", service: "cohort", agentRoot: ROOT });
-    logSelfEchoDrop(item, { stage: "process", service: "cohort", agentRoot: ROOT });
-    const rows = readFileSync(join(ROOT, "logs", "daemon", "self-echo-drops.jsonl"), "utf-8")
-      .split("\n").filter(Boolean).map((l) => JSON.parse(l));
-    assert.equal(rows.length, 2);
-    assert.equal(rows[0].stage, "poll");
-    assert.equal(rows[1].stage, "process");
-    assert.equal(rows[0].raw_ref, "cohort:dm:e-1:42");
-    assert.equal(rows[0].sender, "Isla Roselli");
-  });
-
-  test("never throws, even for a junk item", () => {
-    assert.doesNotThrow(() => logSelfEchoDrop(null, { agentRoot: ROOT }));
-    assert.doesNotThrow(() => logSelfEchoDrop(undefined, { agentRoot: join(ROOT, "no", "such", "deep") }));
-  });
-});