@cohortapp/agent-sdk 2.16.0 → 2.18.4

package/scripts/session/supervisor-sh.test.mjs

@@ -1,218 +0,0 @@
-/**
- * supervisor-sh.test.mjs — coverage for scripts/session/supervisor.sh.
- *
- * Builds a fixture agent root, points NODE_BIN at a stub that dumps its argv
- * and environment, runs the wrapper, and asserts what reached the "node"
- * process: AGENT_ROOT, HOME, the PATH prefix, the .env variables (quotes
- * stripped, malformed lines skipped, existing env not clobbered), and the
- * supervisor.mjs entrypoint. Also pins that the wrapper's exit code is the
- * child's (exec) and that the log lands under logs/session/.
- */
-
-import { test } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, writeFileSync, readFileSync, readdirSync, copyFileSync, chmodSync, rmSync, realpathSync, existsSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join, resolve, dirname } from "node:path";
-import { fileURLToPath } from "node:url";
-import { spawnSync } from "node:child_process";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const WRAPPER_SRC = resolve(__dirname, "supervisor.sh");
-
-function makeAgent() {
-  // The wrapper resolves AGENT_ROOT with `pwd -P`, so compare against the real path (/var → /private/var on macOS).
-  const root = realpathSync(mkdtempSync(join(tmpdir(), "maestro-supervisor-sh-")));
-  mkdirSync(join(root, "scripts", "session"), { recursive: true });
-  mkdirSync(join(root, "config"), { recursive: true });
-  writeFileSync(join(root, "config", "agent.json"), JSON.stringify({ firstName: "Olivia" }));
-  copyFileSync(WRAPPER_SRC, join(root, "scripts", "session", "supervisor.sh"));
-  chmodSync(join(root, "scripts", "session", "supervisor.sh"), 0o755);
-  writeFileSync(join(root, "scripts", "session", "supervisor.mjs"), "// stub entrypoint (never run: NODE_BIN is a stub)\n");
-  mkdirSync(join(root, "bin"), { recursive: true });
-  const stub = join(root, "bin", "node");
-  writeFileSync(stub, [
-    "#!/bin/sh",
-    'echo "ARGV:$*"',
-    "env | grep -E '^(AGENT_ROOT|AGENT_DIR|HOME|USER|PATH|MAESTRO_TEST_[A-Z_]*)=' | sort",
-    'exit "${STUB_EXIT:-0}"',
-    "",
-  ].join("\n"));
-  chmodSync(stub, 0o755);
-  return { root, stub };
-}
-
-function runWrapper(root, stub, extraEnv = {}) {
-  const env = { PATH: "/usr/bin:/bin", NODE_BIN: stub, ...extraEnv };
-  const r = spawnSync("/bin/bash", [join(root, "scripts", "session", "supervisor.sh"), "--flag", "x"], { env, encoding: "utf8", timeout: 20_000 });
-  const logDir = join(root, "logs", "session");
-  let log = "";
-  try {
-    const files = readdirSync(logDir).filter((f) => /^supervisor-\d{4}-\d{2}-\d{2}\.log$/.test(f));
-    log = files.map((f) => readFileSync(join(logDir, f), "utf8")).join("");
-  } catch { /* no log dir → assertions below fail loudly */ }
-  return { r, log };
-}
-
-test("supervisor.sh parses under bash -n", () => {
-  const r = spawnSync("/bin/bash", ["-n", WRAPPER_SRC], { encoding: "utf8" });
-  assert.equal(r.status, 0, r.stderr);
-});
-
-test("wrapper sets AGENT_ROOT/HOME/PATH, sources .env safely, execs supervisor.mjs and logs under logs/session", () => {
-  const { root, stub } = makeAgent();
-  try {
-    writeFileSync(join(root, ".env"), [
-      "# comment line",
-      "",
-      "MAESTRO_TEST_PLAIN=plain",
-      'MAESTRO_TEST_QUOTED="has spaces and = signs"',
-      "MAESTRO_TEST_SINGLE='single quoted'",
-      "export MAESTRO_TEST_EXPORTED=exported",
-      "MAESTRO_TEST_PRESET=from-dotenv",
-      "this line is not a kv pair",
-      "BAD KEY=nope",
-      "MAESTRO_TEST_BAD-DASH=nope",
-      // dotenv semantics the daemon already relies on: an unquoted value ends
-      // at the first `#` and is trimmed; a quoted value keeps its `#`; a CRLF
-      // line (edited on Windows) must not leak a trailing \r into a token.
-      "MAESTRO_TEST_INLINE=value # trailing comment",
-      "MAESTRO_TEST_NOSPACE=abc#def",
-      "MAESTRO_TEST_TRAIL=spaced   ",
-      'MAESTRO_TEST_QHASH="keep # this"',
-      "MAESTRO_TEST_CRLF=windows\r",
-      "MAESTRO_TEST_CRLFQ=\"quoted windows\"\r",
-      "",
-    ].join("\n"));
-    const { r, log } = runWrapper(root, stub, { MAESTRO_TEST_PRESET: "from-shell", HOME: "/Users/fixture" });
-    assert.equal(r.status, 0, `${r.stdout}\n${r.stderr}`);
-    assert.equal(r.stdout, "", "wrapper must not write to its own stdout (everything goes to the log)");
-    // exec'd entrypoint + passthrough args
-    assert.match(log, new RegExp(`^ARGV:${join(root, "scripts", "session", "supervisor.mjs").replace(/[.*+?^${}()|[\]\\]/g, "\\$&")} --flag x$`, "m"));
-    assert.match(log, new RegExp(`^AGENT_ROOT=${root.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}$`, "m"));
-    assert.match(log, new RegExp(`^AGENT_DIR=${root.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}$`, "m"));
-    assert.match(log, /^HOME=\/Users\/fixture$/m);
-    assert.match(log, /^USER=.+$/m);
-    assert.match(log, /^PATH=\/Users\/fixture\/\.local\/bin:\/opt\/homebrew\/bin:\/opt\/homebrew\/sbin:\/usr\/local\/bin:\/usr\/bin:\/bin:\/usr\/sbin:\/sbin:\/usr\/bin:\/bin$/m);
-    // .env semantics
-    assert.match(log, /^MAESTRO_TEST_PLAIN=plain$/m);
-    assert.match(log, /^MAESTRO_TEST_QUOTED=has spaces and = signs$/m);
-    assert.match(log, /^MAESTRO_TEST_SINGLE=single quoted$/m);
-    assert.match(log, /^MAESTRO_TEST_EXPORTED=exported$/m);
-    assert.match(log, /^MAESTRO_TEST_PRESET=from-shell$/m, "an existing env var must win over .env");
-    assert.doesNotMatch(log, /MAESTRO_TEST_BAD/);
-    assert.doesNotMatch(log, /nope/);
-    assert.match(log, /^MAESTRO_TEST_INLINE=value$/m, "unquoted inline comment must be stripped");
-    assert.match(log, /^MAESTRO_TEST_NOSPACE=abc$/m);
-    assert.match(log, /^MAESTRO_TEST_TRAIL=spaced$/m);
-    assert.match(log, /^MAESTRO_TEST_QHASH=keep # this$/m, "a quoted # is data");
-    assert.match(log, /^MAESTRO_TEST_CRLF=windows$/m, "CR from a CRLF line must not reach the value");
-    assert.match(log, /^MAESTRO_TEST_CRLFQ=quoted windows$/m);
-    assert.doesNotMatch(log, /\r/, "no carriage return anywhere in the child env");
-  } finally {
-    rmSync(root, { recursive: true, force: true });
-  }
-});
-
-test("wrapper works with no .env at all and returns the supervisor's exit code (75)", () => {
-  const { root, stub } = makeAgent();
-  try {
-    const { r, log } = runWrapper(root, stub, { STUB_EXIT: "75" });
-    assert.equal(r.status, 75);
-    assert.match(log, /^ARGV:/m);
-  } finally {
-    rmSync(root, { recursive: true, force: true });
-  }
-});
-
-test("under an emergency stop (.emergency-stop or state/EMERGENCY_STOP) the wrapper exits 0 without starting node — launchd's KeepAlive does not relaunch a clean exit", () => {
-  for (const marker of [".emergency-stop", join("state", "EMERGENCY_STOP")]) {
-    const { root, stub } = makeAgent();
-    try {
-      mkdirSync(join(root, "state"), { recursive: true });
-      writeFileSync(join(root, marker), "2026-09-09T00:00:00Z\n");
-      const { r, log } = runWrapper(root, stub);
-      assert.equal(r.status, 0, `${marker}: ${r.stderr}`);
-      assert.match(r.stderr, /emergency stop is active/, marker);
-      assert.match(r.stderr, /maestro session start/);
-      assert.ok(!/ARGV:/.test(log), `${marker}: node must not be started`);
-    } finally {
-      rmSync(root, { recursive: true, force: true });
-    }
-  }
-});
-
-test("wrapper exits 127 when no node can be found (candidate list overridden so the branch is deterministic)", () => {
-  const { root } = makeAgent();
-  try {
-    const r = spawnSync("/bin/bash", [join(root, "scripts", "session", "supervisor.sh")], {
-      env: {
-        PATH: "/usr/bin:/bin",
-        HOME: join(root, "nohome"), // no ~/.nvm here either
-        NODE_BIN: "/nonexistent/node",
-        MAESTRO_NODE_CANDIDATES: "/nonexistent/a/node:/nonexistent/b/node",
-      },
-      encoding: "utf8",
-      timeout: 20_000,
-    });
-    assert.equal(r.status, 127, `${r.stdout}\n${r.stderr}`);
-    assert.match(r.stderr, /could not find node/);
-  } finally {
-    rmSync(root, { recursive: true, force: true });
-  }
-});
-
-test("MAESTRO_NODE_CANDIDATES: the first executable candidate wins", () => {
-  const { root, stub } = makeAgent();
-  try {
-    const r = spawnSync("/bin/bash", [join(root, "scripts", "session", "supervisor.sh")], {
-      env: { PATH: "/usr/bin:/bin", HOME: join(root, "nohome"), MAESTRO_NODE_CANDIDATES: `/nonexistent/node:${stub}` },
-      encoding: "utf8",
-      timeout: 20_000,
-    });
-    assert.equal(r.status, 0, r.stderr);
-    const log = readdirSync(join(root, "logs", "session")).map((f) => readFileSync(join(root, "logs", "session", f), "utf8")).join("");
-    assert.match(log, /^ARGV:/m);
-  } finally {
-    rmSync(root, { recursive: true, force: true });
-  }
-});
-
-test("a preset AGENT_ROOT wins over the script's own location (the npm-global copy can serve an agent dir)", () => {
-  const pkg = makeAgent();   // where the wrapper lives (stands in for the global package)
-  const agent = makeAgent(); // the seat
-  try {
-    const r = spawnSync("/bin/bash", [join(pkg.root, "scripts", "session", "supervisor.sh")], {
-      env: { PATH: "/usr/bin:/bin", NODE_BIN: pkg.stub, AGENT_ROOT: agent.root },
-      encoding: "utf8",
-      timeout: 20_000,
-    });
-    assert.equal(r.status, 0, r.stderr);
-    const logDir = join(agent.root, "logs", "session");
-    const log = readdirSync(logDir).map((f) => readFileSync(join(logDir, f), "utf8")).join("");
-    const esc = (x) => x.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
-    assert.match(log, new RegExp(`^AGENT_ROOT=${esc(agent.root)}$`, "m"));
-    assert.match(log, new RegExp(`^ARGV:${esc(join(agent.root, "scripts", "session", "supervisor.mjs"))}$`, "m"));
-    assert.ok(!existsSync(join(pkg.root, "logs")), "nothing is written under the package dir");
-  } finally {
-    rmSync(pkg.root, { recursive: true, force: true });
-    rmSync(agent.root, { recursive: true, force: true });
-  }
-});
-
-test("wrapper refuses (exit 78, EX_CONFIG) when the resolved root is not an agent dir (no config/agent.json)", () => {
-  const { root, stub } = makeAgent();
-  try {
-    rmSync(join(root, "config", "agent.json"));
-    const r = spawnSync("/bin/bash", [join(root, "scripts", "session", "supervisor.sh")], {
-      env: { PATH: "/usr/bin:/bin", NODE_BIN: stub },
-      encoding: "utf8",
-      timeout: 20_000,
-    });
-    assert.equal(r.status, 78, `${r.stdout}\n${r.stderr}`);
-    assert.match(r.stderr, /not an agent directory/);
-    assert.ok(!existsSync(join(root, "logs")), "must not create logs/ or run node in a non-agent dir");
-  } finally {
-    rmSync(root, { recursive: true, force: true });
-  }
-});