@coffeerunhobby/mcp-ha-connect 2.2.1 → 2.3.1

package/tests/bdd/service-calls.spec.ts

@@ -1,144 +0,0 @@
-/**
- * BDD tests for Service Calls
- * Uses vitest-cucumber for Gherkin syntax
- */
-
-import { loadFeature, describeFeature } from '@amiceli/vitest-cucumber';
-import { expect, vi } from 'vitest';
-import { ServiceOperations } from '../../src/haClient/services.js';
-import type { RequestHandler } from '../../src/haClient/request.js';
-import type { ServiceCallResponse } from '../../src/types/index.js';
-
-const feature = await loadFeature('tests/features/service-calls.feature');
-
-describeFeature(feature, ({ Scenario }) => {
-  // Shared test state
-  let mockRequest: RequestHandler;
-  let serviceOps: ServiceOperations;
-  let result: ServiceCallResponse;
-  let lastPostCall: { path: string; data: Record<string, unknown> } | null;
-
-  function setupMocks() {
-    lastPostCall = null;
-
-    mockRequest = {
-      post: vi.fn().mockImplementation(async (path: string, data: Record<string, unknown>) => {
-        lastPostCall = { path, data };
-        return { context: { id: 'ctx-123', parent_id: null, user_id: null } };
-      }),
-    } as unknown as RequestHandler;
-
-    serviceOps = new ServiceOperations(mockRequest);
-  }
-
-  Scenario('Call service with domain and service name', ({ Given, When, Then, And }) => {
-    Given('a Home Assistant connection', () => {
-      setupMocks();
-    });
-
-    When('I call service "light.turn_on"', async () => {
-      result = await serviceOps.callService({
-        domain: 'light',
-        service: 'turn_on',
-      });
-    });
-
-    Then('the service should be called successfully', () => {
-      expect(result).toBeDefined();
-      expect(result.context).toBeDefined();
-    });
-
-    And('the request should go to "/services/light/turn_on"', () => {
-      expect(lastPostCall?.path).toBe('/services/light/turn_on');
-    });
-  });
-
-  Scenario('Call service with target entity', ({ Given, When, Then }) => {
-    Given('a Home Assistant connection', () => {
-      setupMocks();
-    });
-
-    When('I call service "light.turn_on" targeting "light.living_room"', async () => {
-      result = await serviceOps.callService({
-        domain: 'light',
-        service: 'turn_on',
-        target: { entity_id: 'light.living_room' },
-      });
-    });
-
-    Then('the entity_id should be included in the request', () => {
-      expect(lastPostCall?.data.entity_id).toBe('light.living_room');
-    });
-  });
-
-  Scenario('Call service with service data', ({ Given, When, Then }) => {
-    Given('a Home Assistant connection', () => {
-      setupMocks();
-    });
-
-    When('I call service "light.turn_on" with brightness 255', async () => {
-      result = await serviceOps.callService({
-        domain: 'light',
-        service: 'turn_on',
-        target: { entity_id: 'light.living_room' },
-        service_data: { brightness: 255 },
-      });
-    });
-
-    Then('the brightness should be included in the request', () => {
-      expect(lastPostCall?.data.brightness).toBe(255);
-    });
-  });
-
-  Scenario('Call service targeting multiple entities', ({ Given, When, Then }) => {
-    Given('a Home Assistant connection', () => {
-      setupMocks();
-    });
-
-    When('I call service "light.turn_off" targeting multiple entities', async () => {
-      result = await serviceOps.callService({
-        domain: 'light',
-        service: 'turn_off',
-        target: { entity_id: ['light.living_room', 'light.bedroom'] },
-      });
-    });
-
-    Then('all entity IDs should be included in the request', () => {
-      expect(lastPostCall?.data.entity_id).toEqual(['light.living_room', 'light.bedroom']);
-    });
-  });
-
-  Scenario('Call climate service with temperature', ({ Given, When, Then }) => {
-    Given('a Home Assistant connection', () => {
-      setupMocks();
-    });
-
-    When('I call service "climate.set_temperature" with temperature 22', async () => {
-      result = await serviceOps.callService({
-        domain: 'climate',
-        service: 'set_temperature',
-        target: { entity_id: 'climate.living_room' },
-        service_data: { temperature: 22 },
-      });
-    });
-
-    Then('the temperature should be included in the request', () => {
-      expect(lastPostCall?.path).toBe('/services/climate/set_temperature');
-      expect(lastPostCall?.data.temperature).toBe(22);
-    });
-  });
-
-  Scenario('Restart Home Assistant server', ({ Given, When, Then }) => {
-    Given('a Home Assistant connection', () => {
-      setupMocks();
-    });
-
-    When('I call the restart server operation', async () => {
-      await serviceOps.restartServer();
-    });
-
-    Then('the homeassistant.restart service should be called', () => {
-      expect(lastPostCall?.path).toBe('/services/homeassistant/restart');
-    });
-  });
-});

package/tests/bdd/state-retrieval.spec.ts

@@ -1,204 +0,0 @@
-/**
- * BDD tests for State Retrieval
- * Uses vitest-cucumber for Gherkin syntax
- */
-
-import { loadFeature, describeFeature } from '@amiceli/vitest-cucumber';
-import { expect, vi } from 'vitest';
-import { StateOperations } from '../../src/haClient/states.js';
-import type { RequestHandler } from '../../src/haClient/request.js';
-import type { Entity } from '../../src/types/index.js';
-import { ApiError } from '../../src/types/index.js';
-
-const feature = await loadFeature('tests/features/state-retrieval.feature');
-
-describeFeature(feature, ({ Scenario }) => {
-  // Shared test state
-  let mockRequest: RequestHandler;
-  let stateOps: StateOperations;
-  let stateResult: Entity | Entity[] | null;
-  let error: Error | null;
-
-  const mockEntities: Entity[] = [
-    {
-      entity_id: 'light.living_room',
-      state: 'on',
-      attributes: { friendly_name: 'Living Room Light', brightness: 255 },
-      last_changed: '2026-01-08T10:00:00.000Z',
-      last_updated: '2026-01-08T10:00:00.000Z',
-      context: { id: 'ctx-1', parent_id: null, user_id: null },
-    },
-    {
-      entity_id: 'sensor.temperature',
-      state: '22.5',
-      attributes: { friendly_name: 'Temperature', unit_of_measurement: '°C' },
-      last_changed: '2026-01-08T10:00:00.000Z',
-      last_updated: '2026-01-08T10:00:00.000Z',
-      context: { id: 'ctx-2', parent_id: null, user_id: null },
-    },
-    {
-      entity_id: 'binary_sensor.motion',
-      state: 'off',
-      attributes: { friendly_name: 'Motion Sensor', device_class: 'motion' },
-      last_changed: '2026-01-08T09:00:00.000Z',
-      last_updated: '2026-01-08T10:00:00.000Z',
-      context: { id: 'ctx-3', parent_id: null, user_id: null },
-    },
-    {
-      entity_id: 'switch.kitchen',
-      state: 'on',
-      attributes: { friendly_name: 'Kitchen Switch' },
-      last_changed: '2026-01-08T08:00:00.000Z',
-      last_updated: '2026-01-08T10:00:00.000Z',
-      context: { id: 'ctx-4', parent_id: null, user_id: null },
-    },
-  ];
-
-  function setupMocks(entities: Entity[] = mockEntities) {
-    error = null;
-    stateResult = null;
-
-    mockRequest = {
-      get: vi.fn().mockImplementation(async (path: string) => {
-        if (path === '/states') {
-          return entities;
-        }
-        if (path.startsWith('/states/')) {
-          const entityId = path.replace('/states/', '');
-          const entity = entities.find(e => e.entity_id === entityId);
-          if (entity) {
-            return entity;
-          }
-          throw new ApiError('Not found', 404, { path });
-        }
-        return [];
-      }),
-    } as unknown as RequestHandler;
-
-    stateOps = new StateOperations(mockRequest);
-  }
-
-  Scenario('Get all entity states', ({ Given, When, Then, And }) => {
-    Given('a Home Assistant with multiple entities', () => {
-      setupMocks();
-    });
-
-    When('I get all states', async () => {
-      stateResult = await stateOps.getStates();
-    });
-
-    Then('I should receive all entity states', () => {
-      expect(Array.isArray(stateResult)).toBe(true);
-      expect((stateResult as Entity[]).length).toBe(4);
-    });
-
-    And('the states API should be called', () => {
-      expect(mockRequest.get).toHaveBeenCalledWith('/states');
-    });
-  });
-
-  Scenario('Get state of specific entity', ({ Given, When, Then, And }) => {
-    Given('an entity "light.living_room" exists', () => {
-      setupMocks();
-    });
-
-    When('I get the state of "light.living_room"', async () => {
-      stateResult = await stateOps.getState('light.living_room');
-    });
-
-    Then('I should receive the entity state', () => {
-      expect(stateResult).not.toBeNull();
-    });
-
-    And('the state should include entity_id, state, and attributes', () => {
-      const entity = stateResult as Entity;
-      expect(entity.entity_id).toBe('light.living_room');
-      expect(entity.state).toBe('on');
-      expect(entity.attributes).toBeDefined();
-      expect(entity.attributes.friendly_name).toBe('Living Room Light');
-    });
-  });
-
-  Scenario('Get state of non-existent entity', ({ Given, When, Then }) => {
-    Given('an entity does not exist', () => {
-      setupMocks();
-    });
-
-    When('I get the state of "nonexistent.entity"', async () => {
-      stateResult = await stateOps.getState('nonexistent.entity');
-    });
-
-    Then('I should receive null', () => {
-      expect(stateResult).toBeNull();
-    });
-  });
-
-  Scenario('Handle API error gracefully', ({ Given, When, Then }) => {
-    Given('the API returns a 500 error', () => {
-      mockRequest = {
-        get: vi.fn().mockRejectedValue(new ApiError('Server error', 500, { path: '/states/sensor.temperature' })),
-      } as unknown as RequestHandler;
-      stateOps = new StateOperations(mockRequest);
-      error = null;
-    });
-
-    When('I get the state of "sensor.temperature"', async () => {
-      try {
-        stateResult = await stateOps.getState('sensor.temperature');
-      } catch (e) {
-        error = e as Error;
-      }
-    });
-
-    Then('it should throw an API error', () => {
-      expect(error).not.toBeNull();
-      expect(error).toBeInstanceOf(ApiError);
-    });
-  });
-
-  Scenario('Get all sensors', ({ Given, When, Then, And }) => {
-    Given('a Home Assistant with sensors and other entities', () => {
-      setupMocks();
-    });
-
-    When('I get all sensors', async () => {
-      stateResult = await stateOps.getAllSensors();
-    });
-
-    Then('I should only receive sensor and binary_sensor entities', () => {
-      const sensors = stateResult as Entity[];
-      expect(sensors.every(e =>
-        e.entity_id.startsWith('sensor.') || e.entity_id.startsWith('binary_sensor.')
-      )).toBe(true);
-    });
-
-    And('other entity types should be excluded', () => {
-      const sensors = stateResult as Entity[];
-      expect(sensors.some(e => e.entity_id.startsWith('light.'))).toBe(false);
-      expect(sensors.some(e => e.entity_id.startsWith('switch.'))).toBe(false);
-    });
-  });
-
-  Scenario('Get sensors when none exist', ({ Given, When, Then }) => {
-    Given('a Home Assistant with no sensors', () => {
-      setupMocks([
-        {
-          entity_id: 'light.living_room',
-          state: 'on',
-          attributes: { friendly_name: 'Living Room Light' },
-          last_changed: '2026-01-08T10:00:00.000Z',
-          last_updated: '2026-01-08T10:00:00.000Z',
-          context: { id: 'ctx-1', parent_id: null, user_id: null },
-        },
-      ]);
-    });
-
-    When('I get all sensors', async () => {
-      stateResult = await stateOps.getAllSensors();
-    });
-
-    Then('I should receive an empty array', () => {
-      expect(stateResult).toEqual([]);
-    });
-  });
-});

package/tests/bench/hotpaths.bench.ts

@@ -1,68 +0,0 @@
-/**
- * Hot-path benchmarks. Run: `npm run bench`.
- *
- * The server is stateless: EVERY /mcp request builds a fresh McpServer, registers all
- * tools, connects a transport and answers. These benchmarks track that per-request
- * cost plus the other things every request pays for (JWT verify, argument validation),
- * so dependency upgrades (zod, MCP SDK) can be compared against a recorded baseline.
- */
-
-import { bench, describe, vi } from 'vitest';
-import { Client, InMemoryTransport } from '@modelcontextprotocol/client';
-import { createServer } from '../../src/server/common.js';
-import { createJwt, verifyJwt } from '../../src/utils/jwt.js';
-import { controlLightSchema, sendNotificationSchema } from '../../src/tools/common.js';
-import { Role } from '../../src/permissions/index.js';
-
-vi.mock('../../src/utils/logger.js', () => ({
-  logger: { debug: vi.fn(), info: vi.fn(), warn: vi.fn(), error: vi.fn() },
-}));
-
-// Registration never calls the plugin clients; stubs are enough.
-const deps = { haClient: {} as never, omadaClient: {} as never, toolRegistrationMode: 'graph' as const };
-
-describe('per-request server construction (stateless /mcp)', () => {
-  bench('createServer: register all tools', () => {
-    createServer(deps);
-  });
-
-  bench('createServer + filter for a READONLY caller', () => {
-    createServer({ ...deps, callerPermissions: Role.READONLY });
-  });
-
-  bench('full round trip: createServer + connect + tools/list', async () => {
-    const server = createServer(deps);
-    const client = new Client({ name: 'bench', version: '0' });
-    const [a, b] = InMemoryTransport.createLinkedPair();
-    await Promise.all([server.connect(b), client.connect(a)]);
-    await client.listTools();
-    await client.close();
-    await server.close();
-  });
-});
-
-describe('per-request auth', () => {
-  const secret = 'bench-secret-0123456789-0123456789';
-  const token = createJwt({ sub: 'bench', exp: Math.floor(Date.now() / 1000) + 3600 }, secret);
-  bench('verifyJwt (HS256)', () => {
-    verifyJwt(token, secret);
-  });
-});
-
-describe('tool argument validation (zod)', () => {
-  const light = { entity_id: 'light.living_room', action: 'turn_on', brightness_pct: 75, rgb_color: [255, 120, 0] };
-  const notify = {
-    message: 'Front door opened',
-    title: 'Security',
-    target: 'mobile_app_phone',
-    priority: 'high',
-    actions: [{ action: 'ACK', title: 'OK' }],
-    data: { tag: 'door' },
-  };
-  bench('parse controlLight args', () => {
-    controlLightSchema.parse(light);
-  });
-  bench('parse sendNotification args', () => {
-    sendNotificationSchema.parse(notify);
-  });
-});