@codyswann/lisa 4.84.8 → 4.84.10

package/plugins/lisa-wiki-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-wiki",
-  "version": "4.84.8",
+  "version": "4.84.10",
   "description": "LLM Wiki — a distributable, git-native markdown knowledge base for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-wiki-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-wiki",
-  "version": "4.84.8",
+  "version": "4.84.10",
   "description": "LLM Wiki — a distributable, git-native markdown knowledge base for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-wiki-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-wiki",
-  "version": "4.84.8",
+  "version": "4.84.10",
   "description": "LLM Wiki — a distributable, git-native markdown knowledge base for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-wiki-devin/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-wiki",
-  "version": "4.84.8",
+  "version": "4.84.10",
   "description": "LLM Wiki — a distributable, git-native markdown knowledge base for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-wiki-devin/.devin-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-wiki",
-  "version": "4.84.8",
+  "version": "4.84.10",
   "description": "LLM Wiki — a distributable, git-native markdown knowledge base for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/typescript/copy-overwrite/scripts/check-skipped-required-checks.mjs

@@ -2366,8 +2366,9 @@ export function reviewGateState(reading, vocabulary = {}) {
   if (state === "FAILURE" || state === "ERROR") {
     return objectedReviewGateState(state, text, reading.description);
   }
-  if (state === "SKIPPED") {
-    return skippedReviewGateState(
+  if (state === "SKIPPED" || state === "NEUTRAL") {
+    return terminalReviewGateState(
+      state,
       text,
       reading.description,
       vocabulary,
@@ -2386,16 +2387,23 @@ export function reviewGateState(reading, vocabulary = {}) {
 }
 
 /**
- * A terminal skip never proves review, even when its title names completed work.
- * Existing exact waivers retain their policy; all other skips need a trusted
+ * A terminal result alone never proves review, even with a positive title.
+ * Existing exact waivers retain their policy; other terminal results need a trusted
  * head-bound substitute and a clean, readable review surface to permit merging.
+ * @param {string} state - Observed terminal check state
  * @param {string} text - Normalized description
  * @param {string|undefined} description - Original description
  * @param {{waive?: readonly string[]}} vocabulary - Per-check waiver extensions
  * @param {{read: boolean, present: boolean, objected: boolean}|undefined} activity - Independent review surface
  * @returns {{state: string, condition: string, why: string}} Terminal no-review verdict
  */
-function skippedReviewGateState(text, description, vocabulary, activity) {
+function terminalReviewGateState(
+  state,
+  text,
+  description,
+  vocabulary,
+  activity
+) {
   const waivers = [...ENTITLEMENT_WAIVERS, ...(vocabulary.waive ?? [])];
   if (waivers.some(phrase => text === normalizeDescription(phrase))) {
     return waivedReviewGateState(description, activity);
@@ -2403,7 +2411,7 @@ function skippedReviewGateState(text, description, vocabulary, activity) {
   return {
     state: REVIEW_GATE_STATES.unsatisfied,
     condition: REVIEW_GATE_CONDITIONS.notReviewed,
-    why: `reported terminal SKIPPED with the description ${JSON.stringify(description ?? "")}. This check did not complete a review; its title cannot prove otherwise. An existing exact waiver or a trusted substitute for this head is required, and no substitute covers an objection.`,
+    why: `reported terminal ${state} with the description ${JSON.stringify(description ?? "")}. This result does not establish qualifying completed-review proof; its title cannot supply that proof. An existing exact waiver or a trusted substitute for this head is required, and no substitute covers an objection.`,
   };
 }
 
@@ -2527,6 +2535,22 @@ function waivedReviewGateState(description, activity) {
   };
 }
 
+/**
+ * Match explicit waivers exactly, independently of loose no-work detection.
+ *
+ * Shared by raw result decoding and the gate so normalization cannot discard
+ * a supported waiver merely because it is absent from the no-work list.
+ *
+ * @param {string|undefined} description - Original description.
+ * @param {{waive?: readonly string[]}} vocabulary - Per-check extensions.
+ * @returns {boolean} Whether the whole normalized phrase is an explicit waiver.
+ */
+function matchesReviewWaiver(description, vocabulary) {
+  const text = normalizeDescription(description);
+  const waivers = [...ENTITLEMENT_WAIVERS, ...(vocabulary.waive ?? [])];
+  return waivers.some(phrase => text === normalizeDescription(phrase));
+}
+
 /**
  * Classifies a successful check from its exact description vocabulary.
  *
@@ -2545,8 +2569,7 @@ function successfulReviewGateState(text, description, vocabulary, activity) {
       why: `reported ${JSON.stringify(description ?? "")}, which is a review that ran.`,
     };
   }
-  const waivers = [...ENTITLEMENT_WAIVERS, ...(vocabulary.waive ?? [])];
-  if (waivers.some(phrase => text === normalizeDescription(phrase))) {
+  if (matchesReviewWaiver(description, vocabulary)) {
     return waivedReviewGateState(description, activity);
   }
   return {
@@ -3796,7 +3819,15 @@ export function readCarriedReview(declaration, pr, repo, options = {}) {
     declaration,
     listed.map(entry => {
       try {
-        return { ...entry, checks: readChecks(entry.headSha, repo) };
+        return {
+          ...entry,
+          checks: readChecks(
+            entry.headSha,
+            repo,
+            /** @type {{evidence_bearing_checks?: ReviewEvidenceChecks|null}} */
+            (declaration).evidence_bearing_checks ?? {}
+          ),
+        };
       } catch (error) {
         return {
           ...entry,
@@ -3852,10 +3883,11 @@ export function writeVerdictOutputs(verdict, env = process.env) {
  *
  * @param {string|number} pr - Pull request number or URL
  * @param {string} [repo] - `OWNER/NAME`; defaults to the current repository
+ * @param {Record<string, {proof?: readonly string[], no_work?: readonly string[], satisfy?: readonly string[], waive?: readonly string[]}>} [evidenceChecks] - Per-context vocabulary from the declaration
  * @returns {Array<{name: string, state: string, bucket?: string, description?: string}>} The checks
  * @throws {Error} When `gh` is unavailable or its output cannot be parsed
  */
-export function fetchPullRequestChecks(pr, repo) {
+export function fetchPullRequestChecks(pr, repo, evidenceChecks = {}) {
   const args = [
     "pr",
     "checks",
@@ -3876,7 +3908,7 @@ export function fetchPullRequestChecks(pr, repo) {
       // shaped exactly like unreadable content, which never says the word
       // "permission". The commit-status route below needs no `actions` scope
       // and carries the description this arm reads, so try it before refusing.
-      return fetchChecksViaApi(pr, repo, error);
+      return fetchChecksViaApi(pr, repo, error, evidenceChecks);
     }
   }
   try {
@@ -4018,10 +4050,11 @@ function ghApiPaginatedArray(endpoint, query) {
  * @param {string|number} pr - Pull request number
  * @param {string|undefined} repo - `OWNER/NAME`, or undefined to resolve it
  * @param {unknown} cause - The `gh pr checks` failure this is falling back from
+ * @param {Record<string, {proof?: readonly string[], no_work?: readonly string[], satisfy?: readonly string[], waive?: readonly string[]}>} [evidenceChecks] - Per-context vocabulary from the declaration
  * @returns {Array<{name: string, state: string, bucket?: string, description?: string}>} The checks
  * @throws {Error} When the fallback cannot answer either
  */
-export function fetchChecksViaApi(pr, repo, cause) {
+export function fetchChecksViaApi(pr, repo, cause, evidenceChecks = {}) {
   const slug = resolveRepoSlug(repo);
   const why = cause instanceof Error ? cause.message : String(cause ?? "");
   if (slug === undefined) {
@@ -4045,7 +4078,7 @@ export function fetchChecksViaApi(pr, repo, cause) {
       ],
       { encoding: "utf8" }
     ).trim();
-    return fetchChecksForCommit(sha, slug);
+    return fetchChecksForCommit(sha, slug, evidenceChecks);
   } catch (error) {
     throw new Error(
       `check-skipped-required-checks: could not read checks for PR ${pr} in ${slug}. \`gh pr checks\` failed (${why}) — which is what a missing \`actions: read\` looks like, because it resolves the rollup through \`checkSuite.workflowRun\` and exits non-zero with empty output — and the commit-status fallback also failed (${error instanceof Error ? error.message : String(error)}). NOBODY LOOKED at this pull request; that is not the same as nothing being wrong with it.`
@@ -4053,6 +4086,8 @@ export function fetchChecksViaApi(pr, repo, cause) {
   }
 }
 
+/** @typedef {Record<string, {proof?: readonly string[], no_work?: readonly string[], satisfy?: readonly string[], waive?: readonly string[]}>} ReviewEvidenceChecks */
+
 /**
  * Reads the evidence-bearing rows for one exact commit.
  *
@@ -4062,9 +4097,10 @@ export function fetchChecksViaApi(pr, repo, cause) {
  *
  * @param {string} sha - Exact commit whose statuses and check runs to read
  * @param {string|undefined} repo - `OWNER/NAME`, or undefined to resolve it
+ * @param {ReviewEvidenceChecks} [evidenceChecks] - Per-context vocabulary from the declaration
  * @returns {Array<{name: string, state: string, bucket?: string, description?: string}>} The checks
  */
-export function fetchChecksForCommit(sha, repo) {
+export function fetchChecksForCommit(sha, repo, evidenceChecks = {}) {
   const slug = resolveRepoSlug(repo);
   if (slug === undefined) {
     throw new Error(
@@ -4077,18 +4113,76 @@ export function fetchChecksForCommit(sha, repo) {
   );
   const runs = ghApiPaginatedArray(
     `repos/${slug}/commits/${sha}/check-runs?per_page=100`,
-    '[.check_runs[] | {id: .id, name: .name, conclusion: .conclusion, description: (.output.title // ""), completed_at: .completed_at, created_at: .created_at, started_at: .started_at}]'
+    '[.check_runs[] | {id: .id, name: .name, status: .status, conclusion: .conclusion, description: (.output.title // ""), summary: .output.summary, completed_at: .completed_at, created_at: .created_at, started_at: .started_at}]'
   );
   return mergeCheckRows(
     statuses.map(row =>
       normalizeCheckRow(row.name, row.state, row.description)
     ),
     newestCheckRuns(runs).map(row =>
-      normalizeCheckRow(row.name, row.conclusion, row.description)
+      normalizeCheckRow(
+        row.name,
+        /** @type {{status?: string|null}} */ (row).status === "completed"
+          ? row.conclusion
+          : null,
+        checkRunReviewDescription(
+          row,
+          evidenceChecks[/** @type {{name: string}} */ (row).name] ?? {}
+        )
+      )
     )
   );
 }
 
+/**
+ * Decode a selected check run without changing legacy commit-status policy.
+ *
+ * The first physical line owns structured results. Only the supported positive
+ * result from a successful completed run becomes existing semantic proof;
+ * malformed/negative result data cannot inherit a positive title. Absent/plain
+ * summaries keep the existing title contract. Later prose supplies no new proof
+ * or denial. Configured exact waivers and loose no-work notices both retain
+ * their independent policies before any positive result is canonicalized.
+ *
+ * @param {{description?: unknown, summary?: unknown, status?: string|null, conclusion?: string|null}} row - Structured fields on the newest raw check run.
+ * @param {object} vocabulary - This context's configured description vocabulary.
+ * @returns {string} Canonical proof, authoritative result, or legacy title.
+ */
+function checkRunReviewDescription(row, vocabulary) {
+  const title = typeof row.description === "string" ? row.description : "";
+  if (
+    classifyCheckDescription(title, vocabulary) ===
+      DESCRIPTION_VERDICTS.noWork ||
+    matchesReviewWaiver(title, vocabulary)
+  ) {
+    return title;
+  }
+  if (row.summary === null || row.summary === undefined) return title;
+  if (typeof row.summary !== "string") return "Malformed check-run summary";
+  const firstLine = /** @type {string} */ (row.summary.split(/\r?\n/u, 1)[0]);
+  if (
+    classifyCheckDescription(firstLine, vocabulary) ===
+      DESCRIPTION_VERDICTS.noWork ||
+    matchesReviewWaiver(firstLine, vocabulary)
+  ) {
+    return firstLine;
+  }
+  if (
+    row.status === "completed" &&
+    row.conclusion === "success" &&
+    firstLine === "Result: Success - Review completed"
+  ) {
+    return "Review completed";
+  }
+  const resultLooking =
+    /^[\s>#|]*Result\b/iu.test(firstLine) ||
+    /\bResult\s*[:=-]/iu.test(firstLine);
+  if (resultLooking) {
+    return firstLine;
+  }
+  return title;
+}
+
 /**
  * Keep the newest check run for each name across every check suite on a SHA.
  * @param {ReadonlyArray<object>} runs Raw check-run rows with timestamps and ids.
@@ -4251,7 +4345,12 @@ export function fetchSettledChecks(declaration, pr, repo, options = {}) {
           "check-skipped-required-checks: cannot read review evidence without a concrete head commit."
         );
       }
-      return fetchChecksForCommit(headSha, slug);
+      return fetchChecksForCommit(
+        headSha,
+        slug,
+        /** @type {{evidence_bearing_checks?: ReviewEvidenceChecks|null}} */
+        (declaration).evidence_bearing_checks ?? {}
+      );
     });
   const resolveHead = options.headSha ?? resolveHeadSha;
   const clock = options.now ?? Date.now;