@codyswann/lisa 4.81.4 → 4.81.5

package/plugins/src/base/skills/lisa-secrets-access/scripts/validate-config.mjs

@@ -727,6 +727,35 @@ function findCredentials(value, path) {
   );
 }
 
+/**
+ * Validate `sessionManager.operatorIds`: the people the manager works for,
+ * whose assigned items it dispatches first. Matched against the assignee the
+ * way "me" is, so the GitHub entry is a login, not the numeric id
+ * `trustedAuthorIds` takes. An empty list reads as configured but names no
+ * one, so it is refused like an empty `trustedAuthorIds`.
+ * @param {unknown} ids The value, if present.
+ * @returns {string[]} Problems found.
+ */
+function validateOperatorIds(ids) {
+  if (ids === undefined) return [];
+  if (
+    !Array.isArray(ids) ||
+    !ids.every(id => typeof id === "string" && id.trim() !== "")
+  ) {
+    return [
+      `sessionManager.operatorIds must be an array of tracker user ids as ` +
+        `strings, matched against the assignee: the GitHub login, the Jira ` +
+        `accountId or the Linear user id.`,
+    ];
+  }
+  return ids.length === 0
+    ? [
+        `sessionManager.operatorIds must name at least one person. Remove ` +
+          `the key instead if the manager works only for its own identity.`,
+      ]
+    : [];
+}
+
 /**
  * Validate the opt-in `sessionManager` block.
  *
@@ -786,6 +815,7 @@ export function validateSessionManager(block) {
             `if every author's item may be dispatched.`,
         ]
       : []),
+    ...validateOperatorIds(block.operatorIds),
     ...findCredentials(block, "sessionManager"),
   ];
 }

package/plugins/src/base/skills/lisa-session-manager/SKILL.md

@@ -66,7 +66,12 @@ the manager.
   claims go through `lisa-tracker-claim`. Never call a vendor API around them.
 - **"Me".** Resolve once per manager run and store it with `ledger control --me <id>`: GitHub
   `gh api user --jq .login`; Jira the accountId from the `lisa-atlassian-access` identity probe;
-  Linear `viewer.id` through `lisa-linear-access`.
+  Linear `viewer.id` through `lisa-linear-access`. "Me" is whoever the tracker credential belongs
+  to, which is often an agent account.
+- **Operators.** `sessionManager.operatorIds` names the people the manager works for (the same
+  kind of id as "me": GitHub login, Jira accountId, Linear user id). Their assigned items come
+  first, then items assigned to "me", then unassigned. Items assigned to anyone else are never
+  dispatched. Never treat an operator's item as someone else's.
 - **Workers** start only through `spawn`. The worker prompt is exactly
   `/lisa:implement <REF> managedBy=<manager-name>`; `lisa-implement` owns what `managedBy=` means.
   Never start a worker another way, and never reuse a worker for another item or a new attempt.
@@ -207,8 +212,8 @@ Skip while `capacity` reports `paused`. Otherwise:
      Raw Jira issues carry `key` and `fields` (summary, priority, assignee, created, labels,
      description, reporter, issuetype, subtasks); raw Linear nodes carry identifier, title, priority,
      createdAt, assignee, labels, description, creator and children with their state type.
-   - `ordered` is the dispatch order (mine, then unassigned, then priority, then age). `excluded`
-     needs no action.
+   - `ordered` is the dispatch order: assigned to an operator, then to "me", then unassigned; each
+     group by priority, then age. `excluded` needs no action.
 2. **While `capacity` says `can_spawn`** and items remain, take the next item that has no pending
    question in the ledger:
    1. Read it fully (`lisa-tracker-read`): title, description, labels, project, parent, comments.
@@ -223,9 +228,11 @@ Skip while `capacity` reports `paused`. Otherwise:
       `cd "$(node "$SM/session-manager.mjs" repo-dir --repo <key> --raw --project-root "$ROOT")"`
       (omit `--repo` on a single-repo project), invoke `lisa-tracker-claim <ref>`, then
       `cd "$ROOT" && pwd` and confirm the path. Continue only on `claimed` or `reused` with the
-      assignee equal to "me"; anything else means skip. Then re-read the item with
-      `lisa-tracker-read`: if the re-read shows a different assignee, or shows the state did not
-      change to the `claimed` role, skip it (someone else holds it, or the claim did not land).
+      assignee equal to "me" or to one of `sessionManager.operatorIds` (the claim assigns only an
+      unassigned item, so an operator's item keeps the operator); anything else means skip. Then
+      re-read the item with `lisa-tracker-read`: if the re-read shows an assignee that is neither
+      "me" nor an operator, or shows the state did not change to the `claimed` role, skip it
+      (someone else holds it, or the claim did not land).
       Never spawn on the claim's word alone.
    4. **Spawn.** `spawn <ref> [--repo <key>]`.
       - exit 0: post `[<REF>] started in <repo> (<name>)` to Telegram.

package/plugins/src/base/skills/lisa-session-manager/references/runbook-template.md

@@ -18,9 +18,10 @@ session list from `claude agents`; and the project's own Telegram chat.
 
 ## Candidate selection
 
-Leaf items in the `ready` role, ordered: assigned to the operator, then unassigned, then by priority,
-then oldest. Items assigned to someone else, containers, human-held items and (when configured)
-items by untrusted authors are skipped. As many as the machine has capacity for.
+Leaf items in the `ready` role, ordered: assigned to an operator (`sessionManager.operatorIds`),
+then to the manager's own tracker identity, then unassigned; within each, by priority, then oldest.
+Items assigned to someone else, containers, human-held items and (when configured) items by
+untrusted authors are skipped. As many as the machine has capacity for.
 
 ## Scope/bounds
 

package/plugins/src/base/skills/lisa-session-manager/scripts/cli-queue.mjs

@@ -123,9 +123,11 @@ function readEnvelopeQueue(ctx, tracker) {
 }
 
 /**
- * `queue --tracker <github|jira|linear>`: the Ready queue, mine first.
+ * `queue --tracker <github|jira|linear>`: the Ready queue, the operator's
+ * items first (`sessionManager.operatorIds`), then mine, then unassigned.
  * @param {object} ctx - CLI context
- * @returns {Promise<{ json: object }>} `{tracker,me,total,pages,ordered,excluded}`
+ * @returns {Promise<{ json: object }>}
+ *   `{tracker,me,operators,total,pages,ordered,excluded}`
  */
 export async function queue(ctx) {
   const tracker = ctx.values.tracker;
@@ -139,10 +141,14 @@ export async function queue(ctx) {
       ? fetchGithubQueue(ctx, project)
       : readEnvelopeQueue(ctx, tracker);
   const me = ctx.values.me ?? (await readLedger(ctx.root)).control.me ?? null;
+  const operators = config?.operatorIds ?? [];
   const order = orderReadyQueue(items, {
     me,
+    operators,
     trustedAuthorIds: config?.trustedAuthorIds ?? undefined,
     humanNeededLabel: humanNeededLabel(project, tracker),
   });
-  return { json: { tracker, me, total: items.length, pages, ...order } };
+  return {
+    json: { tracker, me, operators, total: items.length, pages, ...order },
+  };
 }

package/plugins/src/base/skills/lisa-session-manager/scripts/cli-runtime.mjs

@@ -126,6 +126,7 @@ function validationView(config) {
     ...config,
     repos: config.repos ?? undefined,
     trustedAuthorIds: config.trustedAuthorIds ?? undefined,
+    operatorIds: config.operatorIds,
   };
 }
 

package/plugins/src/base/skills/lisa-session-manager/scripts/cli-usage.mjs

@@ -111,7 +111,10 @@ Per cycle
   queue --tracker jira|linear --input <file> [--me <id>]
       <file> = {complete:true,pages,items:[raw vendor issues]}; exit 2 unless
       complete is exactly true.
-      Both print {tracker,me,total,pages,ordered,excluded:[{ref,reason}]}.
+      Both print {tracker,me,operators,total,pages,ordered,excluded:[{ref,
+      reason}]}. ordered: items assigned to sessionManager.operatorIds
+      first, then to --me, then unassigned; each group by priority, then age.
+      Items assigned to anyone else are excluded (assigned-to-other).
       --me defaults to the ledger's control.me.
   ledger get [<ref>]
   ledger record-spawn <ref> --worker <name> [--session-id <id>] [--repo <key>]

package/plugins/src/base/skills/lisa-session-manager/scripts/config.mjs

@@ -66,6 +66,7 @@ export const SESSION_MANAGER_DEFAULTS = Object.freeze({
  *   stall: StallBlock,
  *   notify: NotifyBlock,
  *   trustedAuthorIds: string[] | null,
+ *   operatorIds?: string[] | null,
  * }} SessionManagerConfig
  * @typedef {{
  *   name: string,
@@ -120,6 +121,9 @@ export function resolveSessionManagerConfig(globalConfig, localConfig) {
     ...merged,
     repos,
     trustedAuthorIds: merged.trustedAuthorIds ?? null,
+    // Left as declared: absent stays undefined and an explicit null stays null,
+    // so validation can refuse the null instead of reading it as "no operators".
+    operatorIds: merged.operatorIds,
   };
 }
 

package/plugins/src/base/skills/lisa-setup-session-manager/SKILL.md

@@ -54,7 +54,19 @@ writes `$SM`, and pass `--project-root "$ROOT"` (the absolute project root) on e
    bypass-permissions worker; say so plainly. The list holds stable tracker user ids as strings,
    never logins: the GitHub numeric user id (`gh api users/<login> --jq .id`), the Jira
    `accountId`, or the Linear user id. A login matches no one and silently excludes every item.
-4. `node "$SM/session-manager.mjs" validate --project-root "$ROOT"` must print `valid: true`.
+4. Set `sessionManager.operatorIds` to a non-empty **array** holding the operator's own tracker
+   user id, e.g. `"operatorIds": ["<operator-id>"]` (a bare string fails `validate`). Look up the
+   OPERATOR, not the credential: `gh api user` / `viewer.id` return whoever the tracker credential
+   belongs to, which is the agent account in exactly the case this key exists for. The manager dispatches
+   the operator's assigned items first, then items assigned to the tracker credential's identity
+   ("me"), then unassigned ones, and skips items assigned to anyone else. When the tracker
+   credential is not the operator's (an agent or bot account), leaving this unset means the
+   operator's own Ready items are never dispatched; say so plainly. Unlike `trustedAuthorIds`, this
+   is matched against the assignee, exactly and case-sensitively, so use the same kind of id as
+   "me", spelled as the tracker API returns it: the GitHub **login** (`gh api users/<login> --jq
+   .login`), the Jira `accountId`, or the Linear user id (the operator's entry in the team's member
+   list, or `viewer.id` only when the operator runs the lookup with their own credential).
+5. `node "$SM/session-manager.mjs" validate --project-root "$ROOT"` must print `valid: true`.
 
 ## Step 3: Store the bot token