@codyswann/lisa 4.66.0 → 4.66.2

package/plugins/src/expo/skills/expo-router-best-practices/references/static-export-verification.md

@@ -0,0 +1,54 @@
+# Static Export Verification
+
+When `expo export` runs with static output (`output: "static"` in app.json),
+every route must produce an HTML file with the right title and the expected
+initial markup. `expo export` succeeding only proves the bundle built — a
+missing route, a wrong title, or an empty shell all ship green unless the
+exported output itself is checked.
+
+## Enumerate the dynamic routes
+
+Static export prerenders each route it can enumerate. Dynamic segments need
+`generateStaticParams` — an unenumerated `[id]` route produces no page at all.
+After export, enumerate the routes the app *declares* and assert each one has
+a file under `dist/`:
+
+```typescript
+import { existsSync, readdirSync } from "node:fs";
+import path from "node:path";
+
+const DIST = path.resolve("dist");
+
+// The routes the app owns — keep this in sync with app/, or derive it from
+// the route manifest expo-router emits.
+const EXPECTED_ROUTES = ["index", "settings", "players/[id]"];
+
+for (const route of EXPECTED_ROUTES) {
+  const html = path.join(DIST, `${route}.html`);
+  expect(existsSync(html)).toBe(true);
+}
+```
+
+## Per-route titles
+
+`<Stack.Screen options={{ title: "..." }}>` sets the native header title; the
+web `<title>` comes from `Head` (`expo-router/head`). Assert the title the
+exported HTML actually carries:
+
+```typescript
+const html = readFileSync(path.join(DIST, "settings.html"), "utf8");
+expect(html).toMatch(/<title>[^<]*Settings[^<]*<\/title>/);
+```
+
+## Expected initial content
+
+The exported page should ship its prerendered content, not a bare shell —
+that is what makes static export worth shipping at all. Assert a stable marker
+of the route's expected first paint:
+
+```typescript
+expect(html).toContain("Sign in to continue");
+```
+
+Keep the marker to content that exists in the static HTML, never something
+hydration adds later.

package/plugins/src/expo/skills/expo-tailwind-setup/SKILL.md

@@ -478,3 +478,10 @@ Add className to component props:
 ```tsx
 type Props = React.ComponentProps<typeof RNView> & { className?: string };
 ```
+
+The same rule applies at every styling API boundary — `useCssElement`,
+`cssInterop`, or `styled()`: type the wrapped component's props explicitly
+(`React.ComponentProps<typeof X> & { className?: string }`) and pass props
+through, rather than casting to a wider type. A cast compiles over a
+prop-shape drift that an explicit type would refuse — the boundary is where
+the drift is cheapest to catch.

package/plugins/src/expo/skills/playwright-selectors/SKILL.md

@@ -394,6 +394,31 @@ Components from third-party libraries (e.g., `react-native-bouncy-checkbox`, `re
 
 ---
 
+## Reveal-on-Focus Assertions
+
+`toBeVisible()` proves the element exists and is not hidden — it does NOT
+prove the element crossed onto the screen. A focused element scrolled off-view
+still reports visible. For any "focus reveals the element" behavior (skip
+links, focus-trapped modals, scroll-into-view containers), assert on layout,
+not just visibility:
+
+```typescript
+// Rejects when the element has no box at all (display: none, detached).
+const box = await page.getByTestId("dialog:panel").boundingBox();
+expect(box).not.toBeNull();
+
+// Then prove it is actually inside the viewport — the part toBeVisible()
+// cannot say.
+await expect(page.getByTestId("dialog:panel")).toBeInViewport();
+```
+
+Pair them: `boundingBox()` answers "is there a box" (null means never laid
+out), `toBeInViewport()` answers "did it cross onto the screen". An assertion
+that skips the null check reads a missing layout as a viewport miss, which is
+a different bug.
+
+---
+
 ## Implementation Checklist
 
 When adding E2E test coverage to a component:

package/plugins/src/expo/skills/testing-library/references/mocking-patterns.md

@@ -588,3 +588,25 @@ afterAll(() => {
   console.error = originalError;
 });
 ```
+
+## Migrating jest.mock Usage
+
+When moving a test file onto the managed setup, scope the migration to the
+file under your hand — a suite-wide mock sweep is where subtle behavior
+changes hide.
+
+- **Prefer renderer-compatible mocks.** A mock that works in the Node
+  environment but reads `window`, native modules, or ESM-only entry points
+  fails under the jsdom/renderer the Expo preset provides. Mock the seam your
+  component actually imports (`jest.mock("nativewind", ...)`,
+  `jest.mock("@/lib/env", ...)`) — never reach around it to mock a transitive
+  dependency.
+- **Keep factories stable and hoisted.** Jest hoists `jest.mock` calls above
+  imports, so a factory cannot close over outer variables. Everything the
+  factory needs must come from `jest.requireActual`, `jest.requireMock`, or a
+  `mock`-prefixed name. A factory that silently returns a different shape per
+  run is the migration failure that surfaces as unrelated flakes.
+- **Check version compatibility, not history.** A pinned workaround for an
+  old jest-expo/Expo SDK issue is not a permanent blocker — verify whether the
+  current versions still need it before carrying it forward. Historical Expo
+  issues expire; copy them forward only when they reproduce.

package/typescript/copy-contents/.husky/commit-msg

@@ -143,20 +143,112 @@ fi
 
 echo "🤖 Checking for AI co-authorship..."
 
-# Accept attribution from any supported coding agent (Claude or Codex),
-# case-insensitively. Claude Code emits "Co-Authored-By: Claude"; the Codex CLI
-# emits "Co-authored-by: Codex <noreply@openai.com>".
-if ! printf '%s\n' "$COMMIT_MSG" | grep -Eiq "Co-authored-by:.*(Claude|Codex)"; then
+# Fleet agents — the runtimes Lisa ships plugin distributions for — pass on
+# the trailer alone. Any other named agent (e.g. Devin) must also carry
+# AI-Agent/AI-Model/AI-Effort trailers: the gate enforces attribution, not
+# agent gatekeeping, so an agent Lisa does not distribute to can still commit
+# truthfully instead of forcing --no-verify. CodySwannGT/lisa#4282.
+LISA_FLEET_AGENT_RE="Claude|Codex|Cursor|OpenCode|Antigravity|Copilot"
+# Co-authors come from the message's trailer block via git-interpret-trailers —
+# a "Co-authored-by:" string inside prose is not attribution — and every entry
+# is judged on its own, so a fleet trailer can never cover a sibling trailer
+# whose agent owes metadata.
+COAUTHOR_TRAILERS=$(git interpret-trailers --parse "$COMMIT_MSG_FILE" 2>/dev/null | grep -iE "^Co-authored-by:" || true)
+
+if ! printf '%s\n' "$COAUTHOR_TRAILERS" | grep -Eiq "Co-authored-by:"; then
+  no_coauthor=1
+else
+  no_coauthor=0
+fi
+
+nonfleet_coauthor=0
+if [ "$no_coauthor" -eq 0 ]; then
+  while IFS= read -r trailer; do
+    [ -z "$trailer" ] && continue
+    agent_name=$(printf '%s' "${trailer#*:}" | sed -e 's/<[^>]*>//g' -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//')
+    if ! printf '%s\n' "$agent_name" | grep -Eiq "^(${LISA_FLEET_AGENT_RE})([[:space:]]|$)"; then
+      nonfleet_coauthor=1
+    fi
+  done <<LISA_COAUTHOR_TRAILERS
+$COAUTHOR_TRAILERS
+LISA_COAUTHOR_TRAILERS
+fi
+
+if [ "$nonfleet_coauthor" -eq 1 ]; then
+  missing_agent_metadata=0
+  for trailer in AI-Agent AI-Model AI-Effort; do
+    if ! printf '%s\n' "$COMMIT_MSG" | grep -Eiq "^${trailer}:[[:space:]]*[^[:space:]]"; then
+      missing_agent_metadata=1
+    fi
+  done
+  if [ "$missing_agent_metadata" -eq 1 ]; then
+    echo ""
+    echo "❌ Non-fleet agents must include AI metadata trailers!"
+    echo ""
+    echo "Agents outside the supported fleet (Claude, Codex, Cursor, OpenCode,"
+    echo "Antigravity, Copilot) must carry provenance metadata alongside the"
+    echo "Co-authored-by trailer:"
+    echo "  AI-Agent: <agent name>"
+    echo "  AI-Model: <provider/model>"
+    echo "  AI-Effort: <effort or runtime value>"
+    echo ""
+    lisa_commit_gate_families ai-coauthorship
+    exit 1
+  fi
+elif [ "$no_coauthor" -eq 1 ]; then
   echo ""
   echo "❌ Commit message must include AI co-authorship!"
   echo ""
-  echo "All commits must include a Co-authored-by line for a coding agent (Claude or Codex)."
+  echo "All commits must include a Co-authored-by line for a supported coding agent."
+  echo ""
+  echo "Expected one of these trailers:"
+  echo "  Co-authored-by: Claude <noreply@anthropic.com>"
+  echo "  Co-authored-by: Codex <codex@openai.com>"
+  echo "  Co-authored-by: Cursor <noreply@cursor.com>"
+  echo "  Co-authored-by: OpenCode <noreply@opencode.ai>"
+  echo "  Co-authored-by: Antigravity <noreply@google.com>"
+  echo "  Co-authored-by: Copilot <noreply@github.com>"
+  echo ""
+  echo "OpenCode commits must also include:"
+  echo "  AI-Agent: OpenCode"
+  echo "  AI-Model: <provider/model>"
+  echo "  AI-Effort: <effort or runtime value>"
+  echo ""
+  echo "Agents outside the supported fleet (e.g. Devin) may commit by supplying"
+  echo "the same AI-Agent/AI-Model/AI-Effort trailers with their own agent name."
   echo ""
   echo "If you're using Claude Code, use the /git:commit command"
   echo "If you're using Codex, enable commit_attribution in .codex/config.toml"
+  echo "If you're using OpenCode, include the OpenCode trailer and AI-* metadata"
   echo ""
   lisa_commit_gate_families ai-coauthorship
   exit 1
 fi
 
+if printf '%s\n' "$COAUTHOR_TRAILERS" | grep -Eiq "Co-authored-by:.*OpenCode"; then
+  missing_opencode_metadata=0
+  if ! printf '%s\n' "$COMMIT_MSG" | grep -Eiq "^AI-Agent:[[:space:]]*OpenCode[[:space:]]*$"; then
+    missing_opencode_metadata=1
+  fi
+  if ! printf '%s\n' "$COMMIT_MSG" | grep -Eiq "^AI-Model:[[:space:]]*[^[:space:]].*$"; then
+    missing_opencode_metadata=1
+  fi
+  if ! printf '%s\n' "$COMMIT_MSG" | grep -Eiq "^AI-Effort:[[:space:]]*[^[:space:]].*$"; then
+    missing_opencode_metadata=1
+  fi
+
+  if [ "$missing_opencode_metadata" -eq 1 ]; then
+    echo ""
+    echo "❌ OpenCode commits must include AI metadata trailers!"
+    echo ""
+    echo "Expected trailers:"
+    echo "  AI-Agent: OpenCode"
+    echo "  AI-Model: <provider/model>"
+    echo "  AI-Effort: <effort or runtime value>"
+    echo ""
+    lisa_commit_gate_families ai-coauthorship
+    exit 1
+  fi
+fi
+
 # END: AI GUARDRAILS