@codyswann/lisa 4.65.8 → 4.66.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/all/copy-overwrite/scripts/lisa-hooks/worktree-binding-guard.mjs +34 -10
- package/dist/core/lisa-owned-hash-ledger.d.ts.map +1 -1
- package/dist/core/lisa-owned-hash-ledger.js +8 -0
- package/dist/core/lisa-owned-hash-ledger.js.map +1 -1
- package/dist/core/nightly-e2e-guard-behavior-certificate.js +2 -2
- package/dist/core/upstream-evidence-manifest.d.ts.map +1 -1
- package/dist/core/upstream-evidence-manifest.js +16 -7
- package/dist/core/upstream-evidence-manifest.js.map +1 -1
- package/expo/create-only/.github/workflows/maestro-e2e.yml +6 -0
- package/package.json +4 -4
- package/plugins/lisa/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa/hooks/worktree-binding-guard.mjs +34 -10
- package/plugins/lisa-agy/plugin.json +1 -1
- package/plugins/lisa-cdk/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-agy/plugin.json +1 -1
- package/plugins/lisa-cdk-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/hooks/worktree-binding-guard.mjs +34 -10
- package/plugins/lisa-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cursor/hooks/worktree-binding-guard.mjs +34 -10
- package/plugins/lisa-expo/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-expo/.codex-plugin/skills/expo-router-best-practices/SKILL.md +1 -0
- package/plugins/lisa-expo/.codex-plugin/skills/expo-router-best-practices/references/static-export-verification.md +54 -0
- package/plugins/lisa-expo/.codex-plugin/skills/expo-tailwind-setup/SKILL.md +7 -0
- package/plugins/lisa-expo/.codex-plugin/skills/playwright-selectors/SKILL.md +25 -0
- package/plugins/lisa-expo/.codex-plugin/skills/testing-library/references/mocking-patterns.md +22 -0
- package/plugins/lisa-expo/skills/expo-router-best-practices/SKILL.md +1 -0
- package/plugins/lisa-expo/skills/expo-router-best-practices/references/static-export-verification.md +54 -0
- package/plugins/lisa-expo/skills/expo-tailwind-setup/SKILL.md +7 -0
- package/plugins/lisa-expo/skills/playwright-selectors/SKILL.md +25 -0
- package/plugins/lisa-expo/skills/testing-library/references/mocking-patterns.md +22 -0
- package/plugins/lisa-expo-agy/plugin.json +1 -1
- package/plugins/lisa-expo-agy/skills/expo-router-best-practices/SKILL.md +1 -0
- package/plugins/lisa-expo-agy/skills/expo-router-best-practices/references/static-export-verification.md +54 -0
- package/plugins/lisa-expo-agy/skills/expo-tailwind-setup/SKILL.md +7 -0
- package/plugins/lisa-expo-agy/skills/playwright-selectors/SKILL.md +25 -0
- package/plugins/lisa-expo-agy/skills/testing-library/references/mocking-patterns.md +22 -0
- package/plugins/lisa-expo-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-copilot/skills/expo-router-best-practices/SKILL.md +1 -0
- package/plugins/lisa-expo-copilot/skills/expo-router-best-practices/references/static-export-verification.md +54 -0
- package/plugins/lisa-expo-copilot/skills/expo-tailwind-setup/SKILL.md +7 -0
- package/plugins/lisa-expo-copilot/skills/playwright-selectors/SKILL.md +25 -0
- package/plugins/lisa-expo-copilot/skills/testing-library/references/mocking-patterns.md +22 -0
- package/plugins/lisa-expo-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-cursor/skills/expo-router-best-practices/SKILL.md +1 -0
- package/plugins/lisa-expo-cursor/skills/expo-router-best-practices/references/static-export-verification.md +54 -0
- package/plugins/lisa-expo-cursor/skills/expo-tailwind-setup/SKILL.md +7 -0
- package/plugins/lisa-expo-cursor/skills/playwright-selectors/SKILL.md +25 -0
- package/plugins/lisa-expo-cursor/skills/testing-library/references/mocking-patterns.md +22 -0
- package/plugins/lisa-harper-fabric/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-agy/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-agy/plugin.json +1 -1
- package/plugins/lisa-nestjs-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-agy/plugin.json +1 -1
- package/plugins/lisa-openclaw-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-agy/plugin.json +1 -1
- package/plugins/lisa-phaser-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-agy/plugin.json +1 -1
- package/plugins/lisa-rails-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-agy/plugin.json +1 -1
- package/plugins/lisa-typescript-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-agy/plugin.json +1 -1
- package/plugins/lisa-wiki-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/src/base/hooks/worktree-binding-guard.mjs +34 -10
- package/plugins/src/expo/skills/expo-router-best-practices/SKILL.md +1 -0
- package/plugins/src/expo/skills/expo-router-best-practices/references/static-export-verification.md +54 -0
- package/plugins/src/expo/skills/expo-tailwind-setup/SKILL.md +7 -0
- package/plugins/src/expo/skills/playwright-selectors/SKILL.md +25 -0
- package/plugins/src/expo/skills/testing-library/references/mocking-patterns.md +22 -0
|
@@ -112,6 +112,12 @@ jobs:
|
|
|
112
112
|
# MAESTRO_TEST_PHONE=0000000000
|
|
113
113
|
# MAESTRO_TEST_OTP=555555
|
|
114
114
|
#
|
|
115
|
+
# MAESTRO_RUN_ID namespaces the throwaway accounts and uploads a run
|
|
116
|
+
# mints (convention: tester+<runId><ordinal>) so a sweep can delete
|
|
117
|
+
# exactly one run's state. It defaults to the run's own id; uncomment to
|
|
118
|
+
# pin a shared namespace across invocations you will sweep together.
|
|
119
|
+
# run_id: 'my-sweep-namespace'
|
|
120
|
+
#
|
|
115
121
|
# Once per run, before either platform starts — resets, sweeps, seeding.
|
|
116
122
|
# pre_suite_command: |
|
|
117
123
|
# node scripts/maestro/prune-e2e-fixtures.mjs
|
package/package.json
CHANGED
|
@@ -187,7 +187,7 @@
|
|
|
187
187
|
"zod-validation-error": "^4.0.0"
|
|
188
188
|
},
|
|
189
189
|
"name": "@codyswann/lisa",
|
|
190
|
-
"version": "4.
|
|
190
|
+
"version": "4.66.1",
|
|
191
191
|
"description": "Claude Code governance framework that applies guardrails, guidance, and automated enforcement to projects",
|
|
192
192
|
"main": "dist/index.js",
|
|
193
193
|
"exports": {
|
|
@@ -336,7 +336,7 @@
|
|
|
336
336
|
"test": "tests"
|
|
337
337
|
},
|
|
338
338
|
"types": "./dist/index.d.ts",
|
|
339
|
-
"lisaReleaseCommit": "
|
|
340
|
-
"gitHead": "
|
|
341
|
-
"lisaReleaseTag": "v4.
|
|
339
|
+
"lisaReleaseCommit": "0979337762941f8b34642797540d18c946e739bf",
|
|
340
|
+
"gitHead": "0979337762941f8b34642797540d18c946e739bf",
|
|
341
|
+
"lisaReleaseTag": "v4.66.1"
|
|
342
342
|
}
|
|
@@ -506,9 +506,32 @@ function reachesOut(script, foreign, bound) {
|
|
|
506
506
|
]);
|
|
507
507
|
}
|
|
508
508
|
|
|
509
|
-
function stateFile(
|
|
509
|
+
function stateFile(bindingKey) {
|
|
510
510
|
const home = process.env.LISA_STATE_HOME || join(homedir(), ".lisa");
|
|
511
|
-
return join(home, "worktree-binding", `${
|
|
511
|
+
return join(home, "worktree-binding", `${bindingKey}.json`);
|
|
512
|
+
}
|
|
513
|
+
|
|
514
|
+
/**
|
|
515
|
+
* The identity a binding belongs to.
|
|
516
|
+
*
|
|
517
|
+
* Parallel subagents share the session's `session_id`, so keying the binding
|
|
518
|
+
* on it alone made each subagent's guarded call read the binding a sibling
|
|
519
|
+
* recorded — the sibling's worktree then read as "changed underneath it" and
|
|
520
|
+
* its writes were refused, or an acknowledgement rebound the file out from
|
|
521
|
+
* under the sibling (CodySwannGT/lisa#4277). The payload's `agent_id` is what
|
|
522
|
+
* distinguishes a subagent from the main agent, so a caller carrying one gets
|
|
523
|
+
* its own state file. The main agent carries no `agent_id` and keeps the
|
|
524
|
+
* session-scoped key it always had, which is also the fallback for runtimes
|
|
525
|
+
* that never send the field.
|
|
526
|
+
*
|
|
527
|
+
* The key lands in a filename, so the composite is folded into a set that is
|
|
528
|
+
* legal on every filesystem — `:` is not, which rules it out as a separator
|
|
529
|
+
* and as tolerated session_id content on Windows hosts.
|
|
530
|
+
*/
|
|
531
|
+
function bindingKey(payload) {
|
|
532
|
+
const agent = payload?.agent_id;
|
|
533
|
+
if (typeof agent !== "string" || !agent) return payload.session_id;
|
|
534
|
+
return `${payload.session_id}--${agent}`.replaceAll(/[^A-Za-z0-9._-]/g, "_");
|
|
512
535
|
}
|
|
513
536
|
|
|
514
537
|
function readState(sessionId) {
|
|
@@ -640,8 +663,8 @@ function recordBaseline(sessionId, observed) {
|
|
|
640
663
|
function recordClaim(payload, observed) {
|
|
641
664
|
const claimed = claimedRoot(payload.tool_input, payload.cwd);
|
|
642
665
|
if (!claimed || claimed === observed) return;
|
|
643
|
-
const previous = readState(payload
|
|
644
|
-
writeState(payload
|
|
666
|
+
const previous = readState(bindingKey(payload));
|
|
667
|
+
writeState(bindingKey(payload), {
|
|
645
668
|
boundRoot: previous?.boundRoot ?? observed,
|
|
646
669
|
claimedRoot: claimed,
|
|
647
670
|
updatedAt: new Date().toISOString(),
|
|
@@ -681,7 +704,7 @@ function handleAcceptance(payload, observed) {
|
|
|
681
704
|
acceptanceLine(observed),
|
|
682
705
|
]);
|
|
683
706
|
}
|
|
684
|
-
writeState(payload
|
|
707
|
+
writeState(bindingKey(payload), {
|
|
685
708
|
boundRoot: observed,
|
|
686
709
|
claimedRoot: null,
|
|
687
710
|
updatedAt: new Date().toISOString(),
|
|
@@ -883,15 +906,16 @@ function evaluate(payload) {
|
|
|
883
906
|
say("payload carries no session id or cwd; binding is NOT enforced");
|
|
884
907
|
return 0;
|
|
885
908
|
}
|
|
909
|
+
const binding = bindingKey(payload);
|
|
886
910
|
const observed = worktreeRoot(cwd);
|
|
887
911
|
if (!observed) return 0;
|
|
888
912
|
|
|
889
913
|
if (payload.hook_event_name === "SessionStart") {
|
|
890
|
-
recordBaseline(
|
|
914
|
+
recordBaseline(binding, observed);
|
|
891
915
|
// After the baseline, never before: `recordBaseline` writes a fresh state
|
|
892
916
|
// for a session it has not seen, and the notice's record has to go on top
|
|
893
917
|
// of that write rather than under it.
|
|
894
|
-
noticeRuntimeDrift(
|
|
918
|
+
noticeRuntimeDrift(binding, process.env);
|
|
895
919
|
return 0;
|
|
896
920
|
}
|
|
897
921
|
if (payload.tool_name === "EnterWorktree") {
|
|
@@ -903,7 +927,7 @@ function evaluate(payload) {
|
|
|
903
927
|
const accepted = handleAcceptance(payload, observed);
|
|
904
928
|
if (accepted !== null) return accepted;
|
|
905
929
|
|
|
906
|
-
const state = readState(
|
|
930
|
+
const state = readState(binding);
|
|
907
931
|
if (!state?.boundRoot) {
|
|
908
932
|
// No baseline means SessionStart did not run for this session — an older
|
|
909
933
|
// install, a runtime that fires no such event, a harness that skips it.
|
|
@@ -912,7 +936,7 @@ function evaluate(payload) {
|
|
|
912
936
|
// refusing. Treating it as a refusal would turn a floor into a wall on
|
|
913
937
|
// every surface where the event does not fire, and a wall gets switched
|
|
914
938
|
// off, which costs the whole guard.
|
|
915
|
-
writeState(
|
|
939
|
+
writeState(binding, {
|
|
916
940
|
boundRoot: observed,
|
|
917
941
|
claimedRoot: null,
|
|
918
942
|
updatedAt: new Date().toISOString(),
|
|
@@ -923,7 +947,7 @@ function evaluate(payload) {
|
|
|
923
947
|
return unconfirmedSwitch(state.claimedRoot, observed);
|
|
924
948
|
}
|
|
925
949
|
if (state.claimedRoot === observed) {
|
|
926
|
-
writeState(
|
|
950
|
+
writeState(binding, {
|
|
927
951
|
boundRoot: observed,
|
|
928
952
|
claimedRoot: null,
|
|
929
953
|
updatedAt: new Date().toISOString(),
|
|
@@ -506,9 +506,32 @@ function reachesOut(script, foreign, bound) {
|
|
|
506
506
|
]);
|
|
507
507
|
}
|
|
508
508
|
|
|
509
|
-
function stateFile(
|
|
509
|
+
function stateFile(bindingKey) {
|
|
510
510
|
const home = process.env.LISA_STATE_HOME || join(homedir(), ".lisa");
|
|
511
|
-
return join(home, "worktree-binding", `${
|
|
511
|
+
return join(home, "worktree-binding", `${bindingKey}.json`);
|
|
512
|
+
}
|
|
513
|
+
|
|
514
|
+
/**
|
|
515
|
+
* The identity a binding belongs to.
|
|
516
|
+
*
|
|
517
|
+
* Parallel subagents share the session's `session_id`, so keying the binding
|
|
518
|
+
* on it alone made each subagent's guarded call read the binding a sibling
|
|
519
|
+
* recorded — the sibling's worktree then read as "changed underneath it" and
|
|
520
|
+
* its writes were refused, or an acknowledgement rebound the file out from
|
|
521
|
+
* under the sibling (CodySwannGT/lisa#4277). The payload's `agent_id` is what
|
|
522
|
+
* distinguishes a subagent from the main agent, so a caller carrying one gets
|
|
523
|
+
* its own state file. The main agent carries no `agent_id` and keeps the
|
|
524
|
+
* session-scoped key it always had, which is also the fallback for runtimes
|
|
525
|
+
* that never send the field.
|
|
526
|
+
*
|
|
527
|
+
* The key lands in a filename, so the composite is folded into a set that is
|
|
528
|
+
* legal on every filesystem — `:` is not, which rules it out as a separator
|
|
529
|
+
* and as tolerated session_id content on Windows hosts.
|
|
530
|
+
*/
|
|
531
|
+
function bindingKey(payload) {
|
|
532
|
+
const agent = payload?.agent_id;
|
|
533
|
+
if (typeof agent !== "string" || !agent) return payload.session_id;
|
|
534
|
+
return `${payload.session_id}--${agent}`.replaceAll(/[^A-Za-z0-9._-]/g, "_");
|
|
512
535
|
}
|
|
513
536
|
|
|
514
537
|
function readState(sessionId) {
|
|
@@ -640,8 +663,8 @@ function recordBaseline(sessionId, observed) {
|
|
|
640
663
|
function recordClaim(payload, observed) {
|
|
641
664
|
const claimed = claimedRoot(payload.tool_input, payload.cwd);
|
|
642
665
|
if (!claimed || claimed === observed) return;
|
|
643
|
-
const previous = readState(payload
|
|
644
|
-
writeState(payload
|
|
666
|
+
const previous = readState(bindingKey(payload));
|
|
667
|
+
writeState(bindingKey(payload), {
|
|
645
668
|
boundRoot: previous?.boundRoot ?? observed,
|
|
646
669
|
claimedRoot: claimed,
|
|
647
670
|
updatedAt: new Date().toISOString(),
|
|
@@ -681,7 +704,7 @@ function handleAcceptance(payload, observed) {
|
|
|
681
704
|
acceptanceLine(observed),
|
|
682
705
|
]);
|
|
683
706
|
}
|
|
684
|
-
writeState(payload
|
|
707
|
+
writeState(bindingKey(payload), {
|
|
685
708
|
boundRoot: observed,
|
|
686
709
|
claimedRoot: null,
|
|
687
710
|
updatedAt: new Date().toISOString(),
|
|
@@ -883,15 +906,16 @@ function evaluate(payload) {
|
|
|
883
906
|
say("payload carries no session id or cwd; binding is NOT enforced");
|
|
884
907
|
return 0;
|
|
885
908
|
}
|
|
909
|
+
const binding = bindingKey(payload);
|
|
886
910
|
const observed = worktreeRoot(cwd);
|
|
887
911
|
if (!observed) return 0;
|
|
888
912
|
|
|
889
913
|
if (payload.hook_event_name === "SessionStart") {
|
|
890
|
-
recordBaseline(
|
|
914
|
+
recordBaseline(binding, observed);
|
|
891
915
|
// After the baseline, never before: `recordBaseline` writes a fresh state
|
|
892
916
|
// for a session it has not seen, and the notice's record has to go on top
|
|
893
917
|
// of that write rather than under it.
|
|
894
|
-
noticeRuntimeDrift(
|
|
918
|
+
noticeRuntimeDrift(binding, process.env);
|
|
895
919
|
return 0;
|
|
896
920
|
}
|
|
897
921
|
if (payload.tool_name === "EnterWorktree") {
|
|
@@ -903,7 +927,7 @@ function evaluate(payload) {
|
|
|
903
927
|
const accepted = handleAcceptance(payload, observed);
|
|
904
928
|
if (accepted !== null) return accepted;
|
|
905
929
|
|
|
906
|
-
const state = readState(
|
|
930
|
+
const state = readState(binding);
|
|
907
931
|
if (!state?.boundRoot) {
|
|
908
932
|
// No baseline means SessionStart did not run for this session — an older
|
|
909
933
|
// install, a runtime that fires no such event, a harness that skips it.
|
|
@@ -912,7 +936,7 @@ function evaluate(payload) {
|
|
|
912
936
|
// refusing. Treating it as a refusal would turn a floor into a wall on
|
|
913
937
|
// every surface where the event does not fire, and a wall gets switched
|
|
914
938
|
// off, which costs the whole guard.
|
|
915
|
-
writeState(
|
|
939
|
+
writeState(binding, {
|
|
916
940
|
boundRoot: observed,
|
|
917
941
|
claimedRoot: null,
|
|
918
942
|
updatedAt: new Date().toISOString(),
|
|
@@ -923,7 +947,7 @@ function evaluate(payload) {
|
|
|
923
947
|
return unconfirmedSwitch(state.claimedRoot, observed);
|
|
924
948
|
}
|
|
925
949
|
if (state.claimedRoot === observed) {
|
|
926
|
-
writeState(
|
|
950
|
+
writeState(binding, {
|
|
927
951
|
boundRoot: observed,
|
|
928
952
|
claimedRoot: null,
|
|
929
953
|
updatedAt: new Date().toISOString(),
|
|
@@ -506,9 +506,32 @@ function reachesOut(script, foreign, bound) {
|
|
|
506
506
|
]);
|
|
507
507
|
}
|
|
508
508
|
|
|
509
|
-
function stateFile(
|
|
509
|
+
function stateFile(bindingKey) {
|
|
510
510
|
const home = process.env.LISA_STATE_HOME || join(homedir(), ".lisa");
|
|
511
|
-
return join(home, "worktree-binding", `${
|
|
511
|
+
return join(home, "worktree-binding", `${bindingKey}.json`);
|
|
512
|
+
}
|
|
513
|
+
|
|
514
|
+
/**
|
|
515
|
+
* The identity a binding belongs to.
|
|
516
|
+
*
|
|
517
|
+
* Parallel subagents share the session's `session_id`, so keying the binding
|
|
518
|
+
* on it alone made each subagent's guarded call read the binding a sibling
|
|
519
|
+
* recorded — the sibling's worktree then read as "changed underneath it" and
|
|
520
|
+
* its writes were refused, or an acknowledgement rebound the file out from
|
|
521
|
+
* under the sibling (CodySwannGT/lisa#4277). The payload's `agent_id` is what
|
|
522
|
+
* distinguishes a subagent from the main agent, so a caller carrying one gets
|
|
523
|
+
* its own state file. The main agent carries no `agent_id` and keeps the
|
|
524
|
+
* session-scoped key it always had, which is also the fallback for runtimes
|
|
525
|
+
* that never send the field.
|
|
526
|
+
*
|
|
527
|
+
* The key lands in a filename, so the composite is folded into a set that is
|
|
528
|
+
* legal on every filesystem — `:` is not, which rules it out as a separator
|
|
529
|
+
* and as tolerated session_id content on Windows hosts.
|
|
530
|
+
*/
|
|
531
|
+
function bindingKey(payload) {
|
|
532
|
+
const agent = payload?.agent_id;
|
|
533
|
+
if (typeof agent !== "string" || !agent) return payload.session_id;
|
|
534
|
+
return `${payload.session_id}--${agent}`.replaceAll(/[^A-Za-z0-9._-]/g, "_");
|
|
512
535
|
}
|
|
513
536
|
|
|
514
537
|
function readState(sessionId) {
|
|
@@ -640,8 +663,8 @@ function recordBaseline(sessionId, observed) {
|
|
|
640
663
|
function recordClaim(payload, observed) {
|
|
641
664
|
const claimed = claimedRoot(payload.tool_input, payload.cwd);
|
|
642
665
|
if (!claimed || claimed === observed) return;
|
|
643
|
-
const previous = readState(payload
|
|
644
|
-
writeState(payload
|
|
666
|
+
const previous = readState(bindingKey(payload));
|
|
667
|
+
writeState(bindingKey(payload), {
|
|
645
668
|
boundRoot: previous?.boundRoot ?? observed,
|
|
646
669
|
claimedRoot: claimed,
|
|
647
670
|
updatedAt: new Date().toISOString(),
|
|
@@ -681,7 +704,7 @@ function handleAcceptance(payload, observed) {
|
|
|
681
704
|
acceptanceLine(observed),
|
|
682
705
|
]);
|
|
683
706
|
}
|
|
684
|
-
writeState(payload
|
|
707
|
+
writeState(bindingKey(payload), {
|
|
685
708
|
boundRoot: observed,
|
|
686
709
|
claimedRoot: null,
|
|
687
710
|
updatedAt: new Date().toISOString(),
|
|
@@ -883,15 +906,16 @@ function evaluate(payload) {
|
|
|
883
906
|
say("payload carries no session id or cwd; binding is NOT enforced");
|
|
884
907
|
return 0;
|
|
885
908
|
}
|
|
909
|
+
const binding = bindingKey(payload);
|
|
886
910
|
const observed = worktreeRoot(cwd);
|
|
887
911
|
if (!observed) return 0;
|
|
888
912
|
|
|
889
913
|
if (payload.hook_event_name === "SessionStart") {
|
|
890
|
-
recordBaseline(
|
|
914
|
+
recordBaseline(binding, observed);
|
|
891
915
|
// After the baseline, never before: `recordBaseline` writes a fresh state
|
|
892
916
|
// for a session it has not seen, and the notice's record has to go on top
|
|
893
917
|
// of that write rather than under it.
|
|
894
|
-
noticeRuntimeDrift(
|
|
918
|
+
noticeRuntimeDrift(binding, process.env);
|
|
895
919
|
return 0;
|
|
896
920
|
}
|
|
897
921
|
if (payload.tool_name === "EnterWorktree") {
|
|
@@ -903,7 +927,7 @@ function evaluate(payload) {
|
|
|
903
927
|
const accepted = handleAcceptance(payload, observed);
|
|
904
928
|
if (accepted !== null) return accepted;
|
|
905
929
|
|
|
906
|
-
const state = readState(
|
|
930
|
+
const state = readState(binding);
|
|
907
931
|
if (!state?.boundRoot) {
|
|
908
932
|
// No baseline means SessionStart did not run for this session — an older
|
|
909
933
|
// install, a runtime that fires no such event, a harness that skips it.
|
|
@@ -912,7 +936,7 @@ function evaluate(payload) {
|
|
|
912
936
|
// refusing. Treating it as a refusal would turn a floor into a wall on
|
|
913
937
|
// every surface where the event does not fire, and a wall gets switched
|
|
914
938
|
// off, which costs the whole guard.
|
|
915
|
-
writeState(
|
|
939
|
+
writeState(binding, {
|
|
916
940
|
boundRoot: observed,
|
|
917
941
|
claimedRoot: null,
|
|
918
942
|
updatedAt: new Date().toISOString(),
|
|
@@ -923,7 +947,7 @@ function evaluate(payload) {
|
|
|
923
947
|
return unconfirmedSwitch(state.claimedRoot, observed);
|
|
924
948
|
}
|
|
925
949
|
if (state.claimedRoot === observed) {
|
|
926
|
-
writeState(
|
|
950
|
+
writeState(binding, {
|
|
927
951
|
boundRoot: observed,
|
|
928
952
|
claimedRoot: null,
|
|
929
953
|
updatedAt: new Date().toISOString(),
|
|
@@ -426,6 +426,7 @@ const { width } = useWindowDimensions();
|
|
|
426
426
|
For detailed documentation on specific topics, refer to:
|
|
427
427
|
|
|
428
428
|
- `references/official-docs.md` - Condensed official Expo Router documentation
|
|
429
|
+
- `references/static-export-verification.md` - Asserting enumerated routes, per-route titles, and initial HTML after `expo export`
|
|
429
430
|
- `scripts/generate-route.py` - Route scaffolding script
|
|
430
431
|
|
|
431
432
|
Official Documentation: https://docs.expo.dev/router/introduction/
|
|
@@ -0,0 +1,54 @@
|
|
|
1
|
+
# Static Export Verification
|
|
2
|
+
|
|
3
|
+
When `expo export` runs with static output (`output: "static"` in app.json),
|
|
4
|
+
every route must produce an HTML file with the right title and the expected
|
|
5
|
+
initial markup. `expo export` succeeding only proves the bundle built — a
|
|
6
|
+
missing route, a wrong title, or an empty shell all ship green unless the
|
|
7
|
+
exported output itself is checked.
|
|
8
|
+
|
|
9
|
+
## Enumerate the dynamic routes
|
|
10
|
+
|
|
11
|
+
Static export prerenders each route it can enumerate. Dynamic segments need
|
|
12
|
+
`generateStaticParams` — an unenumerated `[id]` route produces no page at all.
|
|
13
|
+
After export, enumerate the routes the app *declares* and assert each one has
|
|
14
|
+
a file under `dist/`:
|
|
15
|
+
|
|
16
|
+
```typescript
|
|
17
|
+
import { existsSync, readdirSync } from "node:fs";
|
|
18
|
+
import path from "node:path";
|
|
19
|
+
|
|
20
|
+
const DIST = path.resolve("dist");
|
|
21
|
+
|
|
22
|
+
// The routes the app owns — keep this in sync with app/, or derive it from
|
|
23
|
+
// the route manifest expo-router emits.
|
|
24
|
+
const EXPECTED_ROUTES = ["index", "settings", "players/[id]"];
|
|
25
|
+
|
|
26
|
+
for (const route of EXPECTED_ROUTES) {
|
|
27
|
+
const html = path.join(DIST, `${route}.html`);
|
|
28
|
+
expect(existsSync(html)).toBe(true);
|
|
29
|
+
}
|
|
30
|
+
```
|
|
31
|
+
|
|
32
|
+
## Per-route titles
|
|
33
|
+
|
|
34
|
+
`<Stack.Screen options={{ title: "..." }}>` sets the native header title; the
|
|
35
|
+
web `<title>` comes from `Head` (`expo-router/head`). Assert the title the
|
|
36
|
+
exported HTML actually carries:
|
|
37
|
+
|
|
38
|
+
```typescript
|
|
39
|
+
const html = readFileSync(path.join(DIST, "settings.html"), "utf8");
|
|
40
|
+
expect(html).toMatch(/<title>[^<]*Settings[^<]*<\/title>/);
|
|
41
|
+
```
|
|
42
|
+
|
|
43
|
+
## Expected initial content
|
|
44
|
+
|
|
45
|
+
The exported page should ship its prerendered content, not a bare shell —
|
|
46
|
+
that is what makes static export worth shipping at all. Assert a stable marker
|
|
47
|
+
of the route's expected first paint:
|
|
48
|
+
|
|
49
|
+
```typescript
|
|
50
|
+
expect(html).toContain("Sign in to continue");
|
|
51
|
+
```
|
|
52
|
+
|
|
53
|
+
Keep the marker to content that exists in the static HTML, never something
|
|
54
|
+
hydration adds later.
|
|
@@ -478,3 +478,10 @@ Add className to component props:
|
|
|
478
478
|
```tsx
|
|
479
479
|
type Props = React.ComponentProps<typeof RNView> & { className?: string };
|
|
480
480
|
```
|
|
481
|
+
|
|
482
|
+
The same rule applies at every styling API boundary — `useCssElement`,
|
|
483
|
+
`cssInterop`, or `styled()`: type the wrapped component's props explicitly
|
|
484
|
+
(`React.ComponentProps<typeof X> & { className?: string }`) and pass props
|
|
485
|
+
through, rather than casting to a wider type. A cast compiles over a
|
|
486
|
+
prop-shape drift that an explicit type would refuse — the boundary is where
|
|
487
|
+
the drift is cheapest to catch.
|
|
@@ -394,6 +394,31 @@ Components from third-party libraries (e.g., `react-native-bouncy-checkbox`, `re
|
|
|
394
394
|
|
|
395
395
|
---
|
|
396
396
|
|
|
397
|
+
## Reveal-on-Focus Assertions
|
|
398
|
+
|
|
399
|
+
`toBeVisible()` proves the element exists and is not hidden — it does NOT
|
|
400
|
+
prove the element crossed onto the screen. A focused element scrolled off-view
|
|
401
|
+
still reports visible. For any "focus reveals the element" behavior (skip
|
|
402
|
+
links, focus-trapped modals, scroll-into-view containers), assert on layout,
|
|
403
|
+
not just visibility:
|
|
404
|
+
|
|
405
|
+
```typescript
|
|
406
|
+
// Rejects when the element has no box at all (display: none, detached).
|
|
407
|
+
const box = await page.getByTestId("dialog:panel").boundingBox();
|
|
408
|
+
expect(box).not.toBeNull();
|
|
409
|
+
|
|
410
|
+
// Then prove it is actually inside the viewport — the part toBeVisible()
|
|
411
|
+
// cannot say.
|
|
412
|
+
await expect(page.getByTestId("dialog:panel")).toBeInViewport();
|
|
413
|
+
```
|
|
414
|
+
|
|
415
|
+
Pair them: `boundingBox()` answers "is there a box" (null means never laid
|
|
416
|
+
out), `toBeInViewport()` answers "did it cross onto the screen". An assertion
|
|
417
|
+
that skips the null check reads a missing layout as a viewport miss, which is
|
|
418
|
+
a different bug.
|
|
419
|
+
|
|
420
|
+
---
|
|
421
|
+
|
|
397
422
|
## Implementation Checklist
|
|
398
423
|
|
|
399
424
|
When adding E2E test coverage to a component:
|
package/plugins/lisa-expo/.codex-plugin/skills/testing-library/references/mocking-patterns.md
CHANGED
|
@@ -588,3 +588,25 @@ afterAll(() => {
|
|
|
588
588
|
console.error = originalError;
|
|
589
589
|
});
|
|
590
590
|
```
|
|
591
|
+
|
|
592
|
+
## Migrating jest.mock Usage
|
|
593
|
+
|
|
594
|
+
When moving a test file onto the managed setup, scope the migration to the
|
|
595
|
+
file under your hand — a suite-wide mock sweep is where subtle behavior
|
|
596
|
+
changes hide.
|
|
597
|
+
|
|
598
|
+
- **Prefer renderer-compatible mocks.** A mock that works in the Node
|
|
599
|
+
environment but reads `window`, native modules, or ESM-only entry points
|
|
600
|
+
fails under the jsdom/renderer the Expo preset provides. Mock the seam your
|
|
601
|
+
component actually imports (`jest.mock("nativewind", ...)`,
|
|
602
|
+
`jest.mock("@/lib/env", ...)`) — never reach around it to mock a transitive
|
|
603
|
+
dependency.
|
|
604
|
+
- **Keep factories stable and hoisted.** Jest hoists `jest.mock` calls above
|
|
605
|
+
imports, so a factory cannot close over outer variables. Everything the
|
|
606
|
+
factory needs must come from `jest.requireActual`, `jest.requireMock`, or a
|
|
607
|
+
`mock`-prefixed name. A factory that silently returns a different shape per
|
|
608
|
+
run is the migration failure that surfaces as unrelated flakes.
|
|
609
|
+
- **Check version compatibility, not history.** A pinned workaround for an
|
|
610
|
+
old jest-expo/Expo SDK issue is not a permanent blocker — verify whether the
|
|
611
|
+
current versions still need it before carrying it forward. Historical Expo
|
|
612
|
+
issues expire; copy them forward only when they reproduce.
|
|
@@ -426,6 +426,7 @@ const { width } = useWindowDimensions();
|
|
|
426
426
|
For detailed documentation on specific topics, refer to:
|
|
427
427
|
|
|
428
428
|
- `references/official-docs.md` - Condensed official Expo Router documentation
|
|
429
|
+
- `references/static-export-verification.md` - Asserting enumerated routes, per-route titles, and initial HTML after `expo export`
|
|
429
430
|
- `scripts/generate-route.py` - Route scaffolding script
|
|
430
431
|
|
|
431
432
|
Official Documentation: https://docs.expo.dev/router/introduction/
|
package/plugins/lisa-expo/skills/expo-router-best-practices/references/static-export-verification.md
ADDED
|
@@ -0,0 +1,54 @@
|
|
|
1
|
+
# Static Export Verification
|
|
2
|
+
|
|
3
|
+
When `expo export` runs with static output (`output: "static"` in app.json),
|
|
4
|
+
every route must produce an HTML file with the right title and the expected
|
|
5
|
+
initial markup. `expo export` succeeding only proves the bundle built — a
|
|
6
|
+
missing route, a wrong title, or an empty shell all ship green unless the
|
|
7
|
+
exported output itself is checked.
|
|
8
|
+
|
|
9
|
+
## Enumerate the dynamic routes
|
|
10
|
+
|
|
11
|
+
Static export prerenders each route it can enumerate. Dynamic segments need
|
|
12
|
+
`generateStaticParams` — an unenumerated `[id]` route produces no page at all.
|
|
13
|
+
After export, enumerate the routes the app *declares* and assert each one has
|
|
14
|
+
a file under `dist/`:
|
|
15
|
+
|
|
16
|
+
```typescript
|
|
17
|
+
import { existsSync, readdirSync } from "node:fs";
|
|
18
|
+
import path from "node:path";
|
|
19
|
+
|
|
20
|
+
const DIST = path.resolve("dist");
|
|
21
|
+
|
|
22
|
+
// The routes the app owns — keep this in sync with app/, or derive it from
|
|
23
|
+
// the route manifest expo-router emits.
|
|
24
|
+
const EXPECTED_ROUTES = ["index", "settings", "players/[id]"];
|
|
25
|
+
|
|
26
|
+
for (const route of EXPECTED_ROUTES) {
|
|
27
|
+
const html = path.join(DIST, `${route}.html`);
|
|
28
|
+
expect(existsSync(html)).toBe(true);
|
|
29
|
+
}
|
|
30
|
+
```
|
|
31
|
+
|
|
32
|
+
## Per-route titles
|
|
33
|
+
|
|
34
|
+
`<Stack.Screen options={{ title: "..." }}>` sets the native header title; the
|
|
35
|
+
web `<title>` comes from `Head` (`expo-router/head`). Assert the title the
|
|
36
|
+
exported HTML actually carries:
|
|
37
|
+
|
|
38
|
+
```typescript
|
|
39
|
+
const html = readFileSync(path.join(DIST, "settings.html"), "utf8");
|
|
40
|
+
expect(html).toMatch(/<title>[^<]*Settings[^<]*<\/title>/);
|
|
41
|
+
```
|
|
42
|
+
|
|
43
|
+
## Expected initial content
|
|
44
|
+
|
|
45
|
+
The exported page should ship its prerendered content, not a bare shell —
|
|
46
|
+
that is what makes static export worth shipping at all. Assert a stable marker
|
|
47
|
+
of the route's expected first paint:
|
|
48
|
+
|
|
49
|
+
```typescript
|
|
50
|
+
expect(html).toContain("Sign in to continue");
|
|
51
|
+
```
|
|
52
|
+
|
|
53
|
+
Keep the marker to content that exists in the static HTML, never something
|
|
54
|
+
hydration adds later.
|
|
@@ -478,3 +478,10 @@ Add className to component props:
|
|
|
478
478
|
```tsx
|
|
479
479
|
type Props = React.ComponentProps<typeof RNView> & { className?: string };
|
|
480
480
|
```
|
|
481
|
+
|
|
482
|
+
The same rule applies at every styling API boundary — `useCssElement`,
|
|
483
|
+
`cssInterop`, or `styled()`: type the wrapped component's props explicitly
|
|
484
|
+
(`React.ComponentProps<typeof X> & { className?: string }`) and pass props
|
|
485
|
+
through, rather than casting to a wider type. A cast compiles over a
|
|
486
|
+
prop-shape drift that an explicit type would refuse — the boundary is where
|
|
487
|
+
the drift is cheapest to catch.
|