@codyswann/lisa 4.59.2 → 4.59.3

package/scripts/check-workflow-package-paths.mjs

@@ -111,6 +111,7 @@ import path from "node:path";
 import { boundedExecFileSync } from "./lib/bounded-spawn.mjs";
 import { invokedAsScript } from "./lib/invoked-as-script.mjs";
 import {
+  compareVersions,
   declarationGaps,
   probeReleases,
   readContractDeclaration,
@@ -489,10 +490,17 @@ export function releaseContains(entries, candidate) {
  * @param {Record<string, readonly string[]>} listings - Version to entry list
  * @returns {readonly string[]} One operator-readable line per failure
  */
-export function findBreakages(groups, listings) {
+export function findBreakages(groups, listings, contracts = {}) {
   return Object.entries(listings).flatMap(([version, entries]) =>
     groups
-      .filter(group => !group.paths.some(p => releaseContains(entries, p)))
+      .filter(
+        group =>
+          !group.paths.some(
+            p =>
+              releaseContains(entries, p) ||
+              introducedLater(version, contracts[p])
+          )
+      )
       .map(
         group =>
           `${version}: ${group.workflow} step "${group.step}" resolves ${group.paths
@@ -504,6 +512,17 @@ export function findBreakages(groups, listings) {
   );
 }
 
+/** A declared optional feature may predate its package artifact only on known older releases. */
+function introducedLater(version, contract) {
+  return (
+    /^\d+\.\d+\.\d+$/.test(version) &&
+    typeof contract?.since === "string" &&
+    typeof contract.degradation === "string" &&
+    contract.degradation.length >= 40 &&
+    compareVersions(version, contract.since) < 0
+  );
+}
+
 /**
  * Run the check.
  * @returns {void}
@@ -567,7 +586,7 @@ function main() {
         });
 
   const breakages = [
-    ...findBreakages(claims.groups, listings),
+    ...findBreakages(claims.groups, listings, declaration.contracts),
     ...gaps.undeclared,
     ...gaps.stale,
     ...contracts.violations,
@@ -579,6 +598,19 @@ function main() {
     releasesExamined: Object.keys(listings),
     contractProbesExecuted: contracts.executed,
     contractProbesDeferred: contracts.deferred,
+    packagePathsDeferred: Object.entries(listings).flatMap(
+      ([version, entries]) =>
+        Object.entries(declaration.contracts)
+          .filter(
+            ([where, contract]) =>
+              !releaseContains(entries, where) &&
+              introducedLater(version, contract)
+          )
+          .map(
+            ([where, contract]) =>
+              `${version}: ${where} introduced in ${contract.since}; ${contract.degradation}`
+          )
+    ),
     contractProbesRun: contracts.probed,
     unattributed: claims.unattributed,
     breakages,
@@ -592,6 +624,8 @@ function main() {
     );
     for (const line of contracts.deferred)
       process.stdout.write(`  · ${line}\n`);
+    for (const line of report.packagePathsDeferred)
+      process.stdout.write(`  · ${line}\n`);
     for (const line of breakages) process.stdout.write(`  ✗ ${line}\n`);
   }
 

package/scripts/lib/workflow-contract-probe.mjs

@@ -151,6 +151,17 @@ export function readContractDeclaration(declared) {
     );
   }
   for (const [where, entry] of Object.entries(contracts)) {
+    if (
+      entry?.since !== undefined &&
+      (typeof entry.since !== "string" ||
+        !/^\d+\.\d+\.\d+$/.test(entry.since) ||
+        typeof entry.degradation !== "string" ||
+        entry.degradation.length < 40)
+    ) {
+      throw new Error(
+        `contracts["${where}"]: since needs a release version and degradation must explain the older caller's behavior`
+      );
+    }
     if (!CONTRACT_KINDS.has(entry?.kind)) {
       throw new Error(
         `contracts["${where}"]: kind must be one of ${[...CONTRACT_KINDS].join(", ")}`

package/scripts/two-channel-couplings.json

@@ -95,7 +95,7 @@
   },
   "inspected": {
     "workflows": 23,
-    "steps": 778,
+    "steps": 779,
     "couplings": 33,
     "inventory": 78
   },