@codyswann/lisa 4.57.2 → 4.57.4

package/expo/copy-overwrite/scripts/classify-maestro-failures.mjs

@@ -626,7 +626,7 @@ function countOccurrences(haystack, needle) {
 
 /**
  * Tally every marker across a run's debug artifacts, per flow.
- * @param {readonly {path: string, text: string}[]} artifacts - Debug artifacts
+ * @param {Iterable<{path: string, text: string}>} artifacts - Debug artifacts, iterated once
  * @param {readonly {flow: string, keys: readonly string[]}[]} flowKeys - Flows in the report
  * @param {readonly string[]} markers - Markers to count
  * @returns {{perFlow: Map<string, object>, unattributed: object}} Tallies
@@ -723,20 +723,72 @@ export function deviceVerdict(tallies, baselines, markers) {
  * Absence is normal and silent: a run that crashed before Maestro started, or a
  * caller that has not wired the flag, simply yields no evidence — and with no
  * evidence nothing is ever a device fault.
+ *
+ * LAZY, and that is load-bearing rather than a micro-optimisation. This used to
+ * build an array holding every file's text at once. A real iOS debug tree is
+ * 3.5 GB across 540 files — `device-simulator.log` alone reaches 235 MB for a
+ * single flow — so the array exhausted the V8 heap and the classifier died with
+ * `FATAL ERROR: Reached heap limit` inside `fs.readFileSync`. Measured on a
+ * 44-flow iOS leg, 2026-09-11.
+ *
+ * That crash was invisible: the workflow used `|| true` and `exit 0`
+ * so the classifier could never fail the job — deliberately, and the
+ * suite beside this file pins that — and the docblock above says absence of
+ * evidence is normal. So an OOM produces exactly the observable of a run with
+ * nothing to classify. On the measured run, the leg's ONE failure was a
+ * simulator launch failure — precisely the device fault this classifier exists
+ * to name — and it went unnamed because the classifier had died.
+ *
+ * Yielding one artifact at a time caps peak memory at the largest single file
+ * instead of their sum, and each text becomes garbage as soon as
+ * {@link tallyDeviceMarkers} has counted it.
+ *
+ * The return is a RE-ITERABLE iterable, not a one-shot generator: `run()`
+ * computes this once and passes it through `classifyRun` for every report, so a
+ * generator would be empty for the second report onward — a silent
+ * evidence-loss bug in place of a loud crash, which would be worse than what it
+ * replaced.
  * @param {string | null} debugRoot - Absolute path of the debug-output directory
  * @param {{listFiles: Function, readFile: Function}} io - Injected readers
- * @returns {{path: string, text: string}[]} Artifacts
+ * @returns {Iterable<{path: string, text: string}>} Artifacts, read on demand
  */
 export function readDebugArtifacts(debugRoot, { listFiles, readFile }) {
   if (!debugRoot) return [];
-  const artifacts = [];
-  for (const file of listFiles(debugRoot) ?? []) {
-    if (isOpaque(file)) continue;
-    const text = readFile(file);
-    if (text === null) continue;
-    artifacts.push({ path: file, text });
-  }
-  return artifacts;
+  return {
+    *[Symbol.iterator]() {
+      for (const file of listFiles(debugRoot) ?? []) {
+        if (isOpaque(file)) continue;
+        const text = readFile(file);
+        // `readFile` returns null for absent, unreadable AND too-large-to-
+        // string files alike. The last is the one that grows back into the bug
+        // above — Node refuses a string past its maximum length, and a
+        // device log that crosses it would drop out of the evidence silently.
+        if (text === null) {
+          reportUnreadableArtifact(file);
+          continue;
+        }
+        yield { path: file, text };
+      }
+    },
+  };
+}
+
+/**
+ * Say on stderr that an artifact could not be read.
+ *
+ * Not a throw: a missing or unreadable artifact must not fail the run, for the
+ * same reason the step absorbs a non-zero exit. But it must not be silent
+ * either — an artifact that drops out of the evidence takes its markers with
+ * it, and a device fault it alone witnessed then reads as a flow failure.
+ * stderr rather than the markdown, so it reaches the job log without becoming
+ * part of the classification that a consumer parses.
+ * @param {string} file - Path of the artifact that could not be read
+ */
+function reportUnreadableArtifact(file) {
+  process.stderr.write(
+    `classify-maestro-failures: could not read ${path.basename(file)} — ` +
+      `its markers are NOT counted in this classification.\n`
+  );
 }
 
 /**
@@ -869,7 +921,7 @@ function resolveFlowPath(reported, { projectRoot, maestroRoot, readFile }) {
  * @param {readonly string[]} [options.signInMarkers] - Project sign-in markers
  * @param {readonly unknown[]} [options.knownIntermittent] - Raw registry entries
  * @param {string} [options.platform] - Arm the report came from
- * @param {readonly {path: string, text: string}[]} [options.debugArtifacts] - Run observation
+ * @param {Iterable<{path: string, text: string}>} [options.debugArtifacts] - Run observation
  * @param {readonly string[]} [options.deviceFaultMarkers] - Presence-decided device faults
  * @param {readonly string[]} [options.deviceInstabilityMarkers] - Count-decided device faults
  * @returns {{failures: object[], deviceRunEvidence: object[]}} The report's verdict
@@ -1115,9 +1167,9 @@ export function loadConfig(projectRoot) {
 /**
  * Classify every named report against one project checkout.
  *
- * The debug-output tree is read ONCE and shared across the named reports: it is
- * the observation of a single run, and re-walking it per report would only cost
- * time. A retry arm writes into the same tree, which is correct — retries only
+ * The debug-output iterable is shared across the named reports. Each report
+ * reads it lazily so artifact text is not retained between reports.
+ * A retry arm writes into the same tree, which is correct — retries only
  * re-run flows that already failed, so its evidence is about those same flows.
  * @param {readonly string[]} reportPaths - Report paths
  * @param {{projectRoot: string, platform: string | null, debugRoot?: string | null}} context - Run context

package/package.json

@@ -187,7 +187,7 @@
     "zod-validation-error": "^4.0.0"
   },
   "name": "@codyswann/lisa",
-  "version": "4.57.2",
+  "version": "4.57.4",
   "description": "Claude Code governance framework that applies guardrails, guidance, and automated enforcement to projects",
   "main": "dist/index.js",
   "exports": {
@@ -336,7 +336,7 @@
     "test": "tests"
   },
   "types": "./dist/index.d.ts",
-  "lisaReleaseCommit": "0a3ca466098950c41a7e4a9f9edf65ae8831b830",
-  "gitHead": "0a3ca466098950c41a7e4a9f9edf65ae8831b830",
-  "lisaReleaseTag": "v4.57.2"
+  "lisaReleaseCommit": "f6f450438d19c364ff02140f32058a0b8c27f764",
+  "gitHead": "f6f450438d19c364ff02140f32058a0b8c27f764",
+  "lisaReleaseTag": "v4.57.4"
 }

package/plugins/lisa/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa",
-  "version": "4.57.2",
+  "version": "4.57.4",
   "description": "Universal governance — agents, skills, commands, hooks, and rules for all projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa",
-  "version": "4.57.2",
+  "version": "4.57.4",
   "description": "Universal governance: agents, skills, commands, hooks, and rules for all projects.",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa/.codex-plugin/skills/lisa-setup-remote-env/scripts/preflight-tools.mjs

@@ -232,8 +232,22 @@ export function preflightTools(
   };
 }
 
+/**
+ * Format a count with the appropriate noun phrase.
+ * @param {number} n How many.
+ * @param {string} one Singular noun phrase.
+ * @param {string} many Plural noun phrase.
+ * @returns {string} A counted phrase such as "1 tool" or "3 tools".
+ */
+function count(n, one, many) {
+  return `${n} ${n === 1 ? one : many}`;
+}
+
 /**
  * Render a verdict for whoever has to act on it.
+ *
+ * Put blockers first and scope the stop instruction to that section. The
+ * separate installable section must not send usable work to the blocked lane.
  * @param {object} result A {@link preflightTools} result.
  * @returns {string} Operator-readable report, empty when nothing needs saying.
  */
@@ -243,42 +257,53 @@ export function reportTools(result) {
   // The header tracks the exit code. Only a blocked tool is a failure — one
   // Lisa can install is an action with a command attached, and calling that
   // "FAILED" while exiting zero teaches readers that the word means nothing.
+  const blocking = count(result.blocked.length, "tool blocks", "tools block");
+  const spare = result.installable.length
+    ? ` ${result.installable.length} more Lisa can install for you.`
+    : ``;
   const header = () => {
-    if (result.blocked.length) return "Tooling preflight FAILED.";
+    if (result.blocked.length)
+      return `Tooling preflight FAILED — ${blocking}.${spare}`;
     if (result.installable.length)
-      return "Tooling preflight — action available.";
+      return (
+        `Tooling preflight — action available. Nothing blocks;` +
+        ` ${count(result.installable.length, "tool", "tools")} Lisa can` +
+        ` install for you.`
+      );
     // Nothing to do and nothing to fix; the note below is the whole message.
-    return "Tooling preflight passed, with a note.";
+    return `Tooling preflight passed, with a note.`;
   };
   const lines = [header()];
-  if (result.installable.length) {
-    lines.push(
-      ``,
-      `Lisa can install these itself — they are pinned and checksummed.`,
-      `Run /lisa:setup:local-env to place them:`,
-      ``
-    );
-    for (const step of result.installable) {
-      lines.push(`  ${step.name} — ${step.reason}`);
-    }
-  }
   if (result.blocked.length) {
     lines.push(
       ``,
-      `These need you. Lisa has no pinned artifact it can place:`,
+      `STOP — these block the work. Lisa has no pinned artifact it can place,`,
+      `so it cannot fix them for you:`,
       ``
     );
     for (const step of result.blocked) {
       const why = result.reasons[step.name];
-      lines.push(`  ${step.name} — ${step.reason}`);
-      if (why) lines.push(`      required because ${why}`);
+      lines.push(`  [BLOCKED] ${step.name} — ${step.reason}`);
+      if (why) lines.push(`            required because ${why}`);
     }
     lines.push(
       ``,
-      `Work needing one of these cannot be completed. Route the item to`,
-      `blocked with this reason rather than claiming it and stopping partway.`
+      `  Work needing one of the tools above cannot be completed. Route that`,
+      `  item to blocked citing that tool, rather than claiming it and`,
+      `  stopping partway. Nothing else in this report is a reason to stop.`
     );
   }
+  if (result.installable.length) {
+    lines.push(
+      ``,
+      `NOT A BLOCKER — Lisa can install these itself; they are pinned and`,
+      `checksummed. Run /lisa:setup:local-env to place them:`,
+      ``
+    );
+    for (const step of result.installable) {
+      lines.push(`  [INSTALLABLE] ${step.name} — ${step.reason}`);
+    }
+  }
   if (result.unverified.length) {
     lines.push(
       ``,

package/plugins/lisa/skills/lisa-setup-remote-env/scripts/preflight-tools.mjs

@@ -232,8 +232,22 @@ export function preflightTools(
   };
 }
 
+/**
+ * Format a count with the appropriate noun phrase.
+ * @param {number} n How many.
+ * @param {string} one Singular noun phrase.
+ * @param {string} many Plural noun phrase.
+ * @returns {string} A counted phrase such as "1 tool" or "3 tools".
+ */
+function count(n, one, many) {
+  return `${n} ${n === 1 ? one : many}`;
+}
+
 /**
  * Render a verdict for whoever has to act on it.
+ *
+ * Put blockers first and scope the stop instruction to that section. The
+ * separate installable section must not send usable work to the blocked lane.
  * @param {object} result A {@link preflightTools} result.
  * @returns {string} Operator-readable report, empty when nothing needs saying.
  */
@@ -243,42 +257,53 @@ export function reportTools(result) {
   // The header tracks the exit code. Only a blocked tool is a failure — one
   // Lisa can install is an action with a command attached, and calling that
   // "FAILED" while exiting zero teaches readers that the word means nothing.
+  const blocking = count(result.blocked.length, "tool blocks", "tools block");
+  const spare = result.installable.length
+    ? ` ${result.installable.length} more Lisa can install for you.`
+    : ``;
   const header = () => {
-    if (result.blocked.length) return "Tooling preflight FAILED.";
+    if (result.blocked.length)
+      return `Tooling preflight FAILED — ${blocking}.${spare}`;
     if (result.installable.length)
-      return "Tooling preflight — action available.";
+      return (
+        `Tooling preflight — action available. Nothing blocks;` +
+        ` ${count(result.installable.length, "tool", "tools")} Lisa can` +
+        ` install for you.`
+      );
     // Nothing to do and nothing to fix; the note below is the whole message.
-    return "Tooling preflight passed, with a note.";
+    return `Tooling preflight passed, with a note.`;
   };
   const lines = [header()];
-  if (result.installable.length) {
-    lines.push(
-      ``,
-      `Lisa can install these itself — they are pinned and checksummed.`,
-      `Run /lisa:setup:local-env to place them:`,
-      ``
-    );
-    for (const step of result.installable) {
-      lines.push(`  ${step.name} — ${step.reason}`);
-    }
-  }
   if (result.blocked.length) {
     lines.push(
       ``,
-      `These need you. Lisa has no pinned artifact it can place:`,
+      `STOP — these block the work. Lisa has no pinned artifact it can place,`,
+      `so it cannot fix them for you:`,
       ``
     );
     for (const step of result.blocked) {
       const why = result.reasons[step.name];
-      lines.push(`  ${step.name} — ${step.reason}`);
-      if (why) lines.push(`      required because ${why}`);
+      lines.push(`  [BLOCKED] ${step.name} — ${step.reason}`);
+      if (why) lines.push(`            required because ${why}`);
     }
     lines.push(
       ``,
-      `Work needing one of these cannot be completed. Route the item to`,
-      `blocked with this reason rather than claiming it and stopping partway.`
+      `  Work needing one of the tools above cannot be completed. Route that`,
+      `  item to blocked citing that tool, rather than claiming it and`,
+      `  stopping partway. Nothing else in this report is a reason to stop.`
     );
   }
+  if (result.installable.length) {
+    lines.push(
+      ``,
+      `NOT A BLOCKER — Lisa can install these itself; they are pinned and`,
+      `checksummed. Run /lisa:setup:local-env to place them:`,
+      ``
+    );
+    for (const step of result.installable) {
+      lines.push(`  [INSTALLABLE] ${step.name} — ${step.reason}`);
+    }
+  }
   if (result.unverified.length) {
     lines.push(
       ``,

package/plugins/lisa-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa",
-  "version": "4.57.2",
+  "version": "4.57.4",
   "description": "Universal governance — agents, skills, commands, hooks, and rules for all projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-agy/skills/lisa-setup-remote-env/scripts/preflight-tools.mjs

@@ -232,8 +232,22 @@ export function preflightTools(
   };
 }
 
+/**
+ * Format a count with the appropriate noun phrase.
+ * @param {number} n How many.
+ * @param {string} one Singular noun phrase.
+ * @param {string} many Plural noun phrase.
+ * @returns {string} A counted phrase such as "1 tool" or "3 tools".
+ */
+function count(n, one, many) {
+  return `${n} ${n === 1 ? one : many}`;
+}
+
 /**
  * Render a verdict for whoever has to act on it.
+ *
+ * Put blockers first and scope the stop instruction to that section. The
+ * separate installable section must not send usable work to the blocked lane.
  * @param {object} result A {@link preflightTools} result.
  * @returns {string} Operator-readable report, empty when nothing needs saying.
  */
@@ -243,42 +257,53 @@ export function reportTools(result) {
   // The header tracks the exit code. Only a blocked tool is a failure — one
   // Lisa can install is an action with a command attached, and calling that
   // "FAILED" while exiting zero teaches readers that the word means nothing.
+  const blocking = count(result.blocked.length, "tool blocks", "tools block");
+  const spare = result.installable.length
+    ? ` ${result.installable.length} more Lisa can install for you.`
+    : ``;
   const header = () => {
-    if (result.blocked.length) return "Tooling preflight FAILED.";
+    if (result.blocked.length)
+      return `Tooling preflight FAILED — ${blocking}.${spare}`;
     if (result.installable.length)
-      return "Tooling preflight — action available.";
+      return (
+        `Tooling preflight — action available. Nothing blocks;` +
+        ` ${count(result.installable.length, "tool", "tools")} Lisa can` +
+        ` install for you.`
+      );
     // Nothing to do and nothing to fix; the note below is the whole message.
-    return "Tooling preflight passed, with a note.";
+    return `Tooling preflight passed, with a note.`;
   };
   const lines = [header()];
-  if (result.installable.length) {
-    lines.push(
-      ``,
-      `Lisa can install these itself — they are pinned and checksummed.`,
-      `Run /lisa:setup:local-env to place them:`,
-      ``
-    );
-    for (const step of result.installable) {
-      lines.push(`  ${step.name} — ${step.reason}`);
-    }
-  }
   if (result.blocked.length) {
     lines.push(
       ``,
-      `These need you. Lisa has no pinned artifact it can place:`,
+      `STOP — these block the work. Lisa has no pinned artifact it can place,`,
+      `so it cannot fix them for you:`,
       ``
     );
     for (const step of result.blocked) {
       const why = result.reasons[step.name];
-      lines.push(`  ${step.name} — ${step.reason}`);
-      if (why) lines.push(`      required because ${why}`);
+      lines.push(`  [BLOCKED] ${step.name} — ${step.reason}`);
+      if (why) lines.push(`            required because ${why}`);
     }
     lines.push(
       ``,
-      `Work needing one of these cannot be completed. Route the item to`,
-      `blocked with this reason rather than claiming it and stopping partway.`
+      `  Work needing one of the tools above cannot be completed. Route that`,
+      `  item to blocked citing that tool, rather than claiming it and`,
+      `  stopping partway. Nothing else in this report is a reason to stop.`
     );
   }
+  if (result.installable.length) {
+    lines.push(
+      ``,
+      `NOT A BLOCKER — Lisa can install these itself; they are pinned and`,
+      `checksummed. Run /lisa:setup:local-env to place them:`,
+      ``
+    );
+    for (const step of result.installable) {
+      lines.push(`  [INSTALLABLE] ${step.name} — ${step.reason}`);
+    }
+  }
   if (result.unverified.length) {
     lines.push(
       ``,

package/plugins/lisa-cdk/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-cdk",
-  "version": "4.57.2",
+  "version": "4.57.4",
   "description": "AWS CDK-specific plugin",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-cdk/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-cdk",
-  "version": "4.57.2",
+  "version": "4.57.4",
   "description": "AWS CDK-specific Lisa plugin.",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-cdk-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-cdk",
-  "version": "4.57.2",
+  "version": "4.57.4",
   "description": "AWS CDK-specific plugin",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-cdk-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-cdk",
-  "version": "4.57.2",
+  "version": "4.57.4",
   "description": "AWS CDK-specific plugin",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-cdk-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-cdk",
-  "version": "4.57.2",
+  "version": "4.57.4",
   "description": "AWS CDK-specific plugin",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa",
-  "version": "4.57.2",
+  "version": "4.57.4",
   "description": "Universal governance — agents, skills, commands, hooks, and rules for all projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-copilot/skills/lisa-setup-remote-env/scripts/preflight-tools.mjs

@@ -232,8 +232,22 @@ export function preflightTools(
   };
 }
 
+/**
+ * Format a count with the appropriate noun phrase.
+ * @param {number} n How many.
+ * @param {string} one Singular noun phrase.
+ * @param {string} many Plural noun phrase.
+ * @returns {string} A counted phrase such as "1 tool" or "3 tools".
+ */
+function count(n, one, many) {
+  return `${n} ${n === 1 ? one : many}`;
+}
+
 /**
  * Render a verdict for whoever has to act on it.
+ *
+ * Put blockers first and scope the stop instruction to that section. The
+ * separate installable section must not send usable work to the blocked lane.
  * @param {object} result A {@link preflightTools} result.
  * @returns {string} Operator-readable report, empty when nothing needs saying.
  */
@@ -243,42 +257,53 @@ export function reportTools(result) {
   // The header tracks the exit code. Only a blocked tool is a failure — one
   // Lisa can install is an action with a command attached, and calling that
   // "FAILED" while exiting zero teaches readers that the word means nothing.
+  const blocking = count(result.blocked.length, "tool blocks", "tools block");
+  const spare = result.installable.length
+    ? ` ${result.installable.length} more Lisa can install for you.`
+    : ``;
   const header = () => {
-    if (result.blocked.length) return "Tooling preflight FAILED.";
+    if (result.blocked.length)
+      return `Tooling preflight FAILED — ${blocking}.${spare}`;
     if (result.installable.length)
-      return "Tooling preflight — action available.";
+      return (
+        `Tooling preflight — action available. Nothing blocks;` +
+        ` ${count(result.installable.length, "tool", "tools")} Lisa can` +
+        ` install for you.`
+      );
     // Nothing to do and nothing to fix; the note below is the whole message.
-    return "Tooling preflight passed, with a note.";
+    return `Tooling preflight passed, with a note.`;
   };
   const lines = [header()];
-  if (result.installable.length) {
-    lines.push(
-      ``,
-      `Lisa can install these itself — they are pinned and checksummed.`,
-      `Run /lisa:setup:local-env to place them:`,
-      ``
-    );
-    for (const step of result.installable) {
-      lines.push(`  ${step.name} — ${step.reason}`);
-    }
-  }
   if (result.blocked.length) {
     lines.push(
       ``,
-      `These need you. Lisa has no pinned artifact it can place:`,
+      `STOP — these block the work. Lisa has no pinned artifact it can place,`,
+      `so it cannot fix them for you:`,
       ``
     );
     for (const step of result.blocked) {
       const why = result.reasons[step.name];
-      lines.push(`  ${step.name} — ${step.reason}`);
-      if (why) lines.push(`      required because ${why}`);
+      lines.push(`  [BLOCKED] ${step.name} — ${step.reason}`);
+      if (why) lines.push(`            required because ${why}`);
     }
     lines.push(
       ``,
-      `Work needing one of these cannot be completed. Route the item to`,
-      `blocked with this reason rather than claiming it and stopping partway.`
+      `  Work needing one of the tools above cannot be completed. Route that`,
+      `  item to blocked citing that tool, rather than claiming it and`,
+      `  stopping partway. Nothing else in this report is a reason to stop.`
     );
   }
+  if (result.installable.length) {
+    lines.push(
+      ``,
+      `NOT A BLOCKER — Lisa can install these itself; they are pinned and`,
+      `checksummed. Run /lisa:setup:local-env to place them:`,
+      ``
+    );
+    for (const step of result.installable) {
+      lines.push(`  [INSTALLABLE] ${step.name} — ${step.reason}`);
+    }
+  }
   if (result.unverified.length) {
     lines.push(
       ``,

package/plugins/lisa-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa",
-  "version": "4.57.2",
+  "version": "4.57.4",
   "description": "Universal governance — agents, skills, commands, hooks, and rules for all projects",
   "author": {
     "name": "Cody Swann"