@codyswann/lisa 4.49.0 → 4.50.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/all/copy-overwrite/scripts/check-conflict-markers.mjs +4 -1
- package/all/copy-overwrite/scripts/lib/gate-failure-diagnosis.mjs +163 -0
- package/all/copy-overwrite/scripts/lisa-enforcement-fallback.sh +178 -1
- package/all/copy-overwrite/scripts/lisa-hooks/block-direct-issue-create.sh +89 -10
- package/all/copy-overwrite/scripts/lisa-hooks/parity-safety-net.sh +44 -0
- package/all/copy-overwrite/scripts/lisa-lint-staged-preflight.mjs +1 -1
- package/all/copy-overwrite/scripts/lisa-run-gates.mjs +24 -24
- package/all/copy-overwrite/scripts/lisa-work-item.mjs +490 -81
- package/cdk/package-lisa/package.lisa.json +45 -15
- package/dist/core/lisa-owned-hash-ledger.d.ts.map +1 -1
- package/dist/core/lisa-owned-hash-ledger.js +76 -0
- package/dist/core/lisa-owned-hash-ledger.js.map +1 -1
- package/dist/core/nightly-e2e-guard-behavior-certificate.js +2 -2
- package/dist/core/upstream-evidence-manifest.d.ts.map +1 -1
- package/dist/core/upstream-evidence-manifest.js +120 -227
- package/dist/core/upstream-evidence-manifest.js.map +1 -1
- package/dist/opencode/plugin-templates/lisa-block-direct-issue-create.ts +45 -1
- package/dist/opencode/plugin-templates/parity-safety-net.sh +44 -0
- package/expo/package-lisa/package.lisa.json +83 -53
- package/harper-fabric/package-lisa/package.lisa.json +62 -32
- package/nestjs/package-lisa/package.lisa.json +57 -27
- package/npm-package/package-lisa/package.lisa.json +43 -7
- package/package.json +11 -7
- package/phaser/copy-overwrite/ast-grep/rules/no-day-truncating-file-age-predicate.yml +50 -0
- package/phaser/package-lisa/package.lisa.json +62 -32
- package/plugins/lisa/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa/.codex-plugin/skills/lisa-drive-pr-to-merge/SKILL.md +17 -1
- package/plugins/lisa/.codex-plugin/skills/lisa-github-build-intake/SKILL.md +4 -0
- package/plugins/lisa/.codex-plugin/skills/lisa-jira-build-intake/SKILL.md +4 -0
- package/plugins/lisa/.codex-plugin/skills/lisa-linear-build-intake/SKILL.md +4 -0
- package/plugins/lisa/.codex-plugin/skills/lisa-repair-intake/SKILL.md +4 -1
- package/plugins/lisa/hooks/block-direct-issue-create.sh +89 -10
- package/plugins/lisa/hooks/discharge-work-item-gates.sh +7 -1
- package/plugins/lisa/hooks/parity-safety-net.sh +44 -0
- package/plugins/lisa/hooks/threshold-ratchet-families.mjs +12 -0
- package/plugins/lisa/rules/eager/00-rule-index.md +79 -0
- package/plugins/lisa/rules/eager/base-rules.md +10 -0
- package/plugins/lisa/rules/eager/config-resolution.md +1 -88
- package/plugins/lisa/rules/reference/automation-runbook-contract.md +97 -0
- package/plugins/lisa/rules/reference/bdd-e2e-coverage.md +56 -0
- package/plugins/lisa/rules/reference/blocker-containment.md +58 -0
- package/plugins/lisa/rules/reference/claim-archaeology.md +42 -0
- package/plugins/lisa/rules/reference/claim-evidence-mapping.md +83 -0
- package/plugins/lisa/rules/reference/claim-time-guards.md +37 -0
- package/plugins/lisa/rules/reference/config-resolution.md +97 -0
- package/plugins/lisa/rules/reference/control-reachability.md +44 -0
- package/plugins/lisa/rules/reference/convergent-review.md +31 -0
- package/plugins/lisa/rules/reference/credential-substrate-precedence.md +57 -0
- package/plugins/lisa/rules/reference/dependency-decision-records.md +37 -0
- package/plugins/lisa/rules/reference/dependency-internalization-kit.md +47 -0
- package/plugins/lisa/rules/reference/dependency-trust-classes.md +48 -0
- package/plugins/lisa/rules/reference/deployed-state-readback.md +52 -0
- package/plugins/lisa/rules/reference/derived-branch-plan.md +52 -0
- package/plugins/lisa/rules/reference/design-source-of-truth.md +43 -0
- package/plugins/lisa/rules/reference/design-value-binding.md +103 -0
- package/plugins/lisa/rules/reference/documentation-source-paths.md +18 -0
- package/plugins/lisa/rules/reference/leaf-only-lifecycle.md +75 -0
- package/plugins/lisa/rules/reference/observability-audit.md +20 -0
- package/plugins/lisa/rules/reference/prd-definition-of-ready.md +37 -0
- package/plugins/lisa/rules/reference/prd-lifecycle-rollup.md +36 -0
- package/plugins/lisa/rules/reference/pre-flight-autofill.md +88 -0
- package/plugins/lisa/rules/reference/promotion-contract.md +21 -0
- package/plugins/lisa/rules/reference/readiness-rubric.md +63 -0
- package/plugins/lisa/rules/reference/ready-role-filing.md +34 -0
- package/plugins/lisa/rules/reference/rejection-detection.md +69 -0
- package/plugins/lisa/rules/reference/repo-scope-split.md +48 -0
- package/plugins/lisa/rules/reference/reset-seed-coverage.md +55 -0
- package/plugins/lisa/rules/reference/usage-accounting.md +38 -0
- package/plugins/lisa/rules/reference/work-item-definition-of-ready.md +32 -0
- package/plugins/lisa/scripts/intake-blocker-reprobe.mjs +158 -1
- package/plugins/lisa/skills/lisa-drive-pr-to-merge/SKILL.md +17 -1
- package/plugins/lisa/skills/lisa-github-build-intake/SKILL.md +4 -0
- package/plugins/lisa/skills/lisa-jira-build-intake/SKILL.md +4 -0
- package/plugins/lisa/skills/lisa-linear-build-intake/SKILL.md +4 -0
- package/plugins/lisa/skills/lisa-repair-intake/SKILL.md +4 -1
- package/plugins/lisa-agy/hooks/block-direct-issue-create.sh +89 -10
- package/plugins/lisa-agy/hooks/parity-safety-net.sh +44 -0
- package/plugins/lisa-agy/plugin.json +1 -1
- package/plugins/lisa-agy/scripts/intake-blocker-reprobe.mjs +158 -1
- package/plugins/lisa-agy/skills/lisa-drive-pr-to-merge/SKILL.md +17 -1
- package/plugins/lisa-agy/skills/lisa-github-build-intake/SKILL.md +4 -0
- package/plugins/lisa-agy/skills/lisa-jira-build-intake/SKILL.md +4 -0
- package/plugins/lisa-agy/skills/lisa-linear-build-intake/SKILL.md +4 -0
- package/plugins/lisa-agy/skills/lisa-repair-intake/SKILL.md +4 -1
- package/plugins/lisa-cdk/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-agy/plugin.json +1 -1
- package/plugins/lisa-cdk-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/hooks/block-direct-issue-create.sh +89 -10
- package/plugins/lisa-copilot/hooks/discharge-work-item-gates.sh +7 -1
- package/plugins/lisa-copilot/hooks/parity-safety-net.sh +44 -0
- package/plugins/lisa-copilot/hooks/threshold-ratchet-families.mjs +12 -0
- package/plugins/lisa-copilot/rules/eager/00-rule-index.md +79 -0
- package/plugins/lisa-copilot/rules/eager/base-rules.md +10 -0
- package/plugins/lisa-copilot/rules/eager/config-resolution.md +1 -88
- package/plugins/lisa-copilot/rules/reference/automation-runbook-contract.md +97 -0
- package/plugins/lisa-copilot/rules/reference/bdd-e2e-coverage.md +56 -0
- package/plugins/lisa-copilot/rules/reference/blocker-containment.md +58 -0
- package/plugins/lisa-copilot/rules/reference/claim-archaeology.md +42 -0
- package/plugins/lisa-copilot/rules/reference/claim-evidence-mapping.md +83 -0
- package/plugins/lisa-copilot/rules/reference/claim-time-guards.md +37 -0
- package/plugins/lisa-copilot/rules/reference/config-resolution.md +97 -0
- package/plugins/lisa-copilot/rules/reference/control-reachability.md +44 -0
- package/plugins/lisa-copilot/rules/reference/convergent-review.md +31 -0
- package/plugins/lisa-copilot/rules/reference/credential-substrate-precedence.md +57 -0
- package/plugins/lisa-copilot/rules/reference/dependency-decision-records.md +37 -0
- package/plugins/lisa-copilot/rules/reference/dependency-internalization-kit.md +47 -0
- package/plugins/lisa-copilot/rules/reference/dependency-trust-classes.md +48 -0
- package/plugins/lisa-copilot/rules/reference/deployed-state-readback.md +52 -0
- package/plugins/lisa-copilot/rules/reference/derived-branch-plan.md +52 -0
- package/plugins/lisa-copilot/rules/reference/design-source-of-truth.md +43 -0
- package/plugins/lisa-copilot/rules/reference/design-value-binding.md +103 -0
- package/plugins/lisa-copilot/rules/reference/documentation-source-paths.md +18 -0
- package/plugins/lisa-copilot/rules/reference/leaf-only-lifecycle.md +75 -0
- package/plugins/lisa-copilot/rules/reference/observability-audit.md +20 -0
- package/plugins/lisa-copilot/rules/reference/prd-definition-of-ready.md +37 -0
- package/plugins/lisa-copilot/rules/reference/prd-lifecycle-rollup.md +36 -0
- package/plugins/lisa-copilot/rules/reference/pre-flight-autofill.md +88 -0
- package/plugins/lisa-copilot/rules/reference/promotion-contract.md +21 -0
- package/plugins/lisa-copilot/rules/reference/readiness-rubric.md +63 -0
- package/plugins/lisa-copilot/rules/reference/ready-role-filing.md +34 -0
- package/plugins/lisa-copilot/rules/reference/rejection-detection.md +69 -0
- package/plugins/lisa-copilot/rules/reference/repo-scope-split.md +48 -0
- package/plugins/lisa-copilot/rules/reference/reset-seed-coverage.md +55 -0
- package/plugins/lisa-copilot/rules/reference/usage-accounting.md +38 -0
- package/plugins/lisa-copilot/rules/reference/work-item-definition-of-ready.md +32 -0
- package/plugins/lisa-copilot/scripts/intake-blocker-reprobe.mjs +158 -1
- package/plugins/lisa-copilot/skills/lisa-drive-pr-to-merge/SKILL.md +17 -1
- package/plugins/lisa-copilot/skills/lisa-github-build-intake/SKILL.md +4 -0
- package/plugins/lisa-copilot/skills/lisa-jira-build-intake/SKILL.md +4 -0
- package/plugins/lisa-copilot/skills/lisa-linear-build-intake/SKILL.md +4 -0
- package/plugins/lisa-copilot/skills/lisa-repair-intake/SKILL.md +4 -1
- package/plugins/lisa-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cursor/hooks/block-direct-issue-create.sh +89 -10
- package/plugins/lisa-cursor/hooks/discharge-work-item-gates.sh +7 -1
- package/plugins/lisa-cursor/hooks/parity-safety-net.sh +44 -0
- package/plugins/lisa-cursor/hooks/threshold-ratchet-families.mjs +12 -0
- package/plugins/lisa-cursor/rules/00-rule-index.mdc +84 -0
- package/plugins/lisa-cursor/rules/automation-runbook-contract-reference.mdc +97 -0
- package/plugins/lisa-cursor/rules/base-rules.mdc +10 -0
- package/plugins/lisa-cursor/rules/bdd-e2e-coverage-reference.mdc +56 -0
- package/plugins/lisa-cursor/rules/blocker-containment-reference.mdc +58 -0
- package/plugins/lisa-cursor/rules/claim-archaeology-reference.mdc +42 -0
- package/plugins/lisa-cursor/rules/claim-evidence-mapping-reference.mdc +83 -0
- package/plugins/lisa-cursor/rules/claim-time-guards-reference.mdc +37 -0
- package/plugins/lisa-cursor/rules/config-resolution-reference.mdc +97 -0
- package/plugins/lisa-cursor/rules/config-resolution.mdc +1 -88
- package/plugins/lisa-cursor/rules/control-reachability-reference.mdc +44 -0
- package/plugins/lisa-cursor/rules/convergent-review-reference.mdc +31 -0
- package/plugins/lisa-cursor/rules/credential-substrate-precedence-reference.mdc +57 -0
- package/plugins/lisa-cursor/rules/dependency-decision-records-reference.mdc +37 -0
- package/plugins/lisa-cursor/rules/dependency-internalization-kit-reference.mdc +47 -0
- package/plugins/lisa-cursor/rules/dependency-trust-classes-reference.mdc +48 -0
- package/plugins/lisa-cursor/rules/deployed-state-readback-reference.mdc +52 -0
- package/plugins/lisa-cursor/rules/derived-branch-plan-reference.mdc +52 -0
- package/plugins/lisa-cursor/rules/design-source-of-truth-reference.mdc +43 -0
- package/plugins/lisa-cursor/rules/design-value-binding-reference.mdc +103 -0
- package/plugins/lisa-cursor/rules/documentation-source-paths-reference.mdc +18 -0
- package/plugins/lisa-cursor/rules/leaf-only-lifecycle-reference.mdc +75 -0
- package/plugins/lisa-cursor/rules/observability-audit-reference.mdc +20 -0
- package/plugins/lisa-cursor/rules/prd-definition-of-ready-reference.mdc +37 -0
- package/plugins/lisa-cursor/rules/prd-lifecycle-rollup-reference.mdc +36 -0
- package/plugins/lisa-cursor/rules/pre-flight-autofill-reference.mdc +88 -0
- package/plugins/lisa-cursor/rules/promotion-contract-reference.mdc +21 -0
- package/plugins/lisa-cursor/rules/readiness-rubric-reference.mdc +63 -0
- package/plugins/lisa-cursor/rules/ready-role-filing-reference.mdc +34 -0
- package/plugins/lisa-cursor/rules/rejection-detection-reference.mdc +69 -0
- package/plugins/lisa-cursor/rules/repo-scope-split-reference.mdc +48 -0
- package/plugins/lisa-cursor/rules/reset-seed-coverage-reference.mdc +55 -0
- package/plugins/lisa-cursor/rules/usage-accounting-reference.mdc +38 -0
- package/plugins/lisa-cursor/rules/work-item-definition-of-ready-reference.mdc +32 -0
- package/plugins/lisa-cursor/scripts/intake-blocker-reprobe.mjs +158 -1
- package/plugins/lisa-cursor/skills/lisa-drive-pr-to-merge/SKILL.md +17 -1
- package/plugins/lisa-cursor/skills/lisa-github-build-intake/SKILL.md +4 -0
- package/plugins/lisa-cursor/skills/lisa-jira-build-intake/SKILL.md +4 -0
- package/plugins/lisa-cursor/skills/lisa-linear-build-intake/SKILL.md +4 -0
- package/plugins/lisa-cursor/skills/lisa-repair-intake/SKILL.md +4 -1
- package/plugins/lisa-expo/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-agy/plugin.json +1 -1
- package/plugins/lisa-expo-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-agy/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-agy/plugin.json +1 -1
- package/plugins/lisa-nestjs-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-agy/plugin.json +1 -1
- package/plugins/lisa-openclaw-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-agy/plugin.json +1 -1
- package/plugins/lisa-phaser-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-agy/plugin.json +1 -1
- package/plugins/lisa-rails-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-agy/plugin.json +1 -1
- package/plugins/lisa-typescript-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-agy/plugin.json +1 -1
- package/plugins/lisa-wiki-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/src/base/hooks/block-direct-issue-create.sh +89 -10
- package/plugins/src/base/hooks/discharge-work-item-gates.sh +7 -1
- package/plugins/src/base/hooks/parity-safety-net.sh +44 -0
- package/plugins/src/base/hooks/threshold-ratchet-families.mjs +12 -0
- package/plugins/src/base/rules/eager/00-rule-index.md +79 -0
- package/plugins/src/base/rules/eager/base-rules.md +10 -0
- package/plugins/src/base/rules/eager/config-resolution.md +1 -88
- package/plugins/src/base/rules/reference/automation-runbook-contract.md +97 -0
- package/plugins/src/base/rules/reference/bdd-e2e-coverage.md +56 -0
- package/plugins/src/base/rules/reference/blocker-containment.md +58 -0
- package/plugins/src/base/rules/reference/claim-archaeology.md +42 -0
- package/plugins/src/base/rules/reference/claim-evidence-mapping.md +83 -0
- package/plugins/src/base/rules/reference/claim-time-guards.md +37 -0
- package/plugins/src/base/rules/reference/config-resolution.md +97 -0
- package/plugins/src/base/rules/reference/control-reachability.md +44 -0
- package/plugins/src/base/rules/reference/convergent-review.md +31 -0
- package/plugins/src/base/rules/reference/credential-substrate-precedence.md +57 -0
- package/plugins/src/base/rules/reference/dependency-decision-records.md +37 -0
- package/plugins/src/base/rules/reference/dependency-internalization-kit.md +47 -0
- package/plugins/src/base/rules/reference/dependency-trust-classes.md +48 -0
- package/plugins/src/base/rules/reference/deployed-state-readback.md +52 -0
- package/plugins/src/base/rules/reference/derived-branch-plan.md +52 -0
- package/plugins/src/base/rules/reference/design-source-of-truth.md +43 -0
- package/plugins/src/base/rules/reference/design-value-binding.md +103 -0
- package/plugins/src/base/rules/reference/documentation-source-paths.md +18 -0
- package/plugins/src/base/rules/reference/leaf-only-lifecycle.md +75 -0
- package/plugins/src/base/rules/reference/observability-audit.md +20 -0
- package/plugins/src/base/rules/reference/prd-definition-of-ready.md +37 -0
- package/plugins/src/base/rules/reference/prd-lifecycle-rollup.md +36 -0
- package/plugins/src/base/rules/reference/pre-flight-autofill.md +88 -0
- package/plugins/src/base/rules/reference/promotion-contract.md +21 -0
- package/plugins/src/base/rules/reference/readiness-rubric.md +63 -0
- package/plugins/src/base/rules/reference/ready-role-filing.md +34 -0
- package/plugins/src/base/rules/reference/rejection-detection.md +69 -0
- package/plugins/src/base/rules/reference/repo-scope-split.md +48 -0
- package/plugins/src/base/rules/reference/reset-seed-coverage.md +55 -0
- package/plugins/src/base/rules/reference/usage-accounting.md +38 -0
- package/plugins/src/base/rules/reference/work-item-definition-of-ready.md +32 -0
- package/plugins/src/base/scripts/intake-blocker-reprobe.mjs +158 -1
- package/plugins/src/base/skills/lisa-drive-pr-to-merge/SKILL.md +17 -1
- package/plugins/src/base/skills/lisa-github-build-intake/SKILL.md +4 -0
- package/plugins/src/base/skills/lisa-jira-build-intake/SKILL.md +4 -0
- package/plugins/src/base/skills/lisa-linear-build-intake/SKILL.md +4 -0
- package/plugins/src/base/skills/lisa-repair-intake/SKILL.md +4 -1
- package/rails/copy-overwrite/ast-grep/rules/no-day-truncating-file-age-predicate.yml +50 -0
- package/rails/copy-overwrite/scripts/threshold-ratchet-families.mjs +12 -0
- package/scripts/check-eager-rule-budget.mjs +176 -0
- package/scripts/check-generated-artifact-merge-coverage.mjs +7 -0
- package/scripts/check-rules-pairing.sh +45 -14
- package/scripts/check-shipped-surface-removals.mjs +851 -0
- package/scripts/generate-export-surface.mjs +318 -0
- package/scripts/lib/shipped-surface.mjs +212 -0
- package/scripts/lisa-enforcement-fallback.sh +178 -1
- package/scripts/remedy-conformance.mjs +435 -0
- package/scripts/two-channel-couplings.json +2 -2
- package/typescript/copy-contents/.husky/pre-push +147 -2
- package/typescript/copy-overwrite/ast-grep/rules/no-day-truncating-file-age-predicate.yml +50 -0
- package/typescript/copy-overwrite/audit.ignore.config.json +0 -10
- package/typescript/copy-overwrite/scripts/lisa-mutation.mjs +180 -29
- package/typescript/copy-overwrite/scripts/threshold-ratchet-families.mjs +12 -0
- package/typescript/package-lisa/package.lisa.json +72 -42
- package/plugins/lisa/rules/eager/automation-runbook-contract.md +0 -92
- package/plugins/lisa/rules/eager/bdd-e2e-coverage.md +0 -51
- package/plugins/lisa/rules/eager/blocker-containment.md +0 -53
- package/plugins/lisa/rules/eager/claim-archaeology.md +0 -37
- package/plugins/lisa/rules/eager/claim-evidence-mapping.md +0 -78
- package/plugins/lisa/rules/eager/claim-time-guards.md +0 -32
- package/plugins/lisa/rules/eager/control-reachability.md +0 -39
- package/plugins/lisa/rules/eager/convergent-review.md +0 -24
- package/plugins/lisa/rules/eager/credential-substrate-precedence.md +0 -54
- package/plugins/lisa/rules/eager/dependency-decision-records.md +0 -32
- package/plugins/lisa/rules/eager/dependency-internalization-kit.md +0 -42
- package/plugins/lisa/rules/eager/dependency-trust-classes.md +0 -43
- package/plugins/lisa/rules/eager/deployed-state-readback.md +0 -47
- package/plugins/lisa/rules/eager/derived-branch-plan.md +0 -47
- package/plugins/lisa/rules/eager/design-source-of-truth.md +0 -38
- package/plugins/lisa/rules/eager/design-value-binding.md +0 -98
- package/plugins/lisa/rules/eager/documentation-source-paths.md +0 -13
- package/plugins/lisa/rules/eager/factory-model.md +0 -41
- package/plugins/lisa/rules/eager/leaf-only-lifecycle.md +0 -70
- package/plugins/lisa/rules/eager/observability-audit.md +0 -15
- package/plugins/lisa/rules/eager/prd-definition-of-ready.md +0 -32
- package/plugins/lisa/rules/eager/prd-lifecycle-rollup.md +0 -31
- package/plugins/lisa/rules/eager/pre-flight-autofill.md +0 -84
- package/plugins/lisa/rules/eager/project-learnings.md +0 -22
- package/plugins/lisa/rules/eager/promotion-contract.md +0 -18
- package/plugins/lisa/rules/eager/readiness-rubric.md +0 -58
- package/plugins/lisa/rules/eager/ready-role-filing.md +0 -29
- package/plugins/lisa/rules/eager/rejection-detection.md +0 -64
- package/plugins/lisa/rules/eager/repo-scope-split.md +0 -43
- package/plugins/lisa/rules/eager/reset-seed-coverage.md +0 -50
- package/plugins/lisa/rules/eager/usage-accounting.md +0 -33
- package/plugins/lisa/rules/eager/work-item-definition-of-ready.md +0 -27
- package/plugins/lisa-copilot/rules/eager/automation-runbook-contract.md +0 -92
- package/plugins/lisa-copilot/rules/eager/bdd-e2e-coverage.md +0 -51
- package/plugins/lisa-copilot/rules/eager/blocker-containment.md +0 -53
- package/plugins/lisa-copilot/rules/eager/claim-archaeology.md +0 -37
- package/plugins/lisa-copilot/rules/eager/claim-evidence-mapping.md +0 -78
- package/plugins/lisa-copilot/rules/eager/claim-time-guards.md +0 -32
- package/plugins/lisa-copilot/rules/eager/control-reachability.md +0 -39
- package/plugins/lisa-copilot/rules/eager/convergent-review.md +0 -24
- package/plugins/lisa-copilot/rules/eager/credential-substrate-precedence.md +0 -54
- package/plugins/lisa-copilot/rules/eager/dependency-decision-records.md +0 -32
- package/plugins/lisa-copilot/rules/eager/dependency-internalization-kit.md +0 -42
- package/plugins/lisa-copilot/rules/eager/dependency-trust-classes.md +0 -43
- package/plugins/lisa-copilot/rules/eager/deployed-state-readback.md +0 -47
- package/plugins/lisa-copilot/rules/eager/derived-branch-plan.md +0 -47
- package/plugins/lisa-copilot/rules/eager/design-source-of-truth.md +0 -38
- package/plugins/lisa-copilot/rules/eager/design-value-binding.md +0 -98
- package/plugins/lisa-copilot/rules/eager/documentation-source-paths.md +0 -13
- package/plugins/lisa-copilot/rules/eager/factory-model.md +0 -41
- package/plugins/lisa-copilot/rules/eager/leaf-only-lifecycle.md +0 -70
- package/plugins/lisa-copilot/rules/eager/observability-audit.md +0 -15
- package/plugins/lisa-copilot/rules/eager/prd-definition-of-ready.md +0 -32
- package/plugins/lisa-copilot/rules/eager/prd-lifecycle-rollup.md +0 -31
- package/plugins/lisa-copilot/rules/eager/pre-flight-autofill.md +0 -84
- package/plugins/lisa-copilot/rules/eager/project-learnings.md +0 -22
- package/plugins/lisa-copilot/rules/eager/promotion-contract.md +0 -18
- package/plugins/lisa-copilot/rules/eager/readiness-rubric.md +0 -58
- package/plugins/lisa-copilot/rules/eager/ready-role-filing.md +0 -29
- package/plugins/lisa-copilot/rules/eager/rejection-detection.md +0 -64
- package/plugins/lisa-copilot/rules/eager/repo-scope-split.md +0 -43
- package/plugins/lisa-copilot/rules/eager/reset-seed-coverage.md +0 -50
- package/plugins/lisa-copilot/rules/eager/usage-accounting.md +0 -33
- package/plugins/lisa-copilot/rules/eager/work-item-definition-of-ready.md +0 -27
- package/plugins/lisa-cursor/rules/automation-runbook-contract.mdc +0 -97
- package/plugins/lisa-cursor/rules/bdd-e2e-coverage.mdc +0 -56
- package/plugins/lisa-cursor/rules/blocker-containment.mdc +0 -58
- package/plugins/lisa-cursor/rules/claim-archaeology.mdc +0 -42
- package/plugins/lisa-cursor/rules/claim-evidence-mapping.mdc +0 -83
- package/plugins/lisa-cursor/rules/claim-time-guards.mdc +0 -37
- package/plugins/lisa-cursor/rules/control-reachability.mdc +0 -44
- package/plugins/lisa-cursor/rules/convergent-review.mdc +0 -29
- package/plugins/lisa-cursor/rules/credential-substrate-precedence.mdc +0 -59
- package/plugins/lisa-cursor/rules/dependency-decision-records.mdc +0 -37
- package/plugins/lisa-cursor/rules/dependency-internalization-kit.mdc +0 -47
- package/plugins/lisa-cursor/rules/dependency-trust-classes.mdc +0 -48
- package/plugins/lisa-cursor/rules/deployed-state-readback.mdc +0 -52
- package/plugins/lisa-cursor/rules/derived-branch-plan.mdc +0 -52
- package/plugins/lisa-cursor/rules/design-source-of-truth.mdc +0 -43
- package/plugins/lisa-cursor/rules/design-value-binding.mdc +0 -103
- package/plugins/lisa-cursor/rules/documentation-source-paths.mdc +0 -18
- package/plugins/lisa-cursor/rules/factory-model.mdc +0 -46
- package/plugins/lisa-cursor/rules/leaf-only-lifecycle.mdc +0 -75
- package/plugins/lisa-cursor/rules/observability-audit.mdc +0 -20
- package/plugins/lisa-cursor/rules/prd-definition-of-ready.mdc +0 -37
- package/plugins/lisa-cursor/rules/prd-lifecycle-rollup.mdc +0 -36
- package/plugins/lisa-cursor/rules/pre-flight-autofill.mdc +0 -89
- package/plugins/lisa-cursor/rules/project-learnings.mdc +0 -27
- package/plugins/lisa-cursor/rules/promotion-contract.mdc +0 -23
- package/plugins/lisa-cursor/rules/readiness-rubric.mdc +0 -63
- package/plugins/lisa-cursor/rules/ready-role-filing.mdc +0 -34
- package/plugins/lisa-cursor/rules/rejection-detection.mdc +0 -69
- package/plugins/lisa-cursor/rules/repo-scope-split.mdc +0 -48
- package/plugins/lisa-cursor/rules/reset-seed-coverage.mdc +0 -55
- package/plugins/lisa-cursor/rules/usage-accounting.mdc +0 -38
- package/plugins/lisa-cursor/rules/work-item-definition-of-ready.mdc +0 -32
- package/plugins/src/base/rules/eager/automation-runbook-contract.md +0 -92
- package/plugins/src/base/rules/eager/bdd-e2e-coverage.md +0 -51
- package/plugins/src/base/rules/eager/blocker-containment.md +0 -53
- package/plugins/src/base/rules/eager/claim-archaeology.md +0 -37
- package/plugins/src/base/rules/eager/claim-evidence-mapping.md +0 -78
- package/plugins/src/base/rules/eager/claim-time-guards.md +0 -32
- package/plugins/src/base/rules/eager/control-reachability.md +0 -39
- package/plugins/src/base/rules/eager/convergent-review.md +0 -24
- package/plugins/src/base/rules/eager/credential-substrate-precedence.md +0 -54
- package/plugins/src/base/rules/eager/dependency-decision-records.md +0 -32
- package/plugins/src/base/rules/eager/dependency-internalization-kit.md +0 -42
- package/plugins/src/base/rules/eager/dependency-trust-classes.md +0 -43
- package/plugins/src/base/rules/eager/deployed-state-readback.md +0 -47
- package/plugins/src/base/rules/eager/derived-branch-plan.md +0 -47
- package/plugins/src/base/rules/eager/design-source-of-truth.md +0 -38
- package/plugins/src/base/rules/eager/design-value-binding.md +0 -98
- package/plugins/src/base/rules/eager/documentation-source-paths.md +0 -13
- package/plugins/src/base/rules/eager/factory-model.md +0 -41
- package/plugins/src/base/rules/eager/leaf-only-lifecycle.md +0 -70
- package/plugins/src/base/rules/eager/observability-audit.md +0 -15
- package/plugins/src/base/rules/eager/prd-definition-of-ready.md +0 -32
- package/plugins/src/base/rules/eager/prd-lifecycle-rollup.md +0 -31
- package/plugins/src/base/rules/eager/pre-flight-autofill.md +0 -84
- package/plugins/src/base/rules/eager/project-learnings.md +0 -22
- package/plugins/src/base/rules/eager/promotion-contract.md +0 -18
- package/plugins/src/base/rules/eager/readiness-rubric.md +0 -58
- package/plugins/src/base/rules/eager/ready-role-filing.md +0 -29
- package/plugins/src/base/rules/eager/rejection-detection.md +0 -64
- package/plugins/src/base/rules/eager/repo-scope-split.md +0 -43
- package/plugins/src/base/rules/eager/reset-seed-coverage.md +0 -50
- package/plugins/src/base/rules/eager/usage-accounting.md +0 -33
- package/plugins/src/base/rules/eager/work-item-definition-of-ready.md +0 -27
|
@@ -231,6 +231,10 @@ other gate's verdict — however conclusive — may promote an item a person par
|
|
|
231
231
|
4. **Name it in the cycle summary** via `summarizeHumanGateHolds([...])`, so the record
|
|
232
232
|
distinguishes "nothing was eligible" from "something eligible was held for a person". A lane
|
|
233
233
|
mutation nobody can see afterwards is the same class of problem this gate exists to fix.
|
|
234
|
+
Report alongside it what the precision rule SKIPPED, via `summarizeHumanGateMentions(n)`
|
|
235
|
+
— the marker occurrences that were mentions rather than declarations (CodySwannGT/lisa#3815).
|
|
236
|
+
A rule that quietly declines to honour half the occurrences it sees reads exactly like a
|
|
237
|
+
rule that saw none, so the count is printed even when it is zero.
|
|
234
238
|
5. **Continue to the next candidate.** A held item does not end the cycle.
|
|
235
239
|
|
|
236
240
|
|
|
@@ -994,7 +994,10 @@ with labels like `build-ready`, or with no Lisa status label at all, that are in
|
|
|
994
994
|
instead — it says that nothing was changed and how a person resumes the item, which is the
|
|
995
995
|
opposite of what the reconciliation note says and must not be substituted for it. A promotion
|
|
996
996
|
declined silently is invisible, which is the quieter version of the failure this step exists to
|
|
997
|
-
prevent, so name every held item in the cycle summary via `summarizeHumanGateHolds([...])`.
|
|
997
|
+
prevent, so name every held item in the cycle summary via `summarizeHumanGateHolds([...])`. Report what the
|
|
998
|
+
precision rule skipped beside it via `summarizeHumanGateMentions(n)`: the marker
|
|
999
|
+
occurrences that were mentions rather than declarations (CodySwannGT/lisa#3815),
|
|
1000
|
+
because a rule that silently drops candidates reads like one that found none.
|
|
998
1001
|
|
|
999
1002
|
### Ungated non-ready filing → surface as an incomplete handoff (read-only)
|
|
1000
1003
|
|
|
@@ -494,6 +494,82 @@ project_dir = os.environ.get("LISA_GUARD_PROJECT_DIR", "")
|
|
|
494
494
|
OVERRIDE_NAME = "LISA_ALLOW_DIRECT_ISSUE_CREATE"
|
|
495
495
|
HUMAN_GATE_MARKER = "[lisa-human-gate]"
|
|
496
496
|
|
|
497
|
+
# Decoration a hold declaration may sit behind, and nothing more: whitespace,
|
|
498
|
+
# blockquote arrows, list bullets or numbers, emphasis, an opening HTML
|
|
499
|
+
# comment. One character class plus two optional groups, deliberately not a
|
|
500
|
+
# nested quantifier — this runs over untrusted issue bodies.
|
|
501
|
+
HUMAN_GATE_DECORATION = re.compile(r"^[ \t>*_+#-]*(?:\d+[.)][ \t]*)?(?:<!--[ \t]*)?[ \t]*")
|
|
502
|
+
HUMAN_GATE_FENCE = re.compile(r"```.*?```", re.DOTALL)
|
|
503
|
+
HUMAN_GATE_CODE_SPAN = re.compile(r"`[^`\n]*`")
|
|
504
|
+
|
|
505
|
+
|
|
506
|
+
def declares_human_gate(text):
|
|
507
|
+
"""Whether a text DECLARES a hold rather than mentioning one.
|
|
508
|
+
|
|
509
|
+
The comment this replaces said the marker is matched anywhere because it
|
|
510
|
+
"has no other meaning, so its presence in the title or body IS the
|
|
511
|
+
declaration". That was true when written and is false now: the marker
|
|
512
|
+
acquired a second meaning -- being discussed -- the moment the feature
|
|
513
|
+
became something people file tickets about, and a ticket about the marker
|
|
514
|
+
then declares a hold on itself (CodySwannGT/lisa#3815).
|
|
515
|
+
|
|
516
|
+
A declaration is POSITIONAL: the marker leads its line, behind at most the
|
|
517
|
+
decoration above, with fenced blocks and inline code spans removed first
|
|
518
|
+
because that is how the marker is written ABOUT. The same rule the intake
|
|
519
|
+
matcher applies, so the two surfaces cannot disagree about one body.
|
|
520
|
+
|
|
521
|
+
NOTE the direction here differs from the intake matcher's. There a match
|
|
522
|
+
HOLDS an item, so a false positive parks work. Here a match ADMITS a
|
|
523
|
+
filing, so a false positive is a hole -- which makes this the tightening
|
|
524
|
+
direction on both sides at once.
|
|
525
|
+
|
|
526
|
+
Args:
|
|
527
|
+
text: Any candidate text -- one argv value, a body file, a payload.
|
|
528
|
+
|
|
529
|
+
Returns:
|
|
530
|
+
True when some line of the text declares a hold.
|
|
531
|
+
"""
|
|
532
|
+
if not text:
|
|
533
|
+
return False
|
|
534
|
+
body = HUMAN_GATE_CODE_SPAN.sub("", HUMAN_GATE_FENCE.sub("", str(text)))
|
|
535
|
+
for line in body.split("\n"):
|
|
536
|
+
if HUMAN_GATE_DECORATION.sub("", line, count=1).startswith(
|
|
537
|
+
HUMAN_GATE_MARKER
|
|
538
|
+
):
|
|
539
|
+
return True
|
|
540
|
+
if _comment_carries_marker(line):
|
|
541
|
+
return True
|
|
542
|
+
return False
|
|
543
|
+
|
|
544
|
+
|
|
545
|
+
def _comment_carries_marker(line):
|
|
546
|
+
"""Whether an HTML comment on this line carries the marker.
|
|
547
|
+
|
|
548
|
+
The second accepted form, and the one this guard needs most: its inputs
|
|
549
|
+
are not markdown documents. A `--body` value is a single line, and a shell
|
|
550
|
+
script writes its declaration as `# <!-- ... -->`, so a purely
|
|
551
|
+
line-leading rule would refuse two declarations people have already
|
|
552
|
+
written -- both of which are in this repository's own test corpus.
|
|
553
|
+
|
|
554
|
+
It is not a loosening. An HTML comment is invisible when rendered, so
|
|
555
|
+
nobody wraps one around the marker in order to TALK about it; a quotation
|
|
556
|
+
has to be visible to be a quotation. Measured over this repository's 42
|
|
557
|
+
matching issue bodies, adding this branch changes not one verdict.
|
|
558
|
+
|
|
559
|
+
Args:
|
|
560
|
+
line: One line of text.
|
|
561
|
+
|
|
562
|
+
Returns:
|
|
563
|
+
True when some comment on the line contains the marker.
|
|
564
|
+
"""
|
|
565
|
+
segments = line.split("<!--")
|
|
566
|
+
for segment in segments[1:]:
|
|
567
|
+
close = segment.find("-->")
|
|
568
|
+
inside = segment if close == -1 else segment[:close]
|
|
569
|
+
if HUMAN_GATE_MARKER in inside:
|
|
570
|
+
return True
|
|
571
|
+
return False
|
|
572
|
+
|
|
497
573
|
# ---------------------------------------------------------------------------
|
|
498
574
|
# WHY THIS IS A TOKEN SCAN AND NOT A PROGRAM RESOLVER
|
|
499
575
|
#
|
|
@@ -580,7 +656,7 @@ LABEL_FLAGS = {"--label", "--labels", "--add-label", "--status", "--state"}
|
|
|
580
656
|
# None — container: state rolls up from children
|
|
581
657
|
#
|
|
582
658
|
# It is a marker with no other meaning, so it is matched wherever the payload
|
|
583
|
-
# reaches —
|
|
659
|
+
# reaches — the asymmetry `HUMAN_GATE_MARKER` gets, and for the related
|
|
584
660
|
# reason. Reading the declaration the writer already emits is also what keeps
|
|
585
661
|
# the guard and the skill from drifting apart a second time: there is one
|
|
586
662
|
# string, defined in one rule, and both read it.
|
|
@@ -1223,7 +1299,7 @@ def text_declares_readiness(text):
|
|
|
1223
1299
|
Returns:
|
|
1224
1300
|
True when the text declares build-ready or a human gate.
|
|
1225
1301
|
"""
|
|
1226
|
-
if
|
|
1302
|
+
if declares_human_gate(text):
|
|
1227
1303
|
return True
|
|
1228
1304
|
for role in (ready_role, upstream_ready_role, default_ready_role):
|
|
1229
1305
|
if not role:
|
|
@@ -1267,7 +1343,7 @@ def scope_declaration(text, state_role_ok):
|
|
|
1267
1343
|
Returns:
|
|
1268
1344
|
True when the text carries a whole-scope declaration.
|
|
1269
1345
|
"""
|
|
1270
|
-
if
|
|
1346
|
+
if declares_human_gate(text):
|
|
1271
1347
|
return True
|
|
1272
1348
|
return bool(state_role_ok and LIFECYCLE_ROLE_READY.search(text))
|
|
1273
1349
|
|
|
@@ -1497,20 +1573,23 @@ def declares_readiness(raw_args, roles, extra="", state_role_ok=False):
|
|
|
1497
1573
|
candidates = [part.strip().strip("'\"") for part in raw.split(",")]
|
|
1498
1574
|
if role in candidates:
|
|
1499
1575
|
return True
|
|
1500
|
-
#
|
|
1501
|
-
#
|
|
1502
|
-
#
|
|
1503
|
-
#
|
|
1504
|
-
|
|
1576
|
+
# Checked per ARGV VALUE rather than against `" ".join(args)`, and that is
|
|
1577
|
+
# what makes the positional rule mean anything here. Joining first destroys
|
|
1578
|
+
# position: after a join, no value's line start survives except the first
|
|
1579
|
+
# argument's, so "the marker leads its line" would be decided by argument
|
|
1580
|
+
# order. A `--title` value is its own single line, which is exactly the
|
|
1581
|
+
# unit the rule is about -- and titles must keep being read, since this
|
|
1582
|
+
# guard reads them and the intake matcher does not.
|
|
1583
|
+
if any(declares_human_gate(value) for value in args):
|
|
1505
1584
|
return True
|
|
1506
1585
|
for path in body_file_paths(args):
|
|
1507
1586
|
try:
|
|
1508
1587
|
with open(path, encoding="utf-8", errors="replace") as handle:
|
|
1509
|
-
if
|
|
1588
|
+
if declares_human_gate(handle.read()):
|
|
1510
1589
|
return True
|
|
1511
1590
|
except OSError:
|
|
1512
1591
|
continue
|
|
1513
|
-
if extra
|
|
1592
|
+
if declares_human_gate(extra):
|
|
1514
1593
|
return True
|
|
1515
1594
|
# The state-based path. Scoped by `state_role_ok` rather than checked
|
|
1516
1595
|
# unconditionally, so this adds a compliant command where none existed and
|
|
@@ -31,8 +31,14 @@ COMMAND="$(printf '%s' "$JSON_INPUT" | jq -r '.tool_input.command // empty' 2>/d
|
|
|
31
31
|
|
|
32
32
|
# `gh pr create` opens one; `gh pr edit` is the other way a body comes to carry
|
|
33
33
|
# — or lose — its declaration. Both change the answer to gate 4.
|
|
34
|
+
#
|
|
35
|
+
# `gh pr reopen` is here because a work item can hold more than one pull
|
|
36
|
+
# request, and a reopened one is a named case: it was closed, so nothing has
|
|
37
|
+
# discharged its gates since, and it is now live again with no CI run to reveal
|
|
38
|
+
# that. Its backlink no longer displaces anyone else's, so re-running the
|
|
39
|
+
# discharge for it is free (CodySwannGT/lisa#3916).
|
|
34
40
|
case "$COMMAND" in
|
|
35
|
-
*"gh pr create"* | *"gh pr edit"*) ;;
|
|
41
|
+
*"gh pr create"* | *"gh pr edit"* | *"gh pr reopen"*) ;;
|
|
36
42
|
*) exit 0 ;;
|
|
37
43
|
esac
|
|
38
44
|
|
|
@@ -26,6 +26,11 @@
|
|
|
26
26
|
# divergence: upstream blocks unconditionally; Lisa allows clean-tree resets.
|
|
27
27
|
# Residual risk (documented, accepted): the dirty check runs in the hook's
|
|
28
28
|
# cwd at hook time, so a `cd elsewhere && git reset --hard` evades it.
|
|
29
|
+
# - `git read-tree` with an update flag AND `--reset` while the working tree
|
|
30
|
+
# is dirty (issue #3978): the plumbing spelling of the same discard, on the
|
|
31
|
+
# same condition, printing the same remedy. Index-only `read-tree`, and
|
|
32
|
+
# `read-tree -m -u` without `--reset` (which git itself refuses rather than
|
|
33
|
+
# clobber a modified file), stay allowed. Lisa-only guard.
|
|
29
34
|
# - `git rebase --abort`/`--quit` while the in-progress rebase holds
|
|
30
35
|
# human-made conflict resolutions (AUTO_MERGE discriminator; issue #1956).
|
|
31
36
|
# Clean or untouched rebase state stays abortable; the apply backend and a
|
|
@@ -1819,6 +1824,45 @@ $DESTRUCTIVE_GUIDANCE"
|
|
|
1819
1824
|
fi
|
|
1820
1825
|
fi
|
|
1821
1826
|
|
|
1827
|
+
# 3a. `git read-tree` with BOTH an update flag and `--reset`, on the same dirty
|
|
1828
|
+
# tree — the plumbing spelling of guard 3 (issue #3978). It resets the index
|
|
1829
|
+
# and writes the result into the working tree, discarding tracked
|
|
1830
|
+
# modifications: the identical destruction, reached through a command that
|
|
1831
|
+
# carries no `--hard` and no `reset` subcommand, so every pattern in
|
|
1832
|
+
# guard 3 misses it. A guard an agent can walk around is a guard that stops
|
|
1833
|
+
# the honest caller and not the one looking for a way through, and this
|
|
1834
|
+
# spelling is strictly worse than the blocked one — it discards WITHOUT
|
|
1835
|
+
# preserving, which is exactly the property guard 3's remedy supplies. Both
|
|
1836
|
+
# refusals therefore print the same $PRESERVE_GUIDANCE, so what they teach
|
|
1837
|
+
# cannot drift apart.
|
|
1838
|
+
#
|
|
1839
|
+
# `--reset` is the discriminator, not `-u`, and the pairing is deliberate:
|
|
1840
|
+
#
|
|
1841
|
+
# - `read-tree` with no update flag touches the INDEX only and destroys
|
|
1842
|
+
# nothing in the working tree, so a blanket `read-tree` block would be
|
|
1843
|
+
# over-broad.
|
|
1844
|
+
# - `read-tree -m -u` (a merge without `--reset`) is safe by git's own
|
|
1845
|
+
# construction: it REFUSES rather than overwrite a locally modified file
|
|
1846
|
+
# ("entry would be overwritten by merge"). `--reset` is precisely the flag
|
|
1847
|
+
# that switches that refusal off.
|
|
1848
|
+
#
|
|
1849
|
+
# So the destructive combination is an update flag AND `--reset` together,
|
|
1850
|
+
# in either order. The update flag is matched in the checkout guard's idiom
|
|
1851
|
+
# so a bundled short option (`-iu`) cannot dodge the anchor, with leading
|
|
1852
|
+
# whitespace required so a `--index-output=/tmp/out-u` style value cannot
|
|
1853
|
+
# read as the flag. Same conditional dirty-tree shape and same accepted
|
|
1854
|
+
# residual risk as guard 3: the probe runs in the hook's cwd at hook time.
|
|
1855
|
+
readonly GIT_READ_TREE="${GIT_CMD}read-tree"
|
|
1856
|
+
if matches "${GIT_READ_TREE}"'[^;&|]*[[:space:]]--reset([[:space:]]|$)' \
|
|
1857
|
+
&& matches "${GIT_READ_TREE}"'[^;&|]*[[:space:]](-[[:alnum:]]*u[[:alnum:]]*|--update)([[:space:]]|=|$)'; then
|
|
1858
|
+
if git rev-parse --is-inside-work-tree >/dev/null 2>&1 \
|
|
1859
|
+
&& [ -n "$(git status --porcelain 2>/dev/null)" ]; then
|
|
1860
|
+
block "git read-tree -u --reset on a dirty working tree would discard uncommitted changes (commit first, or preserve as below)" "$PRESERVE_GUIDANCE
|
|
1861
|
+
|
|
1862
|
+
$DESTRUCTIVE_GUIDANCE"
|
|
1863
|
+
fi
|
|
1864
|
+
fi
|
|
1865
|
+
|
|
1822
1866
|
# 3b. `git rebase --abort` / `--quit` ONLY while human/agent conflict
|
|
1823
1867
|
# resolutions exist (issue #1956). `--abort` restores the pre-rebase branch
|
|
1824
1868
|
# and discards every resolution; `--quit` deletes the rebase bookkeeping
|
|
@@ -72,6 +72,18 @@ export const FAMILIES = [
|
|
|
72
72
|
match: /(^|\/)\.github\/k6\/thresholds\/[^/]+\.json$/,
|
|
73
73
|
kind: "k6",
|
|
74
74
|
},
|
|
75
|
+
{
|
|
76
|
+
// #3992. The always-on eager rule tier is concatenated into every session
|
|
77
|
+
// AND every subagent start, so its byte ceiling is a quality threshold like
|
|
78
|
+
// any other. `max` because the number is a ceiling: lowering it tightens the
|
|
79
|
+
// gate and is free, raising it re-authorises context the cleanup removed and
|
|
80
|
+
// is the change a human has to see. The tier was cut to 26,540 bytes once
|
|
81
|
+
// and regrew to 201,083 in fourteen weeks with nothing watching it.
|
|
82
|
+
id: "eager-rules",
|
|
83
|
+
match: /(^|\/)eager-rules\.thresholds\.json$/,
|
|
84
|
+
kind: "json-num",
|
|
85
|
+
direction: "max",
|
|
86
|
+
},
|
|
75
87
|
{
|
|
76
88
|
id: "lisa-config",
|
|
77
89
|
match: /(^|\/)\.lisa\.config\.json$/,
|
|
@@ -0,0 +1,84 @@
|
|
|
1
|
+
---
|
|
2
|
+
description: "Rule Index — What Exists, and Where to Read It"
|
|
3
|
+
alwaysApply: true
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Rule Index — What Exists, and Where to Read It
|
|
7
|
+
|
|
8
|
+
The rules below are **not loaded**. Each is a full contract that other rules,
|
|
9
|
+
skills, and work items cite **by slug** ("per the `bdd-e2e-coverage` rule").
|
|
10
|
+
When you meet a slug and need the contract behind it, read that file — do not
|
|
11
|
+
re-derive the contract, and do not restate it where you cite it.
|
|
12
|
+
|
|
13
|
+
Read one when you are doing the thing it governs. Reading none of them is the
|
|
14
|
+
normal case for a session, which is why they are here rather than in your
|
|
15
|
+
context: the eager tier was cut to 26,540 bytes in May 2026 and had regrown to
|
|
16
|
+
201,083 by September, at which point every session and **every subagent** paid
|
|
17
|
+
~50,000 tokens before its first tool call (CodySwannGT/lisa#3992).
|
|
18
|
+
|
|
19
|
+
Paths are relative to this file.
|
|
20
|
+
|
|
21
|
+
## Work-item authoring, validation, and lifecycle
|
|
22
|
+
|
|
23
|
+
| Slug | Read it when | Body |
|
|
24
|
+
|---|---|---|
|
|
25
|
+
| `work-item-definition-of-ready` | authoring or validating a leaf; gates S1–S16 | [../reference/work-item-definition-of-ready.md](work-item-definition-of-ready-reference.mdc) |
|
|
26
|
+
| `leaf-only-lifecycle` | applying a lifecycle role, or rolling a parent up | [../reference/leaf-only-lifecycle.md](leaf-only-lifecycle-reference.mdc) |
|
|
27
|
+
| `ready-role-filing` | filing any work item (enforced by `block-direct-issue-create.sh`) | [../reference/ready-role-filing.md](ready-role-filing-reference.mdc) |
|
|
28
|
+
| `repo-scope-split` | a leaf spans repos; gate S10, decomposition step 1.5 | [../reference/repo-scope-split.md](repo-scope-split-reference.mdc) |
|
|
29
|
+
| `derived-branch-plan` | rendering or validating a Branch Plan; gate S19 | [../reference/derived-branch-plan.md](derived-branch-plan-reference.mdc) |
|
|
30
|
+
| `control-reachability` | an item names an existing test as a red-before-green control; gate S20 | [../reference/control-reachability.md](control-reachability-reference.mdc) |
|
|
31
|
+
| `pre-flight-autofill` | the pre-flight gate returned FAIL on ticket quality | [../reference/pre-flight-autofill.md](pre-flight-autofill-reference.mdc) |
|
|
32
|
+
| `blocker-containment` | deciding whether an `is blocked by` dependency is cleared | [../reference/blocker-containment.md](blocker-containment-reference.mdc) |
|
|
33
|
+
| `deployed-state-readback` | authoring a ticket asserting something is missing from a running system | [../reference/deployed-state-readback.md](deployed-state-readback-reference.mdc) |
|
|
34
|
+
| `prd-definition-of-ready` | authoring or validating a PRD's requirement atoms | [../reference/prd-definition-of-ready.md](prd-definition-of-ready-reference.mdc) |
|
|
35
|
+
| `prd-lifecycle-rollup` | rolling a PRD up from its generated top-level work | [../reference/prd-lifecycle-rollup.md](prd-lifecycle-rollup-reference.mdc) |
|
|
36
|
+
| `usage-accounting` | writing the managed `## Lisa Usage` section on an artifact | [../reference/usage-accounting.md](usage-accounting-reference.mdc) |
|
|
37
|
+
|
|
38
|
+
## Build-intake claim time
|
|
39
|
+
|
|
40
|
+
| Slug | Read it when | Body |
|
|
41
|
+
|---|---|---|
|
|
42
|
+
| `rejection-detection` | claiming a ready item (step 3b, before the relabel) | [../reference/rejection-detection.md](rejection-detection-reference.mdc) |
|
|
43
|
+
| `claim-archaeology` | claiming a ready item, after rejection detection | [../reference/claim-archaeology.md](claim-archaeology-reference.mdc) |
|
|
44
|
+
| `claim-time-guards` | claiming a ready item: already-implemented, two-failed-attempts | [../reference/claim-time-guards.md](claim-time-guards-reference.mdc) |
|
|
45
|
+
|
|
46
|
+
## Coverage and evidence contracts
|
|
47
|
+
|
|
48
|
+
| Slug | Read it when | Body |
|
|
49
|
+
|---|---|---|
|
|
50
|
+
| `bdd-e2e-coverage` | the work item adds or changes a user-observable surface | [../reference/bdd-e2e-coverage.md](bdd-e2e-coverage-reference.mdc) |
|
|
51
|
+
| `reset-seed-coverage` | the work item adds or changes persistent state | [../reference/reset-seed-coverage.md](reset-seed-coverage-reference.mdc) |
|
|
52
|
+
| `claim-evidence-mapping` | citing evidence for a claim, or reviewing evidence someone cited | [../reference/claim-evidence-mapping.md](claim-evidence-mapping-reference.mdc) |
|
|
53
|
+
| `observability-audit` | running the `lisa-monitor` audit-and-file arm | [../reference/observability-audit.md](observability-audit-reference.mdc) |
|
|
54
|
+
| `readiness-rubric` | judging whether an unattended fleet may run in a repository | [../reference/readiness-rubric.md](readiness-rubric-reference.mdc) |
|
|
55
|
+
|
|
56
|
+
## Design
|
|
57
|
+
|
|
58
|
+
| Slug | Read it when | Body |
|
|
59
|
+
|---|---|---|
|
|
60
|
+
| `design-value-binding` | implementing a UI surface in a project with a configured design source | [../reference/design-value-binding.md](design-value-binding-reference.mdc) |
|
|
61
|
+
| `design-source-of-truth` | a change touches any UI surface | [../reference/design-source-of-truth.md](design-source-of-truth-reference.mdc) |
|
|
62
|
+
|
|
63
|
+
## Dependencies
|
|
64
|
+
|
|
65
|
+
| Slug | Read it when | Body |
|
|
66
|
+
|---|---|---|
|
|
67
|
+
| `dependency-trust-classes` | adding or major-upgrading a material dependency | [../reference/dependency-trust-classes.md](dependency-trust-classes-reference.mdc) |
|
|
68
|
+
| `dependency-decision-records` | adding, upgrading, or removing a material dependency | [../reference/dependency-decision-records.md](dependency-decision-records-reference.mdc) |
|
|
69
|
+
| `dependency-internalization-kit` | removing, replacing, or internalizing a dependency | [../reference/dependency-internalization-kit.md](dependency-internalization-kit-reference.mdc) |
|
|
70
|
+
|
|
71
|
+
## Process, review, and access
|
|
72
|
+
|
|
73
|
+
| Slug | Read it when | Body |
|
|
74
|
+
|---|---|---|
|
|
75
|
+
| `automation-runbook-contract` | registering a loop, or ending any flow with its run outcome | [../reference/automation-runbook-contract.md](automation-runbook-contract-reference.mdc) |
|
|
76
|
+
| `convergent-review` | reviewing a PR or resolving review findings | [../reference/convergent-review.md](convergent-review-reference.mdc) |
|
|
77
|
+
| `credential-substrate-precedence` | writing or editing an `*-access` skill | [../reference/credential-substrate-precedence.md](credential-substrate-precedence-reference.mdc) |
|
|
78
|
+
| `promotion-contract` | implementing a learnings-ladder promotion ticket | [../reference/promotion-contract.md](promotion-contract-reference.mdc) |
|
|
79
|
+
| `documentation-source-paths` | moving, absorbing, or deleting a docs-like directory | [../reference/documentation-source-paths.md](documentation-source-paths-reference.mdc) |
|
|
80
|
+
| `project-learnings` | you need the learnings ledger's entry schema and field semantics | [../reference/project-learnings.md](project-learnings-reference.mdc) |
|
|
81
|
+
| `factory-model` | you need the shape of the factory model, not its obligations | [../reference/factory-model.md](factory-model-reference.mdc) |
|
|
82
|
+
|
|
83
|
+
The obligations that follow from `factory-model` are in `base-rules`, which is
|
|
84
|
+
eager. This entry is the exposition behind them.
|
|
@@ -5,6 +5,103 @@ alwaysApply: false
|
|
|
5
5
|
|
|
6
6
|
# Automation Runbook Contract
|
|
7
7
|
|
|
8
|
+
> Demoted from the always-on eager tier by CodySwannGT/lisa#3992. The
|
|
9
|
+
> section below is the former eager head, preserved verbatim; the full
|
|
10
|
+
> contract follows it. Reachable on demand via `rules/eager/00-rule-index.md`.
|
|
11
|
+
|
|
12
|
+
## Automation Runbook Contract (load-bearing)
|
|
13
|
+
|
|
14
|
+
**Every registered automation loop carries a checked-in runbook, and every run of that loop ends in
|
|
15
|
+
exactly one of six run outcomes** with a one-line, operator-readable summary. A registered loop with
|
|
16
|
+
no runbook, or a run that stops without naming its outcome, is a contract violation.
|
|
17
|
+
|
|
18
|
+
**One vendor-neutral contract, to be cited by (wired in the loop-conformance ticket)
|
|
19
|
+
`lisa-setup-automations`, `lisa-automation-status`, `lisa-tear-down-automations`, and every
|
|
20
|
+
registered loop skill** (the `leaf-only-lifecycle` / `repo-scope-split` precedent: one shared slug,
|
|
21
|
+
never divergent per-loop prose).
|
|
22
|
+
|
|
23
|
+
## Membership
|
|
24
|
+
|
|
25
|
+
Membership is **registration, not skill-existence**: a loop is under this contract the moment it is
|
|
26
|
+
registered as a scheduled automation, and registering a new one pulls it in automatically. There is
|
|
27
|
+
no hardcoded roster of loops anywhere.
|
|
28
|
+
|
|
29
|
+
### Interactive flows are members too
|
|
30
|
+
|
|
31
|
+
The outcome vocabulary is **not cron-specific** — it answers "did this need me?", which an operator
|
|
32
|
+
asks of an interactive run exactly as often as of a scheduled one. Every Lisa flow that terminates
|
|
33
|
+
is a member: `lisa-implement`, `lisa-verify`, `lisa-plan`, `lisa-git-submit-pr`,
|
|
34
|
+
`lisa-drive-pr-to-merge`, `lisa-research`, and any skill invoked as a slash command.
|
|
35
|
+
|
|
36
|
+
For an interactive flow the required run record is the **final user-facing message**, not a JSONL
|
|
37
|
+
row written by `automation-run-record.mjs`. Interactive flows may also record local JSONL telemetry
|
|
38
|
+
when a specific skill owns that surface, but this contract's mandatory record is the final answer.
|
|
39
|
+
It opens with the outcome and the operator action, before any narrative:
|
|
40
|
+
|
|
41
|
+
```
|
|
42
|
+
change-proved — nothing for you. PR #6393 open, auto-merge on, CI running.
|
|
43
|
+
approval-requested — need a decision: ship the 135 Regular→Bold flips, or hold for design sign-off?
|
|
44
|
+
recovery-required — need you: staging E2E gate red for congestion; rerun or admin-merge.
|
|
45
|
+
```
|
|
46
|
+
|
|
47
|
+
The operator must learn whether they are needed **from the first line**, without reading the report.
|
|
48
|
+
Findings, evidence and caveats follow; they never replace the action line and never precede it.
|
|
49
|
+
|
|
50
|
+
An interactive flow that ends in prose with the action buried — or absent — is the same contract
|
|
51
|
+
violation as a silent cron exit. "I flagged X, I noticed Y, worth knowing Z" is narrative, not an
|
|
52
|
+
outcome. If nothing is needed, say **"nothing for you"** in those words and stop.
|
|
53
|
+
|
|
54
|
+
## The six run outcomes
|
|
55
|
+
|
|
56
|
+
Exactly one per run:
|
|
57
|
+
**`nothing-needed | candidate-proposed | change-proved | approval-requested | recovery-required | policy-obsolete`**
|
|
58
|
+
|
|
59
|
+
Health and operator action are **orthogonal** — a healthy run can still need an answer:
|
|
60
|
+
|
|
61
|
+
- `nothing-needed` — the loop ran and found nothing to act on. **Healthy.** Operator action: none.
|
|
62
|
+
A queue scanner's `nothing-needed` summary must name the lanes it swept and the total open — a dry
|
|
63
|
+
queue and a wrong denominator are otherwise indistinguishable. See the reference body.
|
|
64
|
+
- `candidate-proposed` — the loop proposed work (ticket, PRD, recommendation). **Healthy.** Operator
|
|
65
|
+
action: review the proposed item and flip it ready when you want it built.
|
|
66
|
+
- `change-proved` — the loop made a change and proved it with evidence. **Healthy.** Operator
|
|
67
|
+
action: none (informational).
|
|
68
|
+
- `approval-requested` — the loop reached a boundary it may not cross alone. **Healthy.** Operator
|
|
69
|
+
action: answer the approval question.
|
|
70
|
+
- `recovery-required` — the loop itself could not complete (access, tooling, or substrate broken)
|
|
71
|
+
and escalated a decision-ready packet. **Not healthy.** Operator action: restore the named
|
|
72
|
+
capability, then close the escalation item.
|
|
73
|
+
- `policy-obsolete` — the loop's own retirement policy (the retirement condition written in its
|
|
74
|
+
runbook) tripped, so it proposed its own teardown. **Healthy.** Operator action: approve the
|
|
75
|
+
teardown, decline it (close the proposal as **Not planned**; the loop keeps running at cadence),
|
|
76
|
+
or re-cadence it.
|
|
77
|
+
|
|
78
|
+
## A run outcome is NOT a work-item lifecycle terminal state (CRITICAL)
|
|
79
|
+
|
|
80
|
+
A **run outcome** describes the LOOP ITERATION. A **terminal state** describes a TICKET — Lisa
|
|
81
|
+
already uses that phrase for work-item lifecycles (`lisa-intake`: "`Blocked` is a valid terminal
|
|
82
|
+
state of the downstream lifecycles"). The two vocabularies never merge in an operator-facing report.
|
|
83
|
+
A healthy cycle that routes a work item to `Blocked` with clarifying questions is
|
|
84
|
+
`candidate-proposed` — it produced something — so it is **never `nothing-needed`**, which is
|
|
85
|
+
reserved for runs that found nothing at all, and **never `recovery-required`**, which means the
|
|
86
|
+
loop itself is broken, not that a work item was blocked.
|
|
87
|
+
|
|
88
|
+
## No silent exit
|
|
89
|
+
|
|
90
|
+
Every run — including a trivial early termination — ends by naming exactly one run outcome plus a
|
|
91
|
+
one-line operator summary of what happened, recorded where the status surface can read it —
|
|
92
|
+
there is no silent exit. The shared local substrate is
|
|
93
|
+
`plugins/src/base/scripts/automation-run-record.mjs`, which writes bounded JSONL records under
|
|
94
|
+
`.lisa/automations/runs/<loop-id>.jsonl`. Silence and health must never look identical to an
|
|
95
|
+
operator.
|
|
96
|
+
|
|
97
|
+
## Never block, always degrade
|
|
98
|
+
|
|
99
|
+
A missing runbook, an unreadable record surface, or an absent optional dependency **degrades** the
|
|
100
|
+
run — say so in the summary and finish with an outcome — it never crashes the loop, never blocks
|
|
101
|
+
other work, and never leaves the run unreported.
|
|
102
|
+
|
|
103
|
+
---
|
|
104
|
+
|
|
8
105
|
Scheduled loops are the busiest machinery in the factory and historically the least explicitly
|
|
9
106
|
contracted: what a loop maintains, what it may do on its own, what it must escalate, and when it
|
|
10
107
|
should stop existing all lived implicitly in each loop's prose. The cost lands on the operator — a
|
|
@@ -7,6 +7,16 @@ alwaysApply: true
|
|
|
7
7
|
|
|
8
8
|
These are mandatory disciplines that apply to every session. Full prose, JIRA dev-status query, ADF templates, etc. live in [reference/base-rules.md](base-rules-reference.mdc).
|
|
9
9
|
|
|
10
|
+
## Factory Operating Mode
|
|
11
|
+
|
|
12
|
+
You are factory machinery, not a chat assistant. Three consequences bind every session:
|
|
13
|
+
|
|
14
|
+
- **Do not pause mid-flow to ask a human whether to proceed.** Handoff happens at the gates — the ready-role flips and intake's adversarial validation — never in the middle of a flow.
|
|
15
|
+
- **Every flow must work headless**: no interactive prompts, idempotent re-runs, clean exits on empty queues. Flows run under native schedulers as often as under a human.
|
|
16
|
+
- **Never weaken a gate to get work through it — fix the work.**
|
|
17
|
+
|
|
18
|
+
The model these follow from (the four factories, the gate, the loops, the brownfield on-ramp) is [reference/factory-model.md](factory-model-reference.mdc); read it when you need the shape rather than the obligations.
|
|
19
|
+
|
|
10
20
|
## Requirement Verification
|
|
11
21
|
|
|
12
22
|
Treat every request as potentially underspecified. Before starting any work:
|
|
@@ -5,6 +5,62 @@ alwaysApply: false
|
|
|
5
5
|
|
|
6
6
|
# BDD Behavior Contract & E2E Coverage
|
|
7
7
|
|
|
8
|
+
> Demoted from the always-on eager tier by CodySwannGT/lisa#3992. The
|
|
9
|
+
> section below is the former eager head, preserved verbatim; the full
|
|
10
|
+
> contract follows it. Reachable on demand via `rules/eager/00-rule-index.md`.
|
|
11
|
+
|
|
12
|
+
## BDD Behavior Contract & E2E Coverage (load-bearing)
|
|
13
|
+
|
|
14
|
+
**Every frontend work item ships its behavior as Gherkin scenarios with stable IDs, and seals each required scenario-platform obligation with aligned e2e automation in the project's configured runner for that platform.** A frontend change that adds no scenario, or a required scenario-platform obligation with neither a mapped test nor a dated waiver, is a contract violation.
|
|
15
|
+
|
|
16
|
+
**One vendor-neutral contract, cited by** `lisa-research`, `lisa-acceptance-criteria`, `lisa-task-decomposition`, `lisa-test-strategy`, `lisa-tdd-implementation`, `lisa-implement`, `lisa-codify-verification`, `lisa-verification-lifecycle`, `lisa-spec-conformance`, and `lisa-verify` (the `leaf-only-lifecycle` / `repo-scope-split` precedent: one shared slug, never divergent per-skill prose).
|
|
17
|
+
|
|
18
|
+
## Membership
|
|
19
|
+
|
|
20
|
+
Membership is **surface, not repo name or ticket label**: a work item is frontend-type the moment it adds or changes something a user can observe — a screen, route, component, interaction, visual state, empty/error/loading state, navigation path, or copy a user reads. It applies on every platform the project ships. Backend-only, infrastructure, docs, tooling, and refactors with no user-observable delta are out; a refactor that changes what the user sees is in.
|
|
21
|
+
|
|
22
|
+
## The contract lives in the repo
|
|
23
|
+
|
|
24
|
+
Default locations (a project that already has an equivalent contract keeps its own paths and records them in `.lisa.config.json`):
|
|
25
|
+
|
|
26
|
+
| Artifact | Default path | What it is |
|
|
27
|
+
|---|---|---|
|
|
28
|
+
| Scenarios | `bdd/features/*.feature` | Gherkin, the product-level behavior contract |
|
|
29
|
+
| Coverage map | `bdd/coverage-map.json` | scenario → runner/platform/file/evidence mappings, plus waivers, per-runner test-discovery roots, and exclusions |
|
|
30
|
+
| Generated matrix | `docs/bdd-scenario-matrix.md` | regenerated, never hand-edited |
|
|
31
|
+
| Burndown | `docs/e2e-bdd-coverage.md` | current coverage per platform |
|
|
32
|
+
|
|
33
|
+
## Scenario shape
|
|
34
|
+
|
|
35
|
+
Every scenario carries **one stable `@BDD-<DOMAIN>-<NNN>` ID**, the platforms it requires (`@web`, `@ios`, `@android`, … as the project declares them), provenance (design node, ratified decision), and a tracker tag tying it to the work item that introduced or changed it. IDs are never renumbered or reused: behavior that stays user-observably the same keeps its ID through a rewrite; genuinely different behavior gets a new ID and the old one is marked `@superseded`.
|
|
36
|
+
|
|
37
|
+
Lifecycle tag, exactly one or none:
|
|
38
|
+
|
|
39
|
+
- **no tag** — ratified and required; it is in the coverage denominator.
|
|
40
|
+
- **`@blocked`** — specified but awaiting a decision or dependency; the *product* does not do this yet.
|
|
41
|
+
- **`@reference-only`** — intentionally not authoritative.
|
|
42
|
+
- **`@superseded`** — replaced by a ratified rule or a newer scenario.
|
|
43
|
+
|
|
44
|
+
The last three are out of the denominator. Deleting a committed capability to make coverage look better is a violation; mark it, do not drop it.
|
|
45
|
+
|
|
46
|
+
## What seals a scenario
|
|
47
|
+
|
|
48
|
+
Coverage is counted per **required scenario-platform obligation**, and an obligation is sealed only by **aligned e2e automation in the project's configured runner for that platform** — the runner→platform mapping is project configuration (e.g. a web runner covering `web`, a device runner covering `ios`/`android`), never named by this contract. A unit test, a route boot, a screenshot, a fixture, an API test, or a passing test on a *different* platform never seals an obligation: they prove something else. Each mapping names the runner, the platforms, the file, and the evidence string inside it, so the gate can prove the mapping still resolves.
|
|
49
|
+
|
|
50
|
+
**The gate reads in both directions.** It also walks the test roots the project declares per runner, so an e2e test that exists but that the contract never mentions is a violation — map it to a scenario, or record an exclusion stating why it aligns to no product behavior. Roots are configuration: a subflow or helper directory left undeclared is structurally invisible, which is the same failure as having no gate for it.
|
|
51
|
+
|
|
52
|
+
**Waivers are dated IOUs, never coverage.** An obligation whose runner genuinely cannot decide it today (no camera on the simulator, no request interception, no provisioned provider credential) is recorded with scenario, platforms, reason, and `recordedAt`. It leaves the denominator; it never counts as covered, and nothing about it asserts the behavior works. A waiver is invalid — and fails the gate — when it names a nonexistent scenario or an undeclared platform, covers an already-excluded scenario, or masks a scenario-platform that already has a mapping. Revisit a waiver when its reason dies.
|
|
53
|
+
|
|
54
|
+
## Definition of done
|
|
55
|
+
|
|
56
|
+
A frontend work item is not done until: (1) every user-facing behavior it adds or changes exists as a Gherkin scenario with a stable ID in the project's behavior contract, traceable to the work item; (2) every required scenario-platform obligation it introduces is either mapped to aligned e2e automation in the project's configured runner for that platform, or carries a dated waiver naming the runner limitation; and (3) the coverage gate passes and the generated matrix and burndown are regenerated and committed in the same PR. **Missing BDD coverage is a verification failure, not a warning** — it blocks completion exactly as a `PARTIAL` spec-conformance verdict does, and it is never demoted to "optional", "if cheap", or a follow-up without a linked build-ready ticket created before merge.
|
|
57
|
+
|
|
58
|
+
## Bootstrap and degradation
|
|
59
|
+
|
|
60
|
+
A project with no `bdd/` contract yet is not exempt — the first frontend work item scaffolds the minimum (features dir, coverage map with the project's detected runner→platform mapping, gate + matrix scripts) and covers **its own** behavior. It never backfills the whole app: pre-existing uncovered behavior is recorded as burndown, not treated as this item's blocker. If no e2e runner exists for a required platform at all, record the checked locations and the absence as the reason, exactly as the regression-spec absence path in `verification` does — a silent skip is never one of the exits.
|
|
61
|
+
|
|
62
|
+
---
|
|
63
|
+
|
|
8
64
|
Frontend behavior has historically been specified twice and owned nowhere: once as prose acceptance
|
|
9
65
|
criteria on a ticket that closes and disappears, and once as whatever e2e tests someone had time to
|
|
10
66
|
write. Neither survives the work item. The cost lands at verification time — nobody can answer "what
|
|
@@ -5,6 +5,64 @@ alwaysApply: false
|
|
|
5
5
|
|
|
6
6
|
# Blocker Containment
|
|
7
7
|
|
|
8
|
+
> Demoted from the always-on eager tier by CodySwannGT/lisa#3992. The
|
|
9
|
+
> section below is the former eager head, preserved verbatim; the full
|
|
10
|
+
> contract follows it. Reachable on demand via `rules/eager/00-rule-index.md`.
|
|
11
|
+
|
|
12
|
+
## Blocker Containment (load-bearing)
|
|
13
|
+
|
|
14
|
+
**An `is blocked by` dependency is cleared by one fact only: the blocker's code is present on the branch the dependent will be built from.** A lifecycle status name — `done`, `on-stg`, `on-dev`, `code-review`, or any configured equivalent — is never that fact. It is a label that correlates with the fact in a single-trunk workflow and comes apart from it in a promotion workflow.
|
|
15
|
+
|
|
16
|
+
**One vendor-neutral contract, cited by** `lisa-repair-intake` (Class A dependency clearing), `lisa-intake-explain` (dependency hold gate), and `lisa-ticket-triage` (Phase 1.5 open-blocker gate) — the `leaf-only-lifecycle` / `repo-scope-split` precedent: one shared slug, never divergent per-consumer prose.
|
|
17
|
+
|
|
18
|
+
## Why a status name is the wrong test
|
|
19
|
+
|
|
20
|
+
Where promotion runs `dev → staging → main`, `main` is the **trailing** branch. A blocker at `On Stg` is merged to `staging` and absent from `main`, so a dependent that builds from `main` does not have it. A blocker in `Code Review` is merged to nothing at all. The two failures are symmetric and both are live in the tree:
|
|
21
|
+
|
|
22
|
+
- Test too **loosely** (any env-staged `done` clears) and a dependent is dispatched into work whose prerequisite is not on its branch. Nothing goes red; the item moves to `ready`, which is indistinguishable from a repair that worked.
|
|
23
|
+
- Test too **strictly** (only the production terminal clears) and every dependent strands behind a blocker that is already merged where it matters.
|
|
24
|
+
|
|
25
|
+
Containment is the one predicate that gets both right, because it asks the question the status name was standing in for.
|
|
26
|
+
|
|
27
|
+
## The predicate
|
|
28
|
+
|
|
29
|
+
1. **Resolve the dependent's base branch.** Take the dependent's `## Target Backend Environment` and map that exact key forward through `.lisa.config.json` `deploy.branches`, per `derived-branch-plan` and `config-resolution`. **Never read the rendered `Branch Plan` section as input** — `derived-branch-plan` forbids it; a surface needing the base branch derives it again.
|
|
30
|
+
2. **Resolve the blocker's merge commit** — the commit that landed the blocker's PR.
|
|
31
|
+
3. **Test ancestry on the remote:** is that commit an ancestor of the resolved base branch (`git merge-base --is-ancestor <sha> origin/<base>`)?
|
|
32
|
+
4. **Cleared** iff the answer is yes. Otherwise **still blocking**.
|
|
33
|
+
|
|
34
|
+
## Fail closed
|
|
35
|
+
|
|
36
|
+
**Never fail open on an unresolvable ancestry check.** Any step that cannot be positively resolved leaves the dependency **blocking**, and the run record says which step failed:
|
|
37
|
+
|
|
38
|
+
- no linked PR, or a PR that is not merged;
|
|
39
|
+
- the blocker is inaccessible (deleted, cross-org, permission denied) — containment across repositories is not defined;
|
|
40
|
+
- the dependent's environment is not derivable, maps non-uniquely, or maps to a branch absent from the remote;
|
|
41
|
+
- the ancestry query itself fails.
|
|
42
|
+
|
|
43
|
+
A false negative (left blocked) costs a cycle and is visible. A false positive (dispatched into a missing prerequisite) is invisible and surfaces days later as work begun before its dependency existed. Prefer the visible failure.
|
|
44
|
+
|
|
45
|
+
## The one carve-out: a blocker with no code
|
|
46
|
+
|
|
47
|
+
A dependency need not deliver code. A blocker **closed as completed** that positively declares no code deliverable — `Target Backend Environment: None — no runtime behavior change` (doc-only / config-only / type-only), no linked PR, no merge commit — is **cleared**, because there is no artifact whose location could matter.
|
|
48
|
+
|
|
49
|
+
This requires a **positive determination**, never an absence. "I could not find a PR" is fail-closed under the rule above; "the item declares it ships no code" is this carve-out. Collapsing the two turns the carve-out into a universal bypass.
|
|
50
|
+
|
|
51
|
+
## Ancestry answers a development question, not a deployment one
|
|
52
|
+
|
|
53
|
+
This rule requires an ancestry test. `deployed-state-readback` says ancestry is **never** evidence of deployment. Both are correct — they answer different questions:
|
|
54
|
+
|
|
55
|
+
- **Here:** *is the blocker's code on the branch I will build from?* An `is blocked by` link is a **development** dependency, satisfied once the code is on your base branch. Ancestry is the right test, and waiting for production strands dependents.
|
|
56
|
+
- **There:** *is this thing live?* A commit can be an ancestor of the default branch and never have shipped — a discarded pipeline execution leaves it merged and undeployed. Ancestry is provably insufficient.
|
|
57
|
+
|
|
58
|
+
Never use this rule's test to answer a "does it already exist in the environment?" question.
|
|
59
|
+
|
|
60
|
+
## Human override
|
|
61
|
+
|
|
62
|
+
A human statement on the item that the dependency is satisfied clears it, and outranks a failed containment check. Record it as the reason in the run record. This is the escape hatch for cross-repo and untracked dependencies, and it is the only one. An automation may never synthesize one on its own behalf.
|
|
63
|
+
|
|
64
|
+
---
|
|
65
|
+
|
|
8
66
|
An `is blocked by` link is a **development** dependency. It asks one question: *does the dependent have the blocker's code on the branch it will be built from?* This rule makes that the test, replacing the lifecycle-status-name checks that three Lisa surfaces had each grown independently.
|
|
9
67
|
|
|
10
68
|
It is a **single vendor-neutral contract** consumed by `lisa-repair-intake` (Class A dependency clearing), `lisa-intake-explain` (dependency hold gate), and `lisa-ticket-triage` (Phase 1.5 open-blocker gate). Each cites this slug rather than re-implementing the test, exactly as they cite `leaf-only-lifecycle` and `repo-scope-split`. That is what keeps the three from drifting apart again.
|