@codyswann/lisa 4.38.4 → 4.38.6
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/all/copy-overwrite/scripts/lisa-work-item.mjs +57 -4
- package/dist/core/lisa-owned-hash-ledger.d.ts.map +1 -1
- package/dist/core/lisa-owned-hash-ledger.js +8 -0
- package/dist/core/lisa-owned-hash-ledger.js.map +1 -1
- package/dist/core/nightly-e2e-guard-behavior-certificate.js +2 -2
- package/dist/core/upstream-evidence-manifest.d.ts.map +1 -1
- package/dist/core/upstream-evidence-manifest.js +4 -2
- package/dist/core/upstream-evidence-manifest.js.map +1 -1
- package/package.json +4 -4
- package/plugins/lisa/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-agy/plugin.json +1 -1
- package/plugins/lisa-cdk/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-agy/plugin.json +1 -1
- package/plugins/lisa-cdk-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-agy/plugin.json +1 -1
- package/plugins/lisa-expo-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-agy/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-agy/plugin.json +1 -1
- package/plugins/lisa-nestjs-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-agy/plugin.json +1 -1
- package/plugins/lisa-openclaw-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-agy/plugin.json +1 -1
- package/plugins/lisa-phaser-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-agy/plugin.json +1 -1
- package/plugins/lisa-rails-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-agy/plugin.json +1 -1
- package/plugins/lisa-typescript-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-agy/plugin.json +1 -1
- package/plugins/lisa-wiki-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-cursor/.claude-plugin/plugin.json +1 -1
- package/typescript/copy-overwrite/scripts/check-skipped-required-checks.mjs +60 -6
package/package.json
CHANGED
|
@@ -170,7 +170,7 @@
|
|
|
170
170
|
"zod-validation-error": "^4.0.0"
|
|
171
171
|
},
|
|
172
172
|
"name": "@codyswann/lisa",
|
|
173
|
-
"version": "4.38.
|
|
173
|
+
"version": "4.38.6",
|
|
174
174
|
"description": "Claude Code governance framework that applies guardrails, guidance, and automated enforcement to projects",
|
|
175
175
|
"main": "dist/index.js",
|
|
176
176
|
"exports": {
|
|
@@ -318,7 +318,7 @@
|
|
|
318
318
|
"test": "tests"
|
|
319
319
|
},
|
|
320
320
|
"types": "./dist/index.d.ts",
|
|
321
|
-
"lisaReleaseCommit": "
|
|
322
|
-
"gitHead": "
|
|
323
|
-
"lisaReleaseTag": "v4.38.
|
|
321
|
+
"lisaReleaseCommit": "013a5d226c4a742c2bbc95578a30ffbf1c7a85ff",
|
|
322
|
+
"gitHead": "013a5d226c4a742c2bbc95578a30ffbf1c7a85ff",
|
|
323
|
+
"lisaReleaseTag": "v4.38.6"
|
|
324
324
|
}
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "4.38.
|
|
3
|
+
"version": "4.38.6",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "4.38.
|
|
3
|
+
"version": "4.38.6",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, across Claude and Codex.",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "4.38.
|
|
3
|
+
"version": "4.38.6",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "4.38.
|
|
3
|
+
"version": "4.38.6",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "4.38.
|
|
3
|
+
"version": "4.38.6",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -379,6 +379,47 @@ export const REVIEW_DESCRIPTION_DEFAULTS = Object.freeze({
|
|
|
379
379
|
]),
|
|
380
380
|
});
|
|
381
381
|
|
|
382
|
+
/**
|
|
383
|
+
* `no_work` phrases whose presence does NOT establish that no review happened.
|
|
384
|
+
*
|
|
385
|
+
* The rest of `no_work` is safe to speak plainly about: `review skipped`,
|
|
386
|
+
* `review queued`, `waiting` and the others describe a vendor saying it did not
|
|
387
|
+
* start. `rate limited` turned out not to. Measured on CodySwannGT/lisa#3762 —
|
|
388
|
+
* the check reported `success` with the description `Review rate limited` and
|
|
389
|
+
* the vendor HAD reviewed, posting `CHANGES_REQUESTED` with a comment that
|
|
390
|
+
* found a real defect.
|
|
391
|
+
*
|
|
392
|
+
* Moving the phrase between the two lists would not help, and the reason bounds
|
|
393
|
+
* what any change here can achieve: **the description is not a function of
|
|
394
|
+
* whether a review happened.** `proof` is matched whole-string, so a
|
|
395
|
+
* reviewed-and-objected pull request still carrying `Review rate limited` can
|
|
396
|
+
* never reach it. Settling the question needs a second input — `reviews` /
|
|
397
|
+
* `reviewThreads` — which this script does not read and deliberately does not
|
|
398
|
+
* fetch: that would make the claim checkable at the cost of turning a
|
|
399
|
+
* description classifier into a network client (CodySwannGT/lisa#3827).
|
|
400
|
+
*
|
|
401
|
+
* So the phrase stays in `no_work` — denying credit on it remains correct and
|
|
402
|
+
* remains the safe direction — and only the WORDING changes. For these phrases
|
|
403
|
+
* the report says what it can support and stops instructing a conclusion it
|
|
404
|
+
* cannot.
|
|
405
|
+
*/
|
|
406
|
+
const AMBIGUOUS_NO_WORK = Object.freeze(["rate limited"]);
|
|
407
|
+
|
|
408
|
+
/**
|
|
409
|
+
* Whether a `no_work` description can be reported as proof that nothing ran.
|
|
410
|
+
*
|
|
411
|
+
* Matched as a substring, exactly as `no_work` itself is, so the two always
|
|
412
|
+
* agree about what a description contains.
|
|
413
|
+
* @param {string | undefined} description - Description the check reported
|
|
414
|
+
* @returns {boolean} True when "it did no work" is a claim the text supports
|
|
415
|
+
*/
|
|
416
|
+
export function noWorkClaimIsCertain(description) {
|
|
417
|
+
const text = String(description ?? "")
|
|
418
|
+
.trim()
|
|
419
|
+
.toLowerCase();
|
|
420
|
+
return !AMBIGUOUS_NO_WORK.some(phrase => text.includes(phrase));
|
|
421
|
+
}
|
|
422
|
+
|
|
382
423
|
/**
|
|
383
424
|
* Verdicts `classifyCheckDescription` returns.
|
|
384
425
|
*
|
|
@@ -1298,15 +1339,21 @@ export function evaluateVacuousChecks(declaration, checks, options = {}) {
|
|
|
1298
1339
|
* @param {string} name - Check context name
|
|
1299
1340
|
* @param {boolean} trustRequired - Whether the ruleset snapshot is trusted
|
|
1300
1341
|
* @param {ReadonlySet<string>} required - Required-context snapshot
|
|
1342
|
+
* @param {boolean} certain - Whether the description supports "no review happened"
|
|
1301
1343
|
* @returns {string} Sentence appended to a finding
|
|
1302
1344
|
*/
|
|
1303
|
-
function evidenceRequiredNote(name, trustRequired, required) {
|
|
1345
|
+
function evidenceRequiredNote(name, trustRequired, required, certain) {
|
|
1304
1346
|
if (!trustRequired) {
|
|
1305
1347
|
return " Whether it is ruleset-required is NOT KNOWN here — `required_contexts` has not been transcribed, so this cannot say what the merge gate recorded.";
|
|
1306
1348
|
}
|
|
1307
|
-
|
|
1308
|
-
|
|
1309
|
-
|
|
1349
|
+
if (required.has(name)) {
|
|
1350
|
+
return certain
|
|
1351
|
+
? " This context IS ruleset-required, so branch protection recorded a satisfied review gate for a review that did not happen."
|
|
1352
|
+
: " This context IS ruleset-required, so branch protection recorded a satisfied review gate on evidence that does not establish a review happened.";
|
|
1353
|
+
}
|
|
1354
|
+
return certain
|
|
1355
|
+
? " This context is not in `required_contexts`, so no merge gate was falsified — but nothing reviewed this either."
|
|
1356
|
+
: " This context is not in `required_contexts`, so no merge gate was falsified — and this does not say whether anything reviewed it.";
|
|
1310
1357
|
}
|
|
1311
1358
|
|
|
1312
1359
|
/**
|
|
@@ -1337,17 +1384,24 @@ function evaluateEvidenceBearingCheck(name, entry, checks, context) {
|
|
|
1337
1384
|
return null;
|
|
1338
1385
|
}
|
|
1339
1386
|
|
|
1387
|
+
// Whether "it did no work" is a claim this description can support. A
|
|
1388
|
+
// `rate limited` string cannot (CodySwannGT/lisa#3762), so every sentence
|
|
1389
|
+
// below that would otherwise assert it is softened for that case.
|
|
1390
|
+
const certain = noWorkClaimIsCertain(found.description);
|
|
1340
1391
|
const requiredNote = evidenceRequiredNote(
|
|
1341
1392
|
name,
|
|
1342
1393
|
context.trustRequired,
|
|
1343
|
-
context.required
|
|
1394
|
+
context.required,
|
|
1395
|
+
certain
|
|
1344
1396
|
);
|
|
1345
1397
|
if (verdict === DESCRIPTION_VERDICTS.noWork && state === "SUCCESS") {
|
|
1346
1398
|
return {
|
|
1347
1399
|
kind: VIOLATIONS.vacuous,
|
|
1348
1400
|
token: name,
|
|
1349
1401
|
contexts: [name],
|
|
1350
|
-
message:
|
|
1402
|
+
message: certain
|
|
1403
|
+
? `\`${name}\` reported ${state} with the description ${JSON.stringify(found.description ?? "")}, which says it DID NO WORK.${context.at}${requiredNote} \`gh pr checks\` prints \`pass\` for this exactly as it does for a real review, and shows neither \`reviews\` nor \`reviewThreads\`. Treat this PR as UNREVIEWED.`
|
|
1404
|
+
: `\`${name}\` reported ${state} with the description ${JSON.stringify(found.description ?? "")}, which proves neither that it reviewed anything nor that it did not — this vendor has reported this same description on a pull request it HAD reviewed and objected to (CodySwannGT/lisa#3762).${context.at}${requiredNote} \`gh pr checks\` prints \`pass\` for this exactly as it does for a real review, and cannot tell them apart. Read \`reviews\` and \`reviewThreads\` — which \`gh pr checks\` does not show — before treating this PR as reviewed OR as unreviewed.`,
|
|
1351
1405
|
};
|
|
1352
1406
|
}
|
|
1353
1407
|
return {
|