@codyswann/lisa 4.38.1 → 4.38.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/all/copy-overwrite/scripts/lisa-hooks/block-direct-issue-create.sh +140 -4
- package/dist/core/lisa-owned-hash-ledger.d.ts.map +1 -1
- package/dist/core/lisa-owned-hash-ledger.js +6 -0
- package/dist/core/lisa-owned-hash-ledger.js.map +1 -1
- package/dist/core/nightly-e2e-guard-behavior-certificate.js +2 -2
- package/dist/core/upstream-evidence-manifest.d.ts.map +1 -1
- package/dist/core/upstream-evidence-manifest.js +11 -6
- package/dist/core/upstream-evidence-manifest.js.map +1 -1
- package/dist/opencode/plugin-templates/lisa-block-direct-issue-create.ts +9 -0
- package/package.json +6 -5
- package/plugins/lisa/.claude-plugin/plugin.json +10 -5
- package/plugins/lisa/.codex-plugin/hooks.json +9 -4
- package/plugins/lisa/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa/hooks/block-direct-issue-create.agy.sh +13 -3
- package/plugins/lisa/hooks/block-direct-issue-create.sh +140 -4
- package/plugins/lisa/hooks/threshold-ratchet-families.mjs +8 -0
- package/plugins/lisa-agy/hooks/block-direct-issue-create.agy.sh +13 -3
- package/plugins/lisa-agy/hooks/block-direct-issue-create.sh +140 -4
- package/plugins/lisa-agy/plugin.json +1 -1
- package/plugins/lisa-cdk/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-agy/plugin.json +1 -1
- package/plugins/lisa-cdk-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/.claude-plugin/plugin.json +10 -5
- package/plugins/lisa-copilot/hooks/block-direct-issue-create.sh +140 -4
- package/plugins/lisa-copilot/hooks/threshold-ratchet-families.mjs +8 -0
- package/plugins/lisa-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cursor/hooks/block-direct-issue-create.sh +140 -4
- package/plugins/lisa-cursor/hooks/hooks.json +3 -4
- package/plugins/lisa-cursor/hooks/threshold-ratchet-families.mjs +8 -0
- package/plugins/lisa-expo/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-agy/plugin.json +1 -1
- package/plugins/lisa-expo-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-agy/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-agy/plugin.json +1 -1
- package/plugins/lisa-nestjs-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-agy/plugin.json +1 -1
- package/plugins/lisa-openclaw-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-agy/plugin.json +1 -1
- package/plugins/lisa-phaser-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-agy/plugin.json +1 -1
- package/plugins/lisa-rails-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-agy/plugin.json +1 -1
- package/plugins/lisa-typescript-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-agy/plugin.json +1 -1
- package/plugins/lisa-wiki-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/src/base/.claude-plugin/plugin.json +9 -4
- package/plugins/src/base/hooks/block-direct-issue-create.agy.sh +13 -3
- package/plugins/src/base/hooks/block-direct-issue-create.sh +140 -4
- package/plugins/src/base/hooks/threshold-ratchet-families.mjs +8 -0
- package/rails/copy-overwrite/scripts/threshold-ratchet-families.mjs +8 -0
- package/scripts/check-typecheck-tests.mjs +147 -0
- package/typescript/copy-overwrite/scripts/threshold-ratchet-families.mjs +8 -0
|
@@ -14,6 +14,15 @@
|
|
|
14
14
|
* `output.args.command`. Throwing in `tool.execute.before` cancels the tool
|
|
15
15
|
* call and surfaces the message to the agent.
|
|
16
16
|
*
|
|
17
|
+
* SCOPE GAP, recorded rather than silently dropped (AGENTS.md). Since
|
|
18
|
+
* CodySwannGT/lisa#3753 the canonical guard covers a SECOND substrate —
|
|
19
|
+
* structured tool payloads, where a creation arrives as named fields rather
|
|
20
|
+
* than a command line — because the filing contract was enforced on the shell
|
|
21
|
+
* and unenforced on every tool call beside it. This port returns early for any
|
|
22
|
+
* tool other than `bash`, so on OpenCode that substrate is still uncovered.
|
|
23
|
+
* Closing it needs OpenCode's own creation-tool envelope, which is separate
|
|
24
|
+
* work from porting the shell path.
|
|
25
|
+
*
|
|
17
26
|
* The port matches on the raw command text rather than tokenising it, which
|
|
18
27
|
* makes it naturally immune to the prefix and tokenisation bypass classes the
|
|
19
28
|
* shell guard had to be restructured to close — an unrecognised wrapper is just
|
package/package.json
CHANGED
|
@@ -18,7 +18,8 @@
|
|
|
18
18
|
"lint": "oxlint --disable-nested-config && eslint . --quiet",
|
|
19
19
|
"lint:fix": "oxlint --fix --disable-nested-config && eslint . --fix",
|
|
20
20
|
"lint:slow": "eslint . --config eslint.slow.config.ts --quiet",
|
|
21
|
-
"typecheck": "tsc --noEmit",
|
|
21
|
+
"typecheck": "tsc --noEmit && bun run typecheck:tests",
|
|
22
|
+
"typecheck:tests": "node scripts/check-typecheck-tests.mjs",
|
|
22
23
|
"format:check": "prettier --check .",
|
|
23
24
|
"format": "prettier --check . --write",
|
|
24
25
|
"knip:check": "knip",
|
|
@@ -169,7 +170,7 @@
|
|
|
169
170
|
"zod-validation-error": "^4.0.0"
|
|
170
171
|
},
|
|
171
172
|
"name": "@codyswann/lisa",
|
|
172
|
-
"version": "4.38.
|
|
173
|
+
"version": "4.38.3",
|
|
173
174
|
"description": "Claude Code governance framework that applies guardrails, guidance, and automated enforcement to projects",
|
|
174
175
|
"main": "dist/index.js",
|
|
175
176
|
"exports": {
|
|
@@ -317,7 +318,7 @@
|
|
|
317
318
|
"test": "tests"
|
|
318
319
|
},
|
|
319
320
|
"types": "./dist/index.d.ts",
|
|
320
|
-
"lisaReleaseCommit": "
|
|
321
|
-
"gitHead": "
|
|
322
|
-
"lisaReleaseTag": "v4.38.
|
|
321
|
+
"lisaReleaseCommit": "45d3791eee9301486af483eab0f615ac478c5fbc",
|
|
322
|
+
"gitHead": "45d3791eee9301486af483eab0f615ac478c5fbc",
|
|
323
|
+
"lisaReleaseTag": "v4.38.3"
|
|
323
324
|
}
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa",
|
|
3
|
-
"version": "4.38.
|
|
3
|
+
"version": "4.38.3",
|
|
4
4
|
"description": "Universal governance — agents, skills, commands, hooks, and rules for all projects",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -138,10 +138,6 @@
|
|
|
138
138
|
"type": "command",
|
|
139
139
|
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/block-instruction-file-edits.sh"
|
|
140
140
|
},
|
|
141
|
-
{
|
|
142
|
-
"type": "command",
|
|
143
|
-
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/block-direct-issue-create.sh"
|
|
144
|
-
},
|
|
145
141
|
{
|
|
146
142
|
"type": "command",
|
|
147
143
|
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/block-blind-automerge.sh"
|
|
@@ -178,6 +174,15 @@
|
|
|
178
174
|
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/enforce-verification-gate.sh"
|
|
179
175
|
}
|
|
180
176
|
]
|
|
177
|
+
},
|
|
178
|
+
{
|
|
179
|
+
"matcher": "",
|
|
180
|
+
"hooks": [
|
|
181
|
+
{
|
|
182
|
+
"type": "command",
|
|
183
|
+
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/block-direct-issue-create.sh"
|
|
184
|
+
}
|
|
185
|
+
]
|
|
181
186
|
}
|
|
182
187
|
],
|
|
183
188
|
"Stop": [
|
|
@@ -78,10 +78,6 @@
|
|
|
78
78
|
"type": "command",
|
|
79
79
|
"command": "${PLUGIN_ROOT}/hooks/block-instruction-file-edits.sh"
|
|
80
80
|
},
|
|
81
|
-
{
|
|
82
|
-
"type": "command",
|
|
83
|
-
"command": "${PLUGIN_ROOT}/hooks/block-direct-issue-create.sh"
|
|
84
|
-
},
|
|
85
81
|
{
|
|
86
82
|
"type": "command",
|
|
87
83
|
"command": "${PLUGIN_ROOT}/hooks/block-blind-automerge.sh"
|
|
@@ -109,6 +105,15 @@
|
|
|
109
105
|
"command": "${PLUGIN_ROOT}/hooks/enforce-verification-gate.sh"
|
|
110
106
|
}
|
|
111
107
|
]
|
|
108
|
+
},
|
|
109
|
+
{
|
|
110
|
+
"matcher": "",
|
|
111
|
+
"hooks": [
|
|
112
|
+
{
|
|
113
|
+
"type": "command",
|
|
114
|
+
"command": "${PLUGIN_ROOT}/hooks/block-direct-issue-create.sh"
|
|
115
|
+
}
|
|
116
|
+
]
|
|
112
117
|
}
|
|
113
118
|
],
|
|
114
119
|
"Stop": [
|
|
@@ -8,9 +8,19 @@
|
|
|
8
8
|
# block-direct-issue-create.sh beside it (same delegation pattern as
|
|
9
9
|
# block-instruction-file-edits.agy.sh).
|
|
10
10
|
#
|
|
11
|
-
#
|
|
12
|
-
# Bash-only by construction, and
|
|
13
|
-
#
|
|
11
|
+
# SCOPE GAP, recorded rather than silently dropped (AGENTS.md). This used to
|
|
12
|
+
# read "no scope gap here: the canonical guard is Bash-only by construction, and
|
|
13
|
+
# `run_command` is exactly the surface it needs." That stopped being true in
|
|
14
|
+
# CodySwannGT/lisa#3753: the canonical guard now covers a SECOND substrate —
|
|
15
|
+
# structured tool payloads, where a creation arrives as named fields rather than
|
|
16
|
+
# as a command line — because the filing contract was enforced on the shell and
|
|
17
|
+
# unenforced on every tool call beside it.
|
|
18
|
+
#
|
|
19
|
+
# This adapter forwards `run_command` and nothing else, so on agy that second
|
|
20
|
+
# substrate is still uncovered. Closing it needs agy's own tool-call envelope
|
|
21
|
+
# (which tool names its creation surface, and where the arguments land), and
|
|
22
|
+
# that is a different piece of work from translating one protocol. The shell
|
|
23
|
+
# surface agy does expose receives the whole guard, exactly as before.
|
|
14
24
|
#
|
|
15
25
|
# Fail-open on missing runtimes: a missed refusal costs one under-declared
|
|
16
26
|
# ticket, and `lisa-repair-intake` already sweeps for exactly that. Failing
|
|
@@ -79,6 +79,36 @@
|
|
|
79
79
|
# settings env block, CI config). An escape the governed agent reaches by
|
|
80
80
|
# typing one more token in front of the command it was just refused is not an
|
|
81
81
|
# escape hatch — it is the prose problem with extra steps.
|
|
82
|
+
#
|
|
83
|
+
# ## What this hook costs, and the number that would change the decision
|
|
84
|
+
#
|
|
85
|
+
# Registered `matcher: ""` since CodySwannGT/lisa#3753 — it runs on EVERY tool
|
|
86
|
+
# call, not only Bash. Measured on a developer machine at load ~8-26, 50
|
|
87
|
+
# invocations per row:
|
|
88
|
+
#
|
|
89
|
+
# 16.7 ms enforce-team-first.sh already `matcher: ""` today
|
|
90
|
+
# 17.5 ms enforce-verification-gate.sh already `matcher: ""` today
|
|
91
|
+
# 11.5 ms this guard, non-Bash payload what the broad matcher adds
|
|
92
|
+
# 112.3 ms this guard, Bash payload what Bash calls already paid
|
|
93
|
+
#
|
|
94
|
+
# So the broad registration was not novel — two hooks were already there, this
|
|
95
|
+
# one is cheaper than either, and it raises an existing ~34 ms per-call baseline
|
|
96
|
+
# by about a third.
|
|
97
|
+
#
|
|
98
|
+
# THIS IS A THRESHOLD, NOT A PRECEDENT. The argument is about the TOTAL cost of
|
|
99
|
+
# the broad set, so it does not transfer to the next guard: four more hooks
|
|
100
|
+
# moved to `matcher: ""` would put ~90 ms on every tool call and the answer
|
|
101
|
+
# flips. **Before widening any other hook's matcher, re-run the measurement and
|
|
102
|
+
# reconsider if the broad set totals more than ~100 ms per tool call, or if any
|
|
103
|
+
# single broad hook exceeds ~50 ms.** Do not cite these numbers for a fifth
|
|
104
|
+
# hook; measure again, because the number that matters is the sum.
|
|
105
|
+
#
|
|
106
|
+
# The cost is also irreducible rather than sloppy. A 9-line script containing
|
|
107
|
+
# only this file's preamble measured 11.7 ms, and padding it to this file's
|
|
108
|
+
# length changed nothing (11.5 ms) — it is process spawn plus one `jq`, not
|
|
109
|
+
# parsing. Moving the early exit further up the file buys nothing; the exit is
|
|
110
|
+
# already ahead of config resolution, which is what keeps the figure at 11.5
|
|
111
|
+
# rather than at the 112 ms the Bash path pays.
|
|
82
112
|
set -euo pipefail
|
|
83
113
|
|
|
84
114
|
input="$(cat)"
|
|
@@ -99,13 +129,72 @@ for required in jq python3; do
|
|
|
99
129
|
done
|
|
100
130
|
|
|
101
131
|
tool_name="$(printf '%s' "$input" | jq -r '.tool_name // empty' 2>/dev/null || true)"
|
|
132
|
+
|
|
133
|
+
# ── The two substrates ────────────────────────────────────────────────────
|
|
134
|
+
#
|
|
135
|
+
# A creation reaches a tracker two ways, and until CodySwannGT/lisa#3753 this
|
|
136
|
+
# guard saw only one of them. It was registered `matcher: "Bash"` AND gated
|
|
137
|
+
# here on `tool_name != "Bash"`, so an MCP tool call was refused entry twice
|
|
138
|
+
# over. MEASURED before the change, driving the guard with synthetic payloads:
|
|
139
|
+
#
|
|
140
|
+
# ALLOW mcp__linear-server__create_issue, undeclared <- the defect
|
|
141
|
+
# ALLOW mcp__github__create_issue, undeclared <- the defect
|
|
142
|
+
# REFUSE the same creation as `gh issue create` shell text <- control
|
|
143
|
+
# ALLOW an ordinary Read tool call <- control
|
|
144
|
+
#
|
|
145
|
+
# The two controls are what make those ALLOWs mean anything: the refusal proves
|
|
146
|
+
# the guard is live, the Read proves it is not simply refusing everything.
|
|
147
|
+
#
|
|
148
|
+
# **Widening the matcher alone would have changed nothing** — the call would
|
|
149
|
+
# arrive and this gate would still exit 0. Anyone who "fixed" #3753 by editing
|
|
150
|
+
# `plugin.json` would have seen no test fail and shipped a guard that still
|
|
151
|
+
# allows every MCP filing. The registration and this gate had to move together.
|
|
152
|
+
#
|
|
153
|
+
# The SHELL path below is untouched. A structured payload has no command line
|
|
154
|
+
# to tokenise, so it gets its own small classifier rather than being forced
|
|
155
|
+
# through a parser built for shell text.
|
|
156
|
+
structured_call=""
|
|
102
157
|
if [ "$tool_name" != "Bash" ]; then
|
|
103
|
-
|
|
158
|
+
# The cheap shape gate, deliberately BEFORE config resolution.
|
|
159
|
+
#
|
|
160
|
+
# This hook now runs on EVERY tool call, so the cost of the path that does
|
|
161
|
+
# nothing is the cost of the whole change. Config resolution spawns two jq
|
|
162
|
+
# processes per lookup and is what makes the Bash path ~112 ms; putting it
|
|
163
|
+
# ahead of this gate would charge that to every Read and Grep. So the
|
|
164
|
+
# not-a-creation exit happens here, on a shell `case` with no subprocess.
|
|
165
|
+
#
|
|
166
|
+
# Matched on SHAPE, not on an enumerated list of server tool names. Server
|
|
167
|
+
# names are supplied by whoever wrote the server and change when one is
|
|
168
|
+
# added or renamed, so a list would pass every row anyone thought of and
|
|
169
|
+
# miss the first one nobody did — the failure mode this repository's guard
|
|
170
|
+
# suites are written to defeat.
|
|
171
|
+
#
|
|
172
|
+
# RESIDUAL, stated rather than hidden: a server whose creation tool is named
|
|
173
|
+
# without a create-verb or without a tracker noun (`mcp__x__file_work`) is
|
|
174
|
+
# not recognised and is allowed. That is a fail-open, and it is the honest
|
|
175
|
+
# cost of refusing to enumerate. Add shapes here as they are measured.
|
|
176
|
+
case "$tool_name" in
|
|
177
|
+
Bash | Read | Write | Edit | MultiEdit | Glob | Grep | Task | TodoWrite)
|
|
178
|
+
exit 0
|
|
179
|
+
;;
|
|
180
|
+
esac
|
|
181
|
+
case "$tool_name" in
|
|
182
|
+
*[Cc]reate* | *[Nn]ew* | *[Aa]dd* | *[Ff]ile*) ;;
|
|
183
|
+
*) exit 0 ;;
|
|
184
|
+
esac
|
|
185
|
+
case "$tool_name" in
|
|
186
|
+
*[Ii]ssue* | *[Tt]icket* | *[Tt]ask* | *[Ss]tory* | *[Bb]ug* | *[Ee]pic* | *[Ww]ork*) ;;
|
|
187
|
+
*) exit 0 ;;
|
|
188
|
+
esac
|
|
189
|
+
structured_call="1"
|
|
104
190
|
fi
|
|
105
191
|
|
|
106
|
-
command_str="
|
|
107
|
-
if [ -z "$
|
|
108
|
-
|
|
192
|
+
command_str=""
|
|
193
|
+
if [ -z "$structured_call" ]; then
|
|
194
|
+
command_str="$(printf '%s' "$input" | jq -r '.tool_input.command // empty' 2>/dev/null || true)"
|
|
195
|
+
if [ -z "$command_str" ]; then
|
|
196
|
+
exit 0
|
|
197
|
+
fi
|
|
109
198
|
fi
|
|
110
199
|
|
|
111
200
|
project_dir="${CLAUDE_PROJECT_DIR:-}"
|
|
@@ -1859,6 +1948,53 @@ print("ALLOW")
|
|
|
1859
1948
|
PY
|
|
1860
1949
|
|
|
1861
1950
|
set +e
|
|
1951
|
+
# ── The structured substrate ──────────────────────────────────────────────
|
|
1952
|
+
#
|
|
1953
|
+
# An MCP call carries named fields, not a command line, so `scan()` — which
|
|
1954
|
+
# tokenises shell text — has nothing to parse. The declaration is read from the
|
|
1955
|
+
# payload instead, and the recogniser is deliberately small: this path decides
|
|
1956
|
+
# ONE question (is a build-ready role or a human-gate marker present anywhere
|
|
1957
|
+
# in the submitted fields), where the shell path has to answer "which of these
|
|
1958
|
+
# tokens is a client, an endpoint, a flag value, or a file it executes".
|
|
1959
|
+
#
|
|
1960
|
+
# Every string in the payload is searched, at any depth, because a role lands
|
|
1961
|
+
# in a different field on every tracker — `labels[]` on GitHub, `stateId` or a
|
|
1962
|
+
# workflow state name on Linear, a transition `id` on JIRA — and enumerating
|
|
1963
|
+
# field names per vendor is the same brittleness as enumerating tool names.
|
|
1964
|
+
# Over-collecting is safe here: the values are compared against ONE configured
|
|
1965
|
+
# role string, so an unrelated field cannot accidentally satisfy it.
|
|
1966
|
+
if [ -n "$structured_call" ]; then
|
|
1967
|
+
# The operator's ambient escape works on both substrates. There is no inline
|
|
1968
|
+
# form to disqualify it here — a structured call has no shell in which to
|
|
1969
|
+
# assign one — so the override is simply honoured.
|
|
1970
|
+
if [ -n "$ambient_override" ]; then
|
|
1971
|
+
exit 0
|
|
1972
|
+
fi
|
|
1973
|
+
|
|
1974
|
+
structured_declaration="$(
|
|
1975
|
+
printf '%s' "$input" |
|
|
1976
|
+
jq -r --arg role "$ready_role" '
|
|
1977
|
+
[(.tool_input // {}) | .. | strings] as $values
|
|
1978
|
+
| if ($values | index($role)) then "role"
|
|
1979
|
+
elif ($values | map(select(contains("[lisa-human-gate]"))) | length) > 0 then "gate"
|
|
1980
|
+
else "" end
|
|
1981
|
+
' 2>/dev/null || printf 'UNREADABLE'
|
|
1982
|
+
)"
|
|
1983
|
+
|
|
1984
|
+
# Fail closed on a creation-shaped call whose payload cannot be read. Silence
|
|
1985
|
+
# about a filing the guard could not inspect is the defect this whole ticket
|
|
1986
|
+
# is about, one substrate over.
|
|
1987
|
+
if [ "$structured_declaration" = "UNREADABLE" ]; then
|
|
1988
|
+
refuse "an unreadable $tool_name payload that reads as a tracker creation" \
|
|
1989
|
+
"$ready_role" ""
|
|
1990
|
+
fi
|
|
1991
|
+
|
|
1992
|
+
if [ -z "$structured_declaration" ]; then
|
|
1993
|
+
refuse "a tracker creation through $tool_name" "$ready_role" ""
|
|
1994
|
+
fi
|
|
1995
|
+
exit 0
|
|
1996
|
+
fi
|
|
1997
|
+
|
|
1862
1998
|
verdict="$(
|
|
1863
1999
|
printf '%s' "$classifier" |
|
|
1864
2000
|
LISA_GUARD_COMMAND="$command_str" \
|
|
@@ -77,6 +77,14 @@ export const FAMILIES = [
|
|
|
77
77
|
match: /(^|\/)\.lisa\.config\.json$/,
|
|
78
78
|
kind: "allow-list",
|
|
79
79
|
},
|
|
80
|
+
{
|
|
81
|
+
// The #3811 quarantine. `allow-list` is exactly right here: the list may
|
|
82
|
+
// shrink freely, and ADDING a file — re-authorising type debt that the
|
|
83
|
+
// gate would otherwise refuse — is the change that needs a human to see it.
|
|
84
|
+
id: "typecheck-quarantine",
|
|
85
|
+
match: /(^|\/)typecheck-quarantine\.json$/,
|
|
86
|
+
kind: "allow-list",
|
|
87
|
+
},
|
|
80
88
|
{
|
|
81
89
|
id: "lighthouse",
|
|
82
90
|
match: /(^|\/)(?:lighthouserc-config|lighthouserc|\.lighthouserc)\.json$/,
|
|
@@ -8,9 +8,19 @@
|
|
|
8
8
|
# block-direct-issue-create.sh beside it (same delegation pattern as
|
|
9
9
|
# block-instruction-file-edits.agy.sh).
|
|
10
10
|
#
|
|
11
|
-
#
|
|
12
|
-
# Bash-only by construction, and
|
|
13
|
-
#
|
|
11
|
+
# SCOPE GAP, recorded rather than silently dropped (AGENTS.md). This used to
|
|
12
|
+
# read "no scope gap here: the canonical guard is Bash-only by construction, and
|
|
13
|
+
# `run_command` is exactly the surface it needs." That stopped being true in
|
|
14
|
+
# CodySwannGT/lisa#3753: the canonical guard now covers a SECOND substrate —
|
|
15
|
+
# structured tool payloads, where a creation arrives as named fields rather than
|
|
16
|
+
# as a command line — because the filing contract was enforced on the shell and
|
|
17
|
+
# unenforced on every tool call beside it.
|
|
18
|
+
#
|
|
19
|
+
# This adapter forwards `run_command` and nothing else, so on agy that second
|
|
20
|
+
# substrate is still uncovered. Closing it needs agy's own tool-call envelope
|
|
21
|
+
# (which tool names its creation surface, and where the arguments land), and
|
|
22
|
+
# that is a different piece of work from translating one protocol. The shell
|
|
23
|
+
# surface agy does expose receives the whole guard, exactly as before.
|
|
14
24
|
#
|
|
15
25
|
# Fail-open on missing runtimes: a missed refusal costs one under-declared
|
|
16
26
|
# ticket, and `lisa-repair-intake` already sweeps for exactly that. Failing
|
|
@@ -79,6 +79,36 @@
|
|
|
79
79
|
# settings env block, CI config). An escape the governed agent reaches by
|
|
80
80
|
# typing one more token in front of the command it was just refused is not an
|
|
81
81
|
# escape hatch — it is the prose problem with extra steps.
|
|
82
|
+
#
|
|
83
|
+
# ## What this hook costs, and the number that would change the decision
|
|
84
|
+
#
|
|
85
|
+
# Registered `matcher: ""` since CodySwannGT/lisa#3753 — it runs on EVERY tool
|
|
86
|
+
# call, not only Bash. Measured on a developer machine at load ~8-26, 50
|
|
87
|
+
# invocations per row:
|
|
88
|
+
#
|
|
89
|
+
# 16.7 ms enforce-team-first.sh already `matcher: ""` today
|
|
90
|
+
# 17.5 ms enforce-verification-gate.sh already `matcher: ""` today
|
|
91
|
+
# 11.5 ms this guard, non-Bash payload what the broad matcher adds
|
|
92
|
+
# 112.3 ms this guard, Bash payload what Bash calls already paid
|
|
93
|
+
#
|
|
94
|
+
# So the broad registration was not novel — two hooks were already there, this
|
|
95
|
+
# one is cheaper than either, and it raises an existing ~34 ms per-call baseline
|
|
96
|
+
# by about a third.
|
|
97
|
+
#
|
|
98
|
+
# THIS IS A THRESHOLD, NOT A PRECEDENT. The argument is about the TOTAL cost of
|
|
99
|
+
# the broad set, so it does not transfer to the next guard: four more hooks
|
|
100
|
+
# moved to `matcher: ""` would put ~90 ms on every tool call and the answer
|
|
101
|
+
# flips. **Before widening any other hook's matcher, re-run the measurement and
|
|
102
|
+
# reconsider if the broad set totals more than ~100 ms per tool call, or if any
|
|
103
|
+
# single broad hook exceeds ~50 ms.** Do not cite these numbers for a fifth
|
|
104
|
+
# hook; measure again, because the number that matters is the sum.
|
|
105
|
+
#
|
|
106
|
+
# The cost is also irreducible rather than sloppy. A 9-line script containing
|
|
107
|
+
# only this file's preamble measured 11.7 ms, and padding it to this file's
|
|
108
|
+
# length changed nothing (11.5 ms) — it is process spawn plus one `jq`, not
|
|
109
|
+
# parsing. Moving the early exit further up the file buys nothing; the exit is
|
|
110
|
+
# already ahead of config resolution, which is what keeps the figure at 11.5
|
|
111
|
+
# rather than at the 112 ms the Bash path pays.
|
|
82
112
|
set -euo pipefail
|
|
83
113
|
|
|
84
114
|
input="$(cat)"
|
|
@@ -99,13 +129,72 @@ for required in jq python3; do
|
|
|
99
129
|
done
|
|
100
130
|
|
|
101
131
|
tool_name="$(printf '%s' "$input" | jq -r '.tool_name // empty' 2>/dev/null || true)"
|
|
132
|
+
|
|
133
|
+
# ── The two substrates ────────────────────────────────────────────────────
|
|
134
|
+
#
|
|
135
|
+
# A creation reaches a tracker two ways, and until CodySwannGT/lisa#3753 this
|
|
136
|
+
# guard saw only one of them. It was registered `matcher: "Bash"` AND gated
|
|
137
|
+
# here on `tool_name != "Bash"`, so an MCP tool call was refused entry twice
|
|
138
|
+
# over. MEASURED before the change, driving the guard with synthetic payloads:
|
|
139
|
+
#
|
|
140
|
+
# ALLOW mcp__linear-server__create_issue, undeclared <- the defect
|
|
141
|
+
# ALLOW mcp__github__create_issue, undeclared <- the defect
|
|
142
|
+
# REFUSE the same creation as `gh issue create` shell text <- control
|
|
143
|
+
# ALLOW an ordinary Read tool call <- control
|
|
144
|
+
#
|
|
145
|
+
# The two controls are what make those ALLOWs mean anything: the refusal proves
|
|
146
|
+
# the guard is live, the Read proves it is not simply refusing everything.
|
|
147
|
+
#
|
|
148
|
+
# **Widening the matcher alone would have changed nothing** — the call would
|
|
149
|
+
# arrive and this gate would still exit 0. Anyone who "fixed" #3753 by editing
|
|
150
|
+
# `plugin.json` would have seen no test fail and shipped a guard that still
|
|
151
|
+
# allows every MCP filing. The registration and this gate had to move together.
|
|
152
|
+
#
|
|
153
|
+
# The SHELL path below is untouched. A structured payload has no command line
|
|
154
|
+
# to tokenise, so it gets its own small classifier rather than being forced
|
|
155
|
+
# through a parser built for shell text.
|
|
156
|
+
structured_call=""
|
|
102
157
|
if [ "$tool_name" != "Bash" ]; then
|
|
103
|
-
|
|
158
|
+
# The cheap shape gate, deliberately BEFORE config resolution.
|
|
159
|
+
#
|
|
160
|
+
# This hook now runs on EVERY tool call, so the cost of the path that does
|
|
161
|
+
# nothing is the cost of the whole change. Config resolution spawns two jq
|
|
162
|
+
# processes per lookup and is what makes the Bash path ~112 ms; putting it
|
|
163
|
+
# ahead of this gate would charge that to every Read and Grep. So the
|
|
164
|
+
# not-a-creation exit happens here, on a shell `case` with no subprocess.
|
|
165
|
+
#
|
|
166
|
+
# Matched on SHAPE, not on an enumerated list of server tool names. Server
|
|
167
|
+
# names are supplied by whoever wrote the server and change when one is
|
|
168
|
+
# added or renamed, so a list would pass every row anyone thought of and
|
|
169
|
+
# miss the first one nobody did — the failure mode this repository's guard
|
|
170
|
+
# suites are written to defeat.
|
|
171
|
+
#
|
|
172
|
+
# RESIDUAL, stated rather than hidden: a server whose creation tool is named
|
|
173
|
+
# without a create-verb or without a tracker noun (`mcp__x__file_work`) is
|
|
174
|
+
# not recognised and is allowed. That is a fail-open, and it is the honest
|
|
175
|
+
# cost of refusing to enumerate. Add shapes here as they are measured.
|
|
176
|
+
case "$tool_name" in
|
|
177
|
+
Bash | Read | Write | Edit | MultiEdit | Glob | Grep | Task | TodoWrite)
|
|
178
|
+
exit 0
|
|
179
|
+
;;
|
|
180
|
+
esac
|
|
181
|
+
case "$tool_name" in
|
|
182
|
+
*[Cc]reate* | *[Nn]ew* | *[Aa]dd* | *[Ff]ile*) ;;
|
|
183
|
+
*) exit 0 ;;
|
|
184
|
+
esac
|
|
185
|
+
case "$tool_name" in
|
|
186
|
+
*[Ii]ssue* | *[Tt]icket* | *[Tt]ask* | *[Ss]tory* | *[Bb]ug* | *[Ee]pic* | *[Ww]ork*) ;;
|
|
187
|
+
*) exit 0 ;;
|
|
188
|
+
esac
|
|
189
|
+
structured_call="1"
|
|
104
190
|
fi
|
|
105
191
|
|
|
106
|
-
command_str="
|
|
107
|
-
if [ -z "$
|
|
108
|
-
|
|
192
|
+
command_str=""
|
|
193
|
+
if [ -z "$structured_call" ]; then
|
|
194
|
+
command_str="$(printf '%s' "$input" | jq -r '.tool_input.command // empty' 2>/dev/null || true)"
|
|
195
|
+
if [ -z "$command_str" ]; then
|
|
196
|
+
exit 0
|
|
197
|
+
fi
|
|
109
198
|
fi
|
|
110
199
|
|
|
111
200
|
project_dir="${CLAUDE_PROJECT_DIR:-}"
|
|
@@ -1859,6 +1948,53 @@ print("ALLOW")
|
|
|
1859
1948
|
PY
|
|
1860
1949
|
|
|
1861
1950
|
set +e
|
|
1951
|
+
# ── The structured substrate ──────────────────────────────────────────────
|
|
1952
|
+
#
|
|
1953
|
+
# An MCP call carries named fields, not a command line, so `scan()` — which
|
|
1954
|
+
# tokenises shell text — has nothing to parse. The declaration is read from the
|
|
1955
|
+
# payload instead, and the recogniser is deliberately small: this path decides
|
|
1956
|
+
# ONE question (is a build-ready role or a human-gate marker present anywhere
|
|
1957
|
+
# in the submitted fields), where the shell path has to answer "which of these
|
|
1958
|
+
# tokens is a client, an endpoint, a flag value, or a file it executes".
|
|
1959
|
+
#
|
|
1960
|
+
# Every string in the payload is searched, at any depth, because a role lands
|
|
1961
|
+
# in a different field on every tracker — `labels[]` on GitHub, `stateId` or a
|
|
1962
|
+
# workflow state name on Linear, a transition `id` on JIRA — and enumerating
|
|
1963
|
+
# field names per vendor is the same brittleness as enumerating tool names.
|
|
1964
|
+
# Over-collecting is safe here: the values are compared against ONE configured
|
|
1965
|
+
# role string, so an unrelated field cannot accidentally satisfy it.
|
|
1966
|
+
if [ -n "$structured_call" ]; then
|
|
1967
|
+
# The operator's ambient escape works on both substrates. There is no inline
|
|
1968
|
+
# form to disqualify it here — a structured call has no shell in which to
|
|
1969
|
+
# assign one — so the override is simply honoured.
|
|
1970
|
+
if [ -n "$ambient_override" ]; then
|
|
1971
|
+
exit 0
|
|
1972
|
+
fi
|
|
1973
|
+
|
|
1974
|
+
structured_declaration="$(
|
|
1975
|
+
printf '%s' "$input" |
|
|
1976
|
+
jq -r --arg role "$ready_role" '
|
|
1977
|
+
[(.tool_input // {}) | .. | strings] as $values
|
|
1978
|
+
| if ($values | index($role)) then "role"
|
|
1979
|
+
elif ($values | map(select(contains("[lisa-human-gate]"))) | length) > 0 then "gate"
|
|
1980
|
+
else "" end
|
|
1981
|
+
' 2>/dev/null || printf 'UNREADABLE'
|
|
1982
|
+
)"
|
|
1983
|
+
|
|
1984
|
+
# Fail closed on a creation-shaped call whose payload cannot be read. Silence
|
|
1985
|
+
# about a filing the guard could not inspect is the defect this whole ticket
|
|
1986
|
+
# is about, one substrate over.
|
|
1987
|
+
if [ "$structured_declaration" = "UNREADABLE" ]; then
|
|
1988
|
+
refuse "an unreadable $tool_name payload that reads as a tracker creation" \
|
|
1989
|
+
"$ready_role" ""
|
|
1990
|
+
fi
|
|
1991
|
+
|
|
1992
|
+
if [ -z "$structured_declaration" ]; then
|
|
1993
|
+
refuse "a tracker creation through $tool_name" "$ready_role" ""
|
|
1994
|
+
fi
|
|
1995
|
+
exit 0
|
|
1996
|
+
fi
|
|
1997
|
+
|
|
1862
1998
|
verdict="$(
|
|
1863
1999
|
printf '%s' "$classifier" |
|
|
1864
2000
|
LISA_GUARD_COMMAND="$command_str" \
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa",
|
|
3
|
-
"version": "4.38.
|
|
3
|
+
"version": "4.38.3",
|
|
4
4
|
"description": "Universal governance — agents, skills, commands, hooks, and rules for all projects",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -84,10 +84,6 @@
|
|
|
84
84
|
"type": "command",
|
|
85
85
|
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/block-instruction-file-edits.sh"
|
|
86
86
|
},
|
|
87
|
-
{
|
|
88
|
-
"type": "command",
|
|
89
|
-
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/block-direct-issue-create.sh"
|
|
90
|
-
},
|
|
91
87
|
{
|
|
92
88
|
"type": "command",
|
|
93
89
|
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/block-blind-automerge.sh"
|
|
@@ -115,6 +111,15 @@
|
|
|
115
111
|
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/enforce-verification-gate.sh"
|
|
116
112
|
}
|
|
117
113
|
]
|
|
114
|
+
},
|
|
115
|
+
{
|
|
116
|
+
"matcher": "",
|
|
117
|
+
"hooks": [
|
|
118
|
+
{
|
|
119
|
+
"type": "command",
|
|
120
|
+
"command": "${CLAUDE_PLUGIN_ROOT}/hooks/block-direct-issue-create.sh"
|
|
121
|
+
}
|
|
122
|
+
]
|
|
118
123
|
}
|
|
119
124
|
],
|
|
120
125
|
"agentStop": [
|