@codyswann/lisa 4.33.4 → 4.33.5

package/eslint-plugin-component-structure/rules/no-hooks-in-view.js

@@ -0,0 +1,101 @@
+/**
+ * This file is managed by Lisa.
+ * Do not edit directly — changes will be overwritten on the next `lisa` run.
+ */
+
+/**
+ * ESLint rule banning hook calls anywhere in a View component file.
+ *
+ * The Container/View skill has said "View should not contain hooks" since it was
+ * written, and for that whole time nothing enforced it — the skill's own table
+ * of "ESLint rules that enforce the pattern" listed four rules, none of which
+ * looked at a hook. This rule is the missing half.
+ *
+ * The matcher is a SHAPE — `use` followed by an uppercase letter, called — and
+ * deliberately never a list of names. The call that made the gap expensive was a
+ * project-local custom hook, so any rule built on an enumerated list would have
+ * missed the one that mattered. That is also why there is no exemption list:
+ * a custom data hook and a render helper are indistinguishable by name, so
+ * `useMemo` and `useCallback` are caught too. The skill already forbids
+ * `useMemo` in a View, so exempting it would contradict the document.
+ *
+ * Scope is the file, not the component body: a hook called from a local render
+ * helper still runs during that View's render.
+ * @module eslint-plugin-component-structure/rules/no-hooks-in-view
+ */
+
+const { isEnforcedViewFile } = require("../lib/view-file-scope");
+
+/** `use` plus an uppercase letter — React's own definition of a hook name. */
+const HOOK_NAME = /^use[A-Z]\w*$/u;
+
+/**
+ * The hook a call expression invokes, if it invokes one.
+ *
+ * Covers the bare call (`useFlag()`) and the namespaced one
+ * (`React.useMemo()`); a computed member access is not a statically knowable
+ * name and is left to `no-restricted-imports` and review.
+ * @param {object} callee - The callee of a CallExpression.
+ * @returns {string|null} The hook name, or null when this is not a hook call.
+ */
+function hookName(callee) {
+  if (callee.type === "Identifier" && HOOK_NAME.test(callee.name)) {
+    return callee.name;
+  }
+
+  if (
+    callee.type === "MemberExpression" &&
+    !callee.computed &&
+    callee.property.type === "Identifier" &&
+    HOOK_NAME.test(callee.property.name)
+  ) {
+    return callee.property.name;
+  }
+
+  return null;
+}
+
+module.exports = {
+  meta: {
+    type: "problem",
+    docs: {
+      description:
+        "Disallow hook calls in View components - hooks belong in the Container",
+      category: "Best Practices",
+      recommended: true,
+    },
+    fixable: null,
+    schema: [],
+    messages: {
+      // The message names the escape route on purpose. "No hooks in Views" with
+      // no way out is what makes a developer — or an agent — reach for a disable
+      // comment, and there is no disable this rule will accept.
+      //
+      // The Container is always a legitimate home: Containers may hold logic,
+      // including a callback that returns JSX. The row-component alternative is
+      // named for the `renderItem` shape, where lifting the callback moves JSX
+      // rather than removing it — it is an OPTION, never a requirement.
+      noHooksInView:
+        "View components must not call hooks. Move {{hook}}() into the corresponding Container and pass its result down as a prop — Containers may hold logic, including a callback that returns JSX. If {{hook}}() builds a row (a renderItem or render* callback), extracting that row into its own memoised component is an equally valid alternative.",
+    },
+  },
+
+  create(context) {
+    if (!isEnforcedViewFile(context.getFilename())) {
+      return {};
+    }
+
+    return {
+      CallExpression(node) {
+        const hook = hookName(node.callee);
+        if (hook !== null) {
+          context.report({
+            node,
+            messageId: "noHooksInView",
+            data: { hook },
+          });
+        }
+      },
+    };
+  },
+};

package/eslint-plugin-component-structure/rules/no-return-in-view.js

@@ -3,12 +3,85 @@
  * Do not edit directly — changes will be overwritten on the next `lisa` run.
  */
 
+/**
+ * ESLint rule requiring a View component to be an expression-bodied arrow.
+ *
+ * Stated that way on purpose. The rule used to be stated as "no return
+ * statements", registered exactly one `ArrowFunctionExpression` visitor, and
+ * nothing anywhere required a View to be an arrow function — so
+ * `const XView = (...) => { ... }` was blocked while `function XView(...) { ... }`
+ * was never visited and reported nothing, with `require-memo-in-view` still
+ * passing because it checks the export. Writing `function` instead of `const`
+ * was a silent, complete, permanent opt-out of the only statement gate on Views.
+ *
+ * An expression body is a property a `FunctionDeclaration` cannot have, so
+ * requiring it bans declaration form by construction — no prose scanning, no
+ * substring match on the word "function" (which fires on JSDoc, on local render
+ * helpers, and on disable-comment justifications), and no false-positive
+ * surface.
+ *
+ * What this rule guarantees is "no statement list". It is NOT a purity gate:
+ * `{Date.now()}` and `{Math.random() > 0.5 ? … : …}` sit happily in an
+ * expression body. Hooks are the other half and are `no-hooks-in-view`'s job.
+ * @module eslint-plugin-component-structure/rules/no-return-in-view
+ */
+
+const { isEnforcedViewFile } = require("../lib/view-file-scope");
+
+/**
+ * Whether an identifier names a View component by spelling.
+ * @param {string} name - The declared identifier.
+ * @returns {boolean} True for a PascalCase name containing "View".
+ */
+const isViewComponentName = name =>
+  /^[A-Z]/u.test(name) && name.includes("View");
+
+/**
+ * The binding a function expression or arrow is assigned to, if any.
+ * @param {object} node - The function node.
+ * @returns {string|null} The declared name, or null when there is none.
+ */
+function declaredName(node) {
+  const parent = node.parent;
+  return parent &&
+    parent.type === "VariableDeclarator" &&
+    parent.id.type === "Identifier"
+    ? parent.id.name
+    : null;
+}
+
+/**
+ * The identifier a default export ultimately names.
+ *
+ * Unwraps `memo(X)` and `React.memo(X)` so the component the file actually
+ * exports is recognised whatever it is called. Without this the rule would
+ * depend on the identifier containing the word "View", and a file named
+ * `HomeScreenView.tsx` exporting `HomeScreen` would slip through — the same
+ * class of spelling-dependent hole the rule is being fixed for.
+ * @param {object} declaration - The `export default` declaration node.
+ * @returns {string|null} The exported identifier, or null.
+ */
+function defaultExportedName(declaration) {
+  if (declaration.type === "Identifier") {
+    return declaration.name;
+  }
+
+  if (declaration.type !== "CallExpression") {
+    return null;
+  }
+
+  const [firstArgument] = declaration.arguments;
+  return firstArgument && firstArgument.type === "Identifier"
+    ? firstArgument.name
+    : null;
+}
+
 module.exports = {
   meta: {
     type: "problem",
     docs: {
       description:
-        "Disallow return statements in View components - use arrow function shorthand",
+        "Require View components to be arrow functions with an expression body (no statements)",
       category: "Best Practices",
       recommended: true,
     },
@@ -16,81 +89,79 @@ module.exports = {
     schema: [],
     messages: {
       noReturnInView:
-        "View components should use arrow function shorthand: () => (...) instead of () => { return (...) }. Hoist any definitions outside of the arrow function body or into the corresponding Container.",
+        "View components must use an expression body: () => (...) instead of () => { return (...) }. Hoist any definitions outside of the arrow function body or into the corresponding Container.",
+      mustBeArrowFunction:
+        "View components must be an arrow function with an expression body: const {{name}} = (props) => (...). A function declaration or function expression cannot have one, so it always carries a statement list — move that logic into the corresponding Container.",
     },
   },
 
   create(context) {
-    const filename = context.getFilename();
-    const normalizedPath = filename.replace(/\\/g, "/");
-
-    // Only check View.tsx and View.jsx files
-    if (!filename.endsWith("View.tsx") && !filename.endsWith("View.jsx")) {
+    if (!isEnforcedViewFile(context.getFilename())) {
       return {};
     }
 
-    // Check if file is in features/**/components, features/**/screens, or components directory
-    const isFeatureComponent =
-      normalizedPath.includes("features/") &&
-      normalizedPath.includes("/components/");
-    const isFeatureScreen =
-      normalizedPath.includes("features/") &&
-      normalizedPath.includes("/screens/");
-    const isComponentsDir =
-      normalizedPath.includes("/components/") &&
-      !normalizedPath.includes("/components/ui/") &&
-      !normalizedPath.includes("/components/custom/ui/");
-
-    if (!isFeatureComponent && !isFeatureScreen && !isComponentsDir) {
-      return {};
-    }
+    /** Statement-bodied functions that are not arrows, pending a verdict. */
+    const nonArrowCandidates = [];
+    /** Names the default export resolves to. */
+    const exportedNames = new Set();
+
+    /**
+     * Record a non-arrow function that may be this file's View component.
+     * @param {object} node - The FunctionDeclaration or FunctionExpression.
+     * @param {string|null} name - Its declared name, when it has one.
+     * @returns {void}
+     */
+    const considerNonArrow = (node, name) => {
+      const isDefaultExported =
+        node.parent && node.parent.type === "ExportDefaultDeclaration";
+      nonArrowCandidates.push({ node, name, isDefaultExported });
+    };
 
     return {
       ArrowFunctionExpression(node) {
-        // Check if this is a component (starts with capital letter or is exported)
         const parent = node.parent;
+        const name = declaredName(node);
+        const isComponent =
+          (parent && parent.type === "ExportDefaultDeclaration") ||
+          (name !== null && isViewComponentName(name));
 
-        // Helper to check if variable has a View component name
-        const isViewComponent = name =>
-          /^[A-Z]/.test(name) && name.includes("View");
-
-        // Determine if this is a component
-        const isComponent = (() => {
-          // Check if it's a default export
-          if (parent.type === "ExportDefaultDeclaration") {
-            return true;
-          }
-
-          // Check if it's a variable declaration with PascalCase name
-          if (
-            parent.type === "VariableDeclarator" &&
-            parent.id.type === "Identifier"
-          ) {
-            return isViewComponent(parent.id.name);
-          }
-
-          // Check if it's part of an export statement
-          if (
-            parent.type === "VariableDeclarator" &&
-            parent.parent.type === "VariableDeclaration" &&
-            parent.parent.parent.type === "ExportNamedDeclaration"
-          ) {
-            return isViewComponent(parent.id.name);
-          }
-
-          return false;
-        })();
-
-        if (!isComponent) return;
-
-        // Check if the arrow function has a block body (any BlockStatement is forbidden)
-        if (node.body.type === "BlockStatement") {
-          context.report({
-            node,
-            messageId: "noReturnInView",
-          });
+        if (isComponent && node.body.type === "BlockStatement") {
+          context.report({ node, messageId: "noReturnInView" });
         }
       },
+
+      FunctionDeclaration(node) {
+        considerNonArrow(node, node.id ? node.id.name : null);
+      },
+
+      FunctionExpression(node) {
+        considerNonArrow(node, declaredName(node));
+      },
+
+      ExportDefaultDeclaration(node) {
+        const name = defaultExportedName(node.declaration);
+        if (name !== null) {
+          exportedNames.add(name);
+        }
+      },
+
+      "Program:exit"() {
+        nonArrowCandidates
+          .filter(
+            candidate =>
+              candidate.isDefaultExported ||
+              (candidate.name !== null &&
+                (isViewComponentName(candidate.name) ||
+                  exportedNames.has(candidate.name)))
+          )
+          .forEach(candidate => {
+            context.report({
+              node: candidate.node,
+              messageId: "mustBeArrowFunction",
+              data: { name: candidate.name ?? "ComponentView" },
+            });
+          });
+      },
     };
   },
 };

package/expo/copy-overwrite/eslint.expo.ts

@@ -59,6 +59,39 @@ const componentStructure = require("@codyswann/eslint-plugin-component-structure
 const uiStandards = require("@codyswann/eslint-plugin-ui-standards");
 const expoConfig = require("eslint-config-expo/flat");
 
+/**
+ * React's hook named exports, banned from a View's import list.
+ *
+ * An enumeration is correct HERE and nowhere else: React's hook set is fixed and
+ * published, and this is the import-line axis. The call-site axis
+ * (`component-structure/no-hooks-in-view`) matches by shape precisely because a
+ * project-local custom hook can never appear on a list like this one.
+ */
+const REACT_HOOK_IMPORT_NAMES = [
+  "useActionState",
+  "useCallback",
+  "useContext",
+  "useDebugValue",
+  "useDeferredValue",
+  "useEffect",
+  "useEffectEvent",
+  "useId",
+  "useImperativeHandle",
+  "useInsertionEffect",
+  "useLayoutEffect",
+  "useMemo",
+  "useOptimistic",
+  "useReducer",
+  "useRef",
+  "useState",
+  "useSyncExternalStore",
+  "useTransition",
+];
+
+/** What a developer is told when a View imports a hook. */
+const VIEW_HOOK_IMPORT_MESSAGE =
+  "View components must not use hooks. Move the hook into the corresponding Container and pass its result down as a prop.";
+
 /**
  * A project's `.lisa.config.json`, when it has one.
  *
@@ -371,7 +404,13 @@ export function getExpoConfig({
       },
     },
 
-    // View component rules
+    // View component rules: no statements, no hooks.
+    //
+    // Stated as those two properties rather than as "Views are pure functions",
+    // which is a guarantee neither rule delivers — `{Date.now()}` and
+    // `{Math.random() > 0.5 ? … : …}` sit happily in an expression body. The
+    // skill claiming an enforcement it did not have is what let a hook live in
+    // a View for so long; the fix must not repeat the shape of the defect.
     {
       files: ["**/*View.tsx", "**/*View.jsx"],
       rules: {
@@ -379,6 +418,54 @@ export function getExpoConfig({
       },
     },
 
+    // View hook ban, on two independent axes.
+    //
+    // `no-hooks-in-view` matches the CALL by shape (`use` + uppercase), so a
+    // project-local custom hook is caught where an enumerated name list would
+    // miss it. `no-restricted-imports` catches the IMPORT LINE, before a call
+    // site exists. Neither subsumes the other: a hook re-exported through a
+    // barrel escapes the import patterns, and an import with no call yet
+    // escapes the call matcher.
+    //
+    // `paths` may enumerate here because React's hook set is fixed and
+    // published; the generic half is the rule, not this list. Scope matches the
+    // Container/View pattern's own applicability table, and the base
+    // `@/features/*/*` restriction is carried forward because a flat-config
+    // override replaces a rule's options wholesale.
+    {
+      files: ["**/*View.tsx", "**/*View.jsx"],
+      ignores: [
+        "components/ui/**",
+        "components/shared/**",
+        "components/icons/**",
+      ],
+      rules: {
+        "component-structure/no-hooks-in-view": "error",
+        "no-restricted-imports": [
+          "error",
+          {
+            paths: [
+              {
+                name: "react",
+                importNames: REACT_HOOK_IMPORT_NAMES,
+                message: VIEW_HOOK_IMPORT_MESSAGE,
+              },
+            ],
+            patterns: [
+              // Objects, not a mix: `no-restricted-imports` accepts an array of
+              // strings OR an array of objects, never both, and a mixed array
+              // is a schema error that disables the whole override.
+              { group: ["@/features/*/*"] },
+              {
+                group: ["**/hooks/**", "@/hooks/**", "~/hooks/**"],
+                message: VIEW_HOOK_IMPORT_MESSAGE,
+              },
+            ],
+          },
+        ],
+      },
+    },
+
     // View memo requirement (excluding UI components)
     {
       files: ["**/*View.tsx", "**/*View.jsx"],

package/package.json

@@ -165,7 +165,7 @@
     "zod-validation-error": "^4.0.0"
   },
   "name": "@codyswann/lisa",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "Claude Code governance framework that applies guardrails, guidance, and automated enforcement to projects",
   "main": "dist/index.js",
   "exports": {
@@ -313,7 +313,7 @@
     "test": "tests"
   },
   "types": "./dist/index.d.ts",
-  "lisaReleaseCommit": "e48bd2085b8b7e9a93defcede3adda0984be0172",
-  "gitHead": "e48bd2085b8b7e9a93defcede3adda0984be0172",
-  "lisaReleaseTag": "v4.33.4"
+  "lisaReleaseCommit": "093c20ef2f67eadda94e473ffe5ff52cd14e1107",
+  "gitHead": "093c20ef2f67eadda94e473ffe5ff52cd14e1107",
+  "lisaReleaseTag": "v4.33.5"
 }

package/plugins/lisa/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "Universal governance — agents, skills, commands, hooks, and rules for all projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "Universal governance: agents, skills, commands, hooks, and rules for all projects.",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "Universal governance — agents, skills, commands, hooks, and rules for all projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-cdk/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-cdk",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "AWS CDK-specific plugin",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-cdk/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-cdk",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "AWS CDK-specific Lisa plugin.",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-cdk-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-cdk",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "AWS CDK-specific plugin",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-cdk-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-cdk",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "AWS CDK-specific plugin",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-cdk-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-cdk",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "AWS CDK-specific plugin",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "Universal governance — agents, skills, commands, hooks, and rules for all projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "Universal governance — agents, skills, commands, hooks, and rules for all projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-expo/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-expo",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "Expo/React Native-specific skills, agents, rules, and MCP servers",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-expo/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-expo",
-  "version": "4.33.4",
+  "version": "4.33.5",
   "description": "Expo and React Native-specific skills, agents, rules, and MCP servers.",
   "author": {
     "name": "Cody Swann"