@codyswann/lisa 4.33.3 → 4.33.5

package/plugins/lisa-expo-cursor/skills/container-view-pattern/scripts/validate_component.py

@@ -10,11 +10,29 @@ This script validates that a component directory follows the Container/View patt
 - Has index.tsx with correct export
 - View uses memo() wrapper
 - View has displayName
-- View uses arrow function shorthand
+- View is an arrow function with an expression body (declaration form is a
+  violation, not an alternative spelling)
+- View calls no hooks — matched by SHAPE (`use` + uppercase), never by a list of
+  names, because the call that motivated this check was a project-local custom
+  hook that no list would have contained
+
+One check reports as an ADVISORY rather than an error: "Container renders JSX
+besides the View". It is a whole-file text scan that cannot tell a returned JSX
+tree from JSX inside a callback, so a Container holding a legitimate `renderItem`
+trips it — and moving a `renderItem` out of a View is one of the sanctioned fixes
+for the View hook ban. It prints and does not fail.
+
+This is a fast pre-check, not the gate. ESLint reads the AST of every file;
+this reads one directory with regexes. When they disagree, ESLint is right.
 
 Usage:
     python3 validate_component.py <path-to-component-directory>
 
+The script ships inside the Lisa plugin, not in a consumer's `.claude/skills/`,
+so invoke it through the plugin root:
+
+    python3 "${CLAUDE_PLUGIN_ROOT:-node_modules/@codyswann/lisa/plugins/lisa-expo}/skills/container-view-pattern/scripts/validate_component.py" <path>
+
 Example:
     python3 validate_component.py features/player-kanban/components/AddColumnButton
 """
@@ -25,21 +43,118 @@ import sys
 from pathlib import Path
 
 
-def validate_component(component_path: str) -> tuple[bool, list[str]]:
+HOOK_CALL = re.compile(r"\b(use[A-Z]\w*)\s*\(")
+"""Every hook call, by SHAPE.
+
+`use` followed by an uppercase letter is React's own definition of a hook name,
+so this matches `useState`, `useMemo`, and every project-local custom hook
+alike. It is a shape and never a list: a list is what let
+`useCreateNoteQuickActionEnabled()` through.
+
+It also matches hook calls inside comments and strings. That is the accepted
+cost of a regex pre-check; ESLint's `component-structure/no-hooks-in-view` reads
+the AST and is the gate.
+"""
+
+
+def _arrow_body_is_block(source: str, start: int) -> bool:
+    """
+    Whether the arrow beginning at `start` has a block body.
+
+    Walks to the first top-level `=>` instead of matching a parameter list with
+    `\\([^)]*\\)`, which fails on any nested paren — a destructured parameter with
+    a default, a type annotation carrying a function type, or a parenthesised
+    union.
+
+    Args:
+        source: The View file's text.
+        start: Index just past the `const <Name>View` binding.
+
+    Returns:
+        True when the arrow's body opens with `{`.
+    """
+    depth = 0
+    index = start
+    while index < len(source) - 1:
+        char = source[index]
+        if char in "([{":
+            depth += 1
+        elif char in ")]}":
+            depth -= 1
+        elif char == ";" and depth == 0:
+            return False
+        elif depth == 0 and source[index : index + 2] == "=>":
+            rest = source[index + 2 :].lstrip()
+            return rest.startswith("{")
+        index += 1
+    return False
+
+
+def view_form_errors(component_name: str, view_content: str) -> list[str]:
+    """
+    Errors about the FORM of the View component.
+
+    The requirement is an arrow function with an expression body. A function
+    declaration cannot have one, so declaration form is banned by construction
+    rather than by scanning for the word "function" — which would fire on JSDoc
+    prose, on local render helpers, and on disable-comment justifications, none
+    of which are the View component.
+
+    Args:
+        component_name: The component directory's name, without the View suffix.
+        view_content: The View file's text.
+
+    Returns:
+        Zero or one error message.
+    """
+    name = f"{component_name}View"
+    expected = f"const {name} = (props) => (...)"
+
+    if re.search(rf"\bfunction\s+{re.escape(name)}\b", view_content):
+        return [
+            f"View must be an arrow function with an expression body: {expected}. "
+            "A function declaration cannot have one, so it always carries a statement list."
+        ]
+
+    function_expression = re.search(
+        rf"\bconst\s+{re.escape(name)}\b[^=]*=\s*function\b", view_content
+    )
+    if function_expression:
+        return [
+            f"View must be an arrow function with an expression body: {expected}. "
+            "A function expression cannot have one."
+        ]
+
+    binding = re.search(rf"\bconst\s+{re.escape(name)}\b", view_content)
+    if binding and _arrow_body_is_block(view_content, binding.end()):
+        return [
+            "View should use arrow function shorthand: () => (...) instead of () => { return (...) }"
+        ]
+
+    return []
+
+
+def validate_component(component_path: str) -> tuple[bool, list[str], list[str]]:
     """
     Validate a component directory follows Container/View pattern.
 
+    Errors and advisories are separated because one check here cannot decide
+    what it reports on — see the Container JSX scan below. A check that cannot
+    tell a violation from a legitimate shape must say so rather than fail the
+    run; a confident wrong verdict is worse than a flagged uncertainty.
+
     Args:
         component_path: Path to the component directory
 
     Returns:
-        Tuple of (is_valid, list of error messages)
+        Tuple of (is_valid, list of error messages, list of advisory messages)
     """
     errors = []
+    advisories = []
     component_dir = Path(component_path)
 
     if not component_dir.is_dir():
-        return False, [f"Path is not a directory: {component_path}"]
+        return False, [f"Path is not a directory: {component_path}"], advisories
 
     component_name = component_dir.name
 
@@ -92,39 +207,24 @@ def validate_component(component_path: str) -> tuple[bool, list[str]]:
         if not re.search(display_name_pattern, view_content):
             errors.append(f"View should have displayName: {component_name}View.displayName = \"{component_name}View\"")
 
-        # Check for block body (return statement) in main component
-        # This is a simplified check - ESLint does the full validation
-        block_body_pattern = rf"const\s+{component_name}View\s*=\s*\([^)]*\)\s*=>\s*{{"
-        if re.search(block_body_pattern, view_content):
-            errors.append("View should use arrow function shorthand: () => (...) instead of () => { return (...) }")
-
-        # Check for hooks in View (they should be in Container)
-        hook_patterns = [
-            r"\buse[A-Z]\w+\s*\(",  # General hook pattern
-            r"\buseState\s*\(",
-            r"\buseEffect\s*\(",
-            r"\buseMemo\s*\(",
-            r"\buseCallback\s*\(",
-            r"\buseReducer\s*\(",
-            r"\buseContext\s*\(",
-        ]
-
-        for hook_pattern in hook_patterns:
-            # Exclude memo import check
-            if hook_pattern == r"\buse[A-Z]\w+\s*\(":
-                # More specific check to avoid false positives
-                if re.search(r"\buseState\s*\(", view_content):
-                    errors.append("View should not contain useState - move to Container")
-                    break
-                if re.search(r"\buseEffect\s*\(", view_content):
-                    errors.append("View should not contain useEffect - move to Container")
-                    break
-                if re.search(r"\buseMemo\s*\(", view_content):
-                    errors.append("View should not contain useMemo - move to Container")
-                    break
-                if re.search(r"\buseCallback\s*\(", view_content):
-                    errors.append("View should not contain useCallback - move to Container")
-                    break
+        # Check the View component's form.
+        #
+        # The old check was `const {name}View = ([^)]*) => {` — arrow-only, and
+        # therefore blind to `function {name}View(...) {`, independently
+        # reproducing the exact defect the ESLint rule carried. It also broke on
+        # any parameter list containing a nested paren.
+        errors.extend(view_form_errors(component_name, view_content))
+
+        # Check for hooks in View (they should be in Container).
+        #
+        # One generic shape match, deliberately. The previous version listed
+        # `\buse[A-Z]\w+\s*\(` first and then narrowed to four hardcoded names
+        # and `break`ed, so the general pattern was UNREACHABLE — dead code that
+        # read as coverage. A project-local hook such as
+        # `useCreateNoteQuickActionEnabled()` matched the pattern that was never
+        # evaluated and none of the four that were.
+        for hook in sorted(set(HOOK_CALL.findall(view_content))):
+            errors.append(f"View should not contain {hook} - move to Container")
 
     # Validate Container file
     if container_file.exists():
@@ -140,14 +240,31 @@ def validate_component(component_path: str) -> tuple[bool, list[str]]:
         if not re.search(return_view_pattern, container_content):
             errors.append(f"Container should return <{component_name}View />")
 
-        # Check that Container ONLY renders View (no other JSX elements)
-        # Find all JSX tags in Container (excluding the View)
+        # ADVISORY, not an error — and deliberately so.
+        #
+        # "Container should ONLY render View" is a naive `<([A-Z]\w*)` scan over
+        # the ENTIRE container file. It cannot tell a component's returned JSX
+        # tree from JSX inside a callback, so a Container holding a perfectly
+        # legitimate `renderItem` — `useCallback(({item}) => <Row … />, […])` —
+        # trips it.
+        #
+        # That matters now that Views may not call hooks: moving a renderItem
+        # callback to the Container is one of the two sanctioned fixes, and
+        # Containers ARE allowed to hold logic, including a callback that
+        # returns JSX. Left as an error, this check would reject the very
+        # migration the View rules ask for.
+        #
+        # So it reports and does not fail. Scoping it to the returned tree needs
+        # a parser, which a regex pre-check is not; until then, saying plainly
+        # what it cannot distinguish beats a confident wrong verdict.
         all_jsx_pattern = r"<([A-Z][a-zA-Z0-9]*)"
         jsx_matches = re.findall(all_jsx_pattern, container_content)
         other_components = [m for m in jsx_matches if m != f"{component_name}View"]
         if other_components:
-            errors.append(
-                f"Container should ONLY render {component_name}View, but found: {', '.join(set(other_components))}"
+            advisories.append(
+                f"Container renders JSX besides {component_name}View: {', '.join(sorted(set(other_components)))}. "
+                "This is a whole-file text scan and cannot tell a returned JSX tree from JSX inside a callback, "
+                "so a legitimate renderItem callback lands here too. Review it; this does not fail validation."
             )
 
     # Check for extra files
@@ -178,7 +295,7 @@ def validate_component(component_path: str) -> tuple[bool, list[str]]:
             if not is_allowed and item.is_file():
                 errors.append(f"Unexpected file in component directory: {item.name}")
 
-    return len(errors) == 0, errors
+    return len(errors) == 0, errors, advisories
 
 
 def main():
@@ -193,7 +310,13 @@ def main():
     print(f"Validating component: {component_path}")
     print("-" * 50)
 
-    is_valid, errors = validate_component(component_path)
+    is_valid, errors, advisories = validate_component(component_path)
+
+    if advisories:
+        print("Advisories (reviewed by a human, not a failure):")
+        for advisory in advisories:
+            print(f"  ~ {advisory}")
+        print("-" * 50)
 
     if is_valid:
         print("Component follows Container/View pattern")

package/plugins/lisa-harper-fabric/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-harper-fabric",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Harper/Fabric-specific rules for TypeScript component apps",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-harper-fabric/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-harper-fabric",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Harper/Fabric-specific Lisa rules for TypeScript component apps.",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-harper-fabric-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-harper-fabric",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Harper/Fabric-specific rules for TypeScript component apps",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-harper-fabric-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-harper-fabric",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Harper/Fabric-specific rules for TypeScript component apps",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-harper-fabric-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-harper-fabric",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Harper/Fabric-specific rules for TypeScript component apps",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-nestjs/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-nestjs",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "NestJS-specific skills (GraphQL, TypeORM) and hooks (migration write-protection)",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-nestjs/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-nestjs",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "NestJS-specific skills and migration write-protection hooks.",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-nestjs-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-nestjs",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "NestJS-specific skills (GraphQL, TypeORM) and hooks (migration write-protection)",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-nestjs-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-nestjs",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "NestJS-specific skills (GraphQL, TypeORM) and hooks (migration write-protection)",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-nestjs-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-nestjs",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "NestJS-specific skills (GraphQL, TypeORM) and hooks (migration write-protection)",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-openclaw/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-openclaw",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-openclaw/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-openclaw",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, across Claude and Codex.",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-openclaw-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-openclaw",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-openclaw-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-openclaw",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-openclaw-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-openclaw",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-phaser/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-phaser",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Phaser 4 game-development rules for TypeScript projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-phaser/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-phaser",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Phaser 4 game-development rules for TypeScript projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-phaser-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-phaser",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Phaser 4 game-development rules for TypeScript projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-phaser-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-phaser",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Phaser 4 game-development rules for TypeScript projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-phaser-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-phaser",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Phaser 4 game-development rules for TypeScript projects",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-rails/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-rails",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Ruby on Rails-specific hooks — RuboCop linting/formatting and ast-grep scanning on edit",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-rails/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-rails",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Ruby on Rails-specific skills and hooks for RuboCop and ast-grep scanning on edit.",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-rails-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-rails",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Ruby on Rails-specific hooks — RuboCop linting/formatting and ast-grep scanning on edit",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-rails-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-rails",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Ruby on Rails-specific hooks — RuboCop linting/formatting and ast-grep scanning on edit",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-rails-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-rails",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Ruby on Rails-specific hooks — RuboCop linting/formatting and ast-grep scanning on edit",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-typescript/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-typescript",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "TypeScript-specific hooks — Prettier formatting, ESLint linting, ast-grep scanning, and error-suppression blocking on edit",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-typescript/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-typescript",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "TypeScript-specific hooks for formatting, linting, and ast-grep scanning on edit.",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-typescript-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-typescript",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "TypeScript-specific hooks — Prettier formatting, ESLint linting, ast-grep scanning, and error-suppression blocking on edit",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-typescript-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-typescript",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "TypeScript-specific hooks — Prettier formatting, ESLint linting, ast-grep scanning, and error-suppression blocking on edit",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-typescript-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-typescript",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "TypeScript-specific hooks — Prettier formatting, ESLint linting, ast-grep scanning, and error-suppression blocking on edit",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-wiki/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-wiki",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "LLM Wiki — a distributable, git-native markdown knowledge base for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-wiki/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-wiki",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "Distributable LLM Wiki kernel — ingest, query, lint, and maintain a git-native markdown knowledge base across Claude and Codex.",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-wiki-agy/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-wiki",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "LLM Wiki — a distributable, git-native markdown knowledge base for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-wiki-copilot/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-wiki",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "LLM Wiki — a distributable, git-native markdown knowledge base for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"

package/plugins/lisa-wiki-cursor/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lisa-wiki",
-  "version": "4.33.3",
+  "version": "4.33.5",
   "description": "LLM Wiki — a distributable, git-native markdown knowledge base for Claude Code and Codex",
   "author": {
     "name": "Cody Swann"