@codyswann/lisa 4.28.2 → 4.28.4

package/scripts/verify-packed-learnings-contract.mjs

@@ -2,7 +2,14 @@
 /** Empirical proof that the packed public learnings API preserves v2 semantics. */
 import assert from "node:assert/strict";
 import { execFile } from "node:child_process";
-import { mkdir, mkdtemp, readFile, rm } from "node:fs/promises";
+import {
+  mkdir,
+  mkdtemp,
+  readFile,
+  rm,
+  symlink,
+  writeFile,
+} from "node:fs/promises";
 import path from "node:path";
 import { pathToFileURL } from "node:url";
 import { promisify } from "node:util";
@@ -10,6 +17,8 @@ import { promisify } from "node:util";
 const executeFile = promisify(execFile);
 const root = path.resolve(import.meta.dirname, "..");
 const temporary = await mkdtemp(path.join(root, ".packed-learnings-proof-"));
+const packedConfigFile = ".lisa.config.json";
+const packedLearningsFile = "docs/knowledge/PROJECT_LEARNINGS.md";
 
 try {
   const archive = path.join(temporary, "lisa-packed.tgz");
@@ -29,6 +38,96 @@ try {
   assert.equal(learnings.MAX_STABLE_TOKEN_BYTES, 128);
   assert.equal(learnings.LEARNINGS_CONTRACT.maxTokens, 14_900);
 
+  const configProject = path.join(temporary, "config-consumer");
+  await mkdir(configProject);
+  await writeFile(
+    path.join(configProject, packedConfigFile),
+    `${JSON.stringify({
+      learnings: {
+        file: packedLearningsFile,
+        mergeDriver: false,
+      },
+    })}\n`,
+    "utf8"
+  );
+  const packedConfig = await learnings.readProjectConfig(configProject);
+  assert.deepEqual(packedConfig.learnings, {
+    file: packedLearningsFile,
+    mergeDriver: false,
+  });
+  assert.deepEqual(learnings.resolveLearningsSettings(packedConfig), {
+    learningsFile: packedLearningsFile,
+    mergeDriverEnabled: false,
+  });
+  await writeFile(
+    path.join(configProject, packedConfigFile),
+    '{"learnings":{"mergeDriver":"false"}}\n',
+    "utf8"
+  );
+  await assert.rejects(
+    learnings.readProjectConfig(configProject),
+    /learnings\.mergeDriver.*expected boolean.*received "false"/iu
+  );
+
+  const typeConsumer = path.join(temporary, "type-consumer");
+  await mkdir(path.join(typeConsumer, "node_modules", "@codyswann"), {
+    recursive: true,
+  });
+  await symlink(
+    packedRoot,
+    path.join(typeConsumer, "node_modules", "@codyswann", "lisa"),
+    "dir"
+  );
+  await writeFile(
+    path.join(typeConsumer, "tsconfig.json"),
+    `${JSON.stringify(
+      {
+        compilerOptions: {
+          module: "NodeNext",
+          moduleResolution: "NodeNext",
+          noEmit: true,
+          skipLibCheck: true,
+          strict: true,
+          target: "ES2022",
+        },
+        include: ["consumer.ts"],
+      },
+      null,
+      2
+    )}\n`,
+    "utf8"
+  );
+  await writeFile(
+    path.join(typeConsumer, "consumer.ts"),
+    `import { resolveLearningsSettings, type LearningsConfig, type ProjectConfig } from "@codyswann/lisa/learnings";
+
+const absent: LearningsConfig = {};
+const explicitTrue: LearningsConfig = { mergeDriver: true };
+const explicitFalse: LearningsConfig = { mergeDriver: false };
+const withFile: LearningsConfig = { file: "docs/LEARNINGS.md", mergeDriver: false };
+const configs: ProjectConfig[] = [
+  { learnings: absent },
+  { learnings: explicitTrue },
+  { learnings: explicitFalse },
+  { learnings: withFile },
+];
+for (const config of configs) resolveLearningsSettings(config);
+// @ts-expect-error mergeDriver is a boolean opt-out, never a string
+const invalid: LearningsConfig = { mergeDriver: "false" };
+void invalid;
+`,
+    "utf8"
+  );
+  await executeFile(
+    process.execPath,
+    [
+      path.join(root, "node_modules", "typescript", "bin", "tsc"),
+      "-p",
+      typeConsumer,
+    ],
+    { cwd: typeConsumer }
+  );
+
   const packedVictim = "packed-victim";
   const packedProvenance = "issue:#2015";
   const packedDate = "2026-08-26";
@@ -261,7 +360,7 @@ try {
   assert.equal(await readFile(overflow.file, "utf8"), beforeOverflowCollision);
 
   console.log(
-    "[EVIDENCE: packed-learnings-contract] v1=migratable legacy=bounded entries=hardened stamps=hardened race=9 stale=8 chain=stable collision=atomic overflow=fork merge=2 projection=bounded"
+    "[EVIDENCE: packed-learnings-contract] config=validated merge-driver=opt-out types=closed v1=migratable legacy=bounded entries=hardened stamps=hardened race=9 stale=8 chain=stable collision=atomic overflow=fork merge=2 projection=bounded"
   );
 } finally {
   await rm(temporary, { recursive: true, force: true });

package/dist/core/learnings-merge-driver-config.d.ts

@@ -1,7 +0,0 @@
-/**
- * Whether this project accepts the merge-driver registration.
- * @param projectRoot - Host project directory
- * @returns False only when `learnings.mergeDriver` is explicitly `false`
- */
-export declare function isLearningsMergeDriverEnabled(projectRoot: string): Promise<boolean>;
-//# sourceMappingURL=learnings-merge-driver-config.d.ts.map

package/dist/core/learnings-merge-driver-config.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"learnings-merge-driver-config.d.ts","sourceRoot":"","sources":["../../src/core/learnings-merge-driver-config.ts"],"names":[],"mappings":"AA6CA;;;;GAIG;AACH,wBAAsB,6BAA6B,CACjD,WAAW,EAAE,MAAM,GAClB,OAAO,CAAC,OAAO,CAAC,CAQlB"}

package/dist/core/learnings-merge-driver-config.js

@@ -1,58 +0,0 @@
-/**
- * Host opt-out for the project-learnings union merge driver.
- *
- * `lisa apply` registers the driver automatically, and the TypeScript stack
- * wires `lisa apply` into `postinstall` — so an ordinary `npm install` writes
- * `merge.lisa-learnings.driver` into `.git/config` with no separate human step.
- * That is not an escalation over `npm install` itself, which already runs
- * arbitrary code, but it does persist an executable hook that fires on ordinary
- * git operations for as long as the clone exists, outside npm's lifecycle. A
- * host that would rather not carry that hook needs a way to say so.
- *
- * This reads `.lisa.config.json` directly rather than extending the validated
- * `ProjectConfig` schema: `project-config.ts` sits exactly at its 300-line lint
- * cap, and forcing an extraction of its cross-cutting learnings validators to
- * make room would be a far larger change than this flag warrants. Keeping the
- * flag beside the feature it governs also means the driver's opt-out is
- * readable in one place.
- *
- * Opt-out only, and strictly `=== false`: absent, malformed, or non-boolean
- * values all leave the driver enabled, matching the zero-configuration default
- * every other Lisa guardrail uses. A malformed config must not silently disable
- * a data-integrity guard.
- * @module core/learnings-merge-driver-config
- */
-import { readFile } from "node:fs/promises";
-import * as path from "node:path";
-const CONFIG_FILE = ".lisa.config.json";
-/**
- * Read one inert own property without invoking an accessor.
- * @param candidate - Value to inspect
- * @param key - Property name to read
- * @returns The own data value, when present
- */
-function readOwn(candidate, key) {
-    if (candidate === null || typeof candidate !== "object") {
-        return undefined;
-    }
-    const descriptor = Object.getOwnPropertyDescriptor(candidate, key);
-    return descriptor !== undefined && "value" in descriptor
-        ? descriptor.value
-        : undefined;
-}
-/**
- * Whether this project accepts the merge-driver registration.
- * @param projectRoot - Host project directory
- * @returns False only when `learnings.mergeDriver` is explicitly `false`
- */
-export async function isLearningsMergeDriverEnabled(projectRoot) {
-    try {
-        const raw = await readFile(path.join(projectRoot, CONFIG_FILE), "utf8");
-        const learnings = readOwn(JSON.parse(raw), "learnings");
-        return readOwn(learnings, "mergeDriver") !== false;
-    }
-    catch {
-        return true;
-    }
-}
-//# sourceMappingURL=learnings-merge-driver-config.js.map

package/dist/core/learnings-merge-driver-config.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"learnings-merge-driver-config.js","sourceRoot":"","sources":["../../src/core/learnings-merge-driver-config.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,OAAO,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAC;AAC5C,OAAO,KAAK,IAAI,MAAM,WAAW,CAAC;AAElC,MAAM,WAAW,GAAG,mBAAmB,CAAC;AAExC;;;;;GAKG;AACH,SAAS,OAAO,CAAC,SAAkB,EAAE,GAAW;IAC9C,IAAI,SAAS,KAAK,IAAI,IAAI,OAAO,SAAS,KAAK,QAAQ,EAAE,CAAC;QACxD,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,MAAM,UAAU,GAAG,MAAM,CAAC,wBAAwB,CAAC,SAAS,EAAE,GAAG,CAAC,CAAC;IACnE,OAAO,UAAU,KAAK,SAAS,IAAI,OAAO,IAAI,UAAU;QACtD,CAAC,CAAC,UAAU,CAAC,KAAK;QAClB,CAAC,CAAC,SAAS,CAAC;AAChB,CAAC;AAED;;;;GAIG;AACH,MAAM,CAAC,KAAK,UAAU,6BAA6B,CACjD,WAAmB;IAEnB,IAAI,CAAC;QACH,MAAM,GAAG,GAAG,MAAM,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,WAAW,CAAC,EAAE,MAAM,CAAC,CAAC;QACxE,MAAM,SAAS,GAAG,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAY,EAAE,WAAW,CAAC,CAAC;QACnE,OAAO,OAAO,CAAC,SAAS,EAAE,aAAa,CAAC,KAAK,KAAK,CAAC;IACrD,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,IAAI,CAAC;IACd,CAAC;AACH,CAAC"}