@codyswann/lisa 4.22.9 → 4.22.10

package/typescript/copy-overwrite/scripts/threshold-ratchet-families.mjs

@@ -95,11 +95,11 @@ export const FAMILIES = [
  * Unknown keys stay unwatched until their direction is explicit here.
  * @type {Readonly<Record<string, "min"|"max">>}
  */
-export const LIGHTHOUSE_ASSERTION_DIRECTIONS = {
+export const LIGHTHOUSE_ASSERTION_DIRECTIONS = Object.freeze({
   minScore: "min",
   maxNumericValue: "max",
   maxLength: "max",
-};
+});
 
 /**
  * Extract numeric Lighthouse assertions with a direction chosen per key.
@@ -112,10 +112,22 @@ export const LIGHTHOUSE_ASSERTION_DIRECTIONS = {
  */
 export function extractLighthouseAssertions(conf) {
   const out = new Map();
-  const assertions =
+  const root =
     conf && typeof conf === "object" && !Array.isArray(conf)
-      ? /** @type {Record<string, unknown>} */ (conf).assertions
+      ? /** @type {Record<string, unknown>} */ (conf)
       : undefined;
+  const ci =
+    root?.ci && typeof root.ci === "object" && !Array.isArray(root.ci)
+      ? /** @type {Record<string, unknown>} */ (root.ci)
+      : undefined;
+  const assert =
+    ci?.assert && typeof ci.assert === "object" && !Array.isArray(ci.assert)
+      ? /** @type {Record<string, unknown>} */ (ci.assert)
+      : undefined;
+  // Lighthouse CI's canonical shape is `ci.assert.assertions`. Keep the
+  // historical top-level shape as a compatibility lane for already-generated
+  // project configs, but never merge the two into an ambiguous hybrid.
+  const assertions = assert?.assertions ?? root?.assertions;
   if (
     !assertions ||
     typeof assertions !== "object" ||
@@ -124,9 +136,21 @@ export function extractLighthouseAssertions(conf) {
     return out;
   }
   for (const [audit, spec] of Object.entries(assertions)) {
-    if (!spec || typeof spec !== "object" || Array.isArray(spec)) continue;
-    for (const [key, value] of Object.entries(spec)) {
-      const direction = LIGHTHOUSE_ASSERTION_DIRECTIONS[key];
+    const options =
+      Array.isArray(spec) &&
+      spec.length >= 2 &&
+      spec[1] &&
+      typeof spec[1] === "object" &&
+      !Array.isArray(spec[1])
+        ? /** @type {Record<string, unknown>} */ (spec[1])
+        : spec && typeof spec === "object" && !Array.isArray(spec)
+          ? /** @type {Record<string, unknown>} */ (spec)
+          : undefined;
+    if (!options) continue;
+    for (const [key, value] of Object.entries(options)) {
+      const direction = Object.hasOwn(LIGHTHOUSE_ASSERTION_DIRECTIONS, key)
+        ? LIGHTHOUSE_ASSERTION_DIRECTIONS[key]
+        : undefined;
       if (direction && typeof value === "number" && Number.isFinite(value)) {
         out.set(`${audit}.${key}`, { value, direction });
       }

package/typescript/package-lisa/package.lisa.json

@@ -7,7 +7,7 @@
       "format": "prettier --check . --write",
       "test": "vitest run",
       "test:unit": "vitest run --exclude='**/integration/**'",
-      "test:integration:lisa": "vitest run '.integration.' 'integration/' --passWithNoTests",
+      "test:integration:lisa": "vitest run '.integration.' 'integration/'",
       "test:cov": "vitest run --coverage",
       "test:cov:unit": "LISA_COVERAGE_SCOPE=unit vitest run --coverage --exclude='**/integration/**'",
       "test:mutation": "node scripts/lisa-mutation.mjs",