@codyswann/lisa 4.22.10 → 4.22.12

package/scripts/check-release-package-identity.mjs

@@ -90,6 +90,33 @@ function tarMember(tarballPath, member) {
   }
 }
 
+/** Create the one npm archive whose bytes will be published. */
+function createCandidateArchive(root, packDestination) {
+  mkdirSync(packDestination, { recursive: true });
+  if (readdirSync(packDestination).length !== 0) {
+    mismatch(`pack destination must be empty (${packDestination})`);
+  }
+  try {
+    return String(
+      boundedExecFileSync(
+        "npm",
+        [
+          "pack",
+          "--ignore-scripts",
+          "--silent",
+          "--pack-destination",
+          packDestination,
+        ],
+        { cwd: root, encoding: "utf8", timeout: 120_000 }
+      )
+    );
+  } catch (error) {
+    mismatch(
+      `npm pack failed before publication (${error instanceof Error ? error.message : String(error)})`
+    );
+  }
+}
+
 /** Extract the one workspace package version certified by generated bytes. */
 function certificateVersion(bytes, label) {
   const match = String(bytes).match(
@@ -115,18 +142,24 @@ export function assertReleaseCommit(releaseCommit) {
  * @returns {{headCommit: string, tagCommit: string, releaseCommit: string}}
  */
 export function assertCheckoutIdentity({ root, releaseCommit, tag }) {
-  assertReleaseCommit(releaseCommit);
+  const validatedReleaseCommit = assertReleaseCommit(releaseCommit);
   const headCommit = gitCommit(root, "HEAD");
-  if (headCommit !== releaseCommit) {
+  if (headCommit !== validatedReleaseCommit) {
     mismatch(
-      `HEAD ${headCommit} does not match release commit ${releaseCommit}`
+      `HEAD ${headCommit} does not match release commit ${validatedReleaseCommit}`
     );
   }
   const tagCommit = gitCommit(root, tag);
-  if (tagCommit !== releaseCommit) {
-    mismatch(`tag ${tag} resolves ${tagCommit}, expected ${releaseCommit}`);
+  if (tagCommit !== validatedReleaseCommit) {
+    mismatch(
+      `tag ${tag} resolves ${tagCommit}, expected ${validatedReleaseCommit}`
+    );
   }
-  return Object.freeze({ headCommit, tagCommit, releaseCommit });
+  return Object.freeze({
+    headCommit,
+    tagCommit,
+    releaseCommit: validatedReleaseCommit,
+  });
 }
 
 /**
@@ -140,21 +173,21 @@ export function packAndValidateReleaseCandidate({
   releaseCommit,
   packDestination,
 }) {
-  assertReleaseCommit(releaseCommit);
+  const validatedReleaseCommit = assertReleaseCommit(releaseCommit);
   const packageJson = readJson(path.join(root, "package.json"), "package.json");
   if (packageJson.version !== version) {
     mismatch(
       `package.json version ${JSON.stringify(packageJson.version)} expected ${version}`
     );
   }
-  if (packageJson.lisaReleaseCommit !== releaseCommit) {
+  if (packageJson.lisaReleaseCommit !== validatedReleaseCommit) {
     mismatch(
-      `package.json lisaReleaseCommit ${JSON.stringify(packageJson.lisaReleaseCommit)} expected ${releaseCommit}`
+      `package.json lisaReleaseCommit ${JSON.stringify(packageJson.lisaReleaseCommit)} expected ${validatedReleaseCommit}`
     );
   }
-  if (packageJson.gitHead !== releaseCommit) {
+  if (packageJson.gitHead !== validatedReleaseCommit) {
     mismatch(
-      `package.json gitHead ${JSON.stringify(packageJson.gitHead)} expected ${releaseCommit}`
+      `package.json gitHead ${JSON.stringify(packageJson.gitHead)} expected ${validatedReleaseCommit}`
     );
   }
 
@@ -172,30 +205,7 @@ export function packAndValidateReleaseCandidate({
     }
   }
 
-  mkdirSync(packDestination, { recursive: true });
-  if (readdirSync(packDestination).length !== 0) {
-    mismatch(`pack destination must be empty (${packDestination})`);
-  }
-  let packOutput;
-  try {
-    packOutput = String(
-      boundedExecFileSync(
-        "npm",
-        [
-          "pack",
-          "--ignore-scripts",
-          "--silent",
-          "--pack-destination",
-          packDestination,
-        ],
-        { cwd: root, encoding: "utf8", timeout: 120_000 }
-      )
-    );
-  } catch (error) {
-    mismatch(
-      `npm pack failed before publication (${error instanceof Error ? error.message : String(error)})`
-    );
-  }
+  const packOutput = createCandidateArchive(root, packDestination);
   const candidates = readdirSync(packDestination).filter(file =>
     file.endsWith(".tgz")
   );
@@ -223,14 +233,14 @@ export function packAndValidateReleaseCandidate({
       `packed package version ${JSON.stringify(packedPackage.version)} expected ${version}`
     );
   }
-  if (packedPackage.lisaReleaseCommit !== releaseCommit) {
+  if (packedPackage.lisaReleaseCommit !== validatedReleaseCommit) {
     mismatch(
-      `packed lisaReleaseCommit ${JSON.stringify(packedPackage.lisaReleaseCommit)} expected ${releaseCommit}`
+      `packed lisaReleaseCommit ${JSON.stringify(packedPackage.lisaReleaseCommit)} expected ${validatedReleaseCommit}`
     );
   }
-  if (packedPackage.gitHead !== releaseCommit) {
+  if (packedPackage.gitHead !== validatedReleaseCommit) {
     mismatch(
-      `packed gitHead ${JSON.stringify(packedPackage.gitHead)} expected ${releaseCommit}`
+      `packed gitHead ${JSON.stringify(packedPackage.gitHead)} expected ${validatedReleaseCommit}`
     );
   }
 
@@ -241,7 +251,7 @@ export function packAndValidateReleaseCandidate({
     packedCertificateVersion = certificateVersion(member, "packed certificate");
     if (packedCertificateVersion !== version) {
       mismatch(
-        `packed certificate names ${packedCertificateVersion}, expected ${version} at release commit ${releaseCommit} (${PACKED_CERTIFICATE})`
+        `packed certificate names ${packedCertificateVersion}, expected ${version} at release commit ${validatedReleaseCommit} (${PACKED_CERTIFICATE})`
       );
     }
     certificateMemberSha256 = sha256(member);
@@ -249,7 +259,7 @@ export function packAndValidateReleaseCandidate({
 
   return Object.freeze({
     version,
-    releaseCommit,
+    releaseCommit: validatedReleaseCommit,
     certificateVersion: packedCertificateVersion,
     tarballPath,
     tarballSha256: sha256(tarballBytes),