@codyswann/lisa 3.70.0 → 3.70.2

package/all/copy-overwrite/scripts/lisa-hooks/block-no-verify.sh

@@ -12,7 +12,9 @@
 #   2. HUSKY=0 / HUSKY_SKIP_HOOKS=... — disables husky-managed git hooks;
 #   3. core.hooksPath pointed anywhere but an allowlisted in-repo hooks dir;
 #   4. --config-env=core.hooksPath=VAR, in both the one- and two-token spellings;
-#   5. GIT_CONFIG_KEY_<n>=core.hooksPath env-var-style command-scope config.
+#   5. GIT_CONFIG_KEY_<n>=core.hooksPath env-var-style command-scope config;
+#   6. the short `-n`, as a real argv token of a `git commit` — bare, or bundled
+#      into a short-option cluster such as `-nm "msg"`.
 #
 # The line below is what lets `lisa apply` tell a downstream copy of this guard
 # that is BEHIND from one that is AHEAD. Byte comparison cannot: both look like
@@ -23,15 +25,31 @@
 # Add a name here in the same commit that closes a vector. A hardening that
 # forgets to is invisible to refresh, and shows up as an unexplained diff at
 # review time instead of a named capability.
-# lisa-guard-capabilities: no-verify-abbrev, husky-env, hookspath-allowlist, config-env, git-config-key
+# lisa-guard-capabilities: no-verify-abbrev, husky-env, hookspath-allowlist, config-env, git-config-key, no-verify-short
 #
 # Shell-token matching avoids false positives from issue bodies, heredocs, and
 # commit-message prose while still catching quoted real argv values such as
 # `git -c "core.hooksPath=/dev/null"`.
 #
-# The short `-n` form is intentionally NOT matched (see block-no-verify.agy.sh):
-# grep cannot distinguish a real -n option from -n in commit-message prose or an
-# unrelated piped command, and -n is far more common than --no-verify.
+# The short `-n` form used to be excluded here, and the stated reason was that
+# "grep cannot distinguish a real -n option from -n in commit-message prose or
+# an unrelated piped command". That was true of the matcher it was written for.
+# It is not true of this one: the command is TOKENIZED, not grepped, so `-m "fix
+# the -n flag"` is one token holding the message and `grep -n` is a separate
+# command — the two cases the comment called inseparable are separated by the
+# same machinery `--config-env` and `GIT_CONFIG_KEY_<n>` already depend on.
+#
+# A rationale that outlives the implementation it describes is worse than none:
+# it reads as a considered decision and stops the next reader from re-examining
+# it. Measured against real git, `git commit -n`, `-nm msg`, and `-anm msg` all
+# skip pre-commit exactly as completely as `--no-verify`, and `-nm` is the more
+# likely spelling in practice because it reads as an ordinary message flag.
+#
+# What the old comment got right is the part about `-n` being common, and that
+# concern is answered by SCOPE rather than by giving up: `-n` is `--dry-run` for
+# `push`, `--no-stat` for `merge`, and a line count for head/tail/sort/grep, so
+# the match is confined to the argv of a `git commit` invocation and nothing
+# else. See `git_commit_skips_verification` below.
 set -euo pipefail
 
 input="$(cat)"
@@ -168,6 +186,203 @@ def disables_verification(token):
         and NO_VERIFY.startswith(token)
     )
 
+
+# `git commit -n` is the short spelling of --no-verify and skips pre-commit and
+# commit-msg identically. Matching it needs one thing the `--no-verify` scan
+# above does not: SCOPE. `-n` means --dry-run to `git push`, --no-stat to `git
+# merge`, and a line count to head/tail/sort/grep, so a token-anywhere match
+# would refuse ordinary commands all day. Only `git commit` reads it as a hook
+# bypass, so only that invocation's argv is scanned.
+#
+# The tokenizer below is a SECOND pass, deliberately not shared with the one the
+# checks above use. `shlex.split` leaves `|` and `;` glued to their neighbours,
+# which those checks paper over by stripping the punctuation off each token —
+# fine when the question is "does this token look like a bypass anywhere in the
+# line", fatal when the question is "where does this command end", because
+# `git commit -m x && grep -n foo` would then read as one long git invocation
+# and refuse the grep. `punctuation_chars=True` emits the operators as their own
+# tokens, so the invocation's boundary is a token the scan can stop at.
+COMMAND_SEPARATORS = {
+    ";", "|", "||", "&", "&&", "(", ")", "<", ">", ">>", "<<", "&|",
+}
+
+# git's own options that take a SEPARATE value token, which therefore must be
+# skipped when looking for the subcommand: `git -c core.hooksPath=x commit` and
+# `git -C /repo commit` both reach `commit`.
+GIT_GLOBAL_SEPARATE_VALUE = {
+    "-c", "-C", "--config-env", "--git-dir", "--work-tree",
+    "--namespace", "--exec-path", "--super-prefix",
+}
+
+# `git commit` long options whose value can be a separate token. Listed so the
+# VALUE is never mistaken for a flag — `git commit --author "A -n B" -m x`
+# must stay allowed. Only genuinely value-taking options belong here: adding a
+# boolean one by mistake would swallow the token after it, and `git commit
+# --amend -n` would go unnoticed.
+COMMIT_LONG_SEPARATE_VALUE = {
+    "--message", "--file", "--author", "--date", "--template", "--cleanup",
+    "--reuse-message", "--reedit-message", "--fixup", "--squash",
+    "--pathspec-from-file", "--trailer",
+}
+
+# Short `git commit` options that REQUIRE a value: `-m`/`-F`/`-c`/`-C`/`-t`.
+# In a cluster the value is whatever follows them in the same token, or the next
+# token when nothing does — which is why `-mn` is the message "n" and not a
+# bypass, and `-nm msg` IS one.
+COMMIT_SHORT_REQUIRED_VALUE = set("mFcCt")
+
+# Short options taking an OPTIONAL value, which git only ever reads attached:
+# `-uno` is --untracked-files=no, `-Skeyid` is --gpg-sign=keyid. The cluster
+# ends at them either way, so `-un` is untracked-files "n" rather than a bypass.
+COMMIT_SHORT_OPTIONAL_VALUE = set("uS")
+
+
+def line_boundaries_as_separators(text):
+    """Turn newlines into command separators, keeping continuations intact.
+
+    A newline ends a command exactly as `;` does, but shlex treats it as plain
+    whitespace — so `git commit -m x` on one line and `grep -n foo` on the next
+    read as ONE invocation and the grep gets refused. That is the same
+    false-positive class the short-form match exists to avoid, arriving through
+    the boundary rather than through the token.
+
+    Backslash-newline is joined first, because there the newline is NOT a
+    boundary: `git commit \\` + newline + `-nm x` is one command, and turning
+    that newline into a separator would hide a real bypass.
+
+    Args:
+        text: The command line, heredoc payloads already stripped.
+
+    Returns:
+        The same command with line breaks spelled as separators.
+    """
+    joined = text.replace("\r\n", "\n").replace("\\\n", " ")
+    return joined.replace("\n", " ; ")
+
+
+def shell_tokens(text):
+    """Tokenize a command with shell operators kept as their own tokens.
+
+    Args:
+        text: The command line, heredoc payloads already stripped.
+
+    Returns:
+        The token list, with `;`, `|`, `&&`, `(` and friends standing alone.
+    """
+    lexer = shlex.shlex(
+        line_boundaries_as_separators(text), posix=True, punctuation_chars=True
+    )
+    lexer.whitespace_split = True
+    # shlex treats `#` as a comment introducer by default and would silently
+    # truncate the rest of the line; `shlex.split` disables it, and so must this.
+    lexer.commenters = ""
+    return list(lexer)
+
+
+def cluster_skips_verification(cluster):
+    """Read a short-option cluster the way git's own parser reads it.
+
+    Args:
+        cluster: A single token beginning with one `-`, e.g. `-nm` or `-mn`.
+
+    Returns:
+        A pair (bypasses, consumes_next_token). `bypasses` is True when a real
+        `-n` option is present; `consumes_next_token` is True when the cluster
+        ends in a value-taking option whose value is the following token.
+    """
+    body = cluster[1:]
+    for offset, letter in enumerate(body):
+        if letter == "n":
+            return (True, False)
+        if letter in COMMIT_SHORT_REQUIRED_VALUE:
+            # Everything after this letter is the value. It is a separate token
+            # only when nothing is attached.
+            return (False, offset == len(body) - 1)
+        if letter in COMMIT_SHORT_OPTIONAL_VALUE:
+            return (False, False)
+    return (False, False)
+
+
+def commit_bypasses_verification(argv):
+    """Whether a `git commit` invocation's argv carries a real short `-n`.
+
+    Args:
+        argv: Tokens following the `commit` subcommand, to the end of the line.
+
+    Returns:
+        True if git would read one of them as --no-verify.
+    """
+    index = 0
+    while index < len(argv):
+        token = argv[index]
+        index += 1
+        # `--` ends the options; everything after it is a pathspec, and a file
+        # legitimately named `-n` is not a bypass.
+        if token in COMMAND_SEPARATORS or token == "--":
+            return False
+        if token.startswith("--"):
+            if token in COMMIT_LONG_SEPARATE_VALUE:
+                index += 1
+            continue
+        # A bare `-` is git's stdin placeholder, not an option cluster.
+        if not token.startswith("-") or token == "-":
+            continue
+        bypasses, consumes_next = cluster_skips_verification(token)
+        if bypasses:
+            return True
+        if consumes_next:
+            index += 1
+    return False
+
+
+def subcommand_after_git(tokens, start):
+    """Find the subcommand a `git` token introduces, and its argv.
+
+    Args:
+        tokens: The full operator-aware token list.
+        start: Index just past the `git` token.
+
+    Returns:
+        A pair (subcommand, argv), or None when the invocation names none.
+    """
+    index = start
+    while index < len(tokens):
+        token = tokens[index]
+        if token in COMMAND_SEPARATORS:
+            return None
+        if not token.startswith("-"):
+            return (token, tokens[index + 1:])
+        index += 2 if token in GIT_GLOBAL_SEPARATE_VALUE else 1
+    return None
+
+
+def git_commit_skips_verification(text):
+    """Whether the command runs `git commit` with the short `-n` bypass.
+
+    Args:
+        text: The command line, heredoc payloads already stripped.
+
+    Returns:
+        True if any `git commit` invocation on the line skips verification.
+    """
+    try:
+        scoped_tokens = shell_tokens(text)
+    except ValueError:
+        return False
+    for index, token in enumerate(scoped_tokens):
+        # `/usr/bin/git` and a bare `git` are the same program; an env prefix
+        # (`HUSKY=1 git commit -n`) simply sits in an earlier token.
+        if token != "git" and not token.endswith("/git"):
+            continue
+        found = subcommand_after_git(scoped_tokens, index + 1)
+        if found and found[0] == "commit" and commit_bypasses_verification(found[1]):
+            return True
+    return False
+
+
+if git_commit_skips_verification(strip_heredocs(command)):
+    sys.exit(1)
+
 for i, token in enumerate(normalized_tokens):
     if disables_verification(token):
         sys.exit(1)
@@ -238,8 +453,10 @@ sys.exit(0)
 PY
 then
   cat >&2 <<'EOF'
-Blocked: this command bypasses pre-commit/pre-push hooks (--no-verify, HUSKY=0,
-or core.hooksPath disabling). Fix the underlying issue (security audit, lint,
+Blocked: this command bypasses pre-commit/pre-push hooks (--no-verify or its
+short form -n, HUSKY=0, or core.hooksPath disabling). `git commit -n` and a
+cluster such as `-nm "msg"` skip pre-commit exactly as completely as the long
+flag. Fix the underlying issue (security audit, lint,
 typecheck, tests, formatting) instead. If a fix is genuinely impossible, ask the
 user to make the risk-acceptance decision and add a specific documented ignore;
 never bypass the hook.

package/dist/cli/prompts.d.ts

@@ -7,6 +7,16 @@ export type OverwriteDecision = "yes" | "no" | "diff";
  * Interface for user prompts
  */
 export interface IPrompter {
+    /**
+     * Whether this run has no operator decision available to it — neither a live
+     * prompt to answer nor a `--yes` given in advance.
+     *
+     * The apply needs to tell those apart, and the prompter is the only thing
+     * that knows. A `--yes` run is *attended*: the operator decided before
+     * starting. A run with no TTY and no flag is not — there is nobody to ask,
+     * and answering on their behalf is what #3026 was.
+     */
+    readonly unattended: boolean;
     /**
      * Prompt for file overwrite decision
      * @param relativePath Path to the conflicting file
@@ -30,17 +40,52 @@ export interface IPrompter {
  * Interactive prompter using {@link https://github.com/enquirer/enquirer inquirer}/prompts
  */
 export declare class InteractivePrompter implements IPrompter {
+    /** A human is at the keyboard and answers every question. */
+    readonly unattended = false;
     promptOverwrite(relativePath: string): Promise<OverwriteDecision>;
     confirmProjectTypes(detected: readonly ProjectType[]): Promise<readonly ProjectType[]>;
     confirmDirtyGit(status: string): Promise<boolean>;
 }
 /**
- * Auto-accepting prompter for non-interactive mode
+ * Auto-accepting prompter for `--yes`
+ *
+ * Reached only when the operator passed the flag. That flag *is* the decision —
+ * "replace what differs, do not ask me" — so this prompter is attended even
+ * though nothing is interactive about it. What it must never cover is a run
+ * where no such flag was given; see {@link UnattendedPrompter}.
  *
  * Note: confirmDirtyGit always prompts interactively even in auto-accept mode,
  * as running Lisa on a dirty working directory requires explicit user consent.
  */
 export declare class AutoAcceptPrompter implements IPrompter {
+    /** The operator decided in advance by passing `--yes`. */
+    readonly unattended = false;
+    promptOverwrite(_relativePath: string): Promise<OverwriteDecision>;
+    confirmProjectTypes(detected: readonly ProjectType[]): Promise<readonly ProjectType[]>;
+    confirmDirtyGit(status: string): Promise<boolean>;
+}
+/**
+ * Prompter for a run with no operator on either end — no TTY to ask, and no
+ * `--yes` given in advance.
+ *
+ * This is the common case, not the exotic one: every agent-driven, scripted,
+ * and CI `lisa apply` lands here. It used to be answered by
+ * {@link AutoAcceptPrompter}, which says "yes" to every overwrite. So a bare
+ * `lisa apply` replaced host-customised `knip.json`, `eslint.config.ts`, and
+ * `tsconfig.json` and reported the result under "Overwritten: N files
+ * (approved or Lisa-owned)" — nobody approved them, and Lisa owns none of
+ * them. The absence of a terminal was being read as consent from an operator
+ * who was never there (#3026).
+ *
+ * It answers "no" so that nothing is silently replaced even if a caller builds
+ * a strategy context by hand. The apply's own routing does the rest: an
+ * unattended run takes the same branch the postinstall does, which reports the
+ * file as out of date and still honours `--refresh-templates`, the flag that
+ * means "take upstream's version of these".
+ */
+export declare class UnattendedPrompter implements IPrompter {
+    /** There is nobody to ask and no answer was given in advance. */
+    readonly unattended = true;
     promptOverwrite(_relativePath: string): Promise<OverwriteDecision>;
     confirmProjectTypes(detected: readonly ProjectType[]): Promise<readonly ProjectType[]>;
     confirmDirtyGit(status: string): Promise<boolean>;
@@ -52,6 +97,12 @@ export declare class AutoAcceptPrompter implements IPrompter {
 export declare function isInteractive(): boolean;
 /**
  * Create appropriate prompter based on mode and TTY
+ *
+ * The three cases are three different sources of authority, and collapsing any
+ * two of them loses the distinction that matters. `--yes` is consent given in
+ * advance. A TTY is consent obtainable on demand. Neither one is a run with no
+ * operator at all, which gets a prompter that declines rather than one that
+ * invents an approval (#3026).
  * @param yesMode Non-interactive mode flag
  * @returns Prompter instance
  */

package/dist/cli/prompts.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prompts.d.ts","sourceRoot":"","sources":["../../src/cli/prompts.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAarD;;GAEG;AACH,MAAM,MAAM,iBAAiB,GAAG,KAAK,GAAG,IAAI,GAAG,MAAM,CAAC;AAEtD;;GAEG;AACH,MAAM,WAAW,SAAS;IACxB;;;;OAIG;IACH,eAAe,CAAC,YAAY,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,CAAC,CAAC;IAElE;;;;OAIG;IACH,mBAAmB,CACjB,QAAQ,EAAE,SAAS,WAAW,EAAE,GAC/B,OAAO,CAAC,SAAS,WAAW,EAAE,CAAC,CAAC;IAEnC;;;;OAIG;IACH,eAAe,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAAC;CACnD;AAED;;GAEG;AACH,qBAAa,mBAAoB,YAAW,SAAS;IAC7C,eAAe,CAAC,YAAY,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,CAAC;IAWjE,mBAAmB,CACvB,QAAQ,EAAE,SAAS,WAAW,EAAE,GAC/B,OAAO,CAAC,SAAS,WAAW,EAAE,CAAC;IAY5B,eAAe,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;CAUxD;AAED;;;;;GAKG;AACH,qBAAa,kBAAmB,YAAW,SAAS;IAC5C,eAAe,CAAC,aAAa,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,CAAC;IAIlE,mBAAmB,CACvB,QAAQ,EAAE,SAAS,WAAW,EAAE,GAC/B,OAAO,CAAC,SAAS,WAAW,EAAE,CAAC;IAI5B,eAAe,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;CAwBxD;AAED;;;GAGG;AACH,wBAAgB,aAAa,IAAI,OAAO,CAEvC;AAED;;;;GAIG;AACH,wBAAgB,cAAc,CAAC,OAAO,EAAE,OAAO,GAAG,SAAS,CAK1D"}
+{"version":3,"file":"prompts.d.ts","sourceRoot":"","sources":["../../src/cli/prompts.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAarD;;GAEG;AACH,MAAM,MAAM,iBAAiB,GAAG,KAAK,GAAG,IAAI,GAAG,MAAM,CAAC;AAEtD;;GAEG;AACH,MAAM,WAAW,SAAS;IACxB;;;;;;;;OAQG;IACH,QAAQ,CAAC,UAAU,EAAE,OAAO,CAAC;IAE7B;;;;OAIG;IACH,eAAe,CAAC,YAAY,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,CAAC,CAAC;IAElE;;;;OAIG;IACH,mBAAmB,CACjB,QAAQ,EAAE,SAAS,WAAW,EAAE,GAC/B,OAAO,CAAC,SAAS,WAAW,EAAE,CAAC,CAAC;IAEnC;;;;OAIG;IACH,eAAe,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAAC;CACnD;AAED;;GAEG;AACH,qBAAa,mBAAoB,YAAW,SAAS;IACnD,6DAA6D;IAC7D,QAAQ,CAAC,UAAU,SAAS;IAEtB,eAAe,CAAC,YAAY,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,CAAC;IAWjE,mBAAmB,CACvB,QAAQ,EAAE,SAAS,WAAW,EAAE,GAC/B,OAAO,CAAC,SAAS,WAAW,EAAE,CAAC;IAY5B,eAAe,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;CAUxD;AAED;;;;;;;;;;GAUG;AACH,qBAAa,kBAAmB,YAAW,SAAS;IAClD,0DAA0D;IAC1D,QAAQ,CAAC,UAAU,SAAS;IAEtB,eAAe,CAAC,aAAa,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,CAAC;IAIlE,mBAAmB,CACvB,QAAQ,EAAE,SAAS,WAAW,EAAE,GAC/B,OAAO,CAAC,SAAS,WAAW,EAAE,CAAC;IAI5B,eAAe,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;CAwBxD;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH,qBAAa,kBAAmB,YAAW,SAAS;IAClD,iEAAiE;IACjE,QAAQ,CAAC,UAAU,QAAQ;IAErB,eAAe,CAAC,aAAa,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,CAAC;IAIlE,mBAAmB,CACvB,QAAQ,EAAE,SAAS,WAAW,EAAE,GAC/B,OAAO,CAAC,SAAS,WAAW,EAAE,CAAC;IAI5B,eAAe,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;CAUxD;AAED;;;GAGG;AACH,wBAAgB,aAAa,IAAI,OAAO,CAEvC;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,cAAc,CAAC,OAAO,EAAE,OAAO,GAAG,SAAS,CAQ1D"}

package/dist/cli/prompts.js

@@ -11,6 +11,8 @@ const DIRTY_GIT_CONFIRM_MESSAGE = "Your git working directory has uncommitted ch
  * Interactive prompter using {@link https://github.com/enquirer/enquirer inquirer}/prompts
  */
 export class InteractivePrompter {
+    /** A human is at the keyboard and answers every question. */
+    unattended = false;
     async promptOverwrite(relativePath) {
         return select({
             message: `File differs: ${relativePath}\nOverwrite?`,
@@ -40,12 +42,19 @@ export class InteractivePrompter {
     }
 }
 /**
- * Auto-accepting prompter for non-interactive mode
+ * Auto-accepting prompter for `--yes`
+ *
+ * Reached only when the operator passed the flag. That flag *is* the decision —
+ * "replace what differs, do not ask me" — so this prompter is attended even
+ * though nothing is interactive about it. What it must never cover is a run
+ * where no such flag was given; see {@link UnattendedPrompter}.
  *
  * Note: confirmDirtyGit always prompts interactively even in auto-accept mode,
  * as running Lisa on a dirty working directory requires explicit user consent.
  */
 export class AutoAcceptPrompter {
+    /** The operator decided in advance by passing `--yes`. */
+    unattended = false;
     async promptOverwrite(_relativePath) {
         return "yes";
     }
@@ -73,6 +82,43 @@ export class AutoAcceptPrompter {
         });
     }
 }
+/**
+ * Prompter for a run with no operator on either end — no TTY to ask, and no
+ * `--yes` given in advance.
+ *
+ * This is the common case, not the exotic one: every agent-driven, scripted,
+ * and CI `lisa apply` lands here. It used to be answered by
+ * {@link AutoAcceptPrompter}, which says "yes" to every overwrite. So a bare
+ * `lisa apply` replaced host-customised `knip.json`, `eslint.config.ts`, and
+ * `tsconfig.json` and reported the result under "Overwritten: N files
+ * (approved or Lisa-owned)" — nobody approved them, and Lisa owns none of
+ * them. The absence of a terminal was being read as consent from an operator
+ * who was never there (#3026).
+ *
+ * It answers "no" so that nothing is silently replaced even if a caller builds
+ * a strategy context by hand. The apply's own routing does the rest: an
+ * unattended run takes the same branch the postinstall does, which reports the
+ * file as out of date and still honours `--refresh-templates`, the flag that
+ * means "take upstream's version of these".
+ */
+export class UnattendedPrompter {
+    /** There is nobody to ask and no answer was given in advance. */
+    unattended = true;
+    async promptOverwrite(_relativePath) {
+        return "no";
+    }
+    async confirmProjectTypes(detected) {
+        return detected;
+    }
+    async confirmDirtyGit(status) {
+        console.log(UNCOMMITTED_CHANGES_HEADER);
+        console.log(status);
+        console.log("");
+        console.log("Cannot proceed: working directory has uncommitted changes and no TTY available for confirmation.");
+        console.log("Please commit or stash your changes before running Lisa.");
+        return false;
+    }
+}
 /**
  * Check if running in interactive mode (TTY available)
  * @returns True if running in TTY mode
@@ -82,13 +128,22 @@ export function isInteractive() {
 }
 /**
  * Create appropriate prompter based on mode and TTY
+ *
+ * The three cases are three different sources of authority, and collapsing any
+ * two of them loses the distinction that matters. `--yes` is consent given in
+ * advance. A TTY is consent obtainable on demand. Neither one is a run with no
+ * operator at all, which gets a prompter that declines rather than one that
+ * invents an approval (#3026).
  * @param yesMode Non-interactive mode flag
  * @returns Prompter instance
  */
 export function createPrompter(yesMode) {
-    if (yesMode || !isInteractive()) {
+    if (yesMode) {
         return new AutoAcceptPrompter();
     }
+    if (!isInteractive()) {
+        return new UnattendedPrompter();
+    }
     return new InteractivePrompter();
 }
 //# sourceMappingURL=prompts.js.map

package/dist/cli/prompts.js.map

@@ -1 +1 @@
-{"version":3,"file":"prompts.js","sourceRoot":"","sources":["../../src/cli/prompts.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,MAAM,mBAAmB,CAAC;AAGpD;;GAEG;AACH,MAAM,0BAA0B,GAAG,iCAAiC,CAAC;AAErE;;GAEG;AACH,MAAM,yBAAyB,GAC7B,iFAAiF,CAAC;AAmCpF;;GAEG;AACH,MAAM,OAAO,mBAAmB;IAC9B,KAAK,CAAC,eAAe,CAAC,YAAoB;QACxC,OAAO,MAAM,CAAC;YACZ,OAAO,EAAE,iBAAiB,YAAY,cAAc;YACpD,OAAO,EAAE;gBACP,EAAE,IAAI,EAAE,iBAAiB,EAAE,KAAK,EAAE,KAAc,EAAE;gBAClD,EAAE,IAAI,EAAE,WAAW,EAAE,KAAK,EAAE,IAAa,EAAE;gBAC3C,EAAE,IAAI,EAAE,yBAAyB,EAAE,KAAK,EAAE,MAAe,EAAE;aAC5D;SACF,CAAC,CAAC;IACL,CAAC;IAED,KAAK,CAAC,mBAAmB,CACvB,QAAgC;QAEhC,MAAM,YAAY,GAChB,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,iBAAiB,CAAC;QAEhE,MAAM,OAAO,CAAC;YACZ,OAAO,EAAE,2BAA2B,YAAY,8BAA8B;YAC9E,OAAO,EAAE,IAAI;SACd,CAAC,CAAC;QAEH,OAAO,QAAQ,CAAC;IAClB,CAAC;IAED,KAAK,CAAC,eAAe,CAAC,MAAc;QAClC,OAAO,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;QACxC,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;QACpB,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QAEhB,OAAO,OAAO,CAAC;YACb,OAAO,EAAE,yBAAyB;YAClC,OAAO,EAAE,KAAK;SACf,CAAC,CAAC;IACL,CAAC;CACF;AAED;;;;;GAKG;AACH,MAAM,OAAO,kBAAkB;IAC7B,KAAK,CAAC,eAAe,CAAC,aAAqB;QACzC,OAAO,KAAK,CAAC;IACf,CAAC;IAED,KAAK,CAAC,mBAAmB,CACvB,QAAgC;QAEhC,OAAO,QAAQ,CAAC;IAClB,CAAC;IAED,KAAK,CAAC,eAAe,CAAC,MAAc;QAClC,wDAAwD;QACxD,qEAAqE;QACrE,IAAI,CAAC,aAAa,EAAE,EAAE,CAAC;YACrB,8DAA8D;YAC9D,OAAO,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;YACxC,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;YACpB,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;YAChB,OAAO,CAAC,GAAG,CACT,kGAAkG,CACnG,CAAC;YACF,OAAO,CAAC,GAAG,CAAC,0DAA0D,CAAC,CAAC;YACxE,OAAO,KAAK,CAAC;QACf,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;QACxC,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;QACpB,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QAEhB,OAAO,OAAO,CAAC;YACb,OAAO,EAAE,yBAAyB;YAClC,OAAO,EAAE,KAAK;SACf,CAAC,CAAC;IACL,CAAC;CACF;AAED;;;GAGG;AACH,MAAM,UAAU,aAAa;IAC3B,OAAO,OAAO,CAAC,KAAK,CAAC,KAAK,KAAK,IAAI,CAAC;AACtC,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,cAAc,CAAC,OAAgB;IAC7C,IAAI,OAAO,IAAI,CAAC,aAAa,EAAE,EAAE,CAAC;QAChC,OAAO,IAAI,kBAAkB,EAAE,CAAC;IAClC,CAAC;IACD,OAAO,IAAI,mBAAmB,EAAE,CAAC;AACnC,CAAC"}
+{"version":3,"file":"prompts.js","sourceRoot":"","sources":["../../src/cli/prompts.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,MAAM,mBAAmB,CAAC;AAGpD;;GAEG;AACH,MAAM,0BAA0B,GAAG,iCAAiC,CAAC;AAErE;;GAEG;AACH,MAAM,yBAAyB,GAC7B,iFAAiF,CAAC;AA8CpF;;GAEG;AACH,MAAM,OAAO,mBAAmB;IAC9B,6DAA6D;IACpD,UAAU,GAAG,KAAK,CAAC;IAE5B,KAAK,CAAC,eAAe,CAAC,YAAoB;QACxC,OAAO,MAAM,CAAC;YACZ,OAAO,EAAE,iBAAiB,YAAY,cAAc;YACpD,OAAO,EAAE;gBACP,EAAE,IAAI,EAAE,iBAAiB,EAAE,KAAK,EAAE,KAAc,EAAE;gBAClD,EAAE,IAAI,EAAE,WAAW,EAAE,KAAK,EAAE,IAAa,EAAE;gBAC3C,EAAE,IAAI,EAAE,yBAAyB,EAAE,KAAK,EAAE,MAAe,EAAE;aAC5D;SACF,CAAC,CAAC;IACL,CAAC;IAED,KAAK,CAAC,mBAAmB,CACvB,QAAgC;QAEhC,MAAM,YAAY,GAChB,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,iBAAiB,CAAC;QAEhE,MAAM,OAAO,CAAC;YACZ,OAAO,EAAE,2BAA2B,YAAY,8BAA8B;YAC9E,OAAO,EAAE,IAAI;SACd,CAAC,CAAC;QAEH,OAAO,QAAQ,CAAC;IAClB,CAAC;IAED,KAAK,CAAC,eAAe,CAAC,MAAc;QAClC,OAAO,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;QACxC,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;QACpB,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QAEhB,OAAO,OAAO,CAAC;YACb,OAAO,EAAE,yBAAyB;YAClC,OAAO,EAAE,KAAK;SACf,CAAC,CAAC;IACL,CAAC;CACF;AAED;;;;;;;;;;GAUG;AACH,MAAM,OAAO,kBAAkB;IAC7B,0DAA0D;IACjD,UAAU,GAAG,KAAK,CAAC;IAE5B,KAAK,CAAC,eAAe,CAAC,aAAqB;QACzC,OAAO,KAAK,CAAC;IACf,CAAC;IAED,KAAK,CAAC,mBAAmB,CACvB,QAAgC;QAEhC,OAAO,QAAQ,CAAC;IAClB,CAAC;IAED,KAAK,CAAC,eAAe,CAAC,MAAc;QAClC,wDAAwD;QACxD,qEAAqE;QACrE,IAAI,CAAC,aAAa,EAAE,EAAE,CAAC;YACrB,8DAA8D;YAC9D,OAAO,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;YACxC,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;YACpB,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;YAChB,OAAO,CAAC,GAAG,CACT,kGAAkG,CACnG,CAAC;YACF,OAAO,CAAC,GAAG,CAAC,0DAA0D,CAAC,CAAC;YACxE,OAAO,KAAK,CAAC;QACf,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;QACxC,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;QACpB,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QAEhB,OAAO,OAAO,CAAC;YACb,OAAO,EAAE,yBAAyB;YAClC,OAAO,EAAE,KAAK;SACf,CAAC,CAAC;IACL,CAAC;CACF;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH,MAAM,OAAO,kBAAkB;IAC7B,iEAAiE;IACxD,UAAU,GAAG,IAAI,CAAC;IAE3B,KAAK,CAAC,eAAe,CAAC,aAAqB;QACzC,OAAO,IAAI,CAAC;IACd,CAAC;IAED,KAAK,CAAC,mBAAmB,CACvB,QAAgC;QAEhC,OAAO,QAAQ,CAAC;IAClB,CAAC;IAED,KAAK,CAAC,eAAe,CAAC,MAAc;QAClC,OAAO,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;QACxC,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;QACpB,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QAChB,OAAO,CAAC,GAAG,CACT,kGAAkG,CACnG,CAAC;QACF,OAAO,CAAC,GAAG,CAAC,0DAA0D,CAAC,CAAC;QACxE,OAAO,KAAK,CAAC;IACf,CAAC;CACF;AAED;;;GAGG;AACH,MAAM,UAAU,aAAa;IAC3B,OAAO,OAAO,CAAC,KAAK,CAAC,KAAK,KAAK,IAAI,CAAC;AACtC,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,cAAc,CAAC,OAAgB;IAC7C,IAAI,OAAO,EAAE,CAAC;QACZ,OAAO,IAAI,kBAAkB,EAAE,CAAC;IAClC,CAAC;IACD,IAAI,CAAC,aAAa,EAAE,EAAE,CAAC;QACrB,OAAO,IAAI,kBAAkB,EAAE,CAAC;IAClC,CAAC;IACD,OAAO,IAAI,mBAAmB,EAAE,CAAC;AACnC,CAAC"}