@codyswann/lisa 2.326.0 → 2.326.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/core/upstream-evidence-manifest.js +1 -1
- package/package.json +1 -1
- package/plugins/lisa/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa/.codex-plugin/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +61 -15
- package/plugins/lisa/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +61 -15
- package/plugins/lisa-agy/plugin.json +1 -1
- package/plugins/lisa-agy/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +61 -15
- package/plugins/lisa-cdk/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-agy/plugin.json +1 -1
- package/plugins/lisa-cdk-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +61 -15
- package/plugins/lisa-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cursor/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +61 -15
- package/plugins/lisa-expo/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-agy/plugin.json +1 -1
- package/plugins/lisa-expo-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-agy/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-agy/plugin.json +1 -1
- package/plugins/lisa-nestjs-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-agy/plugin.json +1 -1
- package/plugins/lisa-openclaw-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-agy/plugin.json +1 -1
- package/plugins/lisa-phaser-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-agy/plugin.json +1 -1
- package/plugins/lisa-rails-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-agy/plugin.json +1 -1
- package/plugins/lisa-typescript-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-agy/plugin.json +1 -1
- package/plugins/lisa-wiki-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/src/base/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +61 -15
|
@@ -426,7 +426,7 @@ export const UPSTREAM_EVIDENCE_MANIFEST = Object.freeze({
|
|
|
426
426
|
"plugins/src/base/skills/lisa-debrief/SKILL.md": "47e4cda36b07994ff47ab15fb04a17dd6b0c310ad804f9cae9d69637edaaa72a",
|
|
427
427
|
"plugins/src/base/skills/lisa-delivery-effectiveness/SKILL.md": "21bc55fa0e86a9694bd22269fd089dbfae0c54c199262f46a4955447acea0f35",
|
|
428
428
|
"plugins/src/base/skills/lisa-detect-tooling/SKILL.md": "1778a009d06099b3bd2d9a33b37bec34836b295e21fad220ae926491d3557208",
|
|
429
|
-
"plugins/src/base/skills/lisa-detect-tooling/scripts/detect-tooling.mjs": "
|
|
429
|
+
"plugins/src/base/skills/lisa-detect-tooling/scripts/detect-tooling.mjs": "d2ff0e79dd8a3f79252d425d8203dab54f9e2afd387d113cb8b1a7637a5082e7",
|
|
430
430
|
"plugins/src/base/skills/lisa-doctor/SKILL.md": "fb41a1e63c5332d47a46e715aff52551f3df867033b5e4f37dfaeee30019b891",
|
|
431
431
|
"plugins/src/base/skills/lisa-drive-pr-to-merge/SKILL.md": "c78ae2ba32c830d0b2cd7d24de91adf99e2b3cef4c7cab1c417580d86f41351f",
|
|
432
432
|
"plugins/src/base/skills/lisa-epic-triage/SKILL.md": "d02760411249bddbd396f283191fe3e82bb7b95bf9393a19a7025dc5a57c3ab7",
|
package/package.json
CHANGED
|
@@ -115,7 +115,7 @@
|
|
|
115
115
|
"brace-expansion": ">=5.0.9"
|
|
116
116
|
},
|
|
117
117
|
"name": "@codyswann/lisa",
|
|
118
|
-
"version": "2.326.
|
|
118
|
+
"version": "2.326.3",
|
|
119
119
|
"description": "Claude Code governance framework that applies guardrails, guidance, and automated enforcement to projects",
|
|
120
120
|
"main": "dist/index.js",
|
|
121
121
|
"exports": {
|
|
@@ -22,9 +22,12 @@
|
|
|
22
22
|
* @module detect-tooling
|
|
23
23
|
*/
|
|
24
24
|
|
|
25
|
-
import { existsSync, readFileSync } from "node:fs";
|
|
25
|
+
import { existsSync, readFileSync, statSync } from "node:fs";
|
|
26
26
|
import { join } from "node:path";
|
|
27
27
|
|
|
28
|
+
/** The tool named by the Expo template's scripts and its flows directory. */
|
|
29
|
+
const MAESTRO = "maestro";
|
|
30
|
+
|
|
28
31
|
/**
|
|
29
32
|
* Tools Lisa or its templates invoke, and how to recognise a need for them.
|
|
30
33
|
*
|
|
@@ -33,9 +36,12 @@ import { join } from "node:path";
|
|
|
33
36
|
* ones that only appear when the tool is genuinely used.
|
|
34
37
|
*/
|
|
35
38
|
const KNOWN_TOOLS = Object.freeze({
|
|
36
|
-
|
|
39
|
+
[MAESTRO]: {
|
|
40
|
+
// A flows directory is the artifact maestro consumes; its presence is
|
|
41
|
+
// usage, where a synced threshold default is not.
|
|
42
|
+
artifacts: ".maestro",
|
|
37
43
|
why: "Expo's template ships npm scripts that invoke `maestro`, and nothing installs the binary.",
|
|
38
|
-
mcpFallback:
|
|
44
|
+
mcpFallback: MAESTRO,
|
|
39
45
|
},
|
|
40
46
|
gh: {
|
|
41
47
|
why: "The work-item guardrails shell out to `gh` for every tracker read.",
|
|
@@ -199,22 +205,62 @@ export function toolsFromSecretNotes(notes) {
|
|
|
199
205
|
}
|
|
200
206
|
|
|
201
207
|
/**
|
|
202
|
-
*
|
|
208
|
+
* Whether anything in the project actually reaches for this tool.
|
|
209
|
+
*
|
|
210
|
+
* Corroboration for a threshold, which on its own says only that a default was
|
|
211
|
+
* synced. Two independent witnesses: a script that names the binary, or the
|
|
212
|
+
* directory of artifacts the tool consumes.
|
|
213
|
+
* @param {string} tool Tool name.
|
|
214
|
+
* @param {object|null} pkg Parsed package.json.
|
|
215
|
+
* @param {string} cwd Project root.
|
|
216
|
+
* @returns {boolean} Whether the project uses it.
|
|
217
|
+
*/
|
|
218
|
+
function usedByProject(tool, pkg, cwd) {
|
|
219
|
+
const invoked = [...toolsFromScripts(pkg).keys()].includes(tool);
|
|
220
|
+
if (invoked) return true;
|
|
221
|
+
const artifacts = KNOWN_TOOLS[tool]?.artifacts;
|
|
222
|
+
if (!artifacts) return false;
|
|
223
|
+
// A DIRECTORY, not merely an entry with that name. `existsSync` is true for a
|
|
224
|
+
// regular file too, so a stray `.maestro` note or editor artifact would have
|
|
225
|
+
// corroborated the threshold and reintroduced the 300MB proposal this check
|
|
226
|
+
// exists to prevent — a false positive arriving through the very guard added
|
|
227
|
+
// to stop one.
|
|
228
|
+
try {
|
|
229
|
+
return statSync(join(cwd, artifacts)).isDirectory();
|
|
230
|
+
} catch {
|
|
231
|
+
return false;
|
|
232
|
+
}
|
|
233
|
+
}
|
|
234
|
+
|
|
235
|
+
/**
|
|
236
|
+
* Tools a project's quality configuration CORROBORATES — never establishes.
|
|
237
|
+
*
|
|
238
|
+
* A threshold is not usage. `quality.e2eCoverage` defaults are synced into
|
|
239
|
+
* every project by `src/sync/registry.ts`, so this repository carries a
|
|
240
|
+
* `maestro` entry while having no `.maestro` directory and no script that
|
|
241
|
+
* invokes it. Treating that as evidence proposed pinning a 300MB JVM
|
|
242
|
+
* application into a container for a tool nothing runs.
|
|
243
|
+
*
|
|
244
|
+
* Evidence that a tool is CONFIGURED is not evidence that it is NEEDED — the
|
|
245
|
+
* same mistake as proposing a binary npm already provides. So a threshold only
|
|
246
|
+
* counts when something corroborates it: a script that invokes the tool, or the
|
|
247
|
+
* artifacts it consumes. In a real Expo project the script signal fires and
|
|
248
|
+
* this adds nothing; in a project that merely inherited the defaults, it
|
|
249
|
+
* correctly stays quiet.
|
|
203
250
|
* @param {object|null} config Parsed .lisa.config.json.
|
|
251
|
+
* @param {object|null} [pkg] Parsed package.json, for corroboration.
|
|
252
|
+
* @param {string} [cwd] Project root, for artifact corroboration.
|
|
204
253
|
* @returns {Map<string, string>} Tool name to the setting that implies it.
|
|
205
254
|
*/
|
|
206
|
-
export function toolsFromQuality(config) {
|
|
255
|
+
export function toolsFromQuality(config, pkg = null, cwd = process.cwd()) {
|
|
207
256
|
const found = new Map();
|
|
208
|
-
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
-
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
-
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
-
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
-
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
-
// while the gap is right there is worse than no gate.
|
|
214
257
|
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
-
if (Object.hasOwn(KNOWN_TOOLS, runner))
|
|
216
|
-
|
|
217
|
-
|
|
258
|
+
if (!Object.hasOwn(KNOWN_TOOLS, runner)) continue;
|
|
259
|
+
if (!usedByProject(runner, pkg, cwd)) continue;
|
|
260
|
+
found.set(
|
|
261
|
+
runner,
|
|
262
|
+
`quality.e2eCoverage.${runner} is configured, and the project uses it`
|
|
263
|
+
);
|
|
218
264
|
}
|
|
219
265
|
if (config?.quality?.sonar || config?.sonar) {
|
|
220
266
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -288,7 +334,7 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
288
334
|
toolsFromScripts(pkg),
|
|
289
335
|
toolsFromMcp(mcp),
|
|
290
336
|
toolsFromSecretNotes(notes),
|
|
291
|
-
toolsFromQuality(config),
|
|
337
|
+
toolsFromQuality(config, pkg, cwd),
|
|
292
338
|
];
|
|
293
339
|
|
|
294
340
|
const merged = new Map();
|
|
@@ -22,9 +22,12 @@
|
|
|
22
22
|
* @module detect-tooling
|
|
23
23
|
*/
|
|
24
24
|
|
|
25
|
-
import { existsSync, readFileSync } from "node:fs";
|
|
25
|
+
import { existsSync, readFileSync, statSync } from "node:fs";
|
|
26
26
|
import { join } from "node:path";
|
|
27
27
|
|
|
28
|
+
/** The tool named by the Expo template's scripts and its flows directory. */
|
|
29
|
+
const MAESTRO = "maestro";
|
|
30
|
+
|
|
28
31
|
/**
|
|
29
32
|
* Tools Lisa or its templates invoke, and how to recognise a need for them.
|
|
30
33
|
*
|
|
@@ -33,9 +36,12 @@ import { join } from "node:path";
|
|
|
33
36
|
* ones that only appear when the tool is genuinely used.
|
|
34
37
|
*/
|
|
35
38
|
const KNOWN_TOOLS = Object.freeze({
|
|
36
|
-
|
|
39
|
+
[MAESTRO]: {
|
|
40
|
+
// A flows directory is the artifact maestro consumes; its presence is
|
|
41
|
+
// usage, where a synced threshold default is not.
|
|
42
|
+
artifacts: ".maestro",
|
|
37
43
|
why: "Expo's template ships npm scripts that invoke `maestro`, and nothing installs the binary.",
|
|
38
|
-
mcpFallback:
|
|
44
|
+
mcpFallback: MAESTRO,
|
|
39
45
|
},
|
|
40
46
|
gh: {
|
|
41
47
|
why: "The work-item guardrails shell out to `gh` for every tracker read.",
|
|
@@ -199,22 +205,62 @@ export function toolsFromSecretNotes(notes) {
|
|
|
199
205
|
}
|
|
200
206
|
|
|
201
207
|
/**
|
|
202
|
-
*
|
|
208
|
+
* Whether anything in the project actually reaches for this tool.
|
|
209
|
+
*
|
|
210
|
+
* Corroboration for a threshold, which on its own says only that a default was
|
|
211
|
+
* synced. Two independent witnesses: a script that names the binary, or the
|
|
212
|
+
* directory of artifacts the tool consumes.
|
|
213
|
+
* @param {string} tool Tool name.
|
|
214
|
+
* @param {object|null} pkg Parsed package.json.
|
|
215
|
+
* @param {string} cwd Project root.
|
|
216
|
+
* @returns {boolean} Whether the project uses it.
|
|
217
|
+
*/
|
|
218
|
+
function usedByProject(tool, pkg, cwd) {
|
|
219
|
+
const invoked = [...toolsFromScripts(pkg).keys()].includes(tool);
|
|
220
|
+
if (invoked) return true;
|
|
221
|
+
const artifacts = KNOWN_TOOLS[tool]?.artifacts;
|
|
222
|
+
if (!artifacts) return false;
|
|
223
|
+
// A DIRECTORY, not merely an entry with that name. `existsSync` is true for a
|
|
224
|
+
// regular file too, so a stray `.maestro` note or editor artifact would have
|
|
225
|
+
// corroborated the threshold and reintroduced the 300MB proposal this check
|
|
226
|
+
// exists to prevent — a false positive arriving through the very guard added
|
|
227
|
+
// to stop one.
|
|
228
|
+
try {
|
|
229
|
+
return statSync(join(cwd, artifacts)).isDirectory();
|
|
230
|
+
} catch {
|
|
231
|
+
return false;
|
|
232
|
+
}
|
|
233
|
+
}
|
|
234
|
+
|
|
235
|
+
/**
|
|
236
|
+
* Tools a project's quality configuration CORROBORATES — never establishes.
|
|
237
|
+
*
|
|
238
|
+
* A threshold is not usage. `quality.e2eCoverage` defaults are synced into
|
|
239
|
+
* every project by `src/sync/registry.ts`, so this repository carries a
|
|
240
|
+
* `maestro` entry while having no `.maestro` directory and no script that
|
|
241
|
+
* invokes it. Treating that as evidence proposed pinning a 300MB JVM
|
|
242
|
+
* application into a container for a tool nothing runs.
|
|
243
|
+
*
|
|
244
|
+
* Evidence that a tool is CONFIGURED is not evidence that it is NEEDED — the
|
|
245
|
+
* same mistake as proposing a binary npm already provides. So a threshold only
|
|
246
|
+
* counts when something corroborates it: a script that invokes the tool, or the
|
|
247
|
+
* artifacts it consumes. In a real Expo project the script signal fires and
|
|
248
|
+
* this adds nothing; in a project that merely inherited the defaults, it
|
|
249
|
+
* correctly stays quiet.
|
|
203
250
|
* @param {object|null} config Parsed .lisa.config.json.
|
|
251
|
+
* @param {object|null} [pkg] Parsed package.json, for corroboration.
|
|
252
|
+
* @param {string} [cwd] Project root, for artifact corroboration.
|
|
204
253
|
* @returns {Map<string, string>} Tool name to the setting that implies it.
|
|
205
254
|
*/
|
|
206
|
-
export function toolsFromQuality(config) {
|
|
255
|
+
export function toolsFromQuality(config, pkg = null, cwd = process.cwd()) {
|
|
207
256
|
const found = new Map();
|
|
208
|
-
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
-
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
-
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
-
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
-
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
-
// while the gap is right there is worse than no gate.
|
|
214
257
|
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
-
if (Object.hasOwn(KNOWN_TOOLS, runner))
|
|
216
|
-
|
|
217
|
-
|
|
258
|
+
if (!Object.hasOwn(KNOWN_TOOLS, runner)) continue;
|
|
259
|
+
if (!usedByProject(runner, pkg, cwd)) continue;
|
|
260
|
+
found.set(
|
|
261
|
+
runner,
|
|
262
|
+
`quality.e2eCoverage.${runner} is configured, and the project uses it`
|
|
263
|
+
);
|
|
218
264
|
}
|
|
219
265
|
if (config?.quality?.sonar || config?.sonar) {
|
|
220
266
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -288,7 +334,7 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
288
334
|
toolsFromScripts(pkg),
|
|
289
335
|
toolsFromMcp(mcp),
|
|
290
336
|
toolsFromSecretNotes(notes),
|
|
291
|
-
toolsFromQuality(config),
|
|
337
|
+
toolsFromQuality(config, pkg, cwd),
|
|
292
338
|
];
|
|
293
339
|
|
|
294
340
|
const merged = new Map();
|
|
@@ -22,9 +22,12 @@
|
|
|
22
22
|
* @module detect-tooling
|
|
23
23
|
*/
|
|
24
24
|
|
|
25
|
-
import { existsSync, readFileSync } from "node:fs";
|
|
25
|
+
import { existsSync, readFileSync, statSync } from "node:fs";
|
|
26
26
|
import { join } from "node:path";
|
|
27
27
|
|
|
28
|
+
/** The tool named by the Expo template's scripts and its flows directory. */
|
|
29
|
+
const MAESTRO = "maestro";
|
|
30
|
+
|
|
28
31
|
/**
|
|
29
32
|
* Tools Lisa or its templates invoke, and how to recognise a need for them.
|
|
30
33
|
*
|
|
@@ -33,9 +36,12 @@ import { join } from "node:path";
|
|
|
33
36
|
* ones that only appear when the tool is genuinely used.
|
|
34
37
|
*/
|
|
35
38
|
const KNOWN_TOOLS = Object.freeze({
|
|
36
|
-
|
|
39
|
+
[MAESTRO]: {
|
|
40
|
+
// A flows directory is the artifact maestro consumes; its presence is
|
|
41
|
+
// usage, where a synced threshold default is not.
|
|
42
|
+
artifacts: ".maestro",
|
|
37
43
|
why: "Expo's template ships npm scripts that invoke `maestro`, and nothing installs the binary.",
|
|
38
|
-
mcpFallback:
|
|
44
|
+
mcpFallback: MAESTRO,
|
|
39
45
|
},
|
|
40
46
|
gh: {
|
|
41
47
|
why: "The work-item guardrails shell out to `gh` for every tracker read.",
|
|
@@ -199,22 +205,62 @@ export function toolsFromSecretNotes(notes) {
|
|
|
199
205
|
}
|
|
200
206
|
|
|
201
207
|
/**
|
|
202
|
-
*
|
|
208
|
+
* Whether anything in the project actually reaches for this tool.
|
|
209
|
+
*
|
|
210
|
+
* Corroboration for a threshold, which on its own says only that a default was
|
|
211
|
+
* synced. Two independent witnesses: a script that names the binary, or the
|
|
212
|
+
* directory of artifacts the tool consumes.
|
|
213
|
+
* @param {string} tool Tool name.
|
|
214
|
+
* @param {object|null} pkg Parsed package.json.
|
|
215
|
+
* @param {string} cwd Project root.
|
|
216
|
+
* @returns {boolean} Whether the project uses it.
|
|
217
|
+
*/
|
|
218
|
+
function usedByProject(tool, pkg, cwd) {
|
|
219
|
+
const invoked = [...toolsFromScripts(pkg).keys()].includes(tool);
|
|
220
|
+
if (invoked) return true;
|
|
221
|
+
const artifacts = KNOWN_TOOLS[tool]?.artifacts;
|
|
222
|
+
if (!artifacts) return false;
|
|
223
|
+
// A DIRECTORY, not merely an entry with that name. `existsSync` is true for a
|
|
224
|
+
// regular file too, so a stray `.maestro` note or editor artifact would have
|
|
225
|
+
// corroborated the threshold and reintroduced the 300MB proposal this check
|
|
226
|
+
// exists to prevent — a false positive arriving through the very guard added
|
|
227
|
+
// to stop one.
|
|
228
|
+
try {
|
|
229
|
+
return statSync(join(cwd, artifacts)).isDirectory();
|
|
230
|
+
} catch {
|
|
231
|
+
return false;
|
|
232
|
+
}
|
|
233
|
+
}
|
|
234
|
+
|
|
235
|
+
/**
|
|
236
|
+
* Tools a project's quality configuration CORROBORATES — never establishes.
|
|
237
|
+
*
|
|
238
|
+
* A threshold is not usage. `quality.e2eCoverage` defaults are synced into
|
|
239
|
+
* every project by `src/sync/registry.ts`, so this repository carries a
|
|
240
|
+
* `maestro` entry while having no `.maestro` directory and no script that
|
|
241
|
+
* invokes it. Treating that as evidence proposed pinning a 300MB JVM
|
|
242
|
+
* application into a container for a tool nothing runs.
|
|
243
|
+
*
|
|
244
|
+
* Evidence that a tool is CONFIGURED is not evidence that it is NEEDED — the
|
|
245
|
+
* same mistake as proposing a binary npm already provides. So a threshold only
|
|
246
|
+
* counts when something corroborates it: a script that invokes the tool, or the
|
|
247
|
+
* artifacts it consumes. In a real Expo project the script signal fires and
|
|
248
|
+
* this adds nothing; in a project that merely inherited the defaults, it
|
|
249
|
+
* correctly stays quiet.
|
|
203
250
|
* @param {object|null} config Parsed .lisa.config.json.
|
|
251
|
+
* @param {object|null} [pkg] Parsed package.json, for corroboration.
|
|
252
|
+
* @param {string} [cwd] Project root, for artifact corroboration.
|
|
204
253
|
* @returns {Map<string, string>} Tool name to the setting that implies it.
|
|
205
254
|
*/
|
|
206
|
-
export function toolsFromQuality(config) {
|
|
255
|
+
export function toolsFromQuality(config, pkg = null, cwd = process.cwd()) {
|
|
207
256
|
const found = new Map();
|
|
208
|
-
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
-
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
-
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
-
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
-
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
-
// while the gap is right there is worse than no gate.
|
|
214
257
|
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
-
if (Object.hasOwn(KNOWN_TOOLS, runner))
|
|
216
|
-
|
|
217
|
-
|
|
258
|
+
if (!Object.hasOwn(KNOWN_TOOLS, runner)) continue;
|
|
259
|
+
if (!usedByProject(runner, pkg, cwd)) continue;
|
|
260
|
+
found.set(
|
|
261
|
+
runner,
|
|
262
|
+
`quality.e2eCoverage.${runner} is configured, and the project uses it`
|
|
263
|
+
);
|
|
218
264
|
}
|
|
219
265
|
if (config?.quality?.sonar || config?.sonar) {
|
|
220
266
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -288,7 +334,7 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
288
334
|
toolsFromScripts(pkg),
|
|
289
335
|
toolsFromMcp(mcp),
|
|
290
336
|
toolsFromSecretNotes(notes),
|
|
291
|
-
toolsFromQuality(config),
|
|
337
|
+
toolsFromQuality(config, pkg, cwd),
|
|
292
338
|
];
|
|
293
339
|
|
|
294
340
|
const merged = new Map();
|
|
@@ -22,9 +22,12 @@
|
|
|
22
22
|
* @module detect-tooling
|
|
23
23
|
*/
|
|
24
24
|
|
|
25
|
-
import { existsSync, readFileSync } from "node:fs";
|
|
25
|
+
import { existsSync, readFileSync, statSync } from "node:fs";
|
|
26
26
|
import { join } from "node:path";
|
|
27
27
|
|
|
28
|
+
/** The tool named by the Expo template's scripts and its flows directory. */
|
|
29
|
+
const MAESTRO = "maestro";
|
|
30
|
+
|
|
28
31
|
/**
|
|
29
32
|
* Tools Lisa or its templates invoke, and how to recognise a need for them.
|
|
30
33
|
*
|
|
@@ -33,9 +36,12 @@ import { join } from "node:path";
|
|
|
33
36
|
* ones that only appear when the tool is genuinely used.
|
|
34
37
|
*/
|
|
35
38
|
const KNOWN_TOOLS = Object.freeze({
|
|
36
|
-
|
|
39
|
+
[MAESTRO]: {
|
|
40
|
+
// A flows directory is the artifact maestro consumes; its presence is
|
|
41
|
+
// usage, where a synced threshold default is not.
|
|
42
|
+
artifacts: ".maestro",
|
|
37
43
|
why: "Expo's template ships npm scripts that invoke `maestro`, and nothing installs the binary.",
|
|
38
|
-
mcpFallback:
|
|
44
|
+
mcpFallback: MAESTRO,
|
|
39
45
|
},
|
|
40
46
|
gh: {
|
|
41
47
|
why: "The work-item guardrails shell out to `gh` for every tracker read.",
|
|
@@ -199,22 +205,62 @@ export function toolsFromSecretNotes(notes) {
|
|
|
199
205
|
}
|
|
200
206
|
|
|
201
207
|
/**
|
|
202
|
-
*
|
|
208
|
+
* Whether anything in the project actually reaches for this tool.
|
|
209
|
+
*
|
|
210
|
+
* Corroboration for a threshold, which on its own says only that a default was
|
|
211
|
+
* synced. Two independent witnesses: a script that names the binary, or the
|
|
212
|
+
* directory of artifacts the tool consumes.
|
|
213
|
+
* @param {string} tool Tool name.
|
|
214
|
+
* @param {object|null} pkg Parsed package.json.
|
|
215
|
+
* @param {string} cwd Project root.
|
|
216
|
+
* @returns {boolean} Whether the project uses it.
|
|
217
|
+
*/
|
|
218
|
+
function usedByProject(tool, pkg, cwd) {
|
|
219
|
+
const invoked = [...toolsFromScripts(pkg).keys()].includes(tool);
|
|
220
|
+
if (invoked) return true;
|
|
221
|
+
const artifacts = KNOWN_TOOLS[tool]?.artifacts;
|
|
222
|
+
if (!artifacts) return false;
|
|
223
|
+
// A DIRECTORY, not merely an entry with that name. `existsSync` is true for a
|
|
224
|
+
// regular file too, so a stray `.maestro` note or editor artifact would have
|
|
225
|
+
// corroborated the threshold and reintroduced the 300MB proposal this check
|
|
226
|
+
// exists to prevent — a false positive arriving through the very guard added
|
|
227
|
+
// to stop one.
|
|
228
|
+
try {
|
|
229
|
+
return statSync(join(cwd, artifacts)).isDirectory();
|
|
230
|
+
} catch {
|
|
231
|
+
return false;
|
|
232
|
+
}
|
|
233
|
+
}
|
|
234
|
+
|
|
235
|
+
/**
|
|
236
|
+
* Tools a project's quality configuration CORROBORATES — never establishes.
|
|
237
|
+
*
|
|
238
|
+
* A threshold is not usage. `quality.e2eCoverage` defaults are synced into
|
|
239
|
+
* every project by `src/sync/registry.ts`, so this repository carries a
|
|
240
|
+
* `maestro` entry while having no `.maestro` directory and no script that
|
|
241
|
+
* invokes it. Treating that as evidence proposed pinning a 300MB JVM
|
|
242
|
+
* application into a container for a tool nothing runs.
|
|
243
|
+
*
|
|
244
|
+
* Evidence that a tool is CONFIGURED is not evidence that it is NEEDED — the
|
|
245
|
+
* same mistake as proposing a binary npm already provides. So a threshold only
|
|
246
|
+
* counts when something corroborates it: a script that invokes the tool, or the
|
|
247
|
+
* artifacts it consumes. In a real Expo project the script signal fires and
|
|
248
|
+
* this adds nothing; in a project that merely inherited the defaults, it
|
|
249
|
+
* correctly stays quiet.
|
|
203
250
|
* @param {object|null} config Parsed .lisa.config.json.
|
|
251
|
+
* @param {object|null} [pkg] Parsed package.json, for corroboration.
|
|
252
|
+
* @param {string} [cwd] Project root, for artifact corroboration.
|
|
204
253
|
* @returns {Map<string, string>} Tool name to the setting that implies it.
|
|
205
254
|
*/
|
|
206
|
-
export function toolsFromQuality(config) {
|
|
255
|
+
export function toolsFromQuality(config, pkg = null, cwd = process.cwd()) {
|
|
207
256
|
const found = new Map();
|
|
208
|
-
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
-
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
-
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
-
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
-
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
-
// while the gap is right there is worse than no gate.
|
|
214
257
|
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
-
if (Object.hasOwn(KNOWN_TOOLS, runner))
|
|
216
|
-
|
|
217
|
-
|
|
258
|
+
if (!Object.hasOwn(KNOWN_TOOLS, runner)) continue;
|
|
259
|
+
if (!usedByProject(runner, pkg, cwd)) continue;
|
|
260
|
+
found.set(
|
|
261
|
+
runner,
|
|
262
|
+
`quality.e2eCoverage.${runner} is configured, and the project uses it`
|
|
263
|
+
);
|
|
218
264
|
}
|
|
219
265
|
if (config?.quality?.sonar || config?.sonar) {
|
|
220
266
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -288,7 +334,7 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
288
334
|
toolsFromScripts(pkg),
|
|
289
335
|
toolsFromMcp(mcp),
|
|
290
336
|
toolsFromSecretNotes(notes),
|
|
291
|
-
toolsFromQuality(config),
|
|
337
|
+
toolsFromQuality(config, pkg, cwd),
|
|
292
338
|
];
|
|
293
339
|
|
|
294
340
|
const merged = new Map();
|
|
@@ -22,9 +22,12 @@
|
|
|
22
22
|
* @module detect-tooling
|
|
23
23
|
*/
|
|
24
24
|
|
|
25
|
-
import { existsSync, readFileSync } from "node:fs";
|
|
25
|
+
import { existsSync, readFileSync, statSync } from "node:fs";
|
|
26
26
|
import { join } from "node:path";
|
|
27
27
|
|
|
28
|
+
/** The tool named by the Expo template's scripts and its flows directory. */
|
|
29
|
+
const MAESTRO = "maestro";
|
|
30
|
+
|
|
28
31
|
/**
|
|
29
32
|
* Tools Lisa or its templates invoke, and how to recognise a need for them.
|
|
30
33
|
*
|
|
@@ -33,9 +36,12 @@ import { join } from "node:path";
|
|
|
33
36
|
* ones that only appear when the tool is genuinely used.
|
|
34
37
|
*/
|
|
35
38
|
const KNOWN_TOOLS = Object.freeze({
|
|
36
|
-
|
|
39
|
+
[MAESTRO]: {
|
|
40
|
+
// A flows directory is the artifact maestro consumes; its presence is
|
|
41
|
+
// usage, where a synced threshold default is not.
|
|
42
|
+
artifacts: ".maestro",
|
|
37
43
|
why: "Expo's template ships npm scripts that invoke `maestro`, and nothing installs the binary.",
|
|
38
|
-
mcpFallback:
|
|
44
|
+
mcpFallback: MAESTRO,
|
|
39
45
|
},
|
|
40
46
|
gh: {
|
|
41
47
|
why: "The work-item guardrails shell out to `gh` for every tracker read.",
|
|
@@ -199,22 +205,62 @@ export function toolsFromSecretNotes(notes) {
|
|
|
199
205
|
}
|
|
200
206
|
|
|
201
207
|
/**
|
|
202
|
-
*
|
|
208
|
+
* Whether anything in the project actually reaches for this tool.
|
|
209
|
+
*
|
|
210
|
+
* Corroboration for a threshold, which on its own says only that a default was
|
|
211
|
+
* synced. Two independent witnesses: a script that names the binary, or the
|
|
212
|
+
* directory of artifacts the tool consumes.
|
|
213
|
+
* @param {string} tool Tool name.
|
|
214
|
+
* @param {object|null} pkg Parsed package.json.
|
|
215
|
+
* @param {string} cwd Project root.
|
|
216
|
+
* @returns {boolean} Whether the project uses it.
|
|
217
|
+
*/
|
|
218
|
+
function usedByProject(tool, pkg, cwd) {
|
|
219
|
+
const invoked = [...toolsFromScripts(pkg).keys()].includes(tool);
|
|
220
|
+
if (invoked) return true;
|
|
221
|
+
const artifacts = KNOWN_TOOLS[tool]?.artifacts;
|
|
222
|
+
if (!artifacts) return false;
|
|
223
|
+
// A DIRECTORY, not merely an entry with that name. `existsSync` is true for a
|
|
224
|
+
// regular file too, so a stray `.maestro` note or editor artifact would have
|
|
225
|
+
// corroborated the threshold and reintroduced the 300MB proposal this check
|
|
226
|
+
// exists to prevent — a false positive arriving through the very guard added
|
|
227
|
+
// to stop one.
|
|
228
|
+
try {
|
|
229
|
+
return statSync(join(cwd, artifacts)).isDirectory();
|
|
230
|
+
} catch {
|
|
231
|
+
return false;
|
|
232
|
+
}
|
|
233
|
+
}
|
|
234
|
+
|
|
235
|
+
/**
|
|
236
|
+
* Tools a project's quality configuration CORROBORATES — never establishes.
|
|
237
|
+
*
|
|
238
|
+
* A threshold is not usage. `quality.e2eCoverage` defaults are synced into
|
|
239
|
+
* every project by `src/sync/registry.ts`, so this repository carries a
|
|
240
|
+
* `maestro` entry while having no `.maestro` directory and no script that
|
|
241
|
+
* invokes it. Treating that as evidence proposed pinning a 300MB JVM
|
|
242
|
+
* application into a container for a tool nothing runs.
|
|
243
|
+
*
|
|
244
|
+
* Evidence that a tool is CONFIGURED is not evidence that it is NEEDED — the
|
|
245
|
+
* same mistake as proposing a binary npm already provides. So a threshold only
|
|
246
|
+
* counts when something corroborates it: a script that invokes the tool, or the
|
|
247
|
+
* artifacts it consumes. In a real Expo project the script signal fires and
|
|
248
|
+
* this adds nothing; in a project that merely inherited the defaults, it
|
|
249
|
+
* correctly stays quiet.
|
|
203
250
|
* @param {object|null} config Parsed .lisa.config.json.
|
|
251
|
+
* @param {object|null} [pkg] Parsed package.json, for corroboration.
|
|
252
|
+
* @param {string} [cwd] Project root, for artifact corroboration.
|
|
204
253
|
* @returns {Map<string, string>} Tool name to the setting that implies it.
|
|
205
254
|
*/
|
|
206
|
-
export function toolsFromQuality(config) {
|
|
255
|
+
export function toolsFromQuality(config, pkg = null, cwd = process.cwd()) {
|
|
207
256
|
const found = new Map();
|
|
208
|
-
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
-
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
-
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
-
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
-
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
-
// while the gap is right there is worse than no gate.
|
|
214
257
|
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
-
if (Object.hasOwn(KNOWN_TOOLS, runner))
|
|
216
|
-
|
|
217
|
-
|
|
258
|
+
if (!Object.hasOwn(KNOWN_TOOLS, runner)) continue;
|
|
259
|
+
if (!usedByProject(runner, pkg, cwd)) continue;
|
|
260
|
+
found.set(
|
|
261
|
+
runner,
|
|
262
|
+
`quality.e2eCoverage.${runner} is configured, and the project uses it`
|
|
263
|
+
);
|
|
218
264
|
}
|
|
219
265
|
if (config?.quality?.sonar || config?.sonar) {
|
|
220
266
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -288,7 +334,7 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
288
334
|
toolsFromScripts(pkg),
|
|
289
335
|
toolsFromMcp(mcp),
|
|
290
336
|
toolsFromSecretNotes(notes),
|
|
291
|
-
toolsFromQuality(config),
|
|
337
|
+
toolsFromQuality(config, pkg, cwd),
|
|
292
338
|
];
|
|
293
339
|
|
|
294
340
|
const merged = new Map();
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "2.326.
|
|
3
|
+
"version": "2.326.3",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "2.326.
|
|
3
|
+
"version": "2.326.3",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, across Claude and Codex.",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "2.326.
|
|
3
|
+
"version": "2.326.3",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "2.326.
|
|
3
|
+
"version": "2.326.3",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "2.326.
|
|
3
|
+
"version": "2.326.3",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -22,9 +22,12 @@
|
|
|
22
22
|
* @module detect-tooling
|
|
23
23
|
*/
|
|
24
24
|
|
|
25
|
-
import { existsSync, readFileSync } from "node:fs";
|
|
25
|
+
import { existsSync, readFileSync, statSync } from "node:fs";
|
|
26
26
|
import { join } from "node:path";
|
|
27
27
|
|
|
28
|
+
/** The tool named by the Expo template's scripts and its flows directory. */
|
|
29
|
+
const MAESTRO = "maestro";
|
|
30
|
+
|
|
28
31
|
/**
|
|
29
32
|
* Tools Lisa or its templates invoke, and how to recognise a need for them.
|
|
30
33
|
*
|
|
@@ -33,9 +36,12 @@ import { join } from "node:path";
|
|
|
33
36
|
* ones that only appear when the tool is genuinely used.
|
|
34
37
|
*/
|
|
35
38
|
const KNOWN_TOOLS = Object.freeze({
|
|
36
|
-
|
|
39
|
+
[MAESTRO]: {
|
|
40
|
+
// A flows directory is the artifact maestro consumes; its presence is
|
|
41
|
+
// usage, where a synced threshold default is not.
|
|
42
|
+
artifacts: ".maestro",
|
|
37
43
|
why: "Expo's template ships npm scripts that invoke `maestro`, and nothing installs the binary.",
|
|
38
|
-
mcpFallback:
|
|
44
|
+
mcpFallback: MAESTRO,
|
|
39
45
|
},
|
|
40
46
|
gh: {
|
|
41
47
|
why: "The work-item guardrails shell out to `gh` for every tracker read.",
|
|
@@ -199,22 +205,62 @@ export function toolsFromSecretNotes(notes) {
|
|
|
199
205
|
}
|
|
200
206
|
|
|
201
207
|
/**
|
|
202
|
-
*
|
|
208
|
+
* Whether anything in the project actually reaches for this tool.
|
|
209
|
+
*
|
|
210
|
+
* Corroboration for a threshold, which on its own says only that a default was
|
|
211
|
+
* synced. Two independent witnesses: a script that names the binary, or the
|
|
212
|
+
* directory of artifacts the tool consumes.
|
|
213
|
+
* @param {string} tool Tool name.
|
|
214
|
+
* @param {object|null} pkg Parsed package.json.
|
|
215
|
+
* @param {string} cwd Project root.
|
|
216
|
+
* @returns {boolean} Whether the project uses it.
|
|
217
|
+
*/
|
|
218
|
+
function usedByProject(tool, pkg, cwd) {
|
|
219
|
+
const invoked = [...toolsFromScripts(pkg).keys()].includes(tool);
|
|
220
|
+
if (invoked) return true;
|
|
221
|
+
const artifacts = KNOWN_TOOLS[tool]?.artifacts;
|
|
222
|
+
if (!artifacts) return false;
|
|
223
|
+
// A DIRECTORY, not merely an entry with that name. `existsSync` is true for a
|
|
224
|
+
// regular file too, so a stray `.maestro` note or editor artifact would have
|
|
225
|
+
// corroborated the threshold and reintroduced the 300MB proposal this check
|
|
226
|
+
// exists to prevent — a false positive arriving through the very guard added
|
|
227
|
+
// to stop one.
|
|
228
|
+
try {
|
|
229
|
+
return statSync(join(cwd, artifacts)).isDirectory();
|
|
230
|
+
} catch {
|
|
231
|
+
return false;
|
|
232
|
+
}
|
|
233
|
+
}
|
|
234
|
+
|
|
235
|
+
/**
|
|
236
|
+
* Tools a project's quality configuration CORROBORATES — never establishes.
|
|
237
|
+
*
|
|
238
|
+
* A threshold is not usage. `quality.e2eCoverage` defaults are synced into
|
|
239
|
+
* every project by `src/sync/registry.ts`, so this repository carries a
|
|
240
|
+
* `maestro` entry while having no `.maestro` directory and no script that
|
|
241
|
+
* invokes it. Treating that as evidence proposed pinning a 300MB JVM
|
|
242
|
+
* application into a container for a tool nothing runs.
|
|
243
|
+
*
|
|
244
|
+
* Evidence that a tool is CONFIGURED is not evidence that it is NEEDED — the
|
|
245
|
+
* same mistake as proposing a binary npm already provides. So a threshold only
|
|
246
|
+
* counts when something corroborates it: a script that invokes the tool, or the
|
|
247
|
+
* artifacts it consumes. In a real Expo project the script signal fires and
|
|
248
|
+
* this adds nothing; in a project that merely inherited the defaults, it
|
|
249
|
+
* correctly stays quiet.
|
|
203
250
|
* @param {object|null} config Parsed .lisa.config.json.
|
|
251
|
+
* @param {object|null} [pkg] Parsed package.json, for corroboration.
|
|
252
|
+
* @param {string} [cwd] Project root, for artifact corroboration.
|
|
204
253
|
* @returns {Map<string, string>} Tool name to the setting that implies it.
|
|
205
254
|
*/
|
|
206
|
-
export function toolsFromQuality(config) {
|
|
255
|
+
export function toolsFromQuality(config, pkg = null, cwd = process.cwd()) {
|
|
207
256
|
const found = new Map();
|
|
208
|
-
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
-
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
-
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
-
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
-
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
-
// while the gap is right there is worse than no gate.
|
|
214
257
|
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
-
if (Object.hasOwn(KNOWN_TOOLS, runner))
|
|
216
|
-
|
|
217
|
-
|
|
258
|
+
if (!Object.hasOwn(KNOWN_TOOLS, runner)) continue;
|
|
259
|
+
if (!usedByProject(runner, pkg, cwd)) continue;
|
|
260
|
+
found.set(
|
|
261
|
+
runner,
|
|
262
|
+
`quality.e2eCoverage.${runner} is configured, and the project uses it`
|
|
263
|
+
);
|
|
218
264
|
}
|
|
219
265
|
if (config?.quality?.sonar || config?.sonar) {
|
|
220
266
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -288,7 +334,7 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
288
334
|
toolsFromScripts(pkg),
|
|
289
335
|
toolsFromMcp(mcp),
|
|
290
336
|
toolsFromSecretNotes(notes),
|
|
291
|
-
toolsFromQuality(config),
|
|
337
|
+
toolsFromQuality(config, pkg, cwd),
|
|
292
338
|
];
|
|
293
339
|
|
|
294
340
|
const merged = new Map();
|