@codyswann/lisa 2.325.2 → 2.325.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/core/upstream-evidence-manifest.js +3 -3
- package/package.json +1 -1
- package/plugins/lisa/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa/.codex-plugin/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +38 -2
- package/plugins/lisa/.codex-plugin/skills/lisa-setup-remote-env/assets/setup.sh +15 -2
- package/plugins/lisa/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +38 -2
- package/plugins/lisa/skills/lisa-setup-remote-env/assets/setup.sh +15 -2
- package/plugins/lisa-agy/plugin.json +1 -1
- package/plugins/lisa-agy/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +38 -2
- package/plugins/lisa-agy/skills/lisa-setup-remote-env/assets/setup.sh +15 -2
- package/plugins/lisa-cdk/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-agy/plugin.json +1 -1
- package/plugins/lisa-cdk-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +38 -2
- package/plugins/lisa-copilot/skills/lisa-setup-remote-env/assets/setup.sh +15 -2
- package/plugins/lisa-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cursor/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +38 -2
- package/plugins/lisa-cursor/skills/lisa-setup-remote-env/assets/setup.sh +15 -2
- package/plugins/lisa-expo/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-agy/plugin.json +1 -1
- package/plugins/lisa-expo-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-agy/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-agy/plugin.json +1 -1
- package/plugins/lisa-nestjs-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-agy/plugin.json +1 -1
- package/plugins/lisa-openclaw-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-agy/plugin.json +1 -1
- package/plugins/lisa-phaser-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-agy/plugin.json +1 -1
- package/plugins/lisa-rails-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-agy/plugin.json +1 -1
- package/plugins/lisa-typescript-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-agy/plugin.json +1 -1
- package/plugins/lisa-wiki-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/src/base/skills/lisa-detect-tooling/scripts/detect-tooling.mjs +38 -2
- package/plugins/src/base/skills/lisa-setup-remote-env/assets/setup.sh +15 -2
- package/scripts/lisa-remote-env/setup.sh +15 -2
|
@@ -425,7 +425,7 @@ export const UPSTREAM_EVIDENCE_MANIFEST = Object.freeze({
|
|
|
425
425
|
"plugins/src/base/skills/lisa-debrief/SKILL.md": "47e4cda36b07994ff47ab15fb04a17dd6b0c310ad804f9cae9d69637edaaa72a",
|
|
426
426
|
"plugins/src/base/skills/lisa-delivery-effectiveness/SKILL.md": "21bc55fa0e86a9694bd22269fd089dbfae0c54c199262f46a4955447acea0f35",
|
|
427
427
|
"plugins/src/base/skills/lisa-detect-tooling/SKILL.md": "1778a009d06099b3bd2d9a33b37bec34836b295e21fad220ae926491d3557208",
|
|
428
|
-
"plugins/src/base/skills/lisa-detect-tooling/scripts/detect-tooling.mjs": "
|
|
428
|
+
"plugins/src/base/skills/lisa-detect-tooling/scripts/detect-tooling.mjs": "05e0c4808e64fbdc277419ad00b6a68da96766a9261a5b97f3a4961bbab107c4",
|
|
429
429
|
"plugins/src/base/skills/lisa-doctor/SKILL.md": "fb41a1e63c5332d47a46e715aff52551f3df867033b5e4f37dfaeee30019b891",
|
|
430
430
|
"plugins/src/base/skills/lisa-drive-pr-to-merge/SKILL.md": "c78ae2ba32c830d0b2cd7d24de91adf99e2b3cef4c7cab1c417580d86f41351f",
|
|
431
431
|
"plugins/src/base/skills/lisa-epic-triage/SKILL.md": "d02760411249bddbd396f283191fe3e82bb7b95bf9393a19a7025dc5a57c3ab7",
|
|
@@ -568,7 +568,7 @@ export const UPSTREAM_EVIDENCE_MANIFEST = Object.freeze({
|
|
|
568
568
|
"plugins/src/base/skills/lisa-setup-remote-aws/SKILL.md": "80fbf157f9c562c033886c25a99b37356602edd9e61cd2d492f339769ddcf97e",
|
|
569
569
|
"plugins/src/base/skills/lisa-setup-remote-env/SKILL.md": "77a537460aaa1a7f9da74128161d24fa3bf758ae1fec6f6dcbc47bde9f078750",
|
|
570
570
|
"plugins/src/base/skills/lisa-setup-remote-env/assets/session-start.sh": "cb63d08b14ab7aa2d405e6770e0cf7db5d6588ae1dcb924ea6224b026fcff496",
|
|
571
|
-
"plugins/src/base/skills/lisa-setup-remote-env/assets/setup.sh": "
|
|
571
|
+
"plugins/src/base/skills/lisa-setup-remote-env/assets/setup.sh": "c30d98a5645f033fc1d3a723043691b9ad997ae5666df539ff6aa19c563431b2",
|
|
572
572
|
"plugins/src/base/skills/lisa-setup-remote-env/scripts/setup-remote-env.mjs": "eb8017ee2eef5b5b166908e5c2fccf493af283b0a40717688033d65263cf35ce",
|
|
573
573
|
"plugins/src/base/skills/lisa-setup-remote-env/scripts/toolchain.mjs": "341e8058e1d20e7e52276007aae9ceda1504b995615cf8421c9494b60b550ef9",
|
|
574
574
|
"plugins/src/base/skills/lisa-setup-remote-env/scripts/verify-remote-env.mjs": "82bc2a27a0a5afb2ff413a88365c619fd7f0eaada5de3ccabf2000938f0607a4",
|
|
@@ -998,7 +998,7 @@ export const UPSTREAM_EVIDENCE_MANIFEST = Object.freeze({
|
|
|
998
998
|
"scripts/lisa-github-repo-setup.sh": "dc2f1c9d718aa34ba57161120d9319b5f78fe6b0b496d8e3c77226a08795aa36",
|
|
999
999
|
"scripts/lisa-github-rulesets.sh": "920a43ba268421b6fe55096062bd85850468bee9389f6006ad7c671010e7cccb",
|
|
1000
1000
|
"scripts/lisa-remote-env/session-start.sh": "cb63d08b14ab7aa2d405e6770e0cf7db5d6588ae1dcb924ea6224b026fcff496",
|
|
1001
|
-
"scripts/lisa-remote-env/setup.sh": "
|
|
1001
|
+
"scripts/lisa-remote-env/setup.sh": "c30d98a5645f033fc1d3a723043691b9ad997ae5666df539ff6aa19c563431b2",
|
|
1002
1002
|
"scripts/lisa-update-local.sh": "c811f9e10dbcb38499a9791c1ae9051460b347051d04a1d2046925bab9a53c96",
|
|
1003
1003
|
"scripts/lisa-work-item.mjs": "51081847e980f314a764c2e50a7a121b1ced9ef4b980f33898057de4c7b852e6",
|
|
1004
1004
|
"scripts/migrate-deploy-order.sh": "77d909b4cbbfc05169a79168d7868600ea7f56f846feefb7d5121618c54800c3",
|
package/package.json
CHANGED
|
@@ -115,7 +115,7 @@
|
|
|
115
115
|
"brace-expansion": ">=5.0.9"
|
|
116
116
|
},
|
|
117
117
|
"name": "@codyswann/lisa",
|
|
118
|
-
"version": "2.325.
|
|
118
|
+
"version": "2.325.4",
|
|
119
119
|
"description": "Claude Code governance framework that applies guardrails, guidance, and automated enforcement to projects",
|
|
120
120
|
"main": "dist/index.js",
|
|
121
121
|
"exports": {
|
|
@@ -205,8 +205,16 @@ export function toolsFromSecretNotes(notes) {
|
|
|
205
205
|
*/
|
|
206
206
|
export function toolsFromQuality(config) {
|
|
207
207
|
const found = new Map();
|
|
208
|
-
|
|
209
|
-
|
|
208
|
+
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
+
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
+
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
+
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
+
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
+
// while the gap is right there is worse than no gate.
|
|
214
|
+
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
+
if (Object.hasOwn(KNOWN_TOOLS, runner)) {
|
|
216
|
+
found.set(runner, `quality.e2eCoverage.${runner} is configured`);
|
|
217
|
+
}
|
|
210
218
|
}
|
|
211
219
|
if (config?.quality?.sonar || config?.sonar) {
|
|
212
220
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -238,6 +246,32 @@ export function declaredTools(config, surface = "remote") {
|
|
|
238
246
|
);
|
|
239
247
|
}
|
|
240
248
|
|
|
249
|
+
/**
|
|
250
|
+
* Whether a tool already reaches this project as an npm dependency.
|
|
251
|
+
*
|
|
252
|
+
* A package that declares `@playwright/test` gets the `playwright` binary in
|
|
253
|
+
* `node_modules/.bin`, and its npm scripts resolve it from there. It never
|
|
254
|
+
* needs to be on PATH, so proposing a manifest entry for it is noise — and
|
|
255
|
+
* noise is how a detector teaches people to skim it, which is the one failure
|
|
256
|
+
* this skill's own documentation warns about.
|
|
257
|
+
*
|
|
258
|
+
* Only the CLI is covered by this. Anything else the tool needs at runtime —
|
|
259
|
+
* Playwright's browsers, for instance — is a separate concern that a package
|
|
260
|
+
* manager does not solve and this function does not claim to.
|
|
261
|
+
* @param {object|null} pkg Parsed package.json.
|
|
262
|
+
* @param {string} tool Tool name.
|
|
263
|
+
* @returns {boolean} Whether npm already provides the binary.
|
|
264
|
+
*/
|
|
265
|
+
export function satisfiedByNpm(pkg, tool) {
|
|
266
|
+
const viaNpm = KNOWN_TOOLS[tool]?.viaNpm;
|
|
267
|
+
if (!viaNpm) return false;
|
|
268
|
+
const declared = {
|
|
269
|
+
...(pkg?.dependencies ?? {}),
|
|
270
|
+
...(pkg?.devDependencies ?? {}),
|
|
271
|
+
};
|
|
272
|
+
return Object.hasOwn(declared, viaNpm);
|
|
273
|
+
}
|
|
274
|
+
|
|
241
275
|
/**
|
|
242
276
|
* Collect every signal and subtract what the manifest already covers.
|
|
243
277
|
* @param {string} [cwd] Project root.
|
|
@@ -261,6 +295,8 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
261
295
|
for (const signal of signals) {
|
|
262
296
|
for (const [tool, evidence] of signal) {
|
|
263
297
|
if (declared.has(tool)) continue;
|
|
298
|
+
// Already provided by the package manager, so there is nothing to pin.
|
|
299
|
+
if (satisfiedByNpm(pkg, tool)) continue;
|
|
264
300
|
const entry = merged.get(tool) ?? { evidence: [] };
|
|
265
301
|
entry.evidence.push(evidence);
|
|
266
302
|
merged.set(tool, entry);
|
|
@@ -49,7 +49,7 @@ fi
|
|
|
49
49
|
#
|
|
50
50
|
# Skipped when node_modules already exists, which is what makes this cheap on a
|
|
51
51
|
# resumed container and correct to run twice.
|
|
52
|
-
if [
|
|
52
|
+
if [ ! -d node_modules ]; then
|
|
53
53
|
if [ -f bun.lock ] || [ -f bun.lockb ]; then install_cmd="bun install"
|
|
54
54
|
elif [ -f pnpm-lock.yaml ]; then install_cmd="pnpm install --frozen-lockfile"
|
|
55
55
|
elif [ -f yarn.lock ]; then
|
|
@@ -83,7 +83,20 @@ if [ "${LISA_SKIP_INSTALL:-}" != "1" ] && [ ! -d node_modules ]; then
|
|
|
83
83
|
# Without it the bug is cache-dependent, not deterministic: a fresh
|
|
84
84
|
# container installs and dirties the tree, a resumed one skips the install
|
|
85
85
|
# and succeeds. That reads as flakiness rather than a cause.
|
|
86
|
-
|
|
86
|
+
# LISA_SKIP_INSTALL suppresses the INSTALL, not the decision. It used to
|
|
87
|
+
# gate the whole block, so the only way to observe which package manager
|
|
88
|
+
# was chosen was to actually run it — which is why a test asserting the
|
|
89
|
+
# choice ran `yarn install` against a fabricated lockfile, passing on a
|
|
90
|
+
# machine without yarn and doing a real network install on one with it.
|
|
91
|
+
#
|
|
92
|
+
# Reporting the choice and skipping the work is also the more useful
|
|
93
|
+
# behaviour for a caller that installed already: it still says what it
|
|
94
|
+
# would have done.
|
|
95
|
+
if [ "${LISA_SKIP_INSTALL:-}" = "1" ]; then
|
|
96
|
+
echo " LISA_SKIP_INSTALL=1 — not running it."
|
|
97
|
+
else
|
|
98
|
+
CI=1 $install_cmd
|
|
99
|
+
fi
|
|
87
100
|
else
|
|
88
101
|
# Not fatal on its own. A project may carry no lockfile and still have the
|
|
89
102
|
# skill in a checkout directory, so let the resolver below decide.
|
|
@@ -205,8 +205,16 @@ export function toolsFromSecretNotes(notes) {
|
|
|
205
205
|
*/
|
|
206
206
|
export function toolsFromQuality(config) {
|
|
207
207
|
const found = new Map();
|
|
208
|
-
|
|
209
|
-
|
|
208
|
+
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
+
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
+
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
+
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
+
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
+
// while the gap is right there is worse than no gate.
|
|
214
|
+
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
+
if (Object.hasOwn(KNOWN_TOOLS, runner)) {
|
|
216
|
+
found.set(runner, `quality.e2eCoverage.${runner} is configured`);
|
|
217
|
+
}
|
|
210
218
|
}
|
|
211
219
|
if (config?.quality?.sonar || config?.sonar) {
|
|
212
220
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -238,6 +246,32 @@ export function declaredTools(config, surface = "remote") {
|
|
|
238
246
|
);
|
|
239
247
|
}
|
|
240
248
|
|
|
249
|
+
/**
|
|
250
|
+
* Whether a tool already reaches this project as an npm dependency.
|
|
251
|
+
*
|
|
252
|
+
* A package that declares `@playwright/test` gets the `playwright` binary in
|
|
253
|
+
* `node_modules/.bin`, and its npm scripts resolve it from there. It never
|
|
254
|
+
* needs to be on PATH, so proposing a manifest entry for it is noise — and
|
|
255
|
+
* noise is how a detector teaches people to skim it, which is the one failure
|
|
256
|
+
* this skill's own documentation warns about.
|
|
257
|
+
*
|
|
258
|
+
* Only the CLI is covered by this. Anything else the tool needs at runtime —
|
|
259
|
+
* Playwright's browsers, for instance — is a separate concern that a package
|
|
260
|
+
* manager does not solve and this function does not claim to.
|
|
261
|
+
* @param {object|null} pkg Parsed package.json.
|
|
262
|
+
* @param {string} tool Tool name.
|
|
263
|
+
* @returns {boolean} Whether npm already provides the binary.
|
|
264
|
+
*/
|
|
265
|
+
export function satisfiedByNpm(pkg, tool) {
|
|
266
|
+
const viaNpm = KNOWN_TOOLS[tool]?.viaNpm;
|
|
267
|
+
if (!viaNpm) return false;
|
|
268
|
+
const declared = {
|
|
269
|
+
...(pkg?.dependencies ?? {}),
|
|
270
|
+
...(pkg?.devDependencies ?? {}),
|
|
271
|
+
};
|
|
272
|
+
return Object.hasOwn(declared, viaNpm);
|
|
273
|
+
}
|
|
274
|
+
|
|
241
275
|
/**
|
|
242
276
|
* Collect every signal and subtract what the manifest already covers.
|
|
243
277
|
* @param {string} [cwd] Project root.
|
|
@@ -261,6 +295,8 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
261
295
|
for (const signal of signals) {
|
|
262
296
|
for (const [tool, evidence] of signal) {
|
|
263
297
|
if (declared.has(tool)) continue;
|
|
298
|
+
// Already provided by the package manager, so there is nothing to pin.
|
|
299
|
+
if (satisfiedByNpm(pkg, tool)) continue;
|
|
264
300
|
const entry = merged.get(tool) ?? { evidence: [] };
|
|
265
301
|
entry.evidence.push(evidence);
|
|
266
302
|
merged.set(tool, entry);
|
|
@@ -49,7 +49,7 @@ fi
|
|
|
49
49
|
#
|
|
50
50
|
# Skipped when node_modules already exists, which is what makes this cheap on a
|
|
51
51
|
# resumed container and correct to run twice.
|
|
52
|
-
if [
|
|
52
|
+
if [ ! -d node_modules ]; then
|
|
53
53
|
if [ -f bun.lock ] || [ -f bun.lockb ]; then install_cmd="bun install"
|
|
54
54
|
elif [ -f pnpm-lock.yaml ]; then install_cmd="pnpm install --frozen-lockfile"
|
|
55
55
|
elif [ -f yarn.lock ]; then
|
|
@@ -83,7 +83,20 @@ if [ "${LISA_SKIP_INSTALL:-}" != "1" ] && [ ! -d node_modules ]; then
|
|
|
83
83
|
# Without it the bug is cache-dependent, not deterministic: a fresh
|
|
84
84
|
# container installs and dirties the tree, a resumed one skips the install
|
|
85
85
|
# and succeeds. That reads as flakiness rather than a cause.
|
|
86
|
-
|
|
86
|
+
# LISA_SKIP_INSTALL suppresses the INSTALL, not the decision. It used to
|
|
87
|
+
# gate the whole block, so the only way to observe which package manager
|
|
88
|
+
# was chosen was to actually run it — which is why a test asserting the
|
|
89
|
+
# choice ran `yarn install` against a fabricated lockfile, passing on a
|
|
90
|
+
# machine without yarn and doing a real network install on one with it.
|
|
91
|
+
#
|
|
92
|
+
# Reporting the choice and skipping the work is also the more useful
|
|
93
|
+
# behaviour for a caller that installed already: it still says what it
|
|
94
|
+
# would have done.
|
|
95
|
+
if [ "${LISA_SKIP_INSTALL:-}" = "1" ]; then
|
|
96
|
+
echo " LISA_SKIP_INSTALL=1 — not running it."
|
|
97
|
+
else
|
|
98
|
+
CI=1 $install_cmd
|
|
99
|
+
fi
|
|
87
100
|
else
|
|
88
101
|
# Not fatal on its own. A project may carry no lockfile and still have the
|
|
89
102
|
# skill in a checkout directory, so let the resolver below decide.
|
|
@@ -205,8 +205,16 @@ export function toolsFromSecretNotes(notes) {
|
|
|
205
205
|
*/
|
|
206
206
|
export function toolsFromQuality(config) {
|
|
207
207
|
const found = new Map();
|
|
208
|
-
|
|
209
|
-
|
|
208
|
+
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
+
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
+
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
+
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
+
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
+
// while the gap is right there is worse than no gate.
|
|
214
|
+
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
+
if (Object.hasOwn(KNOWN_TOOLS, runner)) {
|
|
216
|
+
found.set(runner, `quality.e2eCoverage.${runner} is configured`);
|
|
217
|
+
}
|
|
210
218
|
}
|
|
211
219
|
if (config?.quality?.sonar || config?.sonar) {
|
|
212
220
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -238,6 +246,32 @@ export function declaredTools(config, surface = "remote") {
|
|
|
238
246
|
);
|
|
239
247
|
}
|
|
240
248
|
|
|
249
|
+
/**
|
|
250
|
+
* Whether a tool already reaches this project as an npm dependency.
|
|
251
|
+
*
|
|
252
|
+
* A package that declares `@playwright/test` gets the `playwright` binary in
|
|
253
|
+
* `node_modules/.bin`, and its npm scripts resolve it from there. It never
|
|
254
|
+
* needs to be on PATH, so proposing a manifest entry for it is noise — and
|
|
255
|
+
* noise is how a detector teaches people to skim it, which is the one failure
|
|
256
|
+
* this skill's own documentation warns about.
|
|
257
|
+
*
|
|
258
|
+
* Only the CLI is covered by this. Anything else the tool needs at runtime —
|
|
259
|
+
* Playwright's browsers, for instance — is a separate concern that a package
|
|
260
|
+
* manager does not solve and this function does not claim to.
|
|
261
|
+
* @param {object|null} pkg Parsed package.json.
|
|
262
|
+
* @param {string} tool Tool name.
|
|
263
|
+
* @returns {boolean} Whether npm already provides the binary.
|
|
264
|
+
*/
|
|
265
|
+
export function satisfiedByNpm(pkg, tool) {
|
|
266
|
+
const viaNpm = KNOWN_TOOLS[tool]?.viaNpm;
|
|
267
|
+
if (!viaNpm) return false;
|
|
268
|
+
const declared = {
|
|
269
|
+
...(pkg?.dependencies ?? {}),
|
|
270
|
+
...(pkg?.devDependencies ?? {}),
|
|
271
|
+
};
|
|
272
|
+
return Object.hasOwn(declared, viaNpm);
|
|
273
|
+
}
|
|
274
|
+
|
|
241
275
|
/**
|
|
242
276
|
* Collect every signal and subtract what the manifest already covers.
|
|
243
277
|
* @param {string} [cwd] Project root.
|
|
@@ -261,6 +295,8 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
261
295
|
for (const signal of signals) {
|
|
262
296
|
for (const [tool, evidence] of signal) {
|
|
263
297
|
if (declared.has(tool)) continue;
|
|
298
|
+
// Already provided by the package manager, so there is nothing to pin.
|
|
299
|
+
if (satisfiedByNpm(pkg, tool)) continue;
|
|
264
300
|
const entry = merged.get(tool) ?? { evidence: [] };
|
|
265
301
|
entry.evidence.push(evidence);
|
|
266
302
|
merged.set(tool, entry);
|
|
@@ -49,7 +49,7 @@ fi
|
|
|
49
49
|
#
|
|
50
50
|
# Skipped when node_modules already exists, which is what makes this cheap on a
|
|
51
51
|
# resumed container and correct to run twice.
|
|
52
|
-
if [
|
|
52
|
+
if [ ! -d node_modules ]; then
|
|
53
53
|
if [ -f bun.lock ] || [ -f bun.lockb ]; then install_cmd="bun install"
|
|
54
54
|
elif [ -f pnpm-lock.yaml ]; then install_cmd="pnpm install --frozen-lockfile"
|
|
55
55
|
elif [ -f yarn.lock ]; then
|
|
@@ -83,7 +83,20 @@ if [ "${LISA_SKIP_INSTALL:-}" != "1" ] && [ ! -d node_modules ]; then
|
|
|
83
83
|
# Without it the bug is cache-dependent, not deterministic: a fresh
|
|
84
84
|
# container installs and dirties the tree, a resumed one skips the install
|
|
85
85
|
# and succeeds. That reads as flakiness rather than a cause.
|
|
86
|
-
|
|
86
|
+
# LISA_SKIP_INSTALL suppresses the INSTALL, not the decision. It used to
|
|
87
|
+
# gate the whole block, so the only way to observe which package manager
|
|
88
|
+
# was chosen was to actually run it — which is why a test asserting the
|
|
89
|
+
# choice ran `yarn install` against a fabricated lockfile, passing on a
|
|
90
|
+
# machine without yarn and doing a real network install on one with it.
|
|
91
|
+
#
|
|
92
|
+
# Reporting the choice and skipping the work is also the more useful
|
|
93
|
+
# behaviour for a caller that installed already: it still says what it
|
|
94
|
+
# would have done.
|
|
95
|
+
if [ "${LISA_SKIP_INSTALL:-}" = "1" ]; then
|
|
96
|
+
echo " LISA_SKIP_INSTALL=1 — not running it."
|
|
97
|
+
else
|
|
98
|
+
CI=1 $install_cmd
|
|
99
|
+
fi
|
|
87
100
|
else
|
|
88
101
|
# Not fatal on its own. A project may carry no lockfile and still have the
|
|
89
102
|
# skill in a checkout directory, so let the resolver below decide.
|
|
@@ -205,8 +205,16 @@ export function toolsFromSecretNotes(notes) {
|
|
|
205
205
|
*/
|
|
206
206
|
export function toolsFromQuality(config) {
|
|
207
207
|
const found = new Map();
|
|
208
|
-
|
|
209
|
-
|
|
208
|
+
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
+
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
+
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
+
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
+
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
+
// while the gap is right there is worse than no gate.
|
|
214
|
+
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
+
if (Object.hasOwn(KNOWN_TOOLS, runner)) {
|
|
216
|
+
found.set(runner, `quality.e2eCoverage.${runner} is configured`);
|
|
217
|
+
}
|
|
210
218
|
}
|
|
211
219
|
if (config?.quality?.sonar || config?.sonar) {
|
|
212
220
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -238,6 +246,32 @@ export function declaredTools(config, surface = "remote") {
|
|
|
238
246
|
);
|
|
239
247
|
}
|
|
240
248
|
|
|
249
|
+
/**
|
|
250
|
+
* Whether a tool already reaches this project as an npm dependency.
|
|
251
|
+
*
|
|
252
|
+
* A package that declares `@playwright/test` gets the `playwright` binary in
|
|
253
|
+
* `node_modules/.bin`, and its npm scripts resolve it from there. It never
|
|
254
|
+
* needs to be on PATH, so proposing a manifest entry for it is noise — and
|
|
255
|
+
* noise is how a detector teaches people to skim it, which is the one failure
|
|
256
|
+
* this skill's own documentation warns about.
|
|
257
|
+
*
|
|
258
|
+
* Only the CLI is covered by this. Anything else the tool needs at runtime —
|
|
259
|
+
* Playwright's browsers, for instance — is a separate concern that a package
|
|
260
|
+
* manager does not solve and this function does not claim to.
|
|
261
|
+
* @param {object|null} pkg Parsed package.json.
|
|
262
|
+
* @param {string} tool Tool name.
|
|
263
|
+
* @returns {boolean} Whether npm already provides the binary.
|
|
264
|
+
*/
|
|
265
|
+
export function satisfiedByNpm(pkg, tool) {
|
|
266
|
+
const viaNpm = KNOWN_TOOLS[tool]?.viaNpm;
|
|
267
|
+
if (!viaNpm) return false;
|
|
268
|
+
const declared = {
|
|
269
|
+
...(pkg?.dependencies ?? {}),
|
|
270
|
+
...(pkg?.devDependencies ?? {}),
|
|
271
|
+
};
|
|
272
|
+
return Object.hasOwn(declared, viaNpm);
|
|
273
|
+
}
|
|
274
|
+
|
|
241
275
|
/**
|
|
242
276
|
* Collect every signal and subtract what the manifest already covers.
|
|
243
277
|
* @param {string} [cwd] Project root.
|
|
@@ -261,6 +295,8 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
261
295
|
for (const signal of signals) {
|
|
262
296
|
for (const [tool, evidence] of signal) {
|
|
263
297
|
if (declared.has(tool)) continue;
|
|
298
|
+
// Already provided by the package manager, so there is nothing to pin.
|
|
299
|
+
if (satisfiedByNpm(pkg, tool)) continue;
|
|
264
300
|
const entry = merged.get(tool) ?? { evidence: [] };
|
|
265
301
|
entry.evidence.push(evidence);
|
|
266
302
|
merged.set(tool, entry);
|
|
@@ -49,7 +49,7 @@ fi
|
|
|
49
49
|
#
|
|
50
50
|
# Skipped when node_modules already exists, which is what makes this cheap on a
|
|
51
51
|
# resumed container and correct to run twice.
|
|
52
|
-
if [
|
|
52
|
+
if [ ! -d node_modules ]; then
|
|
53
53
|
if [ -f bun.lock ] || [ -f bun.lockb ]; then install_cmd="bun install"
|
|
54
54
|
elif [ -f pnpm-lock.yaml ]; then install_cmd="pnpm install --frozen-lockfile"
|
|
55
55
|
elif [ -f yarn.lock ]; then
|
|
@@ -83,7 +83,20 @@ if [ "${LISA_SKIP_INSTALL:-}" != "1" ] && [ ! -d node_modules ]; then
|
|
|
83
83
|
# Without it the bug is cache-dependent, not deterministic: a fresh
|
|
84
84
|
# container installs and dirties the tree, a resumed one skips the install
|
|
85
85
|
# and succeeds. That reads as flakiness rather than a cause.
|
|
86
|
-
|
|
86
|
+
# LISA_SKIP_INSTALL suppresses the INSTALL, not the decision. It used to
|
|
87
|
+
# gate the whole block, so the only way to observe which package manager
|
|
88
|
+
# was chosen was to actually run it — which is why a test asserting the
|
|
89
|
+
# choice ran `yarn install` against a fabricated lockfile, passing on a
|
|
90
|
+
# machine without yarn and doing a real network install on one with it.
|
|
91
|
+
#
|
|
92
|
+
# Reporting the choice and skipping the work is also the more useful
|
|
93
|
+
# behaviour for a caller that installed already: it still says what it
|
|
94
|
+
# would have done.
|
|
95
|
+
if [ "${LISA_SKIP_INSTALL:-}" = "1" ]; then
|
|
96
|
+
echo " LISA_SKIP_INSTALL=1 — not running it."
|
|
97
|
+
else
|
|
98
|
+
CI=1 $install_cmd
|
|
99
|
+
fi
|
|
87
100
|
else
|
|
88
101
|
# Not fatal on its own. A project may carry no lockfile and still have the
|
|
89
102
|
# skill in a checkout directory, so let the resolver below decide.
|
|
@@ -205,8 +205,16 @@ export function toolsFromSecretNotes(notes) {
|
|
|
205
205
|
*/
|
|
206
206
|
export function toolsFromQuality(config) {
|
|
207
207
|
const found = new Map();
|
|
208
|
-
|
|
209
|
-
|
|
208
|
+
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
+
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
+
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
+
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
+
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
+
// while the gap is right there is worse than no gate.
|
|
214
|
+
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
+
if (Object.hasOwn(KNOWN_TOOLS, runner)) {
|
|
216
|
+
found.set(runner, `quality.e2eCoverage.${runner} is configured`);
|
|
217
|
+
}
|
|
210
218
|
}
|
|
211
219
|
if (config?.quality?.sonar || config?.sonar) {
|
|
212
220
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -238,6 +246,32 @@ export function declaredTools(config, surface = "remote") {
|
|
|
238
246
|
);
|
|
239
247
|
}
|
|
240
248
|
|
|
249
|
+
/**
|
|
250
|
+
* Whether a tool already reaches this project as an npm dependency.
|
|
251
|
+
*
|
|
252
|
+
* A package that declares `@playwright/test` gets the `playwright` binary in
|
|
253
|
+
* `node_modules/.bin`, and its npm scripts resolve it from there. It never
|
|
254
|
+
* needs to be on PATH, so proposing a manifest entry for it is noise — and
|
|
255
|
+
* noise is how a detector teaches people to skim it, which is the one failure
|
|
256
|
+
* this skill's own documentation warns about.
|
|
257
|
+
*
|
|
258
|
+
* Only the CLI is covered by this. Anything else the tool needs at runtime —
|
|
259
|
+
* Playwright's browsers, for instance — is a separate concern that a package
|
|
260
|
+
* manager does not solve and this function does not claim to.
|
|
261
|
+
* @param {object|null} pkg Parsed package.json.
|
|
262
|
+
* @param {string} tool Tool name.
|
|
263
|
+
* @returns {boolean} Whether npm already provides the binary.
|
|
264
|
+
*/
|
|
265
|
+
export function satisfiedByNpm(pkg, tool) {
|
|
266
|
+
const viaNpm = KNOWN_TOOLS[tool]?.viaNpm;
|
|
267
|
+
if (!viaNpm) return false;
|
|
268
|
+
const declared = {
|
|
269
|
+
...(pkg?.dependencies ?? {}),
|
|
270
|
+
...(pkg?.devDependencies ?? {}),
|
|
271
|
+
};
|
|
272
|
+
return Object.hasOwn(declared, viaNpm);
|
|
273
|
+
}
|
|
274
|
+
|
|
241
275
|
/**
|
|
242
276
|
* Collect every signal and subtract what the manifest already covers.
|
|
243
277
|
* @param {string} [cwd] Project root.
|
|
@@ -261,6 +295,8 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
261
295
|
for (const signal of signals) {
|
|
262
296
|
for (const [tool, evidence] of signal) {
|
|
263
297
|
if (declared.has(tool)) continue;
|
|
298
|
+
// Already provided by the package manager, so there is nothing to pin.
|
|
299
|
+
if (satisfiedByNpm(pkg, tool)) continue;
|
|
264
300
|
const entry = merged.get(tool) ?? { evidence: [] };
|
|
265
301
|
entry.evidence.push(evidence);
|
|
266
302
|
merged.set(tool, entry);
|
|
@@ -49,7 +49,7 @@ fi
|
|
|
49
49
|
#
|
|
50
50
|
# Skipped when node_modules already exists, which is what makes this cheap on a
|
|
51
51
|
# resumed container and correct to run twice.
|
|
52
|
-
if [
|
|
52
|
+
if [ ! -d node_modules ]; then
|
|
53
53
|
if [ -f bun.lock ] || [ -f bun.lockb ]; then install_cmd="bun install"
|
|
54
54
|
elif [ -f pnpm-lock.yaml ]; then install_cmd="pnpm install --frozen-lockfile"
|
|
55
55
|
elif [ -f yarn.lock ]; then
|
|
@@ -83,7 +83,20 @@ if [ "${LISA_SKIP_INSTALL:-}" != "1" ] && [ ! -d node_modules ]; then
|
|
|
83
83
|
# Without it the bug is cache-dependent, not deterministic: a fresh
|
|
84
84
|
# container installs and dirties the tree, a resumed one skips the install
|
|
85
85
|
# and succeeds. That reads as flakiness rather than a cause.
|
|
86
|
-
|
|
86
|
+
# LISA_SKIP_INSTALL suppresses the INSTALL, not the decision. It used to
|
|
87
|
+
# gate the whole block, so the only way to observe which package manager
|
|
88
|
+
# was chosen was to actually run it — which is why a test asserting the
|
|
89
|
+
# choice ran `yarn install` against a fabricated lockfile, passing on a
|
|
90
|
+
# machine without yarn and doing a real network install on one with it.
|
|
91
|
+
#
|
|
92
|
+
# Reporting the choice and skipping the work is also the more useful
|
|
93
|
+
# behaviour for a caller that installed already: it still says what it
|
|
94
|
+
# would have done.
|
|
95
|
+
if [ "${LISA_SKIP_INSTALL:-}" = "1" ]; then
|
|
96
|
+
echo " LISA_SKIP_INSTALL=1 — not running it."
|
|
97
|
+
else
|
|
98
|
+
CI=1 $install_cmd
|
|
99
|
+
fi
|
|
87
100
|
else
|
|
88
101
|
# Not fatal on its own. A project may carry no lockfile and still have the
|
|
89
102
|
# skill in a checkout directory, so let the resolver below decide.
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "2.325.
|
|
3
|
+
"version": "2.325.4",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "2.325.
|
|
3
|
+
"version": "2.325.4",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, across Claude and Codex.",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "2.325.
|
|
3
|
+
"version": "2.325.4",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "2.325.
|
|
3
|
+
"version": "2.325.4",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "lisa-openclaw",
|
|
3
|
-
"version": "2.325.
|
|
3
|
+
"version": "2.325.4",
|
|
4
4
|
"description": "Connect staff roles to Telegram or Slack via OpenClaw — facilitator/specialist hub-and-spoke routing and repo-coding topics, for Claude Code and Codex",
|
|
5
5
|
"author": {
|
|
6
6
|
"name": "Cody Swann"
|
|
@@ -205,8 +205,16 @@ export function toolsFromSecretNotes(notes) {
|
|
|
205
205
|
*/
|
|
206
206
|
export function toolsFromQuality(config) {
|
|
207
207
|
const found = new Map();
|
|
208
|
-
|
|
209
|
-
|
|
208
|
+
// Every runner under e2eCoverage, not a hardcoded one. Naming `playwright`
|
|
209
|
+
// explicitly meant `quality.e2eCoverage.maestro` — configured in this very
|
|
210
|
+
// repository — produced no signal at all, so the one tool that genuinely
|
|
211
|
+
// needs a pinned binary and genuinely was not declared stayed invisible to
|
|
212
|
+
// the detector built to find it. A gate that reports "nothing outstanding"
|
|
213
|
+
// while the gap is right there is worse than no gate.
|
|
214
|
+
for (const runner of Object.keys(config?.quality?.e2eCoverage ?? {})) {
|
|
215
|
+
if (Object.hasOwn(KNOWN_TOOLS, runner)) {
|
|
216
|
+
found.set(runner, `quality.e2eCoverage.${runner} is configured`);
|
|
217
|
+
}
|
|
210
218
|
}
|
|
211
219
|
if (config?.quality?.sonar || config?.sonar) {
|
|
212
220
|
found.set("sonar-scanner", "Sonar analysis is configured");
|
|
@@ -238,6 +246,32 @@ export function declaredTools(config, surface = "remote") {
|
|
|
238
246
|
);
|
|
239
247
|
}
|
|
240
248
|
|
|
249
|
+
/**
|
|
250
|
+
* Whether a tool already reaches this project as an npm dependency.
|
|
251
|
+
*
|
|
252
|
+
* A package that declares `@playwright/test` gets the `playwright` binary in
|
|
253
|
+
* `node_modules/.bin`, and its npm scripts resolve it from there. It never
|
|
254
|
+
* needs to be on PATH, so proposing a manifest entry for it is noise — and
|
|
255
|
+
* noise is how a detector teaches people to skim it, which is the one failure
|
|
256
|
+
* this skill's own documentation warns about.
|
|
257
|
+
*
|
|
258
|
+
* Only the CLI is covered by this. Anything else the tool needs at runtime —
|
|
259
|
+
* Playwright's browsers, for instance — is a separate concern that a package
|
|
260
|
+
* manager does not solve and this function does not claim to.
|
|
261
|
+
* @param {object|null} pkg Parsed package.json.
|
|
262
|
+
* @param {string} tool Tool name.
|
|
263
|
+
* @returns {boolean} Whether npm already provides the binary.
|
|
264
|
+
*/
|
|
265
|
+
export function satisfiedByNpm(pkg, tool) {
|
|
266
|
+
const viaNpm = KNOWN_TOOLS[tool]?.viaNpm;
|
|
267
|
+
if (!viaNpm) return false;
|
|
268
|
+
const declared = {
|
|
269
|
+
...(pkg?.dependencies ?? {}),
|
|
270
|
+
...(pkg?.devDependencies ?? {}),
|
|
271
|
+
};
|
|
272
|
+
return Object.hasOwn(declared, viaNpm);
|
|
273
|
+
}
|
|
274
|
+
|
|
241
275
|
/**
|
|
242
276
|
* Collect every signal and subtract what the manifest already covers.
|
|
243
277
|
* @param {string} [cwd] Project root.
|
|
@@ -261,6 +295,8 @@ export function detectTooling(cwd = process.cwd()) {
|
|
|
261
295
|
for (const signal of signals) {
|
|
262
296
|
for (const [tool, evidence] of signal) {
|
|
263
297
|
if (declared.has(tool)) continue;
|
|
298
|
+
// Already provided by the package manager, so there is nothing to pin.
|
|
299
|
+
if (satisfiedByNpm(pkg, tool)) continue;
|
|
264
300
|
const entry = merged.get(tool) ?? { evidence: [] };
|
|
265
301
|
entry.evidence.push(evidence);
|
|
266
302
|
merged.set(tool, entry);
|
|
@@ -49,7 +49,7 @@ fi
|
|
|
49
49
|
#
|
|
50
50
|
# Skipped when node_modules already exists, which is what makes this cheap on a
|
|
51
51
|
# resumed container and correct to run twice.
|
|
52
|
-
if [
|
|
52
|
+
if [ ! -d node_modules ]; then
|
|
53
53
|
if [ -f bun.lock ] || [ -f bun.lockb ]; then install_cmd="bun install"
|
|
54
54
|
elif [ -f pnpm-lock.yaml ]; then install_cmd="pnpm install --frozen-lockfile"
|
|
55
55
|
elif [ -f yarn.lock ]; then
|
|
@@ -83,7 +83,20 @@ if [ "${LISA_SKIP_INSTALL:-}" != "1" ] && [ ! -d node_modules ]; then
|
|
|
83
83
|
# Without it the bug is cache-dependent, not deterministic: a fresh
|
|
84
84
|
# container installs and dirties the tree, a resumed one skips the install
|
|
85
85
|
# and succeeds. That reads as flakiness rather than a cause.
|
|
86
|
-
|
|
86
|
+
# LISA_SKIP_INSTALL suppresses the INSTALL, not the decision. It used to
|
|
87
|
+
# gate the whole block, so the only way to observe which package manager
|
|
88
|
+
# was chosen was to actually run it — which is why a test asserting the
|
|
89
|
+
# choice ran `yarn install` against a fabricated lockfile, passing on a
|
|
90
|
+
# machine without yarn and doing a real network install on one with it.
|
|
91
|
+
#
|
|
92
|
+
# Reporting the choice and skipping the work is also the more useful
|
|
93
|
+
# behaviour for a caller that installed already: it still says what it
|
|
94
|
+
# would have done.
|
|
95
|
+
if [ "${LISA_SKIP_INSTALL:-}" = "1" ]; then
|
|
96
|
+
echo " LISA_SKIP_INSTALL=1 — not running it."
|
|
97
|
+
else
|
|
98
|
+
CI=1 $install_cmd
|
|
99
|
+
fi
|
|
87
100
|
else
|
|
88
101
|
# Not fatal on its own. A project may carry no lockfile and still have the
|
|
89
102
|
# skill in a checkout directory, so let the resolver below decide.
|
|
@@ -49,7 +49,7 @@ fi
|
|
|
49
49
|
#
|
|
50
50
|
# Skipped when node_modules already exists, which is what makes this cheap on a
|
|
51
51
|
# resumed container and correct to run twice.
|
|
52
|
-
if [
|
|
52
|
+
if [ ! -d node_modules ]; then
|
|
53
53
|
if [ -f bun.lock ] || [ -f bun.lockb ]; then install_cmd="bun install"
|
|
54
54
|
elif [ -f pnpm-lock.yaml ]; then install_cmd="pnpm install --frozen-lockfile"
|
|
55
55
|
elif [ -f yarn.lock ]; then
|
|
@@ -83,7 +83,20 @@ if [ "${LISA_SKIP_INSTALL:-}" != "1" ] && [ ! -d node_modules ]; then
|
|
|
83
83
|
# Without it the bug is cache-dependent, not deterministic: a fresh
|
|
84
84
|
# container installs and dirties the tree, a resumed one skips the install
|
|
85
85
|
# and succeeds. That reads as flakiness rather than a cause.
|
|
86
|
-
|
|
86
|
+
# LISA_SKIP_INSTALL suppresses the INSTALL, not the decision. It used to
|
|
87
|
+
# gate the whole block, so the only way to observe which package manager
|
|
88
|
+
# was chosen was to actually run it — which is why a test asserting the
|
|
89
|
+
# choice ran `yarn install` against a fabricated lockfile, passing on a
|
|
90
|
+
# machine without yarn and doing a real network install on one with it.
|
|
91
|
+
#
|
|
92
|
+
# Reporting the choice and skipping the work is also the more useful
|
|
93
|
+
# behaviour for a caller that installed already: it still says what it
|
|
94
|
+
# would have done.
|
|
95
|
+
if [ "${LISA_SKIP_INSTALL:-}" = "1" ]; then
|
|
96
|
+
echo " LISA_SKIP_INSTALL=1 — not running it."
|
|
97
|
+
else
|
|
98
|
+
CI=1 $install_cmd
|
|
99
|
+
fi
|
|
87
100
|
else
|
|
88
101
|
# Not fatal on its own. A project may carry no lockfile and still have the
|
|
89
102
|
# skill in a checkout directory, so let the resolver below decide.
|