@codyswann/lisa 2.322.8 → 2.323.1

package/all/copy-overwrite/scripts/lisa-work-item.mjs

@@ -15,6 +15,7 @@ import {
   writeFileSync,
 } from "node:fs";
 import { dirname, join, resolve } from "node:path";
+import { pathToFileURL } from "node:url";
 
 const RELEASE_SUBJECT =
   /^chore\(release\): \d+\.\d+\.\d+(?:-[0-9A-Za-z.-]+)? \[skip ci\]$/;
@@ -27,6 +28,46 @@ const GUIDANCE = [
 
 class TrackingError extends Error {}
 
+/**
+ * Say which of three different failures a `gh` invocation actually hit.
+ *
+ * The three are indistinguishable from an exit status alone, and they send the
+ * reader to three different places: a missing binary is an environment to
+ * provision, a refused credential is an access grant to obtain, and only the
+ * third is anything to do with the ticket.
+ *
+ * Collapsing them cost a real round trip. On Claude Code web, where `gh` is not
+ * pre-installed, every commit was refused with "issue #2202 does not exist or
+ * is inaccessible" — about an issue that was open and correct. The message
+ * accused the ticket, so that is where the reader went.
+ * @param {{status: number|null, error?: Error, stderr?: string}} result Spawn result.
+ * @param {string} ref Work item reference, for the message.
+ * @param {string} noun What the reference names.
+ * @returns {string} A message naming the actual fault.
+ */
+export function githubFailureReason(result, ref, noun) {
+  if (result.error?.code === "ENOENT") {
+    return (
+      `the GitHub CLI (gh) is not installed, so ${noun} ${ref} could not be ` +
+      `checked.\nThis is an environment gap, not a problem with the work item. ` +
+      `Pin gh in remoteEnv.tools.install for surfaces that lack it.`
+    );
+  }
+  const stderr = String(result.stderr ?? "");
+  if (
+    /not enabled for this session|gh auth login|HTTP 40[13]|Bad credentials|authentication/i.test(
+      stderr
+    )
+  ) {
+    return (
+      `the GitHub CLI cannot authenticate, so ${noun} ${ref} could not be ` +
+      `checked.\nThis is a credential gap, not a problem with the work item.` +
+      `\n${stderr.trim().slice(0, 300)}`
+    );
+  }
+  return `${noun} ${ref} does not exist or is inaccessible`;
+}
+
 function run(command, args, options = {}) {
   const result = spawnSync(command, args, {
     cwd: options.cwd ?? process.cwd(),
@@ -537,9 +578,7 @@ function githubIssue(ref, contract) {
     }
   );
   if (result.status !== 0)
-    throw new TrackingError(
-      `GitHub issue ${ref} does not exist or is inaccessible`
-    );
+    throw new TrackingError(githubFailureReason(result, ref, "GitHub issue"));
   const issue = safeJson(result.stdout, `GitHub issue ${ref}`);
   if (String(issue.number) !== number)
     throw new TrackingError(`GitHub returned the wrong issue for ${ref}`);
@@ -1165,12 +1204,40 @@ function main() {
   );
 }
 
-try {
-  main();
-} catch (error) {
-  const detail = error instanceof Error ? error.message : String(error);
-  console.error(
-    `\n❌ Work-item tracking blocked this operation: ${detail}\n\n${GUIDANCE}\n`
-  );
-  process.exitCode = 1;
+/**
+ * Run the CLI, reporting any refusal the way the Git hooks expect.
+ *
+ * Exported so the thin entrypoint at `scripts/lisa-work-item.mjs` can invoke it
+ * explicitly. That entrypoint re-exports this module rather than duplicating
+ * it, so inside here `import.meta.url` names THIS file while `argv[1]` names
+ * the entrypoint — the two never match, and a guard comparing them would leave
+ * Lisa's own hooks doing nothing at all, silently and with exit 0. An exported
+ * call is unambiguous where a path comparison is a guess.
+ */
+export function runCli() {
+  try {
+    main();
+  } catch (error) {
+    const detail = error instanceof Error ? error.message : String(error);
+    console.error(
+      `\n❌ Work-item tracking blocked this operation: ${detail}\n\n${GUIDANCE}\n`
+    );
+    process.exitCode = 1;
+  }
+}
+
+// Only when invoked as a program. Running on import made every function here
+// unreachable from a test: importing the module executed the CLI, so the only
+// way to exercise any of it was to spawn a process and drive it through the
+// filesystem and PATH. That is why a bug in the message above shipped — the
+// branch that produced it had no way to be asserted on.
+//
+// This branch covers a host project, where the file is copied to
+// `scripts/lisa-work-item.mjs` and invoked directly. Lisa's own checkout keeps
+// a re-exporting entrypoint instead, which calls runCli() itself.
+if (
+  process.argv[1] &&
+  import.meta.url === pathToFileURL(process.argv[1]).href
+) {
+  runCli();
 }

package/dist/core/upstream-evidence-manifest.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"upstream-evidence-manifest.d.ts","sourceRoot":"","sources":["../../src/core/upstream-evidence-manifest.ts"],"names":[],"mappings":"AACA,iFAAiF;AACjF,eAAO,MAAM,0BAA0B,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAgnEpE,CAAC;AAEL,4EAA4E;AAC5E,eAAO,MAAM,yBAAyB,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,IAAI,CAAC,CAsjNjE,CAAC;AAEL,sFAAsF;AACtF,eAAO,MAAM,uBAAuB,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,IAAI,CAAC,CAk6I/D,CAAC"}
+{"version":3,"file":"upstream-evidence-manifest.d.ts","sourceRoot":"","sources":["../../src/core/upstream-evidence-manifest.ts"],"names":[],"mappings":"AACA,iFAAiF;AACjF,eAAO,MAAM,0BAA0B,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAgnEpE,CAAC;AAEL,4EAA4E;AAC5E,eAAO,MAAM,yBAAyB,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,IAAI,CAAC,CAwjNjE,CAAC;AAEL,sFAAsF;AACtF,eAAO,MAAM,uBAAuB,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,IAAI,CAAC,CAk6I/D,CAAC"}

package/dist/core/upstream-evidence-manifest.js

@@ -3,7 +3,7 @@
 export const UPSTREAM_EVIDENCE_MANIFEST = Object.freeze({
     "all/copy-contents/.gitattributes": "9d3831007e681186a3673e1037ef3fc82980cab2fc04e27c0868e562912c9e9f",
     "all/copy-contents/gitignore": "2dbf7fd2f2020fc7824c432342002d9ca3ebb57b2872e761b14e942b23479a11",
-    "all/copy-overwrite/scripts/lisa-work-item.mjs": "5eb31c284e820a51312d4484f0669128007326af55ee515923fec33700d003a1",
+    "all/copy-overwrite/scripts/lisa-work-item.mjs": "96a87c131606b3edd43e52485e68f8ffbf5c528cb4beb7a1185263519a9632ce",
     "all/create-only/.claude/rules/PROJECT_RULES.md": "6e1c7923ad2a15356babc60c97e7f97be728d790af285b6a7cd7d1b4d39cd97f",
     "all/create-only/.lisaignore": "3c9827e7e98daa46510b5357cd6dd9406da1821e64cc46d2eea9f311cd6d06b9",
     "all/create-only/scripts/remote-agent-aws-setup.sh": "7677908a345891810d2104ba8b2fd1a8318bb29c408fb5ce0110d57beef9b556",
@@ -992,7 +992,7 @@ export const UPSTREAM_EVIDENCE_MANIFEST = Object.freeze({
     "scripts/lisa-remote-env/session-start.sh": "6e3871ec2f8d56b8ebb85376ebdd3956f3ed8fa4f7b278c2ed90ca9b8845897c",
     "scripts/lisa-remote-env/setup.sh": "c04afb1cf8e14a2713645228e679fa7772559488330a240ec0297cae6afd03e2",
     "scripts/lisa-update-local.sh": "c811f9e10dbcb38499a9791c1ae9051460b347051d04a1d2046925bab9a53c96",
-    "scripts/lisa-work-item.mjs": "acb359ed7a39150fd5e1e68f4c95144045e75d9d53b735da4a7a9271f063044e",
+    "scripts/lisa-work-item.mjs": "51081847e980f314a764c2e50a7a121b1ced9ef4b980f33898057de4c7b852e6",
     "scripts/migrate-deploy-order.sh": "77d909b4cbbfc05169a79168d7868600ea7f56f846feefb7d5121618c54800c3",
     "scripts/plugin-parity-drift.mjs": "34235c4c75c8735aaca96e3e0a52073ba1dee8bad54c85af01c3cf9912d0ea57",
     "scripts/plugin-routing-validate.mjs": "eb38cf139eb04a27dd6493ff6f766945060d5bf73a35856bd3da4c8e4110e2ba",
@@ -1181,6 +1181,7 @@ export const UPSTREAM_SURFACE_MANIFEST = Object.freeze({
     ".github/workflows/deploy.yml": true,
     ".github/workflows/duplicate-versions.yml": true,
     ".github/workflows/lighthouse.yml": true,
+    ".github/workflows/lisa-build-intake.yml": true,
     ".github/workflows/load-test.yml": true,
     ".github/workflows/maestro-native-e2e.yml": true,
     ".github/workflows/plugins-sync.yml": true,
@@ -7251,6 +7252,7 @@ export const UPSTREAM_SURFACE_MANIFEST = Object.freeze({
     "tests/unit/scripts/threshold-ratchet.test.ts": true,
     "tests/unit/scripts/upstream-evidence-manifest.test.ts": true,
     "tests/unit/scripts/verification-coverage.test.ts": true,
+    "tests/unit/scripts/work-item-github-failure-diagnosis.test.ts": true,
     "tests/unit/secrets/automation-workflow.test.ts": true,
     "tests/unit/secrets/bootstrap-key-naming.test.ts": true,
     "tests/unit/secrets/doctor-secrets.test.ts": true,