@codyswann/lisa 2.268.0 → 2.269.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/core/upstream-evidence-manifest.d.ts.map +1 -1
- package/dist/core/upstream-evidence-manifest.js +5 -3
- package/dist/core/upstream-evidence-manifest.js.map +1 -1
- package/package.json +2 -2
- package/plugins/lisa/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa/rules/eager/convergent-review.md +6 -1
- package/plugins/lisa/rules/reference/convergent-review.md +46 -1
- package/plugins/lisa-agy/plugin.json +1 -1
- package/plugins/lisa-cdk/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-agy/plugin.json +1 -1
- package/plugins/lisa-cdk-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cdk-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-copilot/rules/eager/convergent-review.md +6 -1
- package/plugins/lisa-copilot/rules/reference/convergent-review.md +46 -1
- package/plugins/lisa-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-cursor/rules/convergent-review-reference.mdc +46 -1
- package/plugins/lisa-cursor/rules/convergent-review.mdc +6 -1
- package/plugins/lisa-expo/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-expo/.codex-plugin/skills/expo-cicd-workflows/scripts/package.json +1 -1
- package/plugins/lisa-expo/skills/expo-cicd-workflows/scripts/package.json +1 -1
- package/plugins/lisa-expo-agy/plugin.json +1 -1
- package/plugins/lisa-expo-agy/skills/expo-cicd-workflows/scripts/package.json +1 -1
- package/plugins/lisa-expo-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-copilot/skills/expo-cicd-workflows/scripts/package.json +1 -1
- package/plugins/lisa-expo-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-expo-cursor/skills/expo-cicd-workflows/scripts/package.json +1 -1
- package/plugins/lisa-harper-fabric/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-agy/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-harper-fabric-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-agy/plugin.json +1 -1
- package/plugins/lisa-nestjs-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-nestjs-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-agy/plugin.json +1 -1
- package/plugins/lisa-openclaw-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-openclaw-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-agy/plugin.json +1 -1
- package/plugins/lisa-phaser-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-phaser-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-agy/plugin.json +1 -1
- package/plugins/lisa-rails-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-rails-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-agy/plugin.json +1 -1
- package/plugins/lisa-typescript-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-typescript-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki/.codex-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-agy/plugin.json +1 -1
- package/plugins/lisa-wiki-copilot/.claude-plugin/plugin.json +1 -1
- package/plugins/lisa-wiki-cursor/.claude-plugin/plugin.json +1 -1
- package/plugins/src/base/rules/eager/convergent-review.md +6 -1
- package/plugins/src/base/rules/reference/convergent-review.md +46 -1
- package/plugins/src/expo/skills/expo-cicd-workflows/scripts/package.json +1 -1
|
@@ -7,7 +7,12 @@ Review exists to get correct work merged, not to keep a PR in review orbit.
|
|
|
7
7
|
are non-blocking unless the work item or repository rules make them release
|
|
8
8
|
criteria.
|
|
9
9
|
- Every finding must state severity, blocking yes/no, a concrete failure
|
|
10
|
-
scenario, evidence, and the smallest actionable fix
|
|
10
|
+
scenario, evidence, and the smallest actionable fix — plus
|
|
11
|
+
`invariant_violated` (the property at risk) and `machinery_to_remove` (what
|
|
12
|
+
becomes deletable, or `none`), required for `readiness-rubric` findings and
|
|
13
|
+
recommended elsewhere.
|
|
14
|
+
- Present findings highest-consequence first, by severity and blast radius, not
|
|
15
|
+
by discovery order. Report section order stays stable.
|
|
11
16
|
- A blocking finding without a concrete failure scenario is malformed by
|
|
12
17
|
contract; downgrade it to non-blocking and ask for evidence.
|
|
13
18
|
- Resolve each finding as `fixed`, `deferred`, or `pushed-back`. If the reviewer
|
|
@@ -33,12 +33,57 @@ Every finding must state:
|
|
|
33
33
|
- Evidence: the file, command output, observed behavior, ticket text, or
|
|
34
34
|
external constraint proving the scenario is reachable.
|
|
35
35
|
- Fix: the smallest actionable correction, or the reason no code change is
|
|
36
|
-
needed.
|
|
36
|
+
needed. The correction belongs at the **owning boundary** that permitted the
|
|
37
|
+
failure, not at the symptom site.
|
|
38
|
+
- `invariant_violated`: the named property the system is supposed to hold that
|
|
39
|
+
this finding puts at risk — for example "the artifact that ships is the
|
|
40
|
+
artifact CI validated". The invariant is the property; the failure scenario is
|
|
41
|
+
the outcome when it breaks. State both; they are not interchangeable.
|
|
42
|
+
- `machinery_to_remove`: the redundant checks, workarounds, or scaffolding that
|
|
43
|
+
become deletable once the correction lands, or explicitly `none`. This is a
|
|
44
|
+
**scaffolding-subtraction candidate** — it is surfaced for a human or the
|
|
45
|
+
implementer to act on and is never auto-deleted by any review pass.
|
|
37
46
|
|
|
38
47
|
A finding marked blocking without a concrete failure scenario is malformed by
|
|
39
48
|
contract. Downgrade it to non-blocking and ask for evidence instead of treating
|
|
40
49
|
it as a merge blocker.
|
|
41
50
|
|
|
51
|
+
### Compatibility
|
|
52
|
+
|
|
53
|
+
`invariant_violated` and `machinery_to_remove` are **required for findings
|
|
54
|
+
emitted under the `readiness-rubric`** and **recommended everywhere else**. A
|
|
55
|
+
finding from an existing product, quality, local, bot-parity, or suggestion
|
|
56
|
+
implementation pass that omits them is still well-formed by contract — this
|
|
57
|
+
extension is additive and never retroactively malforms a shipped review surface.
|
|
58
|
+
|
|
59
|
+
### Readiness findings map onto this shape
|
|
60
|
+
|
|
61
|
+
A readiness finding names five fields. All five bind to this contract, so there
|
|
62
|
+
is no second findings format anywhere in the repository:
|
|
63
|
+
|
|
64
|
+
| Readiness field | Contract field |
|
|
65
|
+
|---|---|
|
|
66
|
+
| the at-risk invariant | `invariant_violated` (above) |
|
|
67
|
+
| `evidence` | `Evidence` |
|
|
68
|
+
| `why_proof_missed` | `Evidence`, extended with a required proof-gap clause: why the existing proof machinery did not catch this |
|
|
69
|
+
| `root_correction` | `Fix`, qualified: the correction goes at the owning boundary, not the symptom site |
|
|
70
|
+
| redundant machinery | `machinery_to_remove` (above) |
|
|
71
|
+
|
|
72
|
+
Anything that needs a sixth field extends this section rather than starting a
|
|
73
|
+
parallel format.
|
|
74
|
+
|
|
75
|
+
### Consequence Ordering
|
|
76
|
+
|
|
77
|
+
Findings are presented **highest-consequence first**. Consequence is determined
|
|
78
|
+
by severity and blast radius — how much of the system, how many users, and how
|
|
79
|
+
irreversible the outcome — not by discovery order, file order, or the order a
|
|
80
|
+
tool happened to emit them in. Two reviewers ordering the same finding set
|
|
81
|
+
differently is a defect, not a preference.
|
|
82
|
+
|
|
83
|
+
This governs the order of findings **within** a section only. Report section
|
|
84
|
+
order stays stable and is unaffected: never reorder, merge, or silently omit a
|
|
85
|
+
section to surface a finding earlier.
|
|
86
|
+
|
|
42
87
|
## Dispositions
|
|
43
88
|
|
|
44
89
|
The implementer resolves each finding with exactly one disposition:
|