@codyswann/lisa 2.225.5 → 2.226.0

package/plugins/src/base/scripts/remote-agent-aws-setup.sh

@@ -0,0 +1,163 @@
+#!/usr/bin/env bash
+# Vendor-neutral AWS CLI bootstrap for remote coding environments. This is the
+# source copied into every generated Lisa agent plugin.
+#
+# Required secret:
+#   LISA_AWS_BOOTSTRAP_JSON  Complete SecretString emitted by cdkstarter's
+#                            remote-agent IAM kit.
+# Optional plain variables:
+#   LISA_REMOTE_AGENT       claude | codex | cursor | copilot | agy | opencode
+#   LISA_AWS_DEFAULT_PROFILE  Defaults to dev, then the first available profile.
+#   LISA_AWS_SKIP_VERIFY    Set to 1 only for an offline image build.
+
+set -euo pipefail
+umask 077
+
+BOOTSTRAP_PROFILE="lisa-remote-agent-bootstrap"
+
+fail() {
+  echo "remote-agent-aws-setup: $*" >&2
+  exit 1
+}
+
+need() {
+  command -v "$1" >/dev/null 2>&1
+}
+
+as_root() {
+  if [ "$(id -u)" = "0" ]; then
+    "$@"
+  elif need sudo; then
+    sudo "$@"
+  else
+    fail "root access is required to install $1"
+  fi
+}
+
+install_base_tools() {
+  need curl && need unzip && need jq && return 0
+
+  if need apt-get; then
+    as_root apt-get update -y
+    as_root apt-get install -y curl unzip jq
+  elif need dnf; then
+    as_root dnf install -y curl unzip jq
+  elif need yum; then
+    as_root yum install -y curl unzip jq
+  else
+    fail "install curl, unzip, and jq in the remote image before running this script"
+  fi
+}
+
+install_aws_cli() {
+  need aws && return 0
+
+  local architecture aws_architecture temporary_directory
+  architecture="$(uname -m)"
+  case "$architecture" in
+    x86_64 | amd64) aws_architecture="x86_64" ;;
+    aarch64 | arm64) aws_architecture="aarch64" ;;
+    *) fail "unsupported AWS CLI architecture: $architecture" ;;
+  esac
+
+  temporary_directory="$(mktemp -d)"
+  trap 'rm -rf "${temporary_directory:-}"' EXIT
+  curl -fsSL \
+    "https://awscli.amazonaws.com/awscli-exe-linux-${aws_architecture}.zip" \
+    -o "$temporary_directory/awscliv2.zip"
+  unzip -q "$temporary_directory/awscliv2.zip" -d "$temporary_directory"
+  as_root "$temporary_directory/aws/install" \
+    --install-dir /usr/local/aws-cli \
+    --bin-dir /usr/local/bin
+  rm -rf "$temporary_directory"
+  trap - EXIT
+}
+
+sanitize_session_name() {
+  local candidate
+  candidate="$(printf '%s' "${LISA_REMOTE_AGENT:-remote-agent}" \
+    | sed 's/[^A-Za-z0-9_+=,.@-]/-/g' \
+    | cut -c1-64)"
+  [ "${#candidate}" -ge 2 ] || candidate="remote-agent"
+  printf '%s\n' "$candidate"
+}
+
+install_base_tools
+install_aws_cli
+
+[ -z "${AWS_ACCESS_KEY_ID:-}" ] || fail \
+  "do not set AWS_ACCESS_KEY_ID directly; set only LISA_AWS_BOOTSTRAP_JSON so role profiles cannot be bypassed"
+[ -z "${AWS_SECRET_ACCESS_KEY:-}" ] || fail \
+  "do not set AWS_SECRET_ACCESS_KEY directly; set only LISA_AWS_BOOTSTRAP_JSON so role profiles cannot be bypassed"
+
+bootstrap_json="${LISA_AWS_BOOTSTRAP_JSON:-}"
+[ -n "$bootstrap_json" ] || fail "LISA_AWS_BOOTSTRAP_JSON is required"
+
+printf '%s' "$bootstrap_json" | jq -e '
+  type == "object" and
+  (.accessKeyId | type == "string" and length > 0) and
+  (.secretAccessKey | type == "string" and length > 0) and
+  (.externalId | type == "string" and length > 0) and
+  (.profiles | (type == "object" or type == "string"))
+' >/dev/null || fail "LISA_AWS_BOOTSTRAP_JSON is not a valid remote-agent bootstrap bundle"
+
+access_key_id="$(printf '%s' "$bootstrap_json" | jq -er '.accessKeyId')"
+secret_access_key="$(printf '%s' "$bootstrap_json" | jq -er '.secretAccessKey')"
+external_id="$(printf '%s' "$bootstrap_json" | jq -er '.externalId')"
+session_token="$(printf '%s' "$bootstrap_json" | jq -r '.sessionToken // empty')"
+profiles_json="$(printf '%s' "$bootstrap_json" | jq -c '
+  if (.profiles | type) == "string" then
+    .profiles | fromjson
+  else
+    .profiles
+  end
+')"
+
+printf '%s' "$profiles_json" | jq -e '
+  type == "object" and length > 0 and
+  all(to_entries[];
+    (.key | test("^[A-Za-z0-9_-]+$")) and
+    (.value.roleArn | type == "string" and startswith("arn:aws:iam::")) and
+    (.value.region | type == "string" and length > 0)
+  )
+' >/dev/null || fail "bootstrap profiles must map safe names to roleArn and region"
+
+mkdir -p "$HOME/.aws"
+chmod 700 "$HOME/.aws"
+
+aws configure set aws_access_key_id "$access_key_id" --profile "$BOOTSTRAP_PROFILE"
+aws configure set aws_secret_access_key "$secret_access_key" --profile "$BOOTSTRAP_PROFILE"
+if [ -n "$session_token" ]; then
+  aws configure set aws_session_token "$session_token" --profile "$BOOTSTRAP_PROFILE"
+fi
+
+session_name="$(sanitize_session_name)"
+while IFS=$'\t' read -r profile_name role_arn region; do
+  aws configure set role_arn "$role_arn" --profile "$profile_name"
+  aws configure set source_profile "$BOOTSTRAP_PROFILE" --profile "$profile_name"
+  aws configure set external_id "$external_id" --profile "$profile_name"
+  aws configure set role_session_name "$session_name" --profile "$profile_name"
+  aws configure set region "$region" --profile "$profile_name"
+done < <(printf '%s' "$profiles_json" | jq -r 'to_entries[] | [.key, .value.roleArn, .value.region] | @tsv')
+
+default_profile="${LISA_AWS_DEFAULT_PROFILE:-dev}"
+if ! printf '%s' "$profiles_json" | jq -e --arg profile "$default_profile" 'has($profile)' >/dev/null; then
+  default_profile="$(printf '%s' "$profiles_json" | jq -r 'keys[0]')"
+fi
+
+default_role_arn="$(printf '%s' "$profiles_json" | jq -er --arg profile "$default_profile" '.[$profile].roleArn')"
+default_region="$(printf '%s' "$profiles_json" | jq -er --arg profile "$default_profile" '.[$profile].region')"
+aws configure set role_arn "$default_role_arn" --profile default
+aws configure set source_profile "$BOOTSTRAP_PROFILE" --profile default
+aws configure set external_id "$external_id" --profile default
+aws configure set role_session_name "$session_name" --profile default
+aws configure set region "$default_region" --profile default
+
+chmod 600 "$HOME/.aws/credentials" "$HOME/.aws/config"
+
+if [ "${LISA_AWS_SKIP_VERIFY:-0}" != "1" ]; then
+  AWS_PAGER="" aws sts get-caller-identity --profile "$default_profile" >/dev/null
+fi
+
+profile_names="$(printf '%s' "$profiles_json" | jq -r 'keys | join(", ")')"
+echo "remote-agent-aws-setup: ready (${session_name}; default=${default_profile}; profiles=${profile_names})"

package/plugins/src/base/skills/lisa-analyze-claude-remote/SKILL.md

@@ -150,24 +150,27 @@ Group the findings as:
      Terraform providers).
    - `aws sso login`, `aws:signin:*`, `sso_start_url`, `sso_account_id`, `sso_role_name`, or
      `sso_session` in docs or config.
-   - `AWS_ACCESS_KEY_ID`, `AWS_SECRET_ACCESS_KEY`, `AWS_SESSION_TOKEN`, `AWS_DEFAULT_REGION`,
-     `AWS_PROFILE`, role ARN, external ID, account, or CloudWatch/STS references.
+   - `LISA_AWS_BOOTSTRAP_JSON`, legacy `AWS_ACCESS_KEY_ID` /
+     `AWS_SECRET_ACCESS_KEY`, `AWS_PROFILE`, role ARN, external ID, account, or
+     CloudWatch/STS references.
 
    If AWS is present, emit an AWS credential finding and inventory entry. If the repo's current
    local path is `aws sso login` or an `aws:signin:*` script, classify that local path as a `GAP`
    for headless remote routines: it is an interactive browser/device-authorization flow and cannot
    complete in the cloud. Route to the AWS row in the Credential reference instead of suggesting
-   SSO auth. The finding must name the headless substrate: a dedicated IAM principal (user or role)
-   with only permission to `sts:AssumeRole`, environment credentials in the routine UI, and
-   `~/.aws/config` profiles using `role_arn`, `credential_source = Environment`, optional
-   `external_id`, and `region`.
+   SSO auth. The finding must name Lisa's headless substrate: one dedicated IAM
+   user with only `sts:AssumeRole`; one complete Secrets Manager SecretString
+   set as `LISA_AWS_BOOTSTRAP_JSON`; and `/lisa:setup-remote-aws`, which writes a
+   named source profile plus automatically refreshed role profiles. Explicitly
+   reject standard `AWS_ACCESS_KEY_ID` variables because they can bypass the
+   intended assume-role profile.
 
    When the repository contains concrete non-secret AWS metadata (role ARNs, account aliases,
    profile names, regions, or ExternalId values), include it in an `awsProfiles` inventory array so
    `/lisa:generate-claude-remote-build-script` can write matching `~/.aws/config` profiles. Never
-   invent account IDs, ExternalIds, role names, or regions. If AWS is detected but profile metadata
-   is absent, emit the required AWS secret names plus an action to add project-specific profile
-   metadata to the generated artifact or environment notes.
+   invent account IDs, ExternalIds, role names, or regions. If AWS is detected
+   but profile metadata is absent, require a cdkstarter bootstrap bundle rather
+   than asking the repository to reconstruct account metadata by hand.
 
 5. **MCP servers** — read every committed `.mcp.json`. For each server report transport and auth.
    Project-scoped HTTP/SSE servers with no interactive auth are `OK`. Flag stdio servers as
@@ -276,14 +279,14 @@ unsuffixed `…_TOKEN`/`…_KEY` is the simplest to set in a single-account rout
 - Access: the personal API key inherits the user's workspace permissions — the user must be able to read/create/update Issues in the destination team.
 
 ### AWS — host-project operations, logs, deploys, CDK/Serverless/SST, or AWS SDK usage
-- Headless substrate: a dedicated IAM principal (user or role) with long-lived bootstrap credentials
-  stored in the routine environment, used only to call `sts:AssumeRole` into per-account operational
-  roles. The routine writes `~/.aws/config` profiles with `role_arn`, `credential_source =
-  Environment`, optional `external_id`, and `region`; agents use `aws --profile <profile> ...`.
-- Env: `AWS_ACCESS_KEY_ID`, `AWS_SECRET_ACCESS_KEY`; optional `AWS_SESSION_TOKEN` for temporary
-  bootstrap credentials; `AWS_DEFAULT_REGION` when no profile region is provided. Role ARNs,
-  ExternalIds, profile names, and regions are non-secret project metadata and belong in generated
-  artifacts or project docs, not in the skill's global guidance.
+- Headless substrate: cdkstarter's vendor-neutral remote-agent kit. Its single
+  Secrets Manager SecretString contains the assume-only access key, ExternalId,
+  and per-account role metadata. `/lisa:setup-remote-aws` writes a private named
+  source profile and renewable role profiles; agents use
+  `aws --profile <profile> ...`.
+- Env: `LISA_AWS_BOOTSTRAP_JSON` (secret, required) and
+  `LISA_REMOTE_AGENT` (plain platform label). Do not set `AWS_ACCESS_KEY_ID` or
+  `AWS_SECRET_ACCESS_KEY` in the remote environment.
 - Allowlist: `*.amazonaws.com`, or narrower service hosts such as `sts.amazonaws.com`,
   `logs.<region>.amazonaws.com`, `cloudwatch.<region>.amazonaws.com`,
   `xray.<region>.amazonaws.com`, `ssm.<region>.amazonaws.com`, and service-specific endpoints the
@@ -366,7 +369,7 @@ so the generator can render acquisition comments into its template:
     {
       "name": "dev",
       "roleArn": "arn:aws:iam::<account-id>:role/<role-name>",
-      "credentialSource": "Environment",
+      "credentialSource": "lisa-remote-agent-bootstrap",
       "externalId": "<project-external-id>",
       "region": "us-east-1"
     }

package/plugins/src/base/skills/lisa-generate-claude-remote-build-script/SKILL.md

@@ -71,9 +71,9 @@ tracker/source, plus the host project's own package manager and tooling — not
    include `JAM_PAT`, `SONAR_TOKEN`, or similar documented substrate env vars
    only as optional secrets, with their acquire/scope comments when the analysis
    supplied them. Never invent values or promote dormant substrates to required.
-   When AWS entries are present, list `AWS_ACCESS_KEY_ID`, `AWS_SECRET_ACCESS_KEY`, optional
-   `AWS_SESSION_TOKEN`, and `AWS_DEFAULT_REGION` exactly as the analysis reported. State that these
-   bootstrap credentials are for STS assume-role only; do not emit or recommend `aws sso login`.
+   When AWS entries are present, list only `LISA_AWS_BOOTSTRAP_JSON` as the
+   required secret and `LISA_REMOTE_AGENT=claude` as plain configuration. Never
+   emit standard `AWS_ACCESS_KEY_ID` variables and never recommend `aws sso login`.
 
 3a. **Emit substrate setup snippets.** When the inventory marks an MCP
    `headlessUsable: true` through a documented substrate, render the matching
@@ -91,18 +91,11 @@ tracker/source, plus the host project's own package manager and tooling — not
      transport supports static-token auth. Do not print a Jam `.mcp.json` header snippet because
      Jam's preferred headless substrate is its PAT-authenticated CLI.
 
-3b. **Emit AWS assume-role profile setup.** When the inventory includes `awsProfiles`, write an
-   idempotent `~/.aws/config` block gated on `[ -n "${AWS_ACCESS_KEY_ID:-}" ]`. The generated block
-   must:
-   - `mkdir -p "$HOME/.aws"` and create or append profile stanzas without writing secrets.
-   - Emit one `[profile <name>]` stanza per inventory profile with `role_arn`,
-     `credential_source = Environment`, `region` when present, and `external_id` when present.
-   - Keep regions and ExternalIds as non-secret project metadata from the inventory; never invent
-     account IDs, role names, profile names, regions, or ExternalIds.
-   - Warn and skip profile writing when AWS profile metadata is absent, while still listing the
-     required `AWS_*` env var names in the secret template.
-   - Include a comment that agents should use `aws --profile <name> ...` and must not run
-     `aws sso login` in headless routines.
+3b. **Install the shared AWS bootstrap.** When AWS is present, invoke
+   `/lisa:setup-remote-aws --platform=claude`. Reuse the resulting
+   `scripts/remote-agent-aws-setup.sh`; do not generate a second credential or
+   profile implementation. Add `bash scripts/remote-agent-aws-setup.sh` to the
+   generated cloud setup after required package installation.
 
 4. **Emit the allowlist + gaps notice.** List any custom domains the setup or runtime reaches
    (from `networkAccess.allowlistDomains`, falling back to legacy `allowlistDomains`) that the user
@@ -139,9 +132,9 @@ shape, not a fixed payload):
 #   # Note: GH_TOKEN is for gh CLI only. Raw git uses Claude's connected-GitHub proxy/identity;
 #   # sibling repos reached only by raw git do not need to be in this token scope.
 #   - GH_TOKEN=<token>                          # REQUIRED, github is the active tracker+source
-#   - AWS_ACCESS_KEY_ID=<access-key-id>          # REQUIRED when AWS inventory is active
-#   - AWS_SECRET_ACCESS_KEY=<secret-access-key>  # REQUIRED when AWS inventory is active
-#   - AWS_SESSION_TOKEN=<session-token>          # OPTIONAL for temporary bootstrap creds
+#   - LISA_AWS_BOOTSTRAP_JSON=<complete SecretString> # REQUIRED for AWS
+# PLAIN:
+#   - LISA_REMOTE_AGENT=claude
 # NETWORK: set the environment to Custom and allowlist these non-default domains if not on Full:
 #   - <networkAccess.allowlistDomains, if any>
 set -uo pipefail
@@ -184,13 +177,8 @@ need gh || (sudo apt-get update -y && sudo apt-get install -y gh)
 need jq || sudo apt-get install -y jq
 require gh; require jq
 
-# --- AWS assume-role profiles, when inventory includes awsProfiles ---
-if [ -n "${AWS_ACCESS_KEY_ID:-}" ]; then
-  mkdir -p "$HOME/.aws"
-  # Generated stanzas use credential_source=Environment and contain no secrets.
-  # Agents should run: aws --profile <profile> ...
-  # Do not run aws sso login in headless routines; SSO requires an interactive browser/device flow.
-fi
+# --- AWS assume-role profiles, when AWS inventory is active ---
+bash scripts/remote-agent-aws-setup.sh
 
 # --- optional, only with --include-optional ---
 # (docker / ruby / chromium / etc., guarded)
@@ -213,8 +201,8 @@ to stop are: the analysis could not run, or the `--out` path is not writable.
   raw git/cross-repo clone guidance must not expand the token scope to sibling repositories.
 - Never emit an install for a tool the analysis did not surface, and never install `OPTIONAL` tools
   unless `--include-optional` is set.
-- When AWS is in the inventory, generate environment-backed assume-role profile stanzas from
-  `awsProfiles`; never emit `aws sso login` as a remote setup step.
+- When AWS is in the inventory, reuse `/lisa:setup-remote-aws` and its shared
+  setup script; never emit a second profile implementation or `aws sso login`.
 - Prefer `networkAccess.allowlistDomains` over legacy top-level `allowlistDomains`; never emit
   domains already covered by the routine environment's default Trusted list.
 - Keep the script idempotent and detect-before-install so it is safe to re-run and cache.

package/plugins/src/base/skills/lisa-setup-remote-aws/SKILL.md

@@ -0,0 +1,53 @@
+---
+name: lisa-setup-remote-aws
+description: "Install and validate Lisa's drop-in AWS CLI bootstrap for remote coding environments. Supports Claude, Codex, Cursor, GitHub Copilot, Antigravity on user-managed hosts, OpenCode on user-managed hosts, and future Linux remote agents through one capability contract. Writes no secrets; it installs the common setup script, merges native Cursor/Copilot adapters, and emits exact operator guidance for the selected platform."
+allowed-tools: ["Bash", "Read", "Write", "Glob", "Grep"]
+---
+
+# Set up remote-agent AWS access: $ARGUMENTS
+
+Install the vendor-neutral AWS bootstrap into the current repository.
+
+## Arguments
+
+- `--platform=all|claude|codex|cursor|copilot|agy|opencode` (default `all`)
+- `--project=<path>` (default current working directory)
+- `--secret-name=<name>` (default `remote-agent-credentials`)
+
+## Procedure
+
+1. Resolve the plugin root from `PLUGIN_ROOT`, `CLAUDE_PLUGIN_ROOT`,
+   `CURSOR_PLUGIN_ROOT`, or the installed `@codyswann/lisa/plugins/lisa` package.
+2. Run:
+
+   ```bash
+   node "$PLUGIN_ROOT/scripts/install-remote-agent-aws.mjs" $ARGUMENTS
+   ```
+
+3. Inspect every path returned by the installer. It must install
+   `scripts/remote-agent-aws-setup.sh`; for Cursor it merges
+   `.cursor/environment.json`; for Copilot it creates or merges
+   `.github/workflows/copilot-setup-steps.yml`; and it always writes
+   `docs/remote-agent-aws.md`.
+4. Run `bash -n scripts/remote-agent-aws-setup.sh`.
+5. Never write or request the actual bootstrap SecretString in repository
+   files. Tell the operator to retrieve the `remote-agent-credentials` secret
+   from the shared AWS account and paste its complete SecretString into the
+   platform secret named `LISA_AWS_BOOTSTRAP_JSON`. The default cdkstarter
+   secret name is `remote-agent-credentials`; downstream infrastructure may
+   configure a different name. Pass that name with `--secret-name` so the
+   generated runbook contains the exact retrieval command.
+6. Report the external step that remains: configure that one secret in the
+   remote environment and launch a smoke session.
+
+## Contract
+
+A future coding agent is supported without an AWS change when its remote
+environment provides a Linux shell, a setup/start hook, one opaque secret,
+a writable home directory, and HTTPS access to AWS STS plus the allowed service
+endpoints. Set `LISA_REMOTE_AGENT` to a stable lowercase platform label; it is
+used only as `role_session_name`.
+
+Do not create per-repository or per-agent IAM users. Do not expose the bootstrap
+key through standard `AWS_ACCESS_KEY_ID` variables. Do not add production repair
+permissions; production repair is a human-driven local-workstation workflow.

package/scripts/claude-remote-setup.sh

@@ -23,6 +23,9 @@
 #     #          Pull requests R/W, Metadata R (+Workflows R/W if editing .github/workflows,
 #     #          +Projects R/W if using ProjectV2). Identity needs WRITE+ on the repo.
 #     - GH_TOKEN=<token>        # REQUIRED unless the routine's repo connection already auths `gh`
+#   AWS (when this routine needs account access):
+#     - LISA_AWS_BOOTSTRAP_JSON=<complete remote-agent-credentials SecretString>
+#     - LISA_REMOTE_AGENT=claude
 #   Dormant (set ONLY if you switch .lisa.config.json tracker/source):
 #     - JIRA_API_TOKEN / JIRA_SERVER / JIRA_LOGIN / JIRA_PROJECT   # tracker=jira
 #     - ATLASSIAN_API_TOKEN                                        # source=confluence (8 Confluence scopes)
@@ -70,6 +73,12 @@ fi
 require jq
 require gh
 
+# --- AWS CLI + renewable role profiles (when configured) ---
+if [ -n "${LISA_AWS_BOOTSTRAP_JSON:-}" ]; then
+  LISA_REMOTE_AGENT="${LISA_REMOTE_AGENT:-claude}" \
+    bash scripts/remote-agent-aws-setup.sh
+fi
+
 # --- gitleaks (REQUIRED: pre-commit secret scan) ---
 if ! need gitleaks; then
   echo "Installing gitleaks..."
@@ -133,8 +142,6 @@ if [ "$INCLUDE_OPTIONAL" = "1" ]; then
   # Chromium for Lighthouse/Playwright (heavy — can strain the cache budget)
   npx playwright install chromium || echo "WARN: chromium install failed (optional)"
 
-  # aws CLI (cleanup scripts)
-  need aws || apt_get install -y awscli || echo "WARN: awscli install failed (optional)"
 fi
 
 echo "claude-remote-setup: done."

package/scripts/remote-agent-aws-setup.sh

@@ -0,0 +1,17 @@
+#!/usr/bin/env bash
+# Package-level convenience wrapper. The implementation is authored upstream
+# in plugins/src/base and copied into plugins/lisa by build:plugins.
+
+set -euo pipefail
+
+REPOSITORY_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+for candidate in \
+  "$REPOSITORY_ROOT/plugins/lisa/scripts/remote-agent-aws-setup.sh" \
+  "$REPOSITORY_ROOT/plugins/src/base/scripts/remote-agent-aws-setup.sh"; do
+  if [ -x "$candidate" ]; then
+    exec "$candidate" "$@"
+  fi
+done
+
+echo "remote-agent-aws-setup: Lisa plugin script is missing; run bun run build:plugins" >&2
+exit 1